)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d4bf52741529e574adb0a4cba56349738ba90560","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Emilien Macchi \u003cemilien@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-03 09:09:57 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Composable role for RabbitMQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add RabbitMQ composable role."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_4a0c0742","line":7,"updated":"2016-05-05 13:03:13.000000000","message":"I think we\u0027re calling the puppet part \u0027profile\u0027","commit_id":"5975461663c23ee6a600c7afcff41628f5b38b2f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bfd5905b429951f45754b5e00e770c3dde374407","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Composable role for RabbitMQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add RabbitMQ composable role, and keep the same logic that we had in"},{"line_number":10,"context_line":"THT."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I961bdbe1cc6dd1d4a315de616439f9fc77d793ae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"dab17558_1949e6b7","line":10,"updated":"2016-05-16 08:31:39.000000000","message":"the tht side for this is at I5fed5c437ad492af75791a9163f99ae292f58895","commit_id":"ad9c91738d88b3a5d5a1ccc96a4140bbb15c75f3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bfd5905b429951f45754b5e00e770c3dde374407","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add RabbitMQ composable role, and keep the same logic that we had in"},{"line_number":10,"context_line":"THT."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I961bdbe1cc6dd1d4a315de616439f9fc77d793ae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"dab17558_79611239","line":11,"updated":"2016-05-16 08:31:39.000000000","message":"Implements: refactor-puppet-manifests","commit_id":"ad9c91738d88b3a5d5a1ccc96a4140bbb15c75f3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f02e3485c12033af06cd39dd2e2a874deacc6968","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Composable role for RabbitMQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add RabbitMQ composable role, and keep the same logic that we had in"},{"line_number":10,"context_line":"THT."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I961bdbe1cc6dd1d4a315de616439f9fc77d793ae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"dab17558_ae3c93e1","line":10,"updated":"2016-05-17 07:03:19.000000000","message":"The tht side for this is at I5fed5c437ad492af75791a9163f99ae292f58895","commit_id":"6aea2f6cbe03ada7e2b57b3482ef339798f87285"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f02e3485c12033af06cd39dd2e2a874deacc6968","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add RabbitMQ composable role, and keep the same logic that we had in"},{"line_number":10,"context_line":"THT."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I961bdbe1cc6dd1d4a315de616439f9fc77d793ae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"dab17558_6e362b04","line":12,"updated":"2016-05-17 07:03:19.000000000","message":"Implements: refactor-puppet-manifests","commit_id":"6aea2f6cbe03ada7e2b57b3482ef339798f87285"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e3c6f7fc15db9bd31d2c7fd9fbfe739f9800884a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add RabbitMQ composable role, and keep the same logic that we had in"},{"line_number":10,"context_line":"THT."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I961bdbe1cc6dd1d4a315de616439f9fc77d793ae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"dab17558_b76047d0","line":12,"updated":"2016-05-17 16:38:47.000000000","message":"you ignored it 2 times already ;) so I have to try once more - in the etherpad we ask people to tag their submissions with the blueprint see https://etherpad.openstack.org/p/tripleo-composable-services (I am actually not 100% but I _think_ you wrote those notes :) )","commit_id":"51e7acc31b7419610ca8a044ed5daa606077e084"}],"manifests/profile/base/rabbitmq.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d4bf52741529e574adb0a4cba56349738ba90560","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":66,"context_line":"    if count($nodes) \u003e 1 {"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      if $ipv6 {"},{"line_number":69,"context_line":"        $rabbit_env \u003d merge($environment, {"},{"line_number":70,"context_line":"          \u0027RABBITMQ_SERVER_START_ARGS\u0027 \u003d\u003e \u0027\"-proto_dist inet6_tcp\"\u0027"},{"line_number":71,"context_line":"        })"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_ca493790","line":68,"updated":"2016-05-05 13:03:13.000000000","message":"I think \"if $ipv6\" should happen regardless of the number of nodes and it looks like this is an error we\u0027re doing in the existing manifest as well but would be nice to fix\n\nsame is for kernel_variables and config_variables which should always be applied\n\nmaybe we can fix in an iteration but would be nice to have a TODO here","commit_id":"5975461663c23ee6a600c7afcff41628f5b38b2f"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"d14e288562f9dd290bad203f666a65248010ac34","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":66,"context_line":"    if count($nodes) \u003e 1 {"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      if $ipv6 {"},{"line_number":69,"context_line":"        $rabbit_env \u003d merge($environment, {"},{"line_number":70,"context_line":"          \u0027RABBITMQ_SERVER_START_ARGS\u0027 \u003d\u003e \u0027\"-proto_dist inet6_tcp\"\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dab17558_6fb06d44","line":67,"updated":"2016-05-07 17:31:55.000000000","message":"Shouldn\u0027t the IPv6 happen outside of the count($nodes) above so that it works on single or multi-node rabbit clusters?","commit_id":"f9110e1d43c71e4f377d71d4c6ec9e0721a718c4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"62f391f4af4a8e0345625cb841d79f4cc6288e8a","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":66,"context_line":"    if count($nodes) \u003e 1 {"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      if $ipv6 {"},{"line_number":69,"context_line":"        $rabbit_env \u003d merge($environment, {"},{"line_number":70,"context_line":"          \u0027RABBITMQ_SERVER_START_ARGS\u0027 \u003d\u003e \u0027\"-proto_dist inet6_tcp\"\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dab17558_af299a8b","line":67,"in_reply_to":"dab17558_6fb06d44","updated":"2016-05-09 12:23:31.000000000","message":"I followed exactly what is in THT at this time. But maybe we can change it.","commit_id":"f9110e1d43c71e4f377d71d4c6ec9e0721a718c4"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"7a403ed38fa61be1b3615f099c42e3c3815da53d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          },"},{"line_number":93,"context_line":"        }"},{"line_number":94,"context_line":"      } else {"},{"line_number":95,"context_line":"      # when running Pacemaker"},{"line_number":96,"context_line":"        file { \u0027/var/lib/rabbitmq/.erlang.cookie\u0027:"},{"line_number":97,"context_line":"          ensure  \u003d\u003e file,"},{"line_number":98,"context_line":"          owner   \u003d\u003e \u0027rabbitmq\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"dab17558_d1b729f3","line":95,"updated":"2016-05-10 13:11:50.000000000","message":"maybe put this in the pacemaker class.","commit_id":"5f35f14f670393843effa15e855b261e83462821"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d52de05601a4706cf69089094565b1c675314cb3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          },"},{"line_number":93,"context_line":"        }"},{"line_number":94,"context_line":"      } else {"},{"line_number":95,"context_line":"      # when running Pacemaker"},{"line_number":96,"context_line":"        file { \u0027/var/lib/rabbitmq/.erlang.cookie\u0027:"},{"line_number":97,"context_line":"          ensure  \u003d\u003e file,"},{"line_number":98,"context_line":"          owner   \u003d\u003e \u0027rabbitmq\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"dab17558_701bc5ca","line":95,"in_reply_to":"dab17558_cca143fa","updated":"2016-05-10 18:19:44.000000000","message":"Done","commit_id":"5f35f14f670393843effa15e855b261e83462821"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"663e3ac71a668e24ce88288be2d35f37cd0b55d0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          },"},{"line_number":93,"context_line":"        }"},{"line_number":94,"context_line":"      } else {"},{"line_number":95,"context_line":"      # when running Pacemaker"},{"line_number":96,"context_line":"        file { \u0027/var/lib/rabbitmq/.erlang.cookie\u0027:"},{"line_number":97,"context_line":"          ensure  \u003d\u003e file,"},{"line_number":98,"context_line":"          owner   \u003d\u003e \u0027rabbitmq\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"dab17558_cca143fa","line":95,"in_reply_to":"dab17558_d1b729f3","updated":"2016-05-10 15:38:46.000000000","message":"Agree. This should go into the pacemaker class.","commit_id":"5f35f14f670393843effa15e855b261e83462821"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f02e3485c12033af06cd39dd2e2a874deacc6968","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   Defaults to hiera(\u0027rabbitmq_config_variables\u0027)."},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*manage_service*]"},{"line_number":42,"context_line":"#   (Optional) Whether to manage the rabbitmq service"},{"line_number":43,"context_line":"#   Defaults to true."},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*step*]"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"dab17558_8e1a6f7b","line":42,"updated":"2016-05-17 07:03:19.000000000","message":"fyi we are removing these altogether (see mynote at the tht side)","commit_id":"6aea2f6cbe03ada7e2b57b3482ef339798f87285"}],"manifests/profile/pacemaker/rabbitmq.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"2e14eb0add2ad250c567defe9bf35c09b4bd409c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*erlang_cookie*]"},{"line_number":31,"context_line":"#   (Optional) Content of erlang cookie."},{"line_number":32,"context_line":"#   Defaults to hiera(\u0027rabbitmq::erlang_cookie\u0027)."},{"line_number":33,"context_line":"class tripleo::profile::pacemaker::rabbitmq ("},{"line_number":34,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":35,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"dab17558_74f086ca","line":32,"updated":"2016-05-12 07:23:40.000000000","message":"missing a # between doc and definition.","commit_id":"38d303b04730b5f64654599a30a258a9f11714e4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"71ff80ce557f53cf7380faccdba66f28de9b1f91","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*erlang_cookie*]"},{"line_number":31,"context_line":"#   (Optional) Content of erlang cookie."},{"line_number":32,"context_line":"#   Defaults to hiera(\u0027rabbitmq::erlang_cookie\u0027)."},{"line_number":33,"context_line":"class tripleo::profile::pacemaker::rabbitmq ("},{"line_number":34,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":35,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"dab17558_995a1182","line":32,"in_reply_to":"dab17558_74f086ca","updated":"2016-05-14 09:28:48.000000000","message":"Done","commit_id":"38d303b04730b5f64654599a30a258a9f11714e4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d9240785f9386b6c0c5747d6cbc88e63b3e1b044","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    $pacemaker_master \u003d false"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  file { \u0027/var/lib/rabbitmq/.erlang.cookie\u0027:"},{"line_number":47,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":48,"context_line":"    owner   \u003d\u003e \u0027rabbitmq\u0027,"},{"line_number":49,"context_line":"    group   \u003d\u003e \u0027rabbitmq\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"dab17558_7e645821","line":46,"updated":"2016-05-16 08:29:42.000000000","message":"not sure if significant but you mentioned issues with the erlang cookie in irc chat. In the original tht, there was a dependency arrow here https://github.com/openstack/tripleo-heat-templates/blob/0d3dacec4b63fb168f4f039501dc6e7b9622315b/puppet/manifests/overcloud_controller_pacemaker.pp#L136\n\n(see the note at https://github.com/openstack/tripleo-heat-templates/blob/0d3dacec4b63fb168f4f039501dc6e7b9622315b/puppet/manifests/overcloud_controller_pacemaker.pp#L120 )","commit_id":"ad9c91738d88b3a5d5a1ccc96a4140bbb15c75f3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"24a08c201a79cb36d9e8011686384e88878ede12","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    $pacemaker_master \u003d false"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  file { \u0027/var/lib/rabbitmq/.erlang.cookie\u0027:"},{"line_number":47,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":48,"context_line":"    owner   \u003d\u003e \u0027rabbitmq\u0027,"},{"line_number":49,"context_line":"    group   \u003d\u003e \u0027rabbitmq\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"dab17558_e3a1baaa","line":46,"in_reply_to":"dab17558_7e645821","updated":"2016-05-16 14:18:20.000000000","message":"damn, I did the other way around. /me facepalm","commit_id":"ad9c91738d88b3a5d5a1ccc96a4140bbb15c75f3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d9240785f9386b6c0c5747d6cbc88e63b3e1b044","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  class { \u0027::tripleo::profile::base::rabbitmq\u0027:"},{"line_number":57,"context_line":"    manage_service \u003d\u003e false,"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"dab17558_fed208ff","line":57,"updated":"2016-05-16 08:29:42.000000000","message":"if you pass this directly from the tht to the rabbitmq class you don\u0027t need to worry about it here and just include the base profile (see comment at https://review.openstack.org/#/c/311863/20/puppet/services/pacemaker/rabbitmq.yaml )","commit_id":"ad9c91738d88b3a5d5a1ccc96a4140bbb15c75f3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"24a08c201a79cb36d9e8011686384e88878ede12","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  class { \u0027::tripleo::profile::base::rabbitmq\u0027:"},{"line_number":57,"context_line":"    manage_service \u003d\u003e false,"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"dab17558_43a1a693","line":57,"in_reply_to":"dab17558_fed208ff","updated":"2016-05-16 14:18:20.000000000","message":"ack","commit_id":"ad9c91738d88b3a5d5a1ccc96a4140bbb15c75f3"}]}