)]}'
{"manifests/profile/base/memcached.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f148b3852016373d3422cf90c2df30684ac4e95","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*manage_service*]"},{"line_number":22,"context_line":"#   (Optional) Whether to manage the memcached service"},{"line_number":23,"context_line":"#   Defaults to true."},{"line_number":24,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_70ea92d9","line":21,"updated":"2016-05-05 13:30:06.000000000","message":"I think we can avoid this by setting the ::memcached class parameter directly from the pcmk template, see [1]\n\n1. https://review.openstack.org/#/c/310940/2/puppet/services/pacemaker/cinder-api.yaml","commit_id":"e9d82cd9ae43cabd1b426d9efad0595b9eaa0707"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d4c6fe01d28ec6863260c179242ca72dc227b0c4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*manage_service*]"},{"line_number":22,"context_line":"#   (Optional) Whether to manage the memcached service"},{"line_number":23,"context_line":"#   Defaults to true."},{"line_number":24,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_59f9e07f","line":21,"in_reply_to":"1a122d0e_70ea92d9","updated":"2016-05-09 12:48:33.000000000","message":"essentially that means that puppet-tripleo memcached will always be service-manage false and we\u0027d not expose those (from the puppet-tripleo side) at all. Note we\u0027ve already landed things that explicitly add this param (like https://review.openstack.org/#/c/293436/21/manifests/profile/base/neutron/server.pp as one example).\n\nso I\u0027ve now added the listen_ip param which similarly will be set on the tht side (in puppet/controller.yaml like tripleo::profile::base::memcached::listen_ip: {get_input: memcached_network} ) I am going to remove the manage_service from here too and set it like you do from the tht side explicitly thanks let\u0027s see what others say","commit_id":"e9d82cd9ae43cabd1b426d9efad0595b9eaa0707"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d49a78451e23b666b866ad534faaf2b329e05054","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":36,"context_line":"      class { \u0027::memcached\u0027:"},{"line_number":37,"context_line":"        service_manage          \u003d\u003e $manage_service,"},{"line_number":38,"context_line":"      }"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_d2ac538a","line":37,"updated":"2016-05-05 10:52:00.000000000","message":"I think we also need to add the listen_ip param here and to the class params above...  it is now set from the tht hiera like memcached::listen_ip : {get_input: memcached_network}","commit_id":"e9d82cd9ae43cabd1b426d9efad0595b9eaa0707"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d4c6fe01d28ec6863260c179242ca72dc227b0c4","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":36,"context_line":"      class { \u0027::memcached\u0027:"},{"line_number":37,"context_line":"        service_manage          \u003d\u003e $manage_service,"},{"line_number":38,"context_line":"      }"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_4f974e90","line":37,"in_reply_to":"1a122d0e_d2ac538a","updated":"2016-05-09 12:48:33.000000000","message":"done (explicitly set in tht side at https://review.openstack.org/#/c/312899/2 like cinder does for the tripleo::profile::base::cinder::volume::cinder_iscsi_address https://review.openstack.org/#/c/310940/2/puppet/controller.yaml)","commit_id":"e9d82cd9ae43cabd1b426d9efad0595b9eaa0707"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0734cd590cb631f6a217342dc62408ac8a587e30","unresolved":false,"context_lines":[{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":36,"context_line":"    if $listen_ip {"},{"line_number":37,"context_line":"      class { \u0027::memcached\u0027:"},{"line_number":38,"context_line":"        listen_ip               \u003d\u003e $listen_ip,"},{"line_number":39,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_6d2fb9f6","line":36,"updated":"2016-05-19 13:57:29.000000000","message":"looks like we don\u0027t need to manage listen_ip from the tripleo module?","commit_id":"a8948bcc45457b94b1350c0d7eed2a2b8842812a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fe3f27ea3b19da4363b354abc3f2588ecd3c077a","unresolved":false,"context_lines":[{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":36,"context_line":"    if $listen_ip {"},{"line_number":37,"context_line":"      class { \u0027::memcached\u0027:"},{"line_number":38,"context_line":"        listen_ip               \u003d\u003e $listen_ip,"},{"line_number":39,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_1898e9bf","line":36,"in_reply_to":"bab6814e_6d2fb9f6","updated":"2016-05-19 14:03:12.000000000","message":"yeah we can fixit here and in the tht https://review.openstack.org/#/c/312899/7/puppet/controller.yaml\n\nI thought we didn\u0027t want to pass the puppet module hiera directly from the puppet/controller.yaml for some reason.","commit_id":"a8948bcc45457b94b1350c0d7eed2a2b8842812a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"59385c0b668788bbfbce91bee6d953cd2025ecb0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class tripleo::profile::base::memcached ("},{"line_number":28,"context_line":"  $step             \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $step \u003e\u003d 1 {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_737dd6e6","line":28,"updated":"2016-05-19 14:26:22.000000000","message":"cat sleeping on space :P","commit_id":"e22afd7839c934eafb74965bfc263efcdfd81c0d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9fe94f33f644787bc2425daddc3d0797abbe8eb4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class tripleo::profile::base::memcached ("},{"line_number":28,"context_line":"  $step             \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $step \u003e\u003d 1 {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_4e7d88e6","line":28,"in_reply_to":"bab6814e_737dd6e6","updated":"2016-05-19 15:23:48.000000000","message":"que?","commit_id":"e22afd7839c934eafb74965bfc263efcdfd81c0d"}],"manifests/profile/pacemaker/memcached.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"517907d748e73fb419461cf0a2405db3147c1965","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  class { \u0027::tripleo::profile::base::memcached\u0027:"},{"line_number":42,"context_line":"    manage_service \u003d\u003e false,"},{"line_number":43,"context_line":"    #listen_ip is set in the THT"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_08e9bbe6","line":42,"updated":"2016-05-09 14:14:22.000000000","message":"It is now set in t-h-t via hiera and the base profile doesn\u0027t have this parameter anymore, so this line should be removed and then the base profile can be included with the `include` keyword.","commit_id":"c61f61590b6c29b27351c39a407e877ddbc8d87c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"517907d748e73fb419461cf0a2405db3147c1965","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":54,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":55,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":56,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":57,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_a886af10","line":54,"updated":"2016-05-09 14:14:22.000000000","message":"Not 100% sure about this being in the memcached role. If we don\u0027t find a better option then i\u0027d be fine landing it like this. Perhaps it\u0027s worth thinking through if openstack-core should be a separate role too?","commit_id":"c61f61590b6c29b27351c39a407e877ddbc8d87c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8db8f51916d81a2f197ca3c51c38970a020bc79c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":54,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":55,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":56,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":57,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_ce3432fd","line":54,"in_reply_to":"dab17558_09c2dde8","updated":"2016-05-12 10:38:23.000000000","message":"some more discussion at https://review.openstack.org/#/c/310939/6/manifests/profile/pacemaker/cinder.pp\n\nso if we all agree... this dummy resource won\u0027t be around for much longer. SO we can leave it in the controller_pacemaker.pp on tht tht side in step 2 and it is then defined for us to reference it here (or in the cinder case or wherever else)","commit_id":"c61f61590b6c29b27351c39a407e877ddbc8d87c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"98946d03b229be109a475d8240988d04c54853b8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":54,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":55,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":56,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":57,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_f3eaf5d9","line":54,"in_reply_to":"dab17558_a886af10","updated":"2016-05-11 13:40:56.000000000","message":"yeah i think you may be right jistr - possibly a stand-alone tripleo::profile::pacemaker::openstack-core is needed and we add these constraints there afaics it is this and galera","commit_id":"c61f61590b6c29b27351c39a407e877ddbc8d87c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"73ca941674599880ee203d1bba105f5b7e270b20","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":54,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":55,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":56,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":57,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_09c2dde8","line":54,"in_reply_to":"dab17558_f3eaf5d9","updated":"2016-05-11 16:33:11.000000000","message":"IMHO we can leave openstack-core in the _pacemaker.pp file to start with and worry about it later ... only if we really need to; openstack-core is not used by lightweight/ha","commit_id":"c61f61590b6c29b27351c39a407e877ddbc8d87c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ec0a0b5c8987e5718bf7905866f90d387e3be56a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":51,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":52,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":53,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":54,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_201d7862","line":51,"updated":"2016-05-16 13:58:24.000000000","message":"Following up on discussion from previous patchset -- +1 on leaving openstack-core in _pacemaker.pp then, i\u0027m just wondering if we should leave all openstack-core constraints there too. +2, don\u0027t wanna block on something that is basically dead code, but if you feel like this should be kept in _pacemaker.pp, feel free to move it and i\u0027ll re-review","commit_id":"579341212a735ff350f9bb1eb47ef5b4236b6766"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5b8b37a44eee94de8fc884db6b9743de67d93b74","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":51,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":52,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":53,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":54,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_fa892270","line":51,"in_reply_to":"dab17558_201d7862","updated":"2016-05-17 13:18:40.000000000","message":"yeah am not sure what the right approach is either. There are a few of them so we need to at least be consistent (either they all stay https://github.com/openstack/tripleo-heat-templates/blob/aeb9482f4b1ec9d78dc3ac44ee3c0b180cd27574/puppet/manifests/overcloud_controller_pacemaker.pp#L1026 or not).\n\nThey way this review stands right now is that the openstack-core \u0027resource\u0027 itself is defined in the _controller_pacemaker.pp and then the constraints would go into the respective puppet-tripleo manifest for that service.\n\nI can change it but, again, not sure what the right way is. lets see if we get more opinions here.","commit_id":"579341212a735ff350f9bb1eb47ef5b4236b6766"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d665ad0952216ea528641db44185c665fd4af00f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":51,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":52,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":53,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":54,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_c6ad2233","line":51,"updated":"2016-05-18 14:44:48.000000000","message":"I think this eventually goes in the openstack-core role, not in the memcached one?","commit_id":"a8948bcc45457b94b1350c0d7eed2a2b8842812a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b5aae63229c33a73528cfd227c9b40a6650e6856","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":51,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":52,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":53,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":54,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_15cb99a6","line":51,"in_reply_to":"bab6814e_60687088","updated":"2016-05-19 12:12:37.000000000","message":"yeah but that\u0027s always been the problem with roles+pcmk because constraints link roles together so we can\u0027t easily split them\n\nluckily memcached won\u0027t be managed by pcmk anymore so we won\u0027t need this constraint anymore; I\u0027m fine leaving it here then, it\u0027ll be a problem if we remove openstack-core from _pacemaker.pp but maybe we can do a mass cleanup of the \u0027old generation\u0027 pcmk templates in one submission","commit_id":"a8948bcc45457b94b1350c0d7eed2a2b8842812a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ba157b2aad9e5c938171d45aa4e3dfdcfd7d7adb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":51,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":52,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":53,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":54,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_e00c603d","line":51,"in_reply_to":"bab6814e_c6ad2233","updated":"2016-05-19 09:31:06.000000000","message":"OK will move back there then see (comments at v2 https://review.openstack.org/#/c/312877/2..6/manifests/profile/pacemaker/memcached.pp )","commit_id":"a8948bcc45457b94b1350c0d7eed2a2b8842812a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1d2fe9a21f92d517a0cc933bbfa33f1b856b1289","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":51,"context_line":"      pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:"},{"line_number":52,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":53,"context_line":"      first_resource  \u003d\u003e \u0027memcached-clone\u0027,"},{"line_number":54,"context_line":"      second_resource \u003d\u003e \u0027openstack-core-clone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_60687088","line":51,"in_reply_to":"bab6814e_e00c603d","updated":"2016-05-19 09:35:23.000000000","message":"well hold on... i mean we said we won\u0027t be making an openstack-core role though no? in which case we would leave the definition of openstack-core in the controller_pacemaker.pp manifest for now.\n\nSo I can move this constraint back to there. But if we leave it here, it only gets defined if we have memcached. Which makes sense to me no?","commit_id":"a8948bcc45457b94b1350c0d7eed2a2b8842812a"}]}
