)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6e2214184ade48cc131bbf6e9f0f862e8d4b6d7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add Heat profiles for non-ha \u0026 ha scenarios."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I194cbb6aa307c2331597147545cf10299cab132f"},{"line_number":12,"context_line":"Partially-implements: blueprint refactor-puppet-manifests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bab6814e_253ec4b8","line":12,"updated":"2016-05-18 06:37:09.000000000","message":"so my new theory is this needs to appear above the change-id (to get it listed at https://blueprints.launchpad.net/tripleo/+spec/refactor-puppet-manifests )","commit_id":"a862c24144b000513cec10980f7c52a643ec6c1d"}],"manifests/profile/base/heat.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"15887bd260112752277463cc257ebe326758c84b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"class tripleo::profile::base::heat ("},{"line_number":39,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":40,"context_line":"  $heat_notification_driver \u003d hiera(\u0027heat_notification_driver\u0027, \u0027messaging\u0027),"},{"line_number":41,"context_line":"  $bootstrap_master \u003d downcase(hiera(\u0027bootstrap_nodeid\u0027)),"},{"line_number":42,"context_line":"  $manage_db_purge \u003d hiera(\u0027heat_enable_db_purge\u0027, true),"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_b35f6c71","line":40,"updated":"2016-05-18 19:39:13.000000000","message":"Do we really need to default this to hiera(\u0027heat_notification_driver\u0027) or would simply defaulting to \u0027messaging\u0027 be enough? Regardless of the default here we\u0027d ideally rely on setting tripleo::profile::base::heat::notification_driver from t-h-t.\n\nSo change the name to $notification_driver \u003d \u0027messaging\u0027?","commit_id":"a862c24144b000513cec10980f7c52a643ec6c1d"}],"manifests/profile/base/heat/api.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8c03cc4b8e4aad9cc06aa0dbced6880d49ec6142","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class tripleo::profile::base::heat::api ("},{"line_number":35,"context_line":"  $manage_service \u003d undef,"},{"line_number":36,"context_line":"  $enabled        \u003d undef,"},{"line_number":37,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dab17558_6c687bbb","line":36,"updated":"2016-05-13 08:18:05.000000000","message":"hey o/ as commented on the tripleo-heat-template side, https://review.openstack.org/#/c/313577/15/puppet/services/pacemaker/heat-api.yaml if you set the manage_service/enabled from the tht side then we can get ride of them here and the rest of the templates that use them","commit_id":"9d595ff640195c1712be4962666791a1358c533f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9a43ac7adae1172f668a44f7f0f178e1166a9756","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*manage_service*]"},{"line_number":22,"context_line":"#   (Optional) Whether to manage the heat service"},{"line_number":23,"context_line":"#   Defaults to undef"},{"line_number":24,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dab17558_6c2065f8","line":21,"updated":"2016-05-13 15:04:28.000000000","message":"removeme?","commit_id":"ad2b0aa18e21d93dca3b889c3e519cf7da9f8772"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"5bec02afb151105b3ed1ed40a2f83816de71b1f0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*manage_service*]"},{"line_number":22,"context_line":"#   (Optional) Whether to manage the heat service"},{"line_number":23,"context_line":"#   Defaults to undef"},{"line_number":24,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dab17558_4c7c81b5","line":21,"in_reply_to":"dab17558_6c2065f8","updated":"2016-05-13 15:07:13.000000000","message":"Done","commit_id":"ad2b0aa18e21d93dca3b889c3e519cf7da9f8772"}],"manifests/profile/base/heat/api_cfn.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9a43ac7adae1172f668a44f7f0f178e1166a9756","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   (Optional) Whether to manage the heat cloudformation service"},{"line_number":23,"context_line":"#   Defaults to undef"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*enabled*]"},{"line_number":26,"context_line":"#   (Optional) Whether to enable the heat cloudformation service"},{"line_number":27,"context_line":"#   Defaults to undef"},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dab17558_8c7b09f4","line":25,"updated":"2016-05-13 15:04:28.000000000","message":"metoo","commit_id":"ad2b0aa18e21d93dca3b889c3e519cf7da9f8772"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"5bec02afb151105b3ed1ed40a2f83816de71b1f0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   (Optional) Whether to manage the heat cloudformation service"},{"line_number":23,"context_line":"#   Defaults to undef"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*enabled*]"},{"line_number":26,"context_line":"#   (Optional) Whether to enable the heat cloudformation service"},{"line_number":27,"context_line":"#   Defaults to undef"},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dab17558_8c4ca99e","line":25,"in_reply_to":"dab17558_8c7b09f4","updated":"2016-05-13 15:07:13.000000000","message":"Done","commit_id":"ad2b0aa18e21d93dca3b889c3e519cf7da9f8772"}],"manifests/profile/base/heat/engine.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9a43ac7adae1172f668a44f7f0f178e1166a9756","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   (Optional) Whether to run db sync"},{"line_number":23,"context_line":"#   Defaults to undef"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*manage_service*]"},{"line_number":26,"context_line":"#   (Optional) Whether to manage the heat engine service"},{"line_number":27,"context_line":"#   Defaults to undef"},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dab17558_cc5cf17f","line":25,"updated":"2016-05-13 15:04:28.000000000","message":"andme","commit_id":"ad2b0aa18e21d93dca3b889c3e519cf7da9f8772"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"5bec02afb151105b3ed1ed40a2f83816de71b1f0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   (Optional) Whether to run db sync"},{"line_number":23,"context_line":"#   Defaults to undef"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*manage_service*]"},{"line_number":26,"context_line":"#   (Optional) Whether to manage the heat engine service"},{"line_number":27,"context_line":"#   Defaults to undef"},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dab17558_4c53e139","line":25,"in_reply_to":"dab17558_cc5cf17f","updated":"2016-05-13 15:07:13.000000000","message":"Done","commit_id":"ad2b0aa18e21d93dca3b889c3e519cf7da9f8772"}],"manifests/profile/pacemaker/heat.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8c03cc4b8e4aad9cc06aa0dbced6880d49ec6142","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    heat_notification_driver \u003d\u003e \u0027messaging\u0027,"},{"line_number":50,"context_line":"    bootstrap_master         \u003d\u003e $bootstrap_node,"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":"  class { \u0027::tripleo::profile::base::heat::api\u0027:"},{"line_number":53,"context_line":"    manage_service \u003d\u003e false,"},{"line_number":54,"context_line":"    enabled        \u003d\u003e false,"},{"line_number":55,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dab17558_6cafdbe3","line":52,"updated":"2016-05-13 08:18:05.000000000","message":"and then... we can just\n\n  include ::tripleo::profile::base::heat::api \n\nhere cos those params are sorted.","commit_id":"9d595ff640195c1712be4962666791a1358c533f"}]}