)]}'
{"lib/puppet/provider/service_manifest/flat_file.rb":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d9acd068e64eaa003d9d0bfd88714ae69151f213","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bab6814e_08ea740f","updated":"2016-05-19 07:34:47.000000000","message":"uhm... so every time this provider is called, it overwrites the service_manifest. Is this something we want? I guess this works.\n\nAnother possibility is to create the instances and prefetch methods and appropriately fetch the already existing values there, and finally writting the values in flush. exist would only check for the existance of the file.","commit_id":"ee95e4e2386cae506f6e0666f91705bc0f16f81a"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"cffb7808950a0a5150643f4e143b2faf9b98433d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bab6814e_8f1bff7f","in_reply_to":"bab6814e_08ea740f","updated":"2016-05-23 13:55:43.000000000","message":"IIUC it\u0027s not going to overwrite the manifest every time. The `exists?` method returns true if the content of the file is the same, and then the `create` method shouldn\u0027t get executed. (I took this approach from the package_manifest we have.)","commit_id":"ee95e4e2386cae506f6e0666f91705bc0f16f81a"}],"manifests/service_manifest.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"24b264fc9213f5f9bd723e0b06fd135b84384755","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class tripleo::service_manifest ("},{"line_number":27,"context_line":"  $entries,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":"  service_manifest { \"/var/lib/tripleo/services/deployed-services.txt\":"},{"line_number":30,"context_line":"    entries \u003d\u003e $entries,"},{"line_number":31,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":32,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_8d969e92","line":29,"updated":"2016-05-06 13:15:10.000000000","message":"This is setting a convention for the future. If someone sees a reason the path should be different, please speak up.","commit_id":"8b80d904572a57bbf4e628ef6b295e0ebc7f16fe"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"5ed72626a2e32520e16e1c49d0ab42867e8b0fc6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class tripleo::service_manifest ("},{"line_number":27,"context_line":"  $entries,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":"  service_manifest { \"/var/lib/tripleo/services/deployed-services.txt\":"},{"line_number":30,"context_line":"    entries \u003d\u003e $entries,"},{"line_number":31,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":32,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_453bafd1","line":29,"in_reply_to":"dab17558_4dd156cd","updated":"2016-05-09 13:19:15.000000000","message":"Should probably be named with \"services\", as it is. \"ipv6\" will probably also be called \"a service\" within composable t-h-t services codebase, even though it\u0027s not really a system service per se.","commit_id":"8b80d904572a57bbf4e628ef6b295e0ebc7f16fe"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"53397745d5894c8fb5b17249b74b9389446364a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class tripleo::service_manifest ("},{"line_number":27,"context_line":"  $entries,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":"  service_manifest { \"/var/lib/tripleo/services/deployed-services.txt\":"},{"line_number":30,"context_line":"    entries \u003d\u003e $entries,"},{"line_number":31,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":32,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_4dd156cd","line":29,"in_reply_to":"dab17558_8d969e92","updated":"2016-05-06 13:31:11.000000000","message":"Hmm maybe we should name it \"/var/lib/tripleo/roles/deployed-roles.txt\" instead? One thing someone mentioned is that there might actually be an \"ipv6\" role, i wonder if we want to capture such roles (which don\u0027t directly map to a service) in the manifest too.","commit_id":"8b80d904572a57bbf4e628ef6b295e0ebc7f16fe"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d9acd068e64eaa003d9d0bfd88714ae69151f213","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class tripleo::service_manifest ("},{"line_number":27,"context_line":"  $local_services,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":"  service_manifest { \u0027/var/lib/tripleo/services/local-services.txt\u0027:"},{"line_number":30,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":31,"context_line":"    entries \u003d\u003e $local_services,"},{"line_number":32,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_c856acd1","line":29,"updated":"2016-05-19 07:34:47.000000000","message":"should we handle the permissions of the file in the service_manifest type/provider? If not, seems to me like we need to overwrite them in a file resource after this is called.","commit_id":"ee95e4e2386cae506f6e0666f91705bc0f16f81a"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"cffb7808950a0a5150643f4e143b2faf9b98433d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class tripleo::service_manifest ("},{"line_number":27,"context_line":"  $local_services,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":"  service_manifest { \u0027/var/lib/tripleo/services/local-services.txt\u0027:"},{"line_number":30,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":31,"context_line":"    entries \u003d\u003e $local_services,"},{"line_number":32,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_f1bc9bdd","line":29,"in_reply_to":"bab6814e_c856acd1","updated":"2016-05-23 13:55:43.000000000","message":"Right, the implementation depended on the assumption that defaults for root dirs/files created by the root user would be 755/644.\n\nFor the manifest file itself, i\u0027ll chmod it from service manifest resource itself. I\u0027d hardcode it to 644 now as i don\u0027t think we\u0027ll ever need it different, but we can parametrize that later if we want.\n\nFor the manifest\u0027s directory, i\u0027ll use a file resource to manage the permissions. This requires to also manage the parent directory apparently, so i\u0027ll manage that from ::tripleo class itself.\n\nAlso i\u0027m adding a few more unit tests.\n\nThanks!","commit_id":"ee95e4e2386cae506f6e0666f91705bc0f16f81a"}]}
