)]}'
{"manifests/profile/base/neutron/lbaas.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6a676497ce53d5e62122235c28bff5cdfdb404b9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":48,"context_line":"    if hiera(\u0027neutron::enable_lbaas_agent\u0027, false) {"},{"line_number":49,"context_line":"      include ::neutron::services::lbaas"},{"line_number":50,"context_line":"      class {\u0027::neutron::agents::lbaas\u0027:"},{"line_number":51,"context_line":"        manage_haproxy_package \u003d\u003e $manage_haproxy_package,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bff0334d_47da8ee9","line":48,"updated":"2017-04-05 21:45:26.000000000","message":"please move this hiera lookup to a parameter on the class as it would make it easier to test this via rspec.  It would also be good to add some test coverage for these new files as well.","commit_id":"8916ba1994fa54c6e5a733f0607f224d5ebae5e5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7dab413dfddd0646ad93181a2da0c30f5c2e0df1","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":53,"context_line":"    if $enable_lbaas_agent {"},{"line_number":54,"context_line":"      include ::neutron::services::lbaas"},{"line_number":55,"context_line":"      class {\u0027::neutron::agents::lbaas\u0027:"},{"line_number":56,"context_line":"        manage_haproxy_package \u003d\u003e $manage_haproxy_package,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f044301_9b179546","line":53,"range":{"start_line":52,"start_character":2,"end_line":53,"end_character":26},"updated":"2017-05-07 19:27:09.000000000","message":"should just join these two together. No point in having to separate if clauses if there\u0027s nothing else here.\n\nif $step \u003e\u003d4 and $enable_lbaas_agent { ... }","commit_id":"8a54d96573f65bddb228d04769dc8f145e1a23b8"},{"author":{"_account_id":25593,"name":"AndrewToth","email":"atoth@redhat.com","username":"atoth"},"change_message_id":"a4965c51c95152a5676817b44c38259bfa4548e7","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":53,"context_line":"    if $enable_lbaas_agent {"},{"line_number":54,"context_line":"      include ::neutron::services::lbaas"},{"line_number":55,"context_line":"      class {\u0027::neutron::agents::lbaas\u0027:"},{"line_number":56,"context_line":"        manage_haproxy_package \u003d\u003e $manage_haproxy_package,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f044301_9bb3154e","line":53,"range":{"start_line":52,"start_character":2,"end_line":53,"end_character":26},"in_reply_to":"3f044301_9b179546","updated":"2017-05-07 19:41:08.000000000","message":"actually there is the #optional piece that is not within the if $enable_lbaas_agent clause so this recommendation would not respect the intent of the code.","commit_id":"8a54d96573f65bddb228d04769dc8f145e1a23b8"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"f4974a9cc066c818e826ecea7bc1b231cb2cabb0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      include ::neutron::services::lbaas"},{"line_number":55,"context_line":"      class {\u0027::neutron::agents::lbaas\u0027:"},{"line_number":56,"context_line":"        manage_haproxy_package \u003d\u003e $manage_haproxy_package,"},{"line_number":57,"context_line":"        enable_v1              \u003d\u003e $enable_v1,"},{"line_number":58,"context_line":"        enable_v2              \u003d\u003e $enable_v2,"},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f044301_3247747b","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":45},"updated":"2017-05-08 16:06:54.000000000","message":"those parameters are not present anymore in puppet-neutron : https://github.com/openstack/puppet-neutron/commit/a0e35a5ea11814a31c8af5ab5a782160c39c30c8","commit_id":"c44591b9d7249af1eda28a03306b5f4d54029155"},{"author":{"_account_id":25593,"name":"AndrewToth","email":"atoth@redhat.com","username":"atoth"},"change_message_id":"0f2576ee05aa2c04a653319bea8af23d8160492e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      include ::neutron::services::lbaas"},{"line_number":55,"context_line":"      class {\u0027::neutron::agents::lbaas\u0027:"},{"line_number":56,"context_line":"        manage_haproxy_package \u003d\u003e $manage_haproxy_package,"},{"line_number":57,"context_line":"        enable_v1              \u003d\u003e $enable_v1,"},{"line_number":58,"context_line":"        enable_v2              \u003d\u003e $enable_v2,"},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f044301_5a2096ac","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":45},"in_reply_to":"3f044301_3247747b","updated":"2017-05-11 18:03:07.000000000","message":"Yep, will fix","commit_id":"c44591b9d7249af1eda28a03306b5f4d54029155"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d64573bc08d440deecbf5d9b84e25bdcabb70dac","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Optional since manage_service may be false and neutron server may not be colocated."},{"line_number":63,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service\u003c| title \u003d\u003d \u0027neutron-lbaas-service\u0027 |\u003e"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f044301_2c5ddf79","line":63,"updated":"2017-05-08 14:20:50.000000000","message":"Since this is using collectors, this doesn\u0027t even need to be in any step.  My -1 remains because you can just put this outside of the step and it\u0027ll work when needed.  The problem if it\u0027s not collocated is that this relationship needs to be enforced with heat, so i\u0027m not sure we get a big benefit for splitting them apart unless we\u0027re defining this dependency in heat.","commit_id":"c44591b9d7249af1eda28a03306b5f4d54029155"},{"author":{"_account_id":25593,"name":"AndrewToth","email":"atoth@redhat.com","username":"atoth"},"change_message_id":"9e570af081b150feaffddf8a244b02781fbe3551","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Optional since manage_service may be false and neutron server may not be colocated."},{"line_number":63,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service\u003c| title \u003d\u003d \u0027neutron-lbaas-service\u0027 |\u003e"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f044301_3ab5ca7e","line":63,"in_reply_to":"3f044301_2c5ddf79","updated":"2017-05-11 17:57:04.000000000","message":"Ok, Spoke with Emilien at Summit about this and he advised to remove the line and restrict this to step 5 as the Neutron service needs to be available before this is started and that gets started in step 4.","commit_id":"c44591b9d7249af1eda28a03306b5f4d54029155"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"81deb2829c1138a86ac051000c75c2db094f72f5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   (Optional) Whether to manage the haproxy package."},{"line_number":23,"context_line":"#   Defaults to hiera(\u0027manage_haproxy_package\u0027, false)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*enable_lbaas_agent*]"},{"line_number":26,"context_line":"#   (optional) Whether to enable the use of an lbaas agent"},{"line_number":27,"context_line":"#   Defaults to hiera(\u0027neutron::enable_lbaas_agent\u0027, false)"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*step*]"},{"line_number":30,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1f013ff3_e2a60054","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":59},"updated":"2017-05-16 15:12:05.000000000","message":"This parameter seams useless because if you\u0027re using this class that means you want to enable lbaas","commit_id":"7983283efe397988beebec018c8200fa31b1806f"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"81deb2829c1138a86ac051000c75c2db094f72f5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $step                   \u003d hiera(\u0027step\u0027),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  #LBaaS Driver needs to be run @ $step\u003e\u003d5 as the neutron service needs to already be active which is run @ $step\u003d\u003d4"},{"line_number":43,"context_line":"  if (($step \u003e\u003d 5) and $enable_lbaas_agent) {"},{"line_number":44,"context_line":"    include ::neutron::services::lbaas"},{"line_number":45,"context_line":"    class {\u0027::neutron::agents::lbaas\u0027:"},{"line_number":46,"context_line":"      manage_haproxy_package \u003d\u003e $manage_haproxy_package"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1f013ff3_c231c40d","line":49,"range":{"start_line":40,"start_character":0,"end_line":49,"end_character":1},"updated":"2017-05-16 15:12:05.000000000","message":"I think it will be better if you use the same code than dhcp/metadata/l3 agents.\nhttps://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/neutron/dhcp.pp\nThe service is configure during step4 but started after neutron-server","commit_id":"7983283efe397988beebec018c8200fa31b1806f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"186be853e528db3ac7a5dbcdc222d9379c6ff671","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $step                   \u003d hiera(\u0027step\u0027),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  #LBaaS Driver needs to be run @ $step\u003e\u003d5 as the neutron service needs to already be active which is run @ $step\u003d\u003d4"},{"line_number":43,"context_line":"  if (($step \u003e\u003d 5) and $enable_lbaas_agent) {"},{"line_number":44,"context_line":"    include ::neutron::services::lbaas"},{"line_number":45,"context_line":"    class {\u0027::neutron::agents::lbaas\u0027:"},{"line_number":46,"context_line":"      manage_haproxy_package \u003d\u003e $manage_haproxy_package"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1f013ff3_5f746668","line":49,"range":{"start_line":40,"start_character":0,"end_line":49,"end_character":1},"in_reply_to":"1f013ff3_c231c40d","updated":"2017-05-16 16:35:12.000000000","message":"Dimitri: I think https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/neutron/dhcp.pp#L33 is useless if you run neutron-server \u0026 neutron-dhcp-agent on 2 different nodes, at the same step because nothing guarantees the orchestration will be addressed.\n\nWhat needs to be done is move all neutron agents at step 5.","commit_id":"7983283efe397988beebec018c8200fa31b1806f"}],"manifests/profile/pacemaker/neutron/lbaas.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"2b68e35607d5c4e6380f6b10e1ba15a243b3ecc3","unresolved":false,"context_lines":[{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  include ::neutron::params"},{"line_number":36,"context_line":"  include ::tripleo::profile::pacemaker::neutron"},{"line_number":37,"context_line":"  include ::tripleo::profile::base::neutron::lbaas"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  if $step \u003e\u003d 5 and downcase($::hostname) \u003d\u003d $pacemaker_master {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1f013ff3_c11a2616","line":36,"updated":"2017-05-12 15:51:55.000000000","message":"AFAICT this no longer exists. It\u0027s not clear that you need a lbaas pacemaker profile either.","commit_id":"2eda276e36244477d39af80081425879dac1f5fc"}]}