)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"77e72f84b59cea450542795802a6bda2833f556c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint refactor-puppet-manifests"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add OVN support for both pacemaker and non-har profiles of neutron"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3850a8b5584eaf14a656b547f6a47008a2d1289e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a9d85d2_d413165b","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":46},"updated":"2016-06-20 13:34:52.000000000","message":"non-ha","commit_id":"f9243a88ddc37af2724f2f313f4e9fa6c00f502e"}],"manifests/profile/base/neutron/agents/ovn.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"28a8a5f27d8136ca14881828dc84a14f3f8dc8a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"class tripleo::profile::base::neutron::agents::ovn ("},{"line_number":29,"context_line":"  $controller_node_names \u003d hiera(\u0027controller_node_names\u0027),"},{"line_number":30,"context_line":"  $step                  \u003d hiera(\u0027step\u0027)"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_f7409809","line":29,"updated":"2016-08-03 18:50:25.000000000","message":"the notion of controller will disappear with composable roles. You should rather create a new parameter, like \"ovn_controller\" or something similar.","commit_id":"e5965ff10b4b376e885e7de1a9c43c7f8cb080d1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3503ef7cf34a86b0ff75b0baafee8e752623466b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"class tripleo::profile::base::neutron::agents::ovn ("},{"line_number":29,"context_line":"  $controller_node_names \u003d hiera(\u0027controller_node_names\u0027),"},{"line_number":30,"context_line":"  $step                  \u003d hiera(\u0027step\u0027)"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9ad45d7e_f809e6de","line":29,"in_reply_to":"bacf61ea_2d1be781","updated":"2016-08-08 16:23:12.000000000","message":"You used controller_node_names but this parameter won\u0027t exist in the future because we\u0027re removing the notion of controller, so anyone can build their own roles.\nRename the parameter to what you like, and in THT, you\u0027ll create this parameter in the puppet/services/\u003cname of your service\u003e.yaml","commit_id":"e5965ff10b4b376e885e7de1a9c43c7f8cb080d1"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"d5030fa6aefc9f4dac336fb3391790d794228430","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"class tripleo::profile::base::neutron::agents::ovn ("},{"line_number":29,"context_line":"  $controller_node_names \u003d hiera(\u0027controller_node_names\u0027),"},{"line_number":30,"context_line":"  $step                  \u003d hiera(\u0027step\u0027)"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_2d1be781","line":29,"in_reply_to":"bacf61ea_f7409809","updated":"2016-08-04 09:41:24.000000000","message":"I am sorry, I could not understand your suggestion completely. Does it mean that I need to get the first controller node and pass that name alone to this script. I am not sure how we can do that in the heat templates from which this will be invoked. Any example can help me understand that part.","commit_id":"e5965ff10b4b376e885e7de1a9c43c7f8cb080d1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"28a8a5f27d8136ca14881828dc84a14f3f8dc8a6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":33,"context_line":"    $ovn_sbdb_host \u003d split($controller_node_names, \u0027,\u0027)[0]"},{"line_number":34,"context_line":"    $ovn_sbdb_port \u003d hiera(\u0027ovn::southbound::port\u0027)"},{"line_number":35,"context_line":"    class { \u0027::ovn::controller\u0027:"},{"line_number":36,"context_line":"      ovn_remote     \u003d\u003e \"tcp:${ovn_sbdb_host}:${ovn_sbdb_port}\","},{"line_number":37,"context_line":"      ovn_encap_ip   \u003d\u003e $::ipaddress,"},{"line_number":38,"context_line":"      ovn_encap_type \u003d\u003e hiera(\u0027ovn::southboud::encap_type\u0027)"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_7755c8c4","line":35,"updated":"2016-08-03 18:50:25.000000000","message":"you should just include ::ovn::controller here and do the rest via Hiera.","commit_id":"e5965ff10b4b376e885e7de1a9c43c7f8cb080d1"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"d5030fa6aefc9f4dac336fb3391790d794228430","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":33,"context_line":"    $ovn_sbdb_host \u003d split($controller_node_names, \u0027,\u0027)[0]"},{"line_number":34,"context_line":"    $ovn_sbdb_port \u003d hiera(\u0027ovn::southbound::port\u0027)"},{"line_number":35,"context_line":"    class { \u0027::ovn::controller\u0027:"},{"line_number":36,"context_line":"      ovn_remote     \u003d\u003e \"tcp:${ovn_sbdb_host}:${ovn_sbdb_port}\","},{"line_number":37,"context_line":"      ovn_encap_ip   \u003d\u003e $::ipaddress,"},{"line_number":38,"context_line":"      ovn_encap_type \u003d\u003e hiera(\u0027ovn::southboud::encap_type\u0027)"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_78cd9bb6","line":35,"in_reply_to":"bacf61ea_7755c8c4","updated":"2016-08-04 09:41:24.000000000","message":"I am sure there must be ways to manipulate the input strings for ovn_remote. But is there any way we substitute ovn_encap_ip through hiera settings? Any example will help my confusions get settled.","commit_id":"e5965ff10b4b376e885e7de1a9c43c7f8cb080d1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3503ef7cf34a86b0ff75b0baafee8e752623466b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":33,"context_line":"    $ovn_sbdb_host \u003d split($controller_node_names, \u0027,\u0027)[0]"},{"line_number":34,"context_line":"    $ovn_sbdb_port \u003d hiera(\u0027ovn::southbound::port\u0027)"},{"line_number":35,"context_line":"    class { \u0027::ovn::controller\u0027:"},{"line_number":36,"context_line":"      ovn_remote     \u003d\u003e \"tcp:${ovn_sbdb_host}:${ovn_sbdb_port}\","},{"line_number":37,"context_line":"      ovn_encap_ip   \u003d\u003e $::ipaddress,"},{"line_number":38,"context_line":"      ovn_encap_type \u003d\u003e hiera(\u0027ovn::southboud::encap_type\u0027)"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9ad45d7e_b8000eac","line":35,"in_reply_to":"bacf61ea_78cd9bb6","updated":"2016-08-08 16:23:12.000000000","message":"ok keep it like this then.","commit_id":"e5965ff10b4b376e885e7de1a9c43c7f8cb080d1"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"84ff76e6c03e76a1dab6dded92c41d860e673c66","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class tripleo::profile::base::neutron::agents::ovn ("},{"line_number":28,"context_line":"  $ovn_db_host,"},{"line_number":29,"context_line":"  $step                  \u003d hiera(\u0027step\u0027)"},{"line_number":30,"context_line":") {"},{"line_number":31,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":32,"context_line":"    $ovn_sbdb_port \u003d hiera(\u0027ovn::southbound::port\u0027)"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"9ad45d7e_c6a5bca2","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":25},"updated":"2016-08-10 11:19:23.000000000","message":"remove","commit_id":"e63262e93b4ca0fbb61dcf80e39cc4e7e678de62"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"df60fd9a2be320d0c25e82c18e9c88d6f4d98177","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    $ovn_sbdb_port \u003d hiera(\u0027ovn::southbound::port\u0027)"},{"line_number":33,"context_line":"    class { \u0027::ovn::controller\u0027:"},{"line_number":34,"context_line":"      ovn_remote     \u003d\u003e \"tcp:${ovn_db_host}:${ovn_sbdb_port}\","},{"line_number":35,"context_line":"      ovn_encap_ip   \u003d\u003e $::ipaddress,"},{"line_number":36,"context_line":"      ovn_encap_type \u003d\u003e hiera(\u0027ovn::southboud::encap_type\u0027)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"1ac06dbe_0b41c60b","line":35,"updated":"2016-08-25 14:49:03.000000000","message":"I am not sure which network we want this IP to be of? maybe we should set it from THT?","commit_id":"5ba9ef6faca91d7a7eb20121f447145c4a19063b"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"32059ded1f72971b39dce35086438df87261f34f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    $ovn_sbdb_port \u003d hiera(\u0027ovn::southbound::port\u0027)"},{"line_number":33,"context_line":"    class { \u0027::ovn::controller\u0027:"},{"line_number":34,"context_line":"      ovn_remote     \u003d\u003e \"tcp:${ovn_db_host}:${ovn_sbdb_port}\","},{"line_number":35,"context_line":"      ovn_encap_ip   \u003d\u003e $::ipaddress,"},{"line_number":36,"context_line":"      ovn_encap_type \u003d\u003e hiera(\u0027ovn::southboud::encap_type\u0027)"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"fa7ab95a_38a20faf","line":35,"in_reply_to":"1ac06dbe_0b41c60b","updated":"2016-08-29 06:11:26.000000000","message":"Thanks for the review Giulio, in the follow up patch I am using the ip address of an interface and the interface value will be set from THT.","commit_id":"5ba9ef6faca91d7a7eb20121f447145c4a19063b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4c09f702857c5528622c82e76c7a1817c265b301","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"class tripleo::profile::base::neutron::agents::ovn ("},{"line_number":33,"context_line":"  $ovn_db_host,"},{"line_number":34,"context_line":"  $encap_iface \u003d \u0027eth0\u0027,"},{"line_number":35,"context_line":"  $step        \u003d hiera(\u0027step\u0027)"},{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":"  include ::stdlib"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"fa7ab95a_cff862c6","line":34,"updated":"2016-08-29 12:47:20.000000000","message":"should this be the local node ip on one of the provisioned networks? internal_api maybe? in that case we can get the ip from heat with something like [1]\n\n1. https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/cinder-api.yaml#L86","commit_id":"05297cb4e204bbd762d8e97797090b763c336ab5"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"803be71b03d10aa87ca3582b481c5c4a13bacf2c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"class tripleo::profile::base::neutron::agents::ovn ("},{"line_number":33,"context_line":"  $ovn_db_host,"},{"line_number":34,"context_line":"  $encap_iface \u003d \u0027eth0\u0027,"},{"line_number":35,"context_line":"  $step        \u003d hiera(\u0027step\u0027)"},{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":"  include ::stdlib"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"fa7ab95a_4db8dac8","line":34,"in_reply_to":"fa7ab95a_cff862c6","updated":"2016-08-29 13:15:17.000000000","message":"This is in fact the local node IP. Thank you for pointing it out.","commit_id":"05297cb4e204bbd762d8e97797090b763c336ab5"}],"manifests/profile/base/neutron/ovn.pp":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"35a3c545a338c06e42982fa5936dfd073a51405e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class tripleo::profile::base::neutron::ovn ("},{"line_number":47,"context_line":"  $controller_node_ips \u003d hiera(\u0027controller_node_ips\u0027),"},{"line_number":48,"context_line":"  $ovn_nb_port \u003d hiera(\u0027ovn::northbound::port\u0027),"},{"line_number":49,"context_line":"  $ovsdb_connection_timeout \u003d hiera(\u0027neutron::plugins::ovn::ovsdb_connection_timeout\u0027),"},{"line_number":50,"context_line":"  $neutron_sync_mode \u003d hiera(\u0027neutron::plugins::ovn::neutron_sync_mode\u0027),"},{"line_number":51,"context_line":"  $vif_type \u003d hiera(\u0027neutron::plugins::ovn::vif_type\u0027),"},{"line_number":52,"context_line":"  $step \u003d hiera(\u0027step\u0027)"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":"    "},{"line_number":55,"context_line":"  include ::tripleo::profile::base::neutron::server"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_b6067783","line":52,"range":{"start_line":47,"start_character":2,"end_line":52,"end_character":23},"updated":"2016-05-12 05:39:08.000000000","message":"Please align format.","commit_id":"e48f1a0943ffddf60ee5eadebcf5ec9784620383"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"35a3c545a338c06e42982fa5936dfd073a51405e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $step \u003d hiera(\u0027step\u0027)"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":"    "},{"line_number":55,"context_line":"  include ::tripleo::profile::base::neutron::server"},{"line_number":56,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":57,"context_line":"    $ovn_nb_ip \u003d split($controller_node_ips, \u0027,\u0027)[0]"},{"line_number":58,"context_line":"    if $::ipaddress \u003d\u003d $ovn_nb_ip {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_56be2bae","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":2},"updated":"2016-05-12 05:39:08.000000000","message":"Please remove above extra spaces.","commit_id":"e48f1a0943ffddf60ee5eadebcf5ec9784620383"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"6fa4343f87e504cdadbad67556c2321a37c94d72","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"},{"line_number":62,"context_line":"      ovsdb_connection         \u003d\u003e \"tcp:${ovn_nb_ip}:${ovn_nb_port}\","},{"line_number":63,"context_line":"      ovsdb_connection_timeout \u003d\u003e $ovsdb_connection_timeout,"},{"line_number":64,"context_line":"      neutron_sync_mode        \u003d\u003e $neutron_sync_mode,"},{"line_number":65,"context_line":"      vif_type                 \u003d\u003e $vif_type"},{"line_number":66,"context_line":"    }"},{"line_number":67,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dab17558_5e3559d9","line":64,"updated":"2016-05-13 10:12:40.000000000","message":"neutron_sync_mode, vif_type and ovsdb_connection_timeout will all automatically bind to the class if they\u0027re namespaced as above, so unless they\u0027re used for something else you can probably remove them.","commit_id":"4c5ab969f8d9ec6371270dd9316cfc52ce3193d6"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"9b34b196d0a0ba52bb326405653c04e393b9138b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_16164a55","line":1,"updated":"2016-05-24 07:22:05.000000000","message":"You need to change the copyright to 2006","commit_id":"480c6da5789b019f773ebe3cd4e1dfcae587f45a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4170976ba11ecd18020bfc27aa9e928117daaba9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"class tripleo::profile::base::neutron::ovn ("},{"line_number":47,"context_line":"  $controller_node_ips      \u003d hiera(\u0027controller_node_ips\u0027),"},{"line_number":48,"context_line":"  $ovn_nb_port              \u003d hiera(\u0027ovn::northbound::port\u0027),"},{"line_number":49,"context_line":"  $ovsdb_connection_timeout \u003d hiera(\u0027neutron::plugins::ovn::ovsdb_connection_timeout\u0027),"},{"line_number":50,"context_line":"  $neutron_sync_mode        \u003d hiera(\u0027neutron::plugins::ovn::neutron_sync_mode\u0027),"},{"line_number":51,"context_line":"  $vif_type                 \u003d hiera(\u0027neutron::plugins::ovn::vif_type\u0027),"},{"line_number":52,"context_line":"  $step                     \u003d hiera(\u0027step\u0027)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_ede3d703","line":49,"updated":"2016-05-24 15:52:16.000000000","message":"why do we need to set this param?","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"8f39605c6b1cd709679af9894402baa17c62b950","unresolved":false,"context_lines":[{"line_number":46,"context_line":"class tripleo::profile::base::neutron::ovn ("},{"line_number":47,"context_line":"  $controller_node_ips      \u003d hiera(\u0027controller_node_ips\u0027),"},{"line_number":48,"context_line":"  $ovn_nb_port              \u003d hiera(\u0027ovn::northbound::port\u0027),"},{"line_number":49,"context_line":"  $ovsdb_connection_timeout \u003d hiera(\u0027neutron::plugins::ovn::ovsdb_connection_timeout\u0027),"},{"line_number":50,"context_line":"  $neutron_sync_mode        \u003d hiera(\u0027neutron::plugins::ovn::neutron_sync_mode\u0027),"},{"line_number":51,"context_line":"  $vif_type                 \u003d hiera(\u0027neutron::plugins::ovn::vif_type\u0027),"},{"line_number":52,"context_line":"  $step                     \u003d hiera(\u0027step\u0027)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_3e6ce09b","line":49,"in_reply_to":"bab6814e_ede3d703","updated":"2016-05-24 17:30:21.000000000","message":"I guess Babu can answer this question properly, but please have a look at  this\nhttps://github.com/openstack/networking-ovn/blob/master/networking_ovn/common/config.py#L23","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4170976ba11ecd18020bfc27aa9e928117daaba9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $controller_node_ips      \u003d hiera(\u0027controller_node_ips\u0027),"},{"line_number":48,"context_line":"  $ovn_nb_port              \u003d hiera(\u0027ovn::northbound::port\u0027),"},{"line_number":49,"context_line":"  $ovsdb_connection_timeout \u003d hiera(\u0027neutron::plugins::ovn::ovsdb_connection_timeout\u0027),"},{"line_number":50,"context_line":"  $neutron_sync_mode        \u003d hiera(\u0027neutron::plugins::ovn::neutron_sync_mode\u0027),"},{"line_number":51,"context_line":"  $vif_type                 \u003d hiera(\u0027neutron::plugins::ovn::vif_type\u0027),"},{"line_number":52,"context_line":"  $step                     \u003d hiera(\u0027step\u0027)"},{"line_number":53,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_4df143cd","line":50,"updated":"2016-05-24 15:52:16.000000000","message":"same question","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4170976ba11ecd18020bfc27aa9e928117daaba9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $ovn_nb_port              \u003d hiera(\u0027ovn::northbound::port\u0027),"},{"line_number":49,"context_line":"  $ovsdb_connection_timeout \u003d hiera(\u0027neutron::plugins::ovn::ovsdb_connection_timeout\u0027),"},{"line_number":50,"context_line":"  $neutron_sync_mode        \u003d hiera(\u0027neutron::plugins::ovn::neutron_sync_mode\u0027),"},{"line_number":51,"context_line":"  $vif_type                 \u003d hiera(\u0027neutron::plugins::ovn::vif_type\u0027),"},{"line_number":52,"context_line":"  $step                     \u003d hiera(\u0027step\u0027)"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":"  include ::tripleo::profile::base::neutron::server"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_cdb37309","line":51,"updated":"2016-05-24 15:52:16.000000000","message":"same question","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"69c72872f31c520139bbf14ffa3a7e66bc842f75","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $ovn_nb_port              \u003d hiera(\u0027ovn::northbound::port\u0027),"},{"line_number":49,"context_line":"  $ovsdb_connection_timeout \u003d hiera(\u0027neutron::plugins::ovn::ovsdb_connection_timeout\u0027),"},{"line_number":50,"context_line":"  $neutron_sync_mode        \u003d hiera(\u0027neutron::plugins::ovn::neutron_sync_mode\u0027),"},{"line_number":51,"context_line":"  $vif_type                 \u003d hiera(\u0027neutron::plugins::ovn::vif_type\u0027),"},{"line_number":52,"context_line":"  $step                     \u003d hiera(\u0027step\u0027)"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":"  include ::tripleo::profile::base::neutron::server"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_ecdc46e6","line":51,"in_reply_to":"9abb7d3a_55aa9c71","updated":"2016-05-30 18:44:31.000000000","message":"don\u0027t pass them here, they are not used in this manifest. You should rather set them in THT. That\u0027s all.","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"07f2a0c5ac2b0a2e3bfb628613c2a3d7f6ce7e89","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $ovn_nb_port              \u003d hiera(\u0027ovn::northbound::port\u0027),"},{"line_number":49,"context_line":"  $ovsdb_connection_timeout \u003d hiera(\u0027neutron::plugins::ovn::ovsdb_connection_timeout\u0027),"},{"line_number":50,"context_line":"  $neutron_sync_mode        \u003d hiera(\u0027neutron::plugins::ovn::neutron_sync_mode\u0027),"},{"line_number":51,"context_line":"  $vif_type                 \u003d hiera(\u0027neutron::plugins::ovn::vif_type\u0027),"},{"line_number":52,"context_line":"  $step                     \u003d hiera(\u0027step\u0027)"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":"  include ::tripleo::profile::base::neutron::server"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_55aa9c71","line":51,"in_reply_to":"bab6814e_cdb37309","updated":"2016-05-27 06:31:45.000000000","message":"Hi Emilien,\nThe above parameters will be passed to ::neutron::plugins::ovn. Kindly have a look at https://review.openstack.org/#/c/314875/4/manifests/profile/base/neutron/ovn.pp.\nAbove is an older version to this patch","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4170976ba11ecd18020bfc27aa9e928117daaba9","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":57,"context_line":"    $ovn_nb_ip \u003d split($controller_node_ips, \u0027,\u0027)[0]"},{"line_number":58,"context_line":"    if $::ipaddress \u003d\u003d $ovn_nb_ip {"},{"line_number":59,"context_line":"      include ::ovn::northd"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_6dd7e723","line":58,"updated":"2016-05-24 15:52:16.000000000","message":"it sounds very risky in the case of multiple interfaces or when using ipv6.","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"69c72872f31c520139bbf14ffa3a7e66bc842f75","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":57,"context_line":"    $ovn_nb_ip \u003d split($controller_node_ips, \u0027,\u0027)[0]"},{"line_number":58,"context_line":"    if $::ipaddress \u003d\u003d $ovn_nb_ip {"},{"line_number":59,"context_line":"      include ::ovn::northd"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_0cf9ca4d","line":58,"in_reply_to":"9abb7d3a_35d1d8fc","updated":"2016-05-30 18:44:31.000000000","message":"hostname might work... I haven\u0027t tested the result though.","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"07f2a0c5ac2b0a2e3bfb628613c2a3d7f6ce7e89","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":57,"context_line":"    $ovn_nb_ip \u003d split($controller_node_ips, \u0027,\u0027)[0]"},{"line_number":58,"context_line":"    if $::ipaddress \u003d\u003d $ovn_nb_ip {"},{"line_number":59,"context_line":"      include ::ovn::northd"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_35d1d8fc","line":58,"in_reply_to":"bab6814e_6dd7e723","updated":"2016-05-27 06:31:45.000000000","message":"I agree. Do you think it will be better to use controller_node_names and check it against $::hostname?\nThe idea is to run ovn::northd only on the first controller node","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4170976ba11ecd18020bfc27aa9e928117daaba9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"      include ::ovn::northd"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"},{"line_number":62,"context_line":"      ovsdb_connection         \u003d\u003e \"tcp:${ovn_nb_ip}:${ovn_nb_port}\","},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_adaf0f93","line":62,"updated":"2016-05-24 15:52:16.000000000","message":"please align it correctly.","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"07f2a0c5ac2b0a2e3bfb628613c2a3d7f6ce7e89","unresolved":false,"context_lines":[{"line_number":59,"context_line":"      include ::ovn::northd"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"},{"line_number":62,"context_line":"      ovsdb_connection         \u003d\u003e \"tcp:${ovn_nb_ip}:${ovn_nb_port}\","},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_b5b5c8d1","line":62,"in_reply_to":"bab6814e_adaf0f93","updated":"2016-05-27 06:31:45.000000000","message":"ok.","commit_id":"bb48a263ac6187cc8848524e32571f99c8e662bb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"77e72f84b59cea450542795802a6bda2833f556c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   for more details."},{"line_number":26,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"class tripleo::profile::base::neutron::ovn ("},{"line_number":29,"context_line":"  $controller_node_names \u003d hiera(\u0027controller_node_names\u0027),"},{"line_number":30,"context_line":"  $step                  \u003d hiera(\u0027step\u0027)"},{"line_number":31,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a9d85d2_f48d727c","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":42},"updated":"2016-06-20 13:34:52.000000000","message":"it should be tripleo::profile::base::neutron::plugins::ovn","commit_id":"f9243a88ddc37af2724f2f313f4e9fa6c00f502e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"77e72f84b59cea450542795802a6bda2833f556c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $controller_node_names \u003d hiera(\u0027controller_node_names\u0027),"},{"line_number":30,"context_line":"  $step                  \u003d hiera(\u0027step\u0027)"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  include ::tripleo::profile::base::neutron::server"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":35,"context_line":"    $ovn_nb_host \u003d split($controller_node_names, \u0027,\u0027)[0]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a9d85d2_7481824a","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":51},"updated":"2016-06-20 13:34:52.000000000","message":"do not include that, it\u0027s another profile/service","commit_id":"f9243a88ddc37af2724f2f313f4e9fa6c00f502e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"77e72f84b59cea450542795802a6bda2833f556c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":35,"context_line":"    $ovn_nb_host \u003d split($controller_node_names, \u0027,\u0027)[0]"},{"line_number":36,"context_line":"    if $::hostname \u003d\u003d $ovn_nb_host {"},{"line_number":37,"context_line":"      include ::ovn::northd"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"    $ovn_nb_port \u003d hiera(\u0027ovn::northbound::port\u0027)"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a9d85d2_14bf5efc","line":36,"updated":"2016-06-20 13:34:52.000000000","message":"please add a note, that we might split northd from plugin later, in the case of micro-services, where neutron-server \u0026 northd are on separated containers.","commit_id":"f9243a88ddc37af2724f2f313f4e9fa6c00f502e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"77e72f84b59cea450542795802a6bda2833f556c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    $ovn_nb_port \u003d hiera(\u0027ovn::northbound::port\u0027)"},{"line_number":40,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"},{"line_number":41,"context_line":"      ovsdb_connection         \u003d\u003e \"tcp:${ovn_nb_host}:${ovn_nb_port}\","},{"line_number":42,"context_line":"      ovn_nb_port              \u003d\u003e $ovn_nb_port,"},{"line_number":43,"context_line":"      ovsdb_connection_timeout \u003d\u003e hiera(\u0027neutron::plugins::ovn::ovsdb_connection_timeout\u0027),"},{"line_number":44,"context_line":"      neutron_sync_mode        \u003d\u003e hiera(\u0027neutron::plugins::ovn::neutron_sync_mode\u0027),"},{"line_number":45,"context_line":"      vif_type                 \u003d\u003e hiera(\u0027neutron::plugins::ovn::vif_type\u0027),"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a9d85d2_f45292dc","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":75},"updated":"2016-06-20 13:34:52.000000000","message":"drop it and you\u0027ll set it with hiera in THT when creating the profile.","commit_id":"f9243a88ddc37af2724f2f313f4e9fa6c00f502e"}],"manifests/profile/base/neutron/plugins/ml2_ovn.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"28a8a5f27d8136ca14881828dc84a14f3f8dc8a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"class tripleo::profile::base::neutron::plugins::ml2_ovn ("},{"line_number":29,"context_line":"  $controller_node_names \u003d hiera(\u0027controller_node_names\u0027),"},{"line_number":30,"context_line":"  $step                  \u003d hiera(\u0027step\u0027)"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_b70460c6","line":29,"updated":"2016-08-03 18:50:25.000000000","message":"dito","commit_id":"e5965ff10b4b376e885e7de1a9c43c7f8cb080d1"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"84ff76e6c03e76a1dab6dded92c41d860e673c66","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class tripleo::profile::base::neutron::plugins::ml2_ovn ("},{"line_number":28,"context_line":"  $ovn_db_host,"},{"line_number":29,"context_line":"  $step                  \u003d hiera(\u0027step\u0027)"},{"line_number":30,"context_line":") {"},{"line_number":31,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":32,"context_line":"    if $::hostname \u003d\u003d $ovn_db_host {"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"9ad45d7e_86ae247f","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":25},"updated":"2016-08-10 11:19:23.000000000","message":"remove","commit_id":"e63262e93b4ca0fbb61dcf80e39cc4e7e678de62"}],"manifests/profile/base/neutron/plugins/ovn.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"36c3161e0509c77434cec9f3e26a719d23fb9f7f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    $ovn_nb_host \u003d split($controller_node_names, \u0027,\u0027)[0]"},{"line_number":34,"context_line":"    if $::hostname \u003d\u003d $ovn_nb_host {"},{"line_number":35,"context_line":"      # NOTE: we might split northd from plugin later, in the case of"},{"line_number":36,"context_line":"      # micro-services, where neutron-server \u0026 northd are not in the same "},{"line_number":37,"context_line":"      # containers"},{"line_number":38,"context_line":"      include ::ovn::northd"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1aa78d24_986d3dcf","line":36,"range":{"start_line":36,"start_character":73,"end_line":36,"end_character":74},"updated":"2016-07-08 12:56:39.000000000","message":"whitespace","commit_id":"424cf967f2723f7f9d350593f3221c27511f6f8b"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"5a24df536ba491cfe53387ac770907d54b0751bf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    $ovn_nb_host \u003d split($controller_node_names, \u0027,\u0027)[0]"},{"line_number":34,"context_line":"    if $::hostname \u003d\u003d $ovn_nb_host {"},{"line_number":35,"context_line":"      # NOTE: we might split northd from plugin later, in the case of"},{"line_number":36,"context_line":"      # micro-services, where neutron-server \u0026 northd are not in the same "},{"line_number":37,"context_line":"      # containers"},{"line_number":38,"context_line":"      include ::ovn::northd"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1aa78d24_2d91329b","line":36,"range":{"start_line":36,"start_character":73,"end_line":36,"end_character":74},"in_reply_to":"1aa78d24_986d3dcf","updated":"2016-07-11 04:43:37.000000000","message":"Done","commit_id":"424cf967f2723f7f9d350593f3221c27511f6f8b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"36c3161e0509c77434cec9f3e26a719d23fb9f7f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"    $ovn_nb_port \u003d hiera(\u0027ovn::northbound::port\u0027)"},{"line_number":41,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"},{"line_number":42,"context_line":"      ovsdb_connection         \u003d\u003e \"tcp:${ovn_nb_host}:${ovn_nb_port}\","},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1aa78d24_78a971df","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":31},"updated":"2016-07-08 12:56:39.000000000","message":"remove useless space","commit_id":"424cf967f2723f7f9d350593f3221c27511f6f8b"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"5a24df536ba491cfe53387ac770907d54b0751bf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"    $ovn_nb_port \u003d hiera(\u0027ovn::northbound::port\u0027)"},{"line_number":41,"context_line":"    class { \u0027::neutron::plugins::ovn\u0027:"},{"line_number":42,"context_line":"      ovsdb_connection         \u003d\u003e \"tcp:${ovn_nb_host}:${ovn_nb_port}\","},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1aa78d24_6d8b3a69","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":31},"in_reply_to":"1aa78d24_78a971df","updated":"2016-07-11 04:43:37.000000000","message":"Done","commit_id":"424cf967f2723f7f9d350593f3221c27511f6f8b"}],"manifests/profile/pacemaker/neutron/ovn.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"77e72f84b59cea450542795802a6bda2833f556c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a9d85d2_7414e2f4","line":1,"updated":"2016-06-20 13:34:52.000000000","message":"this class is not needed, you can remove it.","commit_id":"f9243a88ddc37af2724f2f313f4e9fa6c00f502e"}]}