)]}'
{"manifests/profile/base/gnocchi.pp":[{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"33df97a5adea66156c4a8984e5f2c83ef310c96b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":32,"context_line":"    include ::gnocchi"},{"line_number":33,"context_line":"    include ::gnocchi::client"},{"line_number":34,"context_line":"    include ::gnocchi::db::mysql"},{"line_number":35,"context_line":"    include ::gnocchi::db::sync"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3aaa91ec_e1d5ccb9","line":35,"range":{"start_line":34,"start_character":4,"end_line":35,"end_character":31},"updated":"2016-06-21 18:16:42.000000000","message":"move these to backend.pp","commit_id":"3cfc03d7c7b1e04cc131fc2d6dce19b91b3ef090"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":32,"context_line":"    include ::gnocchi"},{"line_number":33,"context_line":"    include ::gnocchi::client"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_bccf3baf","line":33,"updated":"2016-06-22 12:10:32.000000000","message":"you\u0027re missing ::gnocchi::config","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a3f1ad7509c236c0cea0d662b8884a535f663d16","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    include ::gnocchi::config"},{"line_number":34,"context_line":"    include ::gnocchi::client"},{"line_number":35,"context_line":"    include ::gnocchi::db::mysql"},{"line_number":36,"context_line":"    include ::gnocchi::db::sync"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":45,"id":"1aa78d24_6d7203af","line":36,"updated":"2016-07-05 17:42:37.000000000","message":"you need to put this one on a $sync_db conditional.","commit_id":"4358459f77588656013fd82bd59704fe5f8a4446"}],"manifests/profile/base/gnocchi/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   for more details."},{"line_number":24,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class tripleo::profile::base::gnocchi::api ("},{"line_number":28,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_9c5ebfe7","line":26,"updated":"2016-06-22 12:10:32.000000000","message":"drop this # and let an empty space, like;\n\n  # blabla\n  #\n\n  class (...)","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class tripleo::profile::base::gnocchi::api ("},{"line_number":28,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::tripleo::profile::base::gnocchi"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_7c3cb393","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":19},"updated":"2016-06-22 12:10:32.000000000","message":"useless space","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"3f5de35cf40d1c898f17c320778540f8dd50ba48","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 3 and $sync_db {"},{"line_number":43,"context_line":"    include ::gnocchi::db::mysql"},{"line_number":44,"context_line":"    #This is conflicting with the deployment (sync)"},{"line_number":45,"context_line":"    #Not currently executed in THT"},{"line_number":46,"context_line":"    #include ::gnocchi::db::sync"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"3aaa91ec_b55ca2f1","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":32},"updated":"2016-06-27 13:02:15.000000000","message":"This is the manifest breaking the deployment.","commit_id":"e8054dd5f8a1547ac333c8b5051275c2777d9e4b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0e7e0d754b545e84e8dadb9b56202e0b822c6985","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 3 and $sync_db {"},{"line_number":43,"context_line":"    include ::gnocchi::db::mysql"},{"line_number":44,"context_line":"    include ::gnocchi::db::sync"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":46,"id":"1aa78d24_28cbc91f","line":44,"updated":"2016-07-05 18:15:22.000000000","message":"the dbsync will fail because","commit_id":"e6a9b6fbc0fbd4ac3970f401c8b0d2ee524c8894"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"61616bf223471e22a6cb50e74916ba5da9e6cb90","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 3 and $sync_db {"},{"line_number":43,"context_line":"    include ::gnocchi::db::mysql"},{"line_number":44,"context_line":"    include ::gnocchi::db::sync"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":46,"id":"1aa78d24_2ec73a65","line":44,"in_reply_to":"1aa78d24_08fecd36","updated":"2016-07-06 07:19:47.000000000","message":"Yeahp! Giulio told me about it and I fixed it before :)","commit_id":"e6a9b6fbc0fbd4ac3970f401c8b0d2ee524c8894"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1d375af76d1015e699776c3c8e03a24ff7b1a68","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 3 and $sync_db {"},{"line_number":43,"context_line":"    include ::gnocchi::db::mysql"},{"line_number":44,"context_line":"    include ::gnocchi::db::sync"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":46,"id":"1aa78d24_08fecd36","line":44,"in_reply_to":"1aa78d24_28cbc91f","updated":"2016-07-05 18:16:52.000000000","message":"I was about writing something but in fact no. Everything is fine. I thought ::gnocchi was at step 4 but actually is at 3 so we\u0027re good.","commit_id":"e6a9b6fbc0fbd4ac3970f401c8b0d2ee524c8894"}],"manifests/profile/base/gnocchi/backend.pp":[{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"33df97a5adea66156c4a8984e5f2c83ef310c96b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  include ::tripleo::profile::base::gnocchi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":39,"context_line":"    case $gnocchi_backend {"},{"line_number":40,"context_line":"      \u0027swift\u0027: { include ::gnocchi::storage::swift }"},{"line_number":41,"context_line":"      \u0027file\u0027: { include ::gnocchi::storage::file }"},{"line_number":42,"context_line":"      \u0027rbd\u0027: { include ::gnocchi::storage::ceph }"},{"line_number":43,"context_line":"      default: { fail(\u0027Unrecognized gnocchi_backend parameter.\u0027) }"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3aaa91ec_e1102cab","line":44,"range":{"start_line":39,"start_character":4,"end_line":44,"end_character":5},"updated":"2016-06-21 18:16:42.000000000","message":"I think the above block should go into storage.pp .. this should be indexer specific so we should include ::gnocchi::db::mysql here and perhaps sync. May be its clearer to rename this as db.pp instead?","commit_id":"3cfc03d7c7b1e04cc131fc2d6dce19b91b3ef090"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class tripleo::profile::base::gnocchi::backend ("},{"line_number":28,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_bc2bbb2f","line":27,"updated":"2016-06-22 12:10:32.000000000","message":"why do we need this profile? it\u0027s not a service, I think the db thing can be moved in API like we do for other services. Also, make sure to follow the step logic with sync_db boolean to run it only on pacemaker_master.","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class tripleo::profile::base::gnocchi::backend ("},{"line_number":28,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::tripleo::profile::base::gnocchi"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_fc6f0390","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":18},"updated":"2016-06-22 12:10:32.000000000","message":"useless space","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"}],"manifests/profile/base/gnocchi/metricd.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class tripleo::profile::base::gnocchi::metricd ("},{"line_number":28,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::tripleo::profile::base::gnocchi"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_dcdde743","line":28,"range":{"start_line":28,"start_character":9,"end_line":28,"end_character":17},"updated":"2016-06-22 12:10:32.000000000","message":"useless space","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  include ::tripleo::profile::base::gnocchi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    include ::gnocchi::metricd"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_1ccf6f80","line":34,"updated":"2016-06-22 12:10:32.000000000","message":"useless space","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    include ::gnocchi::metricd"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_9ca19fac","line":36,"updated":"2016-06-22 12:10:32.000000000","message":"useless space","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"}],"manifests/profile/base/gnocchi/monitor.pp":[{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"33df97a5adea66156c4a8984e5f2c83ef310c96b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    include ::gnocchi::metricd"},{"line_number":36,"context_line":"    include ::gnocchi::statsd"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3aaa91ec_8177a801","line":36,"range":{"start_line":35,"start_character":4,"end_line":36,"end_character":29},"updated":"2016-06-21 18:16:42.000000000","message":"its better to separate these out into their own .pp files. These are separate services.","commit_id":"3cfc03d7c7b1e04cc131fc2d6dce19b91b3ef090"}],"manifests/profile/base/gnocchi/statsd.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class tripleo::profile::base::gnocchi::statsd ("},{"line_number":28,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::tripleo::profile::base::gnocchi"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_7c8dd330","line":28,"range":{"start_line":28,"start_character":9,"end_line":28,"end_character":17},"updated":"2016-06-22 12:10:32.000000000","message":"use less space","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  include ::tripleo::profile::base::gnocchi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    include ::gnocchi::statsd"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_dcab2788","line":34,"updated":"2016-06-22 12:10:32.000000000","message":"same","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    include ::gnocchi::statsd"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_fc926356","line":36,"updated":"2016-06-22 12:10:32.000000000","message":"same","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"}],"manifests/profile/base/gnocchi/storage.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class tripleo::profile::base::gnocchi::storage ("},{"line_number":32,"context_line":"  $gnocchi_backend \u003d downcase(hiera(\u0027gnocchi_backend\u0027, \u0027swift\u0027)),"},{"line_number":33,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":34,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_9cdd1f17","line":31,"updated":"2016-06-22 12:10:32.000000000","message":"I\u0027m not sure it should be a profile. Who needs storage config? API? If yes, move the code to api profile.","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"}],"manifests/profile/pacemaker/gnocchi.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"19b2820c254ad498ed03c7095c9faf6f1b52dae2","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    pacemaker::resource::service { $::gnocchi::params::metricd_service_name :"},{"line_number":68,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    pacemaker::resource::service { $::gnocchi::params::statsd_service_name :"},{"line_number":71,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"    pacemaker::constraint::base { \u0027gnocchi-metricd-then-gnocchi-statsd-constraint\u0027:"},{"line_number":74,"context_line":"      constraint_type \u003d\u003e \u0027order\u0027,"},{"line_number":75,"context_line":"      first_resource  \u003d\u003e \"${::gnocchi::params::metricd_service_name}-clone\","}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9abb7d3a_a7f0a367","line":72,"range":{"start_line":67,"start_character":0,"end_line":72,"end_character":5},"updated":"2016-06-03 14:38:16.000000000","message":"Managed to deploy the ha job and this is the output:\n\nError: Duplicate declaration:\n  Pacemaker::Resource::Service[undef] is already declared in file /var/lib/heat-config/heat-config-puppet/e53277f1-65b1-4c69-a420-896b61b1eca1.pp:1058;\n  cannot redeclare at /var/lib/heat-config/heat-config-puppet/e53277f1-65b1-4c69-a420-896b61b1eca1.pp:1061 on node overcloud-controller-0.localdomain\n\n\n    pacemaker::resource::service { $::gnocchi::params::metricd_service_name :\n      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,\n    }\n    pacemaker::resource::service { $::gnocchi::params::statsd_service_name :\n      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,\n    }\n\nThese lines are duplicated.","commit_id":"34594107f35f8eb826ed6886a4d4d73a2b19993c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"cfe05f96c57d118eb9e7963fd71bcc0dd04fd806","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if $sync_db {"},{"line_number":72,"context_line":"      class { \u0027::gnocchi::db::mysql\u0027:"},{"line_number":73,"context_line":"        require \u003d\u003e Exec[\u0027galera-ready\u0027],"},{"line_number":74,"context_line":"      }"},{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    pacemaker::resource::service { $::gnocchi::params::metricd_service_name :"},{"line_number":78,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7aa08908_9b5c02ef","line":75,"range":{"start_line":71,"start_character":0,"end_line":75,"end_character":5},"updated":"2016-06-10 07:35:18.000000000","message":"this shouldn\u0027t be here. It\u0027s already taken into use in tripleo::profile::base::gnocchi. So that require needs to be done differently.","commit_id":"e73b954a9dc663c10ef02740de5cc1f7b0f101c9"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"8b335400b156c69172ecc26d22f2d5d3e7c2b871","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if $sync_db {"},{"line_number":72,"context_line":"      class { \u0027::gnocchi::db::mysql\u0027:"},{"line_number":73,"context_line":"        require \u003d\u003e Exec[\u0027galera-ready\u0027],"},{"line_number":74,"context_line":"      }"},{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    pacemaker::resource::service { $::gnocchi::params::metricd_service_name :"},{"line_number":78,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7aa08908_a85fd973","line":75,"range":{"start_line":71,"start_character":0,"end_line":75,"end_character":5},"in_reply_to":"7aa08908_9b5c02ef","updated":"2016-06-10 15:10:29.000000000","message":"hmm So whats the best way to include the galera requires? or is this already handled somewhere?","commit_id":"e73b954a9dc663c10ef02740de5cc1f7b0f101c9"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"503a8179fe6c6fe4b8a5c0e98444779a92811999","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if $sync_db {"},{"line_number":72,"context_line":"      class { \u0027::gnocchi::db::mysql\u0027:"},{"line_number":73,"context_line":"        require \u003d\u003e Exec[\u0027galera-ready\u0027],"},{"line_number":74,"context_line":"      }"},{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    pacemaker::resource::service { $::gnocchi::params::metricd_service_name :"},{"line_number":78,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7aa08908_42c24686","line":75,"range":{"start_line":71,"start_character":0,"end_line":75,"end_character":5},"in_reply_to":"7aa08908_a85fd973","updated":"2016-06-13 14:42:03.000000000","message":"Currently living here:\n  https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/manifests/overcloud_controller_pacemaker.pp#L288","commit_id":"e73b954a9dc663c10ef02740de5cc1f7b0f101c9"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"b248525ac00dddf1bc4923d8bc5f89c5039f5949","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      enabled         \u003d\u003e false,"},{"line_number":73,"context_line":"      step            \u003d\u003e $step,"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3aaa91ec_afb9f5ee","line":75,"updated":"2016-06-21 16:24:46.000000000","message":"This needs to be updated to reflect the service split.","commit_id":"3cfc03d7c7b1e04cc131fc2d6dce19b91b3ef090"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"9ab208112cb1ca6429755e21a1c91345026a48d0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      enabled         \u003d\u003e false,"},{"line_number":73,"context_line":"      step            \u003d\u003e $step,"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3aaa91ec_6fc42d40","line":75,"in_reply_to":"3aaa91ec_afb9f5ee","updated":"2016-06-21 16:27:53.000000000","message":"Yeahp, Im finishing the nonha deployment.. Ill start with the ha part when the other works fine, as changes were made to puppet-tripleo, ha and upgrades should fail until fixed.","commit_id":"3cfc03d7c7b1e04cc131fc2d6dce19b91b3ef090"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bec452d6c14cf293878c9e3867011db3bf1001b2","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  include ::tripleo::profile::base::gnocchi"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  if $step \u003e\u003d 2 and $sync_db {"},{"line_number":62,"context_line":"    if $gnocchi_indexer_backend \u003d\u003d \u0027mysql\u0027 {"},{"line_number":63,"context_line":"      class { \u0027::gnocchi::db::mysql\u0027:"},{"line_number":64,"context_line":"        require \u003d\u003e Exec[\u0027galera-ready\u0027],"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"    }"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_5cf3b79e","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":5},"updated":"2016-06-22 12:10:32.000000000","message":"no, please include base classes and use booleans.\nlike I said, please look how we did ceilometer:\nhttps://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/pacemaker/ceilometer/collector.pp#L43-L45","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"71c452f302e0a6d2683425eed2f82b9a81b9e9cf","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  include ::tripleo::profile::base::gnocchi"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  if $step \u003e\u003d 2 and $sync_db {"},{"line_number":62,"context_line":"    if $gnocchi_indexer_backend \u003d\u003d \u0027mysql\u0027 {"},{"line_number":63,"context_line":"      class { \u0027::gnocchi::db::mysql\u0027:"},{"line_number":64,"context_line":"        require \u003d\u003e Exec[\u0027galera-ready\u0027],"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"    }"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"3aaa91ec_8cd04e55","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":5},"in_reply_to":"3aaa91ec_5cf3b79e","updated":"2016-06-22 12:52:09.000000000","message":"hmm we do the same thing in ceilo profiles:\n\nhttps://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/pacemaker/ceilometer.pp#L66-L71","commit_id":"93d94ced3bae6db47b6e9fe214d8fadfefe70089"}],"manifests/profile/pacemaker/gnocchi/api.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"5c00a036fe13e1a2e5d21bac2ab832ff394ea24a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::tripleo::profile::pacemaker::gnocchi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  class { \u0027::tripleo::profile::base::gnocchi::api\u0027:"},{"line_number":43,"context_line":"    step            \u003d\u003e $step,"},{"line_number":44,"context_line":"    sync_db         \u003d\u003e (downcase($::hostname) \u003d\u003d $pacemaker_master),"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"3aaa91ec_075b902f","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":68},"updated":"2016-06-22 14:46:08.000000000","message":"not properly aligned:\n\n2016-06-22 14:08:08.672008 | manifests/profile/pacemaker/gnocchi/api.pp:43:WARNING: indentation of \u003d\u003e is not properly aligned\n2016-06-22 14:08:08.672205 | manifests/profile/pacemaker/gnocchi/api.pp:44:WARNING: indentation of \u003d\u003e is not properly aligned\n2016-06-22 14:08:08.682744 | [Zuul] Task exit code: 1\n2016-06-22 14:08:11.543390 | [Zuul] Job complete, result: FAILURE","commit_id":"e094e813b5a90de39cf41d16b28dfa07bee367da"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"c258f568e8d1ee00e28bc39819585d6d1432a570","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::tripleo::profile::pacemaker::gnocchi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  class { \u0027::tripleo::profile::base::gnocchi::api\u0027:"},{"line_number":43,"context_line":"    step    \u003d\u003e $step,"},{"line_number":44,"context_line":"    sync_db \u003d\u003e (downcase($::hostname) \u003d\u003d $pacemaker_master),"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":41,"id":"3aaa91ec_b11a9d7a","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":3},"updated":"2016-06-28 19:27:33.000000000","message":"Not sure if this can be changed directly to:\n  ::tripleo::profile::base::gnocchi::api:\n(Removing the unused params here)\nAlso, ::tripleo::profile::base::gnocchi::api is calling ::tripleo::profile::base::gnocchi so, not sure if this can conflict with the ha deployment.\n\nIn any case the nonha and ha deployment runs without errors.","commit_id":"f0e605693c6804fd0c8429f8bae37905a5b596e8"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"099f35b7098d38dc16fd610da0c3a9a7c972f652","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::tripleo::profile::pacemaker::gnocchi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  class { \u0027::tripleo::profile::base::gnocchi::api\u0027:"},{"line_number":43,"context_line":"    step    \u003d\u003e $step,"},{"line_number":44,"context_line":"    sync_db \u003d\u003e (downcase($::hostname) \u003d\u003d $pacemaker_master),"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"3aaa91ec_9538d8d4","line":45,"range":{"start_line":42,"start_character":1,"end_line":45,"end_character":3},"updated":"2016-06-30 08:29:31.000000000","message":"Not sure if this can be changed directly to:\n  ::tripleo::profile::base::gnocchi::api:\n(Removing the unused params here)\nAlso, ::tripleo::profile::base::gnocchi::api is calling ::tripleo::profile::base::gnocchi so, not sure if this can conflict with the ha deployment.\n\nIn any case the nonha and ha deployment runs without errors.","commit_id":"5ce9daab434d0b8f47db5b841f7bc293958d8aa1"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"ec118cfbbcb1ae4b399f4c5f622ec1a1d76dd885","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::tripleo::profile::pacemaker::gnocchi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  class { \u0027::tripleo::profile::base::gnocchi::api\u0027:"},{"line_number":43,"context_line":"    step    \u003d\u003e $step,"},{"line_number":44,"context_line":"    sync_db \u003d\u003e (downcase($::hostname) \u003d\u003d $pacemaker_master),"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"3aaa91ec_481c076a","line":45,"range":{"start_line":42,"start_character":1,"end_line":45,"end_character":3},"in_reply_to":"3aaa91ec_9538d8d4","updated":"2016-06-30 13:57:48.000000000","message":"i think we can leave this as is. In case its not running on pcmk master the sync_db will be false which needs to propagate.","commit_id":"5ce9daab434d0b8f47db5b841f7bc293958d8aa1"}]}