)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"11d8d6a2457dc560cf534f71e0c5aa6e95540802","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Qasim Sarfraz \u003cqasims@plumgrid.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-17 10:41:49 +0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add plumgrid neutron profile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8536782d433f97a9b619e54a1eb1ea0edb8fdaf0"},{"line_number":10,"context_line":"Implements: blueprint refactor-puppet-manifests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_e2c86faa","line":7,"updated":"2016-05-17 07:10:15.000000000","message":"link to the tripleo-heat-templates side of this once you have it please","commit_id":"4698248544fc810f180e4b18b270fa2a028335ca"}],"manifests/profile/base/neutron.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"2a74f96c31fbb986f1be2dc3b4c0cc1701ad14d0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"class tripleo::profile::base::neutron ("},{"line_number":30,"context_line":"  $core_plugin \u003d hiera(\u0027neutron::core_plugin\u0027, \u0027ml2\u0027),"},{"line_number":31,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_eacc086c","line":30,"updated":"2016-05-20 04:09:46.000000000","message":"I apologise, my earlier comment was incorrect and this isn\u0027t needed. We did originally have a switch statement in this class to select the plugin, but I believe this is being moved into the t-h-t side so that the plugin is selected there, and it will include the plugin profile directly. The proposed ML2 one is here: https://review.openstack.org/#/c/308514/10/puppet/services/neutron-ml2.yaml\n\nyou can see down the bottom the profile is included. I\u0027d imagine you\u0027d want a similar service definition for plumgrid.","commit_id":"8b8f0ab29dde0b507385f71d1e7f50ed7debbbcd"}],"manifests/profile/base/neutron/plugins/plumgrid.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9efb5e6a8bd47a0646733adc672c6206789b0504","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*sync_db*]"},{"line_number":27,"context_line":"#   (Optional) Whether to run Neutron DB sync operations"},{"line_number":28,"context_line":"#   Defaults to undef"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::base::neutron::plugins::plumgrid ("},{"line_number":31,"context_line":"  $step    \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7aa08908_fed6adc1","line":28,"updated":"2016-06-10 20:12:28.000000000","message":"default to true","commit_id":"f64cf77784a1015d558a30a17b38e0dd8cd8718c"}],"manifests/profile/base/neutron/plumgrid.pp":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"edfcdbb71c82e43b0a44701a1c158ec2f0ce99d8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027, \u0027\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027, \u0027\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027, \u0027\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027, \u0027\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_ccdb154e","line":44,"range":{"start_line":44,"start_character":57,"end_line":44,"end_character":58},"updated":"2016-05-20 10:04:02.000000000","message":"Do you actually want to default the password to an empty string?\n\nLikewise the other settings - will we get a better error path if someone makes a mistake in a template and forgets to pass one of these items if we just don\u0027t have any defaults?","commit_id":"956c000ede9b4947438747317bc638f0943a61e9"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"c4e21dd4768e1e2c39762ca56ccc0bebbf9bf701","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027, \u0027\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027, \u0027\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027, \u0027\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027, \u0027\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_7a0d503d","line":44,"range":{"start_line":44,"start_character":57,"end_line":44,"end_character":58},"in_reply_to":"bab6814e_85df14d5","updated":"2016-05-26 20:33:27.000000000","message":"Thanks Micheal and Steve. It makes more sense not to pass any defaults here.\n\nI have updated the patch set accordingly.","commit_id":"956c000ede9b4947438747317bc638f0943a61e9"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"8d4d9b39caf909e1930451687bb1ee406b97c85d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027, \u0027\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027, \u0027\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027, \u0027\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027, \u0027\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_85df14d5","line":44,"range":{"start_line":44,"start_character":57,"end_line":44,"end_character":58},"in_reply_to":"bab6814e_bc919c49","updated":"2016-05-26 12:24:08.000000000","message":"If your manifest won\u0027t work without a param being set, it should fail when it\u0027s not. Unless the empty string is a legitimate default value then remove it or replace it with a better default. Ignore the midonet class - it\u0027s copied from the original overcloud.pp in t-h-t and hasn\u0027t actually been implemented yet as a composable service afaik.","commit_id":"956c000ede9b4947438747317bc638f0943a61e9"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"f09b6fb41717f8bee0bf3ae4e5dc5b7407972b50","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027, \u0027\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027, \u0027\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027, \u0027\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027, \u0027\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_bc919c49","line":44,"range":{"start_line":44,"start_character":57,"end_line":44,"end_character":58},"in_reply_to":"bab6814e_ccdb154e","updated":"2016-05-20 11:10:49.000000000","message":"I was passing the empty strings for consistency with other manifests, https://review.openstack.org/#/c/293436/21/manifests/profile/base/neutron/midonet.pp.\n\nI agree ideally the default values should be coming from t-h-t. if we agree on keeping it that way I can update the patch accordingly.\n\nMichael, any comment from your side?","commit_id":"956c000ede9b4947438747317bc638f0943a61e9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"80602af7342fdb1970851dc07eb5e01f2393bca4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   for more details."},{"line_number":40,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":41,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_9b6f57c3","line":42,"updated":"2016-05-26 21:03:47.000000000","message":"same command as neutron_metadata_proxy_shared_secret, we need to find another lookup I think.","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"4564907e7dafe59657992f491073614ca941bcbb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   for more details."},{"line_number":40,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":41,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_773cd293","line":42,"in_reply_to":"9abb7d3a_720376b9","updated":"2016-05-28 17:42:32.000000000","message":"I will use that then.","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"d527de354fe3da3bfddeaa7fe2af33899add2f66","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   for more details."},{"line_number":40,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":41,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_fe15b13f","line":42,"in_reply_to":"bab6814e_9b6f57c3","updated":"2016-05-26 21:29:03.000000000","message":"neutron_dsn, https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/controller.yaml, can be a better lookup for this.","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"37007dbfff387498babee6474b22525dec063c5c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   for more details."},{"line_number":40,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":41,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_720376b9","line":42,"in_reply_to":"bab6814e_fe15b13f","updated":"2016-05-27 05:05:00.000000000","message":"maybe that\u0027s a more appropriate one to look for.","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"80602af7342fdb1970851dc07eb5e01f2393bca4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_7b76f3a4","line":45,"updated":"2016-05-26 21:03:47.000000000","message":"I\u0027m afraid this parameter will miss in hiera when we\u0027ll split roles \u0026 hieradata. I think we need a parameter \"neutron_metadata_proxy_shared_secret\" consumed by both nova::api::neutron_metadata_proxy_shared_secret and neutron classes.","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"4564907e7dafe59657992f491073614ca941bcbb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_9737b6af","line":45,"in_reply_to":"9abb7d3a_52ee32ed","updated":"2016-05-28 17:42:32.000000000","message":"Makes sense. What about \"neutron::agents::metadata::shared_secret\" that can be a better look up right? if not I will the hiera in t-h-t.","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"9308cf6cc7e73bc6e1a8aa567c81db24164e95fa","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_3e19f922","line":45,"in_reply_to":"bab6814e_1e2eb58b","updated":"2016-05-26 21:38:10.000000000","message":"Passing \u0027undef\u0027 here and taking care of it in t-h-t can be another option?","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"37007dbfff387498babee6474b22525dec063c5c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_52ee32ed","line":45,"in_reply_to":"bab6814e_3e19f922","updated":"2016-05-27 05:05:00.000000000","message":"The point is that when we split roles, we cannot longer asure that the nova::api resource will be available in the same node as this resource. So you won\u0027t be able to fetch the \"neutron_metadata_proxy_shared_secret\" as before. So you should probably add a shared \"shared secret\" option via hiera in t-h-t if you will need it from here. I wouldn\u0027t make it undef though, since it seems to me like it will be required","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"d527de354fe3da3bfddeaa7fe2af33899add2f66","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $connection                   \u003d hiera(\u0027neutron::server::database_connection\u0027),"},{"line_number":43,"context_line":"  $controller_priv_host         \u003d hiera(\u0027keystone_admin_api_vip\u0027),"},{"line_number":44,"context_line":"  $admin_password               \u003d hiera(\u0027admin_password\u0027),"},{"line_number":45,"context_line":"  $metadata_proxy_shared_secret \u003d hiera(\u0027nova::api::neutron_metadata_proxy_shared_secret\u0027),"},{"line_number":46,"context_line":"  $step                         \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_1e2eb58b","line":45,"in_reply_to":"bab6814e_7b76f3a4","updated":"2016-05-26 21:29:03.000000000","message":"I don\u0027t see any parameter here, https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/controller.yaml for better lookup. Should I go ahead add one or we should use this for now?","commit_id":"302bca5fb7c1c4c16a39ed3270e9f0cf8063c3da"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"008f3ebeb2e7c998c7bb04d3fcd809378ef48fcc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":26,"context_line":"  $step  \u003d hiera(\u0027step\u0027),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  include ::tripleo::profile::base::neutron::server"},{"line_number":29,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":30,"context_line":"    include ::neutron::plugins::plumgrid"},{"line_number":31,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_625fd141","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":51},"updated":"2016-05-30 12:48:02.000000000","message":"why do you deploy a neutron server here? I\u0027m not sure we need it.","commit_id":"aa094935906e2b0f4d36ef414617d2d539a46c33"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"c24c7088368395a54f4c3a7fb92c132ab90fc4e0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":26,"context_line":"  $step  \u003d hiera(\u0027step\u0027),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  include ::tripleo::profile::base::neutron::server"},{"line_number":29,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":30,"context_line":"    include ::neutron::plugins::plumgrid"},{"line_number":31,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_78d77eed","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":51},"in_reply_to":"9abb7d3a_625fd141","updated":"2016-05-30 13:20:41.000000000","message":"Thanks, you are right we don\u0027t need it. I have updated the patch set.","commit_id":"aa094935906e2b0f4d36ef414617d2d539a46c33"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"149ef85d0cfb9249185b39424582bfb6ec1fa2f1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   for more details."},{"line_number":24,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":25,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":26,"context_line":"  $step  \u003d hiera(\u0027step\u0027),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":29,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9abb7d3a_ec129008","line":26,"range":{"start_line":26,"start_character":7,"end_line":26,"end_character":8},"updated":"2016-05-30 14:33:45.000000000","message":"one please remove this extra space","commit_id":"4ad4e53f613f31a7ac3017e9b8c5e0a5fa9e3b74"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"bc09779f65e7eb812e4c051ef4f78b4270e540f0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   for more details."},{"line_number":24,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":25,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":26,"context_line":"  $step  \u003d hiera(\u0027step\u0027),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":29,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9abb7d3a_6cf8604a","line":26,"range":{"start_line":26,"start_character":7,"end_line":26,"end_character":8},"in_reply_to":"9abb7d3a_ec129008","updated":"2016-05-30 14:39:29.000000000","message":"Done","commit_id":"4ad4e53f613f31a7ac3017e9b8c5e0a5fa9e3b74"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f5ae55d66e5b7cdca0839222be9d3fdff99b8442","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class tripleo::profile::base::neutron::plumgrid ("},{"line_number":26,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":29,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":30,"context_line":"    include ::neutron::plugins::plumgrid"},{"line_number":31,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9abb7d3a_570d0936","line":28,"updated":"2016-05-31 07:55:40.000000000","message":"so this is much simpler than last time I looked :) which is great but I can\u0027t see where we are now setting all the params you previously had (e.g. diff to v4 https://review.openstack.org/#/c/317259/4..8/manifests/profile/base/neutron/plumgrid.pp ) I guess on the tht side","commit_id":"b62aebaa7ca20c70210e37616189eedea187352e"}]}