)]}'
{"manifests/profile/base/swift/proxy.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9eb8e9dd575e6585a945e2ed98bf97a5161cee79","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class tripleo::profile::base::swift::proxy ("},{"line_number":28,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_183c9e92","line":28,"updated":"2016-05-18 16:44:59.000000000","message":"minor comment, but please drop useless spaces.","commit_id":"cbb3fca8724cd80c654637a8d77645155245c518"}],"manifests/profile/base/swift/storage.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9eb8e9dd575e6585a945e2ed98bf97a5161cee79","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# [*swift_mount_check*]"},{"line_number":27,"context_line":"#   (Optional) swift_mount_check"},{"line_number":28,"context_line":"#   Defaults to hiera(\u0027swift_mount_check\u0027) or false"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"class tripleo::profile::base::swift::storage ("},{"line_number":32,"context_line":"  $step \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_58462624","line":29,"updated":"2016-05-18 16:44:59.000000000","message":"useless line","commit_id":"cbb3fca8724cd80c654637a8d77645155245c518"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9eb8e9dd575e6585a945e2ed98bf97a5161cee79","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"class tripleo::profile::base::swift::storage ("},{"line_number":32,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":"  $swift_mount_check \u003d hiera(\u0027swift_mount_check\u0027, false),"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_b84bd22a","line":32,"updated":"2016-05-18 16:44:59.000000000","message":"please align the \"\u003d\"","commit_id":"cbb3fca8724cd80c654637a8d77645155245c518"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9eb8e9dd575e6585a945e2ed98bf97a5161cee79","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"class tripleo::profile::base::swift::storage ("},{"line_number":32,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":"  $swift_mount_check \u003d hiera(\u0027swift_mount_check\u0027, false),"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_18bf7ed1","line":33,"updated":"2016-05-18 16:44:59.000000000","message":"do we actually need this parameter? if we need to override it in some other scenarios, maybe just use hiera in the service?","commit_id":"cbb3fca8724cd80c654637a8d77645155245c518"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"5dcc7d81ddbedb3cd0e74a33ee0fc688cab3da78","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"class tripleo::profile::base::swift::storage ("},{"line_number":32,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":"  $swift_mount_check \u003d hiera(\u0027swift_mount_check\u0027, false),"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_aea1a9ab","line":33,"in_reply_to":"bab6814e_18bf7ed1","updated":"2016-05-19 10:09:35.000000000","message":"It\u0027s set via the SwiftMountCheck parameter, so I assume we\u0027ll want to maintain that interface:\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/overcloud.yaml#L523\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/swift-storage.yaml#L21","commit_id":"cbb3fca8724cd80c654637a8d77645155245c518"}]}
