)]}'
{"manifests/profile/base/ironic.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0ef00d38da885fdccf02f91fc34e6c5dcb88f1bd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $sync_db \u003d true,"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":35,"context_line":"    include ::ironic"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Database is accessed by both API and conductor, hence it\u0027s here."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3aaa91ec_299e2fb8","line":34,"updated":"2016-06-29 08:58:15.000000000","message":"I think the logic here should be:\n\n  if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db )\n\nwhile line 38 could be removed","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2c84dc90975d58d380b0eda327829a2e02dfe52d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $sync_db \u003d true,"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":35,"context_line":"    include ::ironic"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Database is accessed by both API and conductor, hence it\u0027s here."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3aaa91ec_a9f4dfce","line":34,"in_reply_to":"3aaa91ec_299e2fb8","updated":"2016-06-29 09:00:13.000000000","message":"That won\u0027t work. We must include ::ironic otherwise nothing further will work. I\u0027ll follow up with a patch passing sync_db into it.","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4fc2458607eed1633738d30cb8b1c2ba0a0172d2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $sync_db \u003d true,"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":35,"context_line":"    include ::ironic"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Database is accessed by both API and conductor, hence it\u0027s here."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3aaa91ec_b4fd523d","line":34,"in_reply_to":"3aaa91ec_a9f4dfce","updated":"2016-06-29 09:25:20.000000000","message":"my point is to import them all under that logic, not to remove ::ironic\n\nwe\u0027ll have to wire sync_db probably from bootstrap_nodeid in a followup patch anyway to make this skip non-bootstrap nodes in step 3","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6cc35771971ebef18a4d328abd6abb2efc830e07","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $sync_db \u003d true,"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":35,"context_line":"    include ::ironic"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Database is accessed by both API and conductor, hence it\u0027s here."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3aaa91ec_615deb78","line":34,"in_reply_to":"3aaa91ec_b459d25d","updated":"2016-06-29 09:58:15.000000000","message":"The intendend behaviour with:\n\n    if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db )\n\nshould be to include ::ironic and also ironic::db::* only on one node in step 3 and on all nodes in step 4\n\nthis is what happens for example for the heat or cinder profiles but again it only makes sense after we fix the sync_db logic so that it isn\u0027t true when executed on non bootstrap_nodeid ... all of which can be done in a follow-up","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f07e2796721a79768d5c34fea413cd03e798e7c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $sync_db \u003d true,"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":35,"context_line":"    include ::ironic"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Database is accessed by both API and conductor, hence it\u0027s here."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3aaa91ec_b459d25d","line":34,"in_reply_to":"3aaa91ec_b4fd523d","updated":"2016-06-29 09:27:37.000000000","message":"I\u0027ll try doing that; I remember that not including ::ironic on step 3 caused me some problems with later steps.","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d29984c04ce41da74a3b6643927c57471b29ec7d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":35,"context_line":"    include ::ironic"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Database is accessed by both API and conductor, hence it\u0027s here."},{"line_number":38,"context_line":"    if $sync_db {"},{"line_number":39,"context_line":"      include ::ironic::db::mysql"},{"line_number":40,"context_line":"      include ::ironic::db::sync"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_ff239da8","line":37,"updated":"2016-06-15 12:42:51.000000000","message":"those classes do not configure database parameters in ironic.conf, FYI.","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"37ed301d4c269dd589fb4919781aa5053b6bf610","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":35,"context_line":"    include ::ironic"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Database is accessed by both API and conductor, hence it\u0027s here."},{"line_number":38,"context_line":"    if $sync_db {"},{"line_number":39,"context_line":"      include ::ironic::db::mysql"},{"line_number":40,"context_line":"      include ::ironic::db::sync"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a9d85d2_85f836e7","line":37,"in_reply_to":"7aa08908_9fb41936","updated":"2016-06-20 14:23:18.000000000","message":"in other profiles, we declare them on a specific service (it could be ironic-api). See Cinder for example.","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4880f6bc93b606bca0e5b16deb5c8bc214807337","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":35,"context_line":"    include ::ironic"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Database is accessed by both API and conductor, hence it\u0027s here."},{"line_number":38,"context_line":"    if $sync_db {"},{"line_number":39,"context_line":"      include ::ironic::db::mysql"},{"line_number":40,"context_line":"      include ::ironic::db::sync"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_9fb41936","line":37,"in_reply_to":"7aa08908_ff239da8","updated":"2016-06-15 12:45:10.000000000","message":"ironic includes ironic::db https://github.com/openstack/puppet-ironic/blob/master/manifests/init.pp#L364 https://github.com/openstack/puppet-ironic/blob/master/manifests/db.pp so I\u0027m not sure that\u0027s true","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"}],"manifests/profile/base/ironic/api.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"4d2bd69cdb366fa3f1db407f2cd310c8cc694615","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class tripleo::profile::base::ironic::api ("},{"line_number":26,"context_line":"  $step    \u003d hiera(\u0027step\u0027),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  include ::tripleo::profile::base::ironic"},{"line_number":30,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":31,"context_line":"      include ::ironic::api"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_ce29d83c","line":28,"updated":"2016-06-15 10:53:31.000000000","message":"Isn\u0027t something like this needed here for the api?\n    include ::ironic::db::mysql\n    include ::ironic::db::sync","commit_id":"1f684fca6bfc0ab57f0624dd10fd04d9a15a28d2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"37ed301d4c269dd589fb4919781aa5053b6bf610","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"class tripleo::profile::base::ironic::api ("},{"line_number":26,"context_line":"  $step    \u003d hiera(\u0027step\u0027),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  include ::tripleo::profile::base::ironic"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a9d85d2_25e86210","line":26,"range":{"start_line":26,"start_character":7,"end_line":26,"end_character":10},"updated":"2016-06-20 14:23:18.000000000","message":"useless space","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"}],"manifests/profile/base/ironic/conductor.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"37ed301d4c269dd589fb4919781aa5053b6bf610","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"class tripleo::profile::base::ironic::conductor ("},{"line_number":26,"context_line":"  $step    \u003d hiera(\u0027step\u0027),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  include ::tripleo::profile::base::ironic"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a9d85d2_65370ab1","line":26,"range":{"start_line":26,"start_character":7,"end_line":26,"end_character":10},"updated":"2016-06-20 14:23:18.000000000","message":"useless space","commit_id":"a14d2a554ef38c612cc8d744a289250e33ce3a1b"}]}