)]}'
{"lib/puppet/parser/functions/lookup_hiera_hash.rb":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ce8f228e90d0d26e2f44b97648f2c73c7f8cd131","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    unless hash_name.is_a?(String) and key_name.is_a?(String)"},{"line_number":7,"context_line":"      raise Puppet::ParseError, \"The hash name and the key name must be given as strings.\""},{"line_number":8,"context_line":"    end"},{"line_number":9,"context_line":"    hash \u003d function_hiera([hash_name])"},{"line_number":10,"context_line":"    return hash[key_name]"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_402aba7f","line":9,"updated":"2016-05-24 11:50:12.000000000","message":"will exit puppet with an error if the hash doesn\u0027t exist, which I think is what we want","commit_id":"53c2c8c8490e3e3e1188ca37786eed976a39aa12"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ce8f228e90d0d26e2f44b97648f2c73c7f8cd131","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      raise Puppet::ParseError, \"The hash name and the key name must be given as strings.\""},{"line_number":8,"context_line":"    end"},{"line_number":9,"context_line":"    hash \u003d function_hiera([hash_name])"},{"line_number":10,"context_line":"    return hash[key_name]"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_0031d2ec","line":10,"updated":"2016-05-24 11:50:12.000000000","message":"will return empty, but not an error if the key doesn\u0027t exist in the hash, which again I think is what we want","commit_id":"53c2c8c8490e3e3e1188ca37786eed976a39aa12"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"36d9fd672b94ec50b15477023462c16aae6f93aa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      raise Puppet::ParseError, \"The hash name and the key name must be given as strings.\""},{"line_number":8,"context_line":"    end"},{"line_number":9,"context_line":"    hash \u003d function_hiera([hash_name])"},{"line_number":10,"context_line":"    return hash[key_name]"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_80b822e7","line":10,"in_reply_to":"bab6814e_0031d2ec","updated":"2016-05-24 11:55:23.000000000","message":"Actually, now that I think about it. We might want to throw an error here. And this should get a third argument which should be the default value. So if no default value is given, then we should raise an error here.","commit_id":"53c2c8c8490e3e3e1188ca37786eed976a39aa12"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"b2d3ee3fd1f318c13b7cff6fde3ddc3600487bf6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      raise Puppet::ParseError, \"The hash name and the key name must be given as strings.\""},{"line_number":8,"context_line":"    end"},{"line_number":9,"context_line":"    hash \u003d function_hiera([hash_name])"},{"line_number":10,"context_line":"    return hash[key_name]"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_c0506a61","line":10,"in_reply_to":"bab6814e_801022aa","updated":"2016-05-24 12:00:20.000000000","message":"Sure. I have no strong opinion about this.","commit_id":"53c2c8c8490e3e3e1188ca37786eed976a39aa12"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e423d322dd3a9f8f04b8e35eb6d754da2e841385","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      raise Puppet::ParseError, \"The hash name and the key name must be given as strings.\""},{"line_number":8,"context_line":"    end"},{"line_number":9,"context_line":"    hash \u003d function_hiera([hash_name])"},{"line_number":10,"context_line":"    return hash[key_name]"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_801022aa","line":10,"in_reply_to":"bab6814e_80b822e7","updated":"2016-05-24 11:59:10.000000000","message":"I think we want to reproduce the feature that we need in Hiera 2.x, which does exactly what gfidente did in this patch.","commit_id":"53c2c8c8490e3e3e1188ca37786eed976a39aa12"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"870f7fac0ca20173aee665cfbabeb41873ad114a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      raise Puppet::ParseError, \"The hash name and the key name must be given as strings.\""},{"line_number":8,"context_line":"    end"},{"line_number":9,"context_line":"    hash \u003d function_hiera([hash_name])"},{"line_number":10,"context_line":"    return hash[key_name]"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_3bed2726","line":10,"in_reply_to":"bab6814e_80b822e7","updated":"2016-05-24 12:06:40.000000000","message":"ack on exiting if key is not found, thanks!\n\nI will add unit tests as well","commit_id":"53c2c8c8490e3e3e1188ca37786eed976a39aa12"}]}
