)]}'
{"manifests/profile/base/swift/storage.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"73d0fa5cb576f08e5af8c80270eaff38c2b4e975","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $enable_swift_storage \u003d true,"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    if $enable_swift_storage {"},{"line_number":38,"context_line":"      if(!defined(File[\u0027/srv/node\u0027])) {"},{"line_number":39,"context_line":"        file { \u0027/srv/node\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_086da6cb","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":17},"updated":"2016-06-09 08:15:51.000000000","message":"what about the swift::storage::account/container/object classes from https://review.openstack.org/#/c/320580/9/puppet/manifests/overcloud_controller_pacemaker.pp","commit_id":"fb5fa8fb9c46c78823ecf0cb49655768bba12c3b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"fd5422ccf9683cb6f8604a21138aa9132c5d3f0a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $enable_swift_storage \u003d true,"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    if $enable_swift_storage {"},{"line_number":38,"context_line":"      if(!defined(File[\u0027/srv/node\u0027])) {"},{"line_number":39,"context_line":"        file { \u0027/srv/node\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_d83e8cb7","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":17},"in_reply_to":"3aaa91ec_fd89bacb","updated":"2016-06-22 13:46:21.000000000","message":"actually we just want ::all which will include the others, editing","commit_id":"fb5fa8fb9c46c78823ecf0cb49655768bba12c3b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"22cc98d1bace9a059bbb7d6bd28a226f2977798b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $enable_swift_storage \u003d true,"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    if $enable_swift_storage {"},{"line_number":38,"context_line":"      if(!defined(File[\u0027/srv/node\u0027])) {"},{"line_number":39,"context_line":"        file { \u0027/srv/node\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_762faba7","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":17},"in_reply_to":"7aa08908_086da6cb","updated":"2016-06-16 08:09:44.000000000","message":"regardless of whether systemd or pacemaker managed, don\u0027t we need to include the classes here i mean \n\ninclude ::swift::storage::all\ninclude ::swift::storage::account\n+container and object","commit_id":"fb5fa8fb9c46c78823ecf0cb49655768bba12c3b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"163b41c952194df2e7a2a296c1306e9431c48558","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $enable_swift_storage \u003d true,"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    if $enable_swift_storage {"},{"line_number":38,"context_line":"      if(!defined(File[\u0027/srv/node\u0027])) {"},{"line_number":39,"context_line":"        file { \u0027/srv/node\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_fd89bacb","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":17},"in_reply_to":"7aa08908_762faba7","updated":"2016-06-22 13:44:16.000000000","message":"+1\n\nack I think we can just add those without manage_service because there won\u0027t be a pcmk version","commit_id":"fb5fa8fb9c46c78823ecf0cb49655768bba12c3b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"24e9ad5251f92cf697f9e8f8ffd0ecc345e4640a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    if $enable_swift_storage {"},{"line_number":38,"context_line":"      include ::swift::storage::all"},{"line_number":39,"context_line":"      if(!defined(File[\u0027/srv/node\u0027])) {"},{"line_number":40,"context_line":"        file { \u0027/srv/node\u0027:"},{"line_number":41,"context_line":"          ensure  \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_a5cb6da4","line":38,"updated":"2016-06-23 08:57:36.000000000","message":"OK, but sanity check please, why were we previously explicitly including ::swift::storage::account/container/object after declaring ::swift::storage::all @ https://review.openstack.org/#/c/320580/12/puppet/manifests/overcloud_controller_pacemaker.pp - perhaps it was unnecessary but checking due to the diff I see","commit_id":"b88cf72bcdd5def32c64ea610432dd7ce5c78182"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bef25dc1e733b1b07f205600cfb4bed968da45e1","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    if $enable_swift_storage {"},{"line_number":38,"context_line":"      include ::swift::storage::all"},{"line_number":39,"context_line":"      if(!defined(File[\u0027/srv/node\u0027])) {"},{"line_number":40,"context_line":"        file { \u0027/srv/node\u0027:"},{"line_number":41,"context_line":"          ensure  \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_b6d6c14c","line":38,"in_reply_to":"3aaa91ec_6ea95ddf","updated":"2016-06-24 08:42:09.000000000","message":"ack thanks man. So only one more question then :)... before as you say we were setting manage/enabled, to true, but only after step 5 ($non_pcmk_start \u003d hiera(\u0027step\u0027) \u003e\u003d 5).\n\nNow they will get the module default, true I assume, from step 4 - do you know if this will cause issues?","commit_id":"b88cf72bcdd5def32c64ea610432dd7ce5c78182"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7ccf491102f82a381e4f4c43afdaf9ee2dce3d22","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    if $enable_swift_storage {"},{"line_number":38,"context_line":"      include ::swift::storage::all"},{"line_number":39,"context_line":"      if(!defined(File[\u0027/srv/node\u0027])) {"},{"line_number":40,"context_line":"        file { \u0027/srv/node\u0027:"},{"line_number":41,"context_line":"          ensure  \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_6ea95ddf","line":38,"in_reply_to":"3aaa91ec_a5cb6da4","updated":"2016-06-23 11:53:37.000000000","message":"for pacemaker we were calling all storage classes to pass the service_manage and enabled parameters, in the non-pacemaker overcloud_controller.pp we only include ::all","commit_id":"b88cf72bcdd5def32c64ea610432dd7ce5c78182"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b3596efbc1784d4bd07d766a9d959711faab01f6","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    if $enable_swift_storage {"},{"line_number":38,"context_line":"      include ::swift::storage::all"},{"line_number":39,"context_line":"      if(!defined(File[\u0027/srv/node\u0027])) {"},{"line_number":40,"context_line":"        file { \u0027/srv/node\u0027:"},{"line_number":41,"context_line":"          ensure  \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_5c19a287","line":38,"in_reply_to":"3aaa91ec_b6d6c14c","updated":"2016-06-29 15:04:16.000000000","message":"the pacemaker managed services are started by pcmk in step 5 but swift is not managed by pcmk so I think it\u0027s correct to start it in step 4 as it already happens for the others non-pcmk managed services","commit_id":"b88cf72bcdd5def32c64ea610432dd7ce5c78182"}]}