)]}'
{"manifests/profile/base/monitoring/rabbitmq.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fff7d84eb7a9d0d70cc9799969886a36c9688977","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  rabbitmq_vhost { \u0027sensu-rabbit-vhost\u0027:"},{"line_number":40,"context_line":"    ensure \u003d\u003e present,"},{"line_number":41,"context_line":"    name   \u003d\u003e $vhost"},{"line_number":42,"context_line":"  } -\u003e rabbitmq_user { \u0027sensu-rabbit-user\u0027:"},{"line_number":43,"context_line":"    name     \u003d\u003e $user,"},{"line_number":44,"context_line":"    password \u003d\u003e $password,"},{"line_number":45,"context_line":"    tags     \u003d\u003e [\u0027monitoring\u0027]"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_50ee8fb4","line":42,"updated":"2016-07-20 13:21:12.000000000","message":"You don\u0027t need the arrows, there is an Autorequire in the Puppet types. See:\nhttps://github.com/puppetlabs/puppetlabs-rabbitmq/blob/master/lib/puppet/type/rabbitmq_user_permissions.rb#L42-L47","commit_id":"fd21091e4809629082fadda42de57584027422b9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fff7d84eb7a9d0d70cc9799969886a36c9688977","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  } -\u003e rabbitmq_user { \u0027sensu-rabbit-user\u0027:"},{"line_number":43,"context_line":"    name     \u003d\u003e $user,"},{"line_number":44,"context_line":"    password \u003d\u003e $password,"},{"line_number":45,"context_line":"    tags     \u003d\u003e [\u0027monitoring\u0027]"},{"line_number":46,"context_line":"  } -\u003e rabbitmq_user_permissions { \"${user}@${vhost}\":"},{"line_number":47,"context_line":"    configure_permission \u003d\u003e \u0027.*\u0027,"},{"line_number":48,"context_line":"    read_permission      \u003d\u003e \u0027.*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_d038bf3f","line":45,"updated":"2016-07-20 13:21:12.000000000","message":"why this tag? where is it used?","commit_id":"fd21091e4809629082fadda42de57584027422b9"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"cfc7d904c9c75f67e2b285e6a7feca41682b083b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  } -\u003e rabbitmq_user { \u0027sensu-rabbit-user\u0027:"},{"line_number":43,"context_line":"    name     \u003d\u003e $user,"},{"line_number":44,"context_line":"    password \u003d\u003e $password,"},{"line_number":45,"context_line":"    tags     \u003d\u003e [\u0027monitoring\u0027]"},{"line_number":46,"context_line":"  } -\u003e rabbitmq_user_permissions { \"${user}@${vhost}\":"},{"line_number":47,"context_line":"    configure_permission \u003d\u003e \u0027.*\u0027,"},{"line_number":48,"context_line":"    read_permission      \u003d\u003e \u0027.*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_a94799ba","line":45,"in_reply_to":"dada55a8_d038bf3f","updated":"2016-07-20 16:16:25.000000000","message":"It is tag for rabbit, not a puppet resource tag (see [1]). And the reason I tagged it is when operator will maintain users in rabbit, so that he/she has an idea for what purpose the user was created.\n\n[1] https://github.com/puppetlabs/puppetlabs-rabbitmq/blob/master/lib/puppet/type/rabbitmq_user.rb#L47","commit_id":"fd21091e4809629082fadda42de57584027422b9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fff7d84eb7a9d0d70cc9799969886a36c9688977","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    name     \u003d\u003e $user,"},{"line_number":44,"context_line":"    password \u003d\u003e $password,"},{"line_number":45,"context_line":"    tags     \u003d\u003e [\u0027monitoring\u0027]"},{"line_number":46,"context_line":"  } -\u003e rabbitmq_user_permissions { \"${user}@${vhost}\":"},{"line_number":47,"context_line":"    configure_permission \u003d\u003e \u0027.*\u0027,"},{"line_number":48,"context_line":"    read_permission      \u003d\u003e \u0027.*\u0027,"},{"line_number":49,"context_line":"    write_permission     \u003d\u003e \u0027.*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_b0142ba0","line":46,"updated":"2016-07-20 13:21:12.000000000","message":"same thing for the arrow, useless.","commit_id":"fd21091e4809629082fadda42de57584027422b9"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"cfc7d904c9c75f67e2b285e6a7feca41682b083b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    name     \u003d\u003e $user,"},{"line_number":44,"context_line":"    password \u003d\u003e $password,"},{"line_number":45,"context_line":"    tags     \u003d\u003e [\u0027monitoring\u0027]"},{"line_number":46,"context_line":"  } -\u003e rabbitmq_user_permissions { \"${user}@${vhost}\":"},{"line_number":47,"context_line":"    configure_permission \u003d\u003e \u0027.*\u0027,"},{"line_number":48,"context_line":"    read_permission      \u003d\u003e \u0027.*\u0027,"},{"line_number":49,"context_line":"    write_permission     \u003d\u003e \u0027.*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_a975d9fa","line":46,"in_reply_to":"dada55a8_b0142ba0","updated":"2016-07-20 16:16:25.000000000","message":"Ack, will remove them.","commit_id":"fd21091e4809629082fadda42de57584027422b9"}],"manifests/profile/base/monitoring/sensu.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e3b56e1488238e66de6e84eab4fc3e58aca9effe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # TODO(mmagr): To successfully connect to redis without password, we must"},{"line_number":43,"context_line":"    #              not use empty string in config. This should be removed once"},{"line_number":44,"context_line":"    #              it is fixed in sensu-puppet module:"},{"line_number":45,"context_line":"    #              [https://github.com/sensu/sensu-puppet/issues/503]"},{"line_number":46,"context_line":"    if hiera(\u0027::sensu::redis_password\u0027, undef) \u003d\u003d undef {"},{"line_number":47,"context_line":"      augeas { \u0027redis-password-hack\u0027:"},{"line_number":48,"context_line":"        incl    \u003d\u003e \u0027/etc/sensu/conf.d/redis.json\u0027,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_3224adc3","line":45,"updated":"2016-07-20 18:59:18.000000000","message":"You reported the bug on May 26th and you didn\u0027t propose a pull-request until now. This Augeas thing is a terrible hack and will make Puppet catalog not idempotent. We won\u0027t accept this code and you\u0027ll need to fix it in puppet-sensu.","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5616c488c4434a1e2229b4de6df1478033143fb5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # TODO(mmagr): To successfully connect to redis without password, we must"},{"line_number":43,"context_line":"    #              not use empty string in config. This should be removed once"},{"line_number":44,"context_line":"    #              it is fixed in sensu-puppet module:"},{"line_number":45,"context_line":"    #              [https://github.com/sensu/sensu-puppet/issues/503]"},{"line_number":46,"context_line":"    if hiera(\u0027::sensu::redis_password\u0027, undef) \u003d\u003d undef {"},{"line_number":47,"context_line":"      augeas { \u0027redis-password-hack\u0027:"},{"line_number":48,"context_line":"        incl    \u003d\u003e \u0027/etc/sensu/conf.d/redis.json\u0027,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_0672a2ad","line":45,"in_reply_to":"dada55a8_03013d38","updated":"2016-07-22 13:26:56.000000000","message":"Martin, we don\u0027t need this workaround, since we can set a password to Redis, look:\nhttps://github.com/openstack/tripleo-heat-templates/blob/6b30ff11d4e2eafda7a3ab693055c687d4a8da5d/puppet/services/database/redis-base.yaml#L7-L10","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"1657a46d1b233a377eb6cd980fea29f0a91c2ac8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # TODO(mmagr): To successfully connect to redis without password, we must"},{"line_number":43,"context_line":"    #              not use empty string in config. This should be removed once"},{"line_number":44,"context_line":"    #              it is fixed in sensu-puppet module:"},{"line_number":45,"context_line":"    #              [https://github.com/sensu/sensu-puppet/issues/503]"},{"line_number":46,"context_line":"    if hiera(\u0027::sensu::redis_password\u0027, undef) \u003d\u003d undef {"},{"line_number":47,"context_line":"      augeas { \u0027redis-password-hack\u0027:"},{"line_number":48,"context_line":"        incl    \u003d\u003e \u0027/etc/sensu/conf.d/redis.json\u0027,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_03013d38","line":45,"in_reply_to":"dada55a8_3224adc3","updated":"2016-07-21 10:18:45.000000000","message":"Config files in the module are populated using custom provider. Creating that would mean to rewrite part of the provider. Unfortunately our resources are limited, which is the reason I did not submit PR yet.","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e3b56e1488238e66de6e84eab4fc3e58aca9effe","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        require \u003d\u003e Class[\u0027::sensu\u0027]"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      if hiera(\u0027::redis::server\u0027, true) {"},{"line_number":57,"context_line":"        $cmd_server \u003d \u0027sensu-server\u0027"},{"line_number":58,"context_line":"      } else {"},{"line_number":59,"context_line":"        $cmd_server \u003d \u0027\u0027"},{"line_number":60,"context_line":"      }"},{"line_number":61,"context_line":"      if hiera(\u0027::redis::api\u0027, true) {"},{"line_number":62,"context_line":"        $cmd_api \u003d \u0027sensu-api\u0027"},{"line_number":63,"context_line":"      } else {"},{"line_number":64,"context_line":"        $cmd_api \u003d \u0027\u0027"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"      if hiera(\u0027::redis::client\u0027, true) {"},{"line_number":67,"context_line":"        $cmd_client \u003d \u0027sensu-client\u0027"},{"line_number":68,"context_line":"      } else {"},{"line_number":69,"context_line":"        $cmd_client \u003d \u0027\u0027"},{"line_number":70,"context_line":"      }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"      exec { \u0027restart-sensu-services\u0027:"},{"line_number":73,"context_line":"        path    \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027sbin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_b21edd6d","line":70,"range":{"start_line":56,"start_character":0,"end_line":70,"end_character":7},"updated":"2016-07-20 18:59:18.000000000","message":"uh. Why doing that? I never did that before to make it work.","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5616c488c4434a1e2229b4de6df1478033143fb5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        require \u003d\u003e Class[\u0027::sensu\u0027]"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      if hiera(\u0027::redis::server\u0027, true) {"},{"line_number":57,"context_line":"        $cmd_server \u003d \u0027sensu-server\u0027"},{"line_number":58,"context_line":"      } else {"},{"line_number":59,"context_line":"        $cmd_server \u003d \u0027\u0027"},{"line_number":60,"context_line":"      }"},{"line_number":61,"context_line":"      if hiera(\u0027::redis::api\u0027, true) {"},{"line_number":62,"context_line":"        $cmd_api \u003d \u0027sensu-api\u0027"},{"line_number":63,"context_line":"      } else {"},{"line_number":64,"context_line":"        $cmd_api \u003d \u0027\u0027"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"      if hiera(\u0027::redis::client\u0027, true) {"},{"line_number":67,"context_line":"        $cmd_client \u003d \u0027sensu-client\u0027"},{"line_number":68,"context_line":"      } else {"},{"line_number":69,"context_line":"        $cmd_client \u003d \u0027\u0027"},{"line_number":70,"context_line":"      }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"      exec { \u0027restart-sensu-services\u0027:"},{"line_number":73,"context_line":"        path    \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027sbin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_a66116d6","line":70,"range":{"start_line":56,"start_character":0,"end_line":70,"end_character":7},"in_reply_to":"dada55a8_839b6d17","updated":"2016-07-22 13:26:56.000000000","message":"you don\u0027t need it, since we don\u0027t need any hack.","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"1657a46d1b233a377eb6cd980fea29f0a91c2ac8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        require \u003d\u003e Class[\u0027::sensu\u0027]"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      if hiera(\u0027::redis::server\u0027, true) {"},{"line_number":57,"context_line":"        $cmd_server \u003d \u0027sensu-server\u0027"},{"line_number":58,"context_line":"      } else {"},{"line_number":59,"context_line":"        $cmd_server \u003d \u0027\u0027"},{"line_number":60,"context_line":"      }"},{"line_number":61,"context_line":"      if hiera(\u0027::redis::api\u0027, true) {"},{"line_number":62,"context_line":"        $cmd_api \u003d \u0027sensu-api\u0027"},{"line_number":63,"context_line":"      } else {"},{"line_number":64,"context_line":"        $cmd_api \u003d \u0027\u0027"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"      if hiera(\u0027::redis::client\u0027, true) {"},{"line_number":67,"context_line":"        $cmd_client \u003d \u0027sensu-client\u0027"},{"line_number":68,"context_line":"      } else {"},{"line_number":69,"context_line":"        $cmd_client \u003d \u0027\u0027"},{"line_number":70,"context_line":"      }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"      exec { \u0027restart-sensu-services\u0027:"},{"line_number":73,"context_line":"        path    \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027sbin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_839b6d17","line":70,"range":{"start_line":56,"start_character":0,"end_line":70,"end_character":7},"in_reply_to":"dada55a8_b21edd6d","updated":"2016-07-21 10:18:45.000000000","message":"When you update config file, you need to restart service.","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e3b56e1488238e66de6e84eab4fc3e58aca9effe","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        $cmd_client \u003d \u0027\u0027"},{"line_number":70,"context_line":"      }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"      exec { \u0027restart-sensu-services\u0027:"},{"line_number":73,"context_line":"        path    \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027sbin\u0027],"},{"line_number":74,"context_line":"        command \u003d\u003e \"systemctl restart ${cmd_server} ${cmd_api} ${cmd_client}\","},{"line_number":75,"context_line":"        require \u003d\u003e Augeas[\u0027redis-password-hack\u0027]"},{"line_number":76,"context_line":"      }"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_520e813b","line":76,"range":{"start_line":72,"start_character":0,"end_line":76,"end_character":7},"updated":"2016-07-20 18:59:18.000000000","message":"That is a terrible hack. Don\u0027t do it.","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"1657a46d1b233a377eb6cd980fea29f0a91c2ac8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        $cmd_client \u003d \u0027\u0027"},{"line_number":70,"context_line":"      }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"      exec { \u0027restart-sensu-services\u0027:"},{"line_number":73,"context_line":"        path    \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027sbin\u0027],"},{"line_number":74,"context_line":"        command \u003d\u003e \"systemctl restart ${cmd_server} ${cmd_api} ${cmd_client}\","},{"line_number":75,"context_line":"        require \u003d\u003e Augeas[\u0027redis-password-hack\u0027]"},{"line_number":76,"context_line":"      }"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_c346057a","line":76,"range":{"start_line":72,"start_character":0,"end_line":76,"end_character":7},"in_reply_to":"dada55a8_520e813b","updated":"2016-07-21 10:18:45.000000000","message":"Ok, so what we can do here now as a workaround for the current situation is to remove the whole password hack and assume Redis will be always configured to be secured by password. Would that be ok for you?","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5616c488c4434a1e2229b4de6df1478033143fb5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        $cmd_client \u003d \u0027\u0027"},{"line_number":70,"context_line":"      }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"      exec { \u0027restart-sensu-services\u0027:"},{"line_number":73,"context_line":"        path    \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027sbin\u0027],"},{"line_number":74,"context_line":"        command \u003d\u003e \"systemctl restart ${cmd_server} ${cmd_api} ${cmd_client}\","},{"line_number":75,"context_line":"        require \u003d\u003e Augeas[\u0027redis-password-hack\u0027]"},{"line_number":76,"context_line":"      }"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dada55a8_46abfad6","line":76,"range":{"start_line":72,"start_character":0,"end_line":76,"end_character":7},"in_reply_to":"dada55a8_c346057a","updated":"2016-07-22 13:26:56.000000000","message":"No.\nFirst of all, we hate hacks, and second, we don\u0027t need this one. Like I said, TripleO does support password configuration for Redis, just use it in the profile to configure Sensu to use it.","commit_id":"fad90733d5ae97b07d8e339cd4cea49d5d51f293"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3d52e2ca666bc550d29bebffb7692fd4eea7c588","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::base::monitoring::sensu ("},{"line_number":31,"context_line":"  $step              \u003d hiera(\u0027step\u0027, undef),"},{"line_number":32,"context_line":"  $enable_monitoring \u003d hiera(\u0027enable_monitoring\u0027, true),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $enable_monitoring and ($step \u003d\u003d undef or $step \u003e\u003d 3) {"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"dada55a8_66c39e8b","line":32,"updated":"2016-07-22 13:29:59.000000000","message":"I don\u0027t understand why you need this boolean. If you don\u0027t want monitoring, just don\u0027t include this profile. Remove it.","commit_id":"447a1cbd5e30736811419580f8f5b2fbbe1972ed"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ef7e3db36159444d16888b0061495e231118d053","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"class tripleo::profile::base::monitoring::sensu ("},{"line_number":26,"context_line":"  $step              \u003d hiera(\u0027step\u0027, undef),"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if $step \u003d\u003d undef or $step \u003e\u003d 3 {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"dada55a8_943997db","line":26,"range":{"start_line":26,"start_character":7,"end_line":26,"end_character":21},"updated":"2016-07-22 15:23:16.000000000","message":"too much space, but well... let\u0027s move forward.","commit_id":"5971449da0c499f3358447eccaf6e65b838728ac"}],"manifests/profile/base/sensu/client.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a60b8725b60d82029d1472fe7a0d26378c1a7054","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      subscriptions         \u003d\u003e $subscriptions,"},{"line_number":48,"context_line":"      sensu_plugin_provider \u003d\u003e \u0027yum\u0027,"},{"line_number":49,"context_line":"      sensu_plugin_name     \u003d\u003e \u0027rubygem-sensu-plugin\u0027,"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Install OpenStack related check scripts"},{"line_number":53,"context_line":"    package { \u0027osops-tools-monitoring-oschecks\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_94ef1d1d","line":50,"updated":"2016-06-01 12:30:06.000000000","message":"use hiera","commit_id":"ab39f7a067a27221d6765355b54b24c10098c546"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a60b8725b60d82029d1472fe7a0d26378c1a7054","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Install OpenStack related check scripts"},{"line_number":53,"context_line":"    package { \u0027osops-tools-monitoring-oschecks\u0027:"},{"line_number":54,"context_line":"      ensure \u003d\u003e \u0027present\u0027"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_f4f2e904","line":53,"updated":"2016-06-01 12:30:06.000000000","message":"use tripleo-puppet-elements","commit_id":"ab39f7a067a27221d6765355b54b24c10098c546"}],"manifests/profile/base/sensu/server.pp":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"91ac6c4980641974a61fcdd80be9aeb05ec4294a","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    ensure_resource(\u0027class\u0027, \u0027::sensu\u0027, $params)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # TODO(mmagr): To successfully connect to redis without password, we must"},{"line_number":72,"context_line":"    #              use empty string in config. This should be removed once it"},{"line_number":73,"context_line":"    #              is fixed in sensu-puppet module:"},{"line_number":74,"context_line":"    #              [https://github.com/sensu/sensu-puppet/issues/503]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9abb7d3a_ea8e942c","line":71,"range":{"start_line":71,"start_character":72,"end_line":71,"end_character":73},"updated":"2016-06-01 07:55:27.000000000","message":"doh ... \"we must not\", will fix","commit_id":"f821099c8ca2fe0a5ddfbf2a0127882e65fe24da"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a60b8725b60d82029d1472fe7a0d26378c1a7054","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        subscriptions         \u003d\u003e $subscriptions,"},{"line_number":57,"context_line":"        sensu_plugin_provider \u003d\u003e \u0027yum\u0027,"},{"line_number":58,"context_line":"        sensu_plugin_name     \u003d\u003e \u0027rubygem-sensu-plugin\u0027,"},{"line_number":59,"context_line":"      })"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"      # Install OpenStack related check scripts"},{"line_number":62,"context_line":"      package { \u0027osops-tools-monitoring-oschecks\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_19b4067e","line":59,"updated":"2016-06-01 12:30:06.000000000","message":"please use Hiera for all those params. Really, the composable roles should only do \"include\" things with the least logic as possible.","commit_id":"ab39f7a067a27221d6765355b54b24c10098c546"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a60b8725b60d82029d1472fe7a0d26378c1a7054","unresolved":false,"context_lines":[{"line_number":59,"context_line":"      })"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"      # Install OpenStack related check scripts"},{"line_number":62,"context_line":"      package { \u0027osops-tools-monitoring-oschecks\u0027:"},{"line_number":63,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":64,"context_line":"      }"},{"line_number":65,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_19fc066f","line":62,"updated":"2016-06-01 12:30:06.000000000","message":"you should rather manage this package in tripleo-puppet-elements.","commit_id":"ab39f7a067a27221d6765355b54b24c10098c546"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a60b8725b60d82029d1472fe7a0d26378c1a7054","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    # TODO(mmagr): To successfully connect to redis without password, we must"},{"line_number":72,"context_line":"    #              not use empty string in config. This should be removed once"},{"line_number":73,"context_line":"    #              it is fixed in sensu-puppet module:"},{"line_number":74,"context_line":"    #              [https://github.com/sensu/sensu-puppet/issues/503]"},{"line_number":75,"context_line":"    if hiera(\u0027::redis::requirepass\u0027, undef) \u003d\u003d undef {"},{"line_number":76,"context_line":"      augeas { \u0027redis-password-hack\u0027:"},{"line_number":77,"context_line":"        incl    \u003d\u003e \u0027/etc/sensu/conf.d/redis.json\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_b985facf","line":74,"updated":"2016-06-01 12:30:06.000000000","message":"did you submit a pull-request?","commit_id":"ab39f7a067a27221d6765355b54b24c10098c546"}],"manifests/profile/base/sensu/uchiwa.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a60b8725b60d82029d1472fe7a0d26378c1a7054","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*step*]"},{"line_number":22,"context_line":"#   (Optional) String. The current step of the deployment"},{"line_number":23,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":24,"context_line":"#(\u0027redis_password\u0027, undef)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class tripleo::profile::base::sensu::uchiwa ("},{"line_number":27,"context_line":"  $step \u003d hiera(\u0027step\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_74b9d92d","line":24,"range":{"start_line":24,"start_character":1,"end_line":24,"end_character":26},"updated":"2016-06-01 12:30:06.000000000","message":"drop it","commit_id":"ab39f7a067a27221d6765355b54b24c10098c546"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a60b8725b60d82029d1472fe7a0d26378c1a7054","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $step \u003d\u003d undef or $step \u003e\u003d 5 {"},{"line_number":31,"context_line":"    class { \u0027::uchiwa\u0027:"},{"line_number":32,"context_line":"      install_repo \u003d\u003e false,"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_746279d9","line":32,"updated":"2016-06-01 12:30:06.000000000","message":"please use hieradata","commit_id":"ab39f7a067a27221d6765355b54b24c10098c546"}]}