)]}'
{"manifests/profile/base/nova/api.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"18269e2e850d1252fdc02798bb5dd4074ee7c0df","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  include ::tripleo::profile::base::nova"},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":37,"context_line":"    include ::nova::api"},{"line_number":38,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":39,"context_line":"      sync_db     \u003d\u003e $sync_db,"},{"line_number":40,"context_line":"      sync_db_api \u003d\u003e $sync_db,"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7aa08908_ab1accc3","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":3},"updated":"2016-06-14 04:49:02.000000000","message":"Even though this passed and seems to work. This looks quite strange. Why do you need an include ::nova::api and then the class declaration?","commit_id":"9d1b6f6712e2e9f36aeb64e97fd9919a631c6074"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"90f316d98d166af3ffb1236ddbedf4eacddb2590","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  include ::tripleo::profile::base::nova"},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":37,"context_line":"    include ::nova::api"},{"line_number":38,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":39,"context_line":"      sync_db     \u003d\u003e $sync_db,"},{"line_number":40,"context_line":"      sync_db_api \u003d\u003e $sync_db,"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7aa08908_a152eb32","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":3},"in_reply_to":"7aa08908_ab1accc3","updated":"2016-06-14 06:23:05.000000000","message":"So this is actually wrong.","commit_id":"9d1b6f6712e2e9f36aeb64e97fd9919a631c6074"}],"manifests/profile/pacemaker/nova/api.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"1d9439aa2cd03b5ed85782546796b66e439f74b4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  class { \u0027::tripleo::profile::base::nova::api\u0027:"},{"line_number":45,"context_line":"    sync_db \u003d\u003e $sync_db,"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if $step \u003e\u003d 5 and downcase($::hostname) \u003d\u003d $pacemaker_master {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7aa08908_bded5d90","line":45,"updated":"2016-06-10 14:54:29.000000000","message":"Stylistically I\u0027ve been doing this in other modules:\n\n$sync_db \u003d ($::hostname \u003d\u003d downcase($pacemaker_master))\n\nWould save some LOC above...","commit_id":"7cb7134d507b25ee2dbbdfc48c3b08d8c2fa123f"}]}
