)]}'
{"manifests/profile/base/nova.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9f3c8ed1d13a76705b8e0289de475e180fee634e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    $memcached_servers \u003d suffix(hiera(\u0027memcache_node_ips\u0027), \u0027:11211\u0027)"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":35,"context_line":"    class { \u0027::nova\u0027:"},{"line_number":36,"context_line":"      memcached_servers \u003d\u003e $memcached_servers,"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"    include ::nova::config"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_cdb7c984","line":37,"range":{"start_line":35,"start_character":4,"end_line":37,"end_character":5},"updated":"2016-06-07 08:05:56.000000000","message":"it seems you can\u0027t do this yet:\n\nError: Duplicate declaration: Class[Nova] is already declared in file /var/lib/heat-config/heat-config-puppet/f590a095-f153-425f-a4a3-35252664840e.pp:161; cannot redeclare at /etc/puppet/modules/tripleo/manifests/profile/base/nova.pp:37 on node overcloud-controller-0.localdomain\nError: Duplicate declaration: Class[Nova] is already declared in file /var/lib/heat-config/heat-config-puppet/f590a095-f153-425f-a4a3-35252664840e.pp:161; cannot redeclare at /etc/puppet/modules/tripleo/manifests/profile/base/nova.pp:37 on node overcloud-controller-0.localdomain\n\n\nOne workaround in the meantime would be to do something like:\n\nNova {\n  memcached_servers \u003d\u003e $memcached_servers,\n}\n\nAnd then do the include. then we can remove that include is removed from t-h-t.","commit_id":"667a00e89f9dd6956f2b28dd0aff691bb01a57e7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a3e27cd6fdab5f6462001bce786f45698bf89af3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    $memcached_servers \u003d suffix(hiera(\u0027memcache_node_ips\u0027), \u0027:11211\u0027)"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":35,"context_line":"    class { \u0027::nova\u0027:"},{"line_number":36,"context_line":"      memcached_servers \u003d\u003e $memcached_servers,"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"    include ::nova::config"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_61c14a54","line":37,"range":{"start_line":35,"start_character":4,"end_line":37,"end_character":5},"in_reply_to":"7aa08908_cdb7c984","updated":"2016-06-07 21:21:54.000000000","message":"If you read my commit message, you\u0027ll see that I expected this error. IMHO in this case we could probably wait for the THT to be green and land the 2 patches together if we want to make progress.","commit_id":"667a00e89f9dd6956f2b28dd0aff691bb01a57e7"}],"manifests/profile/pacemaker/nova.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"9e50eabccde4e6dabaa777572fd90f3791230994","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    stop       \u003d\u003e \u0027/bin/true\u0027,"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":39,"context_line":"    include ::tripleo::profile::base::nova"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_7dc81575","side":"PARENT","line":38,"updated":"2016-06-10 14:50:19.000000000","message":"Pacemaker currently uses if hiera(\u0027step\u0027) \u003e\u003d 4 or ( hiera(\u0027step\u0027) \u003e\u003d 3 and $sync_db ) {.\n\nI don\u0027t think this will break things to run it at step 3 though.","commit_id":"2f002bb0615a4ab8aa4954796a68936b0a4bdecb"}]}
