)]}'
{"manifests/certmonger/httpd.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7d0d3d9f5dbc37d76590be4343256cf4ace6c848","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db ) {"},{"line_number":89,"context_line":"    Certmonger_certificate[$name] ~\u003e Service[$::apache::params::service_name]"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"9a89bdaa_a89f1f64","line":89,"updated":"2016-09-08 21:21:42.000000000","message":"Actually you could just get away with Certmonger_certificate[$name] ~\u003e Service\u003c| title \u003d\u003d $::apache::params::service_name |\u003e since the certmonger certificate is declared here.","commit_id":"fa69e096411a2e3d8e2dfc687758144ea75deecc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"053e4a94f37253d73d268774b8225dc41be6431c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db ) {"},{"line_number":89,"context_line":"    Certmonger_certificate[$name] ~\u003e Service[$::apache::params::service_name]"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"9a89bdaa_48f5b3c9","line":89,"updated":"2016-09-08 21:19:48.000000000","message":"Rather than require $step here, would it be better to just use spaceship operators so it would just catch anytime the service is in the catalog?\n\nFor example just replacing this if block with\n\nCertmonger_certificate \u003c| title \u003d\u003d $name |\u003e ~\u003e Service\u003c| title \u003d\u003d $::apache::params::service_name |\u003e\n\n\nI don\u0027t know the traditional rules for using $step but it seems like something that should just kinda kept to profiles","commit_id":"fa69e096411a2e3d8e2dfc687758144ea75deecc"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"30fa710205e6180a4dc13e8b64c18a4a9ed1610a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db ) {"},{"line_number":89,"context_line":"    Certmonger_certificate[$name] ~\u003e Service[$::apache::params::service_name]"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"9a89bdaa_69e7b0ac","line":89,"in_reply_to":"9a89bdaa_8902346e","updated":"2016-09-09 14:34:42.000000000","message":"awesome; alright, I\u0027ll fix it in the next patch. Thanks for the tip!","commit_id":"fa69e096411a2e3d8e2dfc687758144ea75deecc"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"de89296231c6eb72a2a6d87de909fa8f27188fab","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db ) {"},{"line_number":89,"context_line":"    Certmonger_certificate[$name] ~\u003e Service[$::apache::params::service_name]"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"9a89bdaa_b4576c25","line":89,"in_reply_to":"9a89bdaa_a89f1f64","updated":"2016-09-09 05:49:14.000000000","message":"Is it a problem that the Service won\u0027t be in the same service catalog for the first two steps of the deployment? I used the step there so the notify is taken only on steps that will eventually have the apache service in the resource catalog. But if we can figure out a way to set that dependency even if some steps won\u0027t even have the service on the catalog. I\u0027m in.","commit_id":"fa69e096411a2e3d8e2dfc687758144ea75deecc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e2588d2c29bb960a833b4ca3be5b67e137d74a77","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db ) {"},{"line_number":89,"context_line":"    Certmonger_certificate[$name] ~\u003e Service[$::apache::params::service_name]"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"9a89bdaa_8902346e","line":89,"in_reply_to":"9a89bdaa_b4576c25","updated":"2016-09-09 14:31:55.000000000","message":"Certmonger_certificate[$name] ~\u003e Service\u003c| title \u003d\u003d $::apache::params::service_name |\u003e  will do that for you. The advantage/disadvantage of using the \u003c||\u003e operator is that it silently \u0027fails\u0027 if it\u0027s not present in the catalog.  Basically you don\u0027t get notified if the service is in the catalog so if you were expecting it and it wasn\u0027t there it\u0027s not a hard failure.\n\nBut the bigger issue is that if you\u0027re expecting for it to notify the apache service in step3, it won\u0027t if the file already existed in step 2. In theory it would be a noop in step 3/4 and would not trigger a service restart.","commit_id":"fa69e096411a2e3d8e2dfc687758144ea75deecc"}],"manifests/certmonger/httpd_internalapi.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"cd4e9bd797c3c4a4108b3df2f3eb447ba7d70f76","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   Defaults to \"HTTP/${::fqdn_internalapi}\""},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*tls_certfile*]"},{"line_number":34,"context_line":"#   (Optional) The path to the certificate that will be used for TLS in this"},{"line_number":35,"context_line":"#   service."},{"line_number":36,"context_line":"#   Defaults to \u0027/etc/pki/tls/certs/keystone.crt\u0027"},{"line_number":37,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"da7fb54a_0a5aba83","line":34,"updated":"2016-09-02 18:01:01.000000000","message":"defaults in docs don\u0027t match default values in code","commit_id":"dd11c8de30478159d2589fb62e430074d8ffb1ca"}],"manifests/certmonger/httpd_management.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"cd4e9bd797c3c4a4108b3df2f3eb447ba7d70f76","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*tls_certfile*]"},{"line_number":34,"context_line":"#   (Optional) The path to the certificate that will be used for TLS in this"},{"line_number":35,"context_line":"#   service."},{"line_number":36,"context_line":"#   Defaults to \u0027/etc/pki/tls/certs/keystone.crt\u0027"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*tls_keyfile*]"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"da7fb54a_8a77aa01","line":35,"updated":"2016-09-02 18:01:01.000000000","message":"defaults in docs don\u0027t match default values in code","commit_id":"dd11c8de30478159d2589fb62e430074d8ffb1ca"}],"manifests/haproxy.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e7c2ab50d0174a1a7f802a54a60e564ade63a020","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    zaqar_ws_ssl_port \u003d\u003e 9000,"},{"line_number":541,"context_line":"  }"},{"line_number":542,"context_line":"  $ports \u003d merge($default_service_ports, $service_ports)"},{"line_number":543,"context_line":"  $enable_internal_tls \u003d hiera(\u0027enable_internal_tls\u0027, false)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"  if $enable_internal_tls {"},{"line_number":546,"context_line":"    # TODO(jaosorior): change verify none to verify required."}],"source_content_type":"text/x-puppet","patch_set":51,"id":"fa6399be_79b5b1ce","line":543,"updated":"2016-10-18 15:58:55.000000000","message":"this probably should be a class parameter since it\u0027s just a heira lookup.","commit_id":"bfd5de240d5abe89f542c0b941fbf49a08df75a6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7ee5fde8e8635ce7b89bb6880f11bbbb07844ee4","unresolved":false,"context_lines":[{"line_number":548,"context_line":"  $ports \u003d merge($default_service_ports, $service_ports)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"  if $enable_internal_tls {"},{"line_number":551,"context_line":"    # TODO(jaosorior): change verify none to verify required."},{"line_number":552,"context_line":"    $internal_tls_member_options \u003d [\u0027ssl\u0027, \u0027verify none\u0027]"},{"line_number":553,"context_line":"  } else {"},{"line_number":554,"context_line":"    $internal_tls_member_options \u003d []"}],"source_content_type":"text/x-puppet","patch_set":53,"id":"fa6399be_6b0e9033","line":551,"updated":"2016-10-19 11:20:54.000000000","message":"do we have a bug for tracking this/visibility","commit_id":"c7aa056afe66d04b5cbb296de331fd1b7a5723ec"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"83f68997d689195b2e571cc7e0a805a053856685","unresolved":false,"context_lines":[{"line_number":548,"context_line":"  $ports \u003d merge($default_service_ports, $service_ports)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"  if $enable_internal_tls {"},{"line_number":551,"context_line":"    # TODO(jaosorior): change verify none to verify required."},{"line_number":552,"context_line":"    $internal_tls_member_options \u003d [\u0027ssl\u0027, \u0027verify none\u0027]"},{"line_number":553,"context_line":"  } else {"},{"line_number":554,"context_line":"    $internal_tls_member_options \u003d []"}],"source_content_type":"text/x-puppet","patch_set":53,"id":"fa6399be_0bb6f489","line":551,"in_reply_to":"fa6399be_6b0e9033","updated":"2016-10-19 11:35:54.000000000","message":"we don\u0027t have a bug yet.","commit_id":"c7aa056afe66d04b5cbb296de331fd1b7a5723ec"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"338b1fa5707c0325ce8aaa1493fed52d1d394add","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"  if $enable_internal_tls {"},{"line_number":551,"context_line":"    # TODO(jaosorior): change verify none to verify required."},{"line_number":552,"context_line":"    $internal_tls_member_options \u003d [\u0027ssl\u0027, \u0027verify none\u0027]"},{"line_number":553,"context_line":"  } else {"},{"line_number":554,"context_line":"    $internal_tls_member_options \u003d []"},{"line_number":555,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":55,"id":"fa6399be_ea00acad","line":552,"updated":"2016-10-20 11:59:58.000000000","message":"Yea i wonder about this, why verify none. If the certs are provided by certmonger, aren\u0027t they signed by a CA which is trusted on the overcloud nodes?","commit_id":"76bf2f532f9541eaf9cd7242ad2bf520f6788033"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"be34be6996502135135cc51be4009906b70be93f","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"  if $enable_internal_tls {"},{"line_number":551,"context_line":"    # TODO(jaosorior): change verify none to verify required."},{"line_number":552,"context_line":"    $internal_tls_member_options \u003d [\u0027ssl\u0027, \u0027verify none\u0027]"},{"line_number":553,"context_line":"  } else {"},{"line_number":554,"context_line":"    $internal_tls_member_options \u003d []"},{"line_number":555,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":55,"id":"da6895a0_21dde042","line":552,"in_reply_to":"fa6399be_2571f544","updated":"2016-10-21 08:57:58.000000000","message":"thanks for the explanation jaosorior - would be nice to have a bug number to put next to that TODO (really no biggie, just filing it would be good as a placeholder) in case someone stumbles across that verify_none and wonders why (it is why I asked about it previously).\n\nBut the discussion here should suffice if someone is really trying hard to find out why :)","commit_id":"76bf2f532f9541eaf9cd7242ad2bf520f6788033"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"c7655fdd1cfe75b3d3ef11592e76931869e64610","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"  if $enable_internal_tls {"},{"line_number":551,"context_line":"    # TODO(jaosorior): change verify none to verify required."},{"line_number":552,"context_line":"    $internal_tls_member_options \u003d [\u0027ssl\u0027, \u0027verify none\u0027]"},{"line_number":553,"context_line":"  } else {"},{"line_number":554,"context_line":"    $internal_tls_member_options \u003d []"},{"line_number":555,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":55,"id":"fa6399be_2571f544","line":552,"in_reply_to":"fa6399be_c573d97e","updated":"2016-10-20 12:06:58.000000000","message":"Ah yea that makes sense, thanks!","commit_id":"76bf2f532f9541eaf9cd7242ad2bf520f6788033"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f6ba31128644b7747ca751babcee09309506c8ae","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"  if $enable_internal_tls {"},{"line_number":551,"context_line":"    # TODO(jaosorior): change verify none to verify required."},{"line_number":552,"context_line":"    $internal_tls_member_options \u003d [\u0027ssl\u0027, \u0027verify none\u0027]"},{"line_number":553,"context_line":"  } else {"},{"line_number":554,"context_line":"    $internal_tls_member_options \u003d []"},{"line_number":555,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":55,"id":"fa6399be_c573d97e","line":552,"in_reply_to":"fa6399be_ea00acad","updated":"2016-10-20 12:02:20.000000000","message":"That is correct, but right now haproxy accesses the nodes via their IP address. And I need to change that at some point to be the hostname instead. Else the name verification will fail, since the certs have no mention of the IP.\n\nHaven\u0027t tested yet how problematic that is with the current haproxy configuration... right now I tested with verify none and it works. I\u0027m planning on working on this soon.","commit_id":"76bf2f532f9541eaf9cd7242ad2bf520f6788033"}],"manifests/internal_tls.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bfa4c1c1cc3adaeca4cc20530668316ec5d454bf","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  $global_ca           \u003d undef,"},{"line_number":33,"context_line":"){"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $enable_internal_tls {"},{"line_number":36,"context_line":"    include ::certmonger"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    unless $global_ca {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_827fdfde","line":35,"updated":"2016-06-08 14:56:09.000000000","message":"IMHO this logic should not exist, just import the class if you need it, no?","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bfa4c1c1cc3adaeca4cc20530668316ec5d454bf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    include ::certmonger"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    unless $global_ca {"},{"line_number":39,"context_line":"      fail(\"If internal TLS is enabled, you must provide the \u0027global_ca\u0027 parameter.\")"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    Certmonger_certificate {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_42e05796","line":39,"updated":"2016-06-08 14:56:09.000000000","message":"if you want to make this parameter required, just don\u0027t put default value and Puppet will fail if no parameter is set.","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"b8616d8675386f1aac4e100ea59ac34256a799ff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    include ::certmonger"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    unless $global_ca {"},{"line_number":39,"context_line":"      fail(\"If internal TLS is enabled, you must provide the \u0027global_ca\u0027 parameter.\")"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    Certmonger_certificate {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_911a6cc4","line":39,"in_reply_to":"7aa08908_42e05796","updated":"2016-06-09 04:56:24.000000000","message":"Good point; will fix.","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f37119b55e71488255f932d10c8229442f57bb0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*global_ca*]"},{"line_number":22,"context_line":"#   (Optional) The certmonger nickname for the CA that will be used."},{"line_number":23,"context_line":"#   This value is mandatory if internal TLS is enabled."},{"line_number":24,"context_line":"#   Defaults to undef"},{"line_number":25,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_5f9f5150","line":22,"updated":"2016-06-09 14:30:18.000000000","message":"not optional, but Required.","commit_id":"2945d7694e5eb4655230773ce274ef810f9bc618"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f37119b55e71488255f932d10c8229442f57bb0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*global_ca*]"},{"line_number":22,"context_line":"#   (Optional) The certmonger nickname for the CA that will be used."},{"line_number":23,"context_line":"#   This value is mandatory if internal TLS is enabled."},{"line_number":24,"context_line":"#   Defaults to undef"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class tripleo::internal_tls ("},{"line_number":27,"context_line":"  $global_ca           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_9fa9b97e","line":24,"updated":"2016-06-09 14:30:18.000000000","message":"no default.","commit_id":"2945d7694e5eb4655230773ce274ef810f9bc618"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f37119b55e71488255f932d10c8229442f57bb0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to undef"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class tripleo::internal_tls ("},{"line_number":27,"context_line":"  $global_ca           \u003d undef,"},{"line_number":28,"context_line":"){"},{"line_number":29,"context_line":"  include ::certmonger"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_1f9dc959","line":27,"updated":"2016-06-09 14:30:18.000000000","message":"no, don\u0027t put undef. Like I said, don\u0027t put default value, so if no value is given, Puppet catalog will fail. It makes the value required.","commit_id":"2945d7694e5eb4655230773ce274ef810f9bc618"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3dd24d9cd9dfaf0e6325cd43bc5682aaa12a961a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"){"},{"line_number":27,"context_line":"  include ::certmonger"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  Certmonger_certificate {"},{"line_number":30,"context_line":"    ca          \u003d\u003e $global_ca,"},{"line_number":31,"context_line":"    ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":32,"context_line":"    certbackend \u003d\u003e \u0027FILE\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_998487d3","line":29,"updated":"2016-06-14 07:43:57.000000000","message":"capitalisation nit? ( I see certmonger_certificate @  https://review.openstack.org/#/c/327029/7/manifests/profile/base/keystone.pp","commit_id":"88eb722208fe75925397a3c35907827ca1bc1fe0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c15bfe53b1c5065a1bc0191d9c34dc28bcc4d38a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"){"},{"line_number":27,"context_line":"  include ::certmonger"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  Certmonger_certificate {"},{"line_number":30,"context_line":"    ca          \u003d\u003e $global_ca,"},{"line_number":31,"context_line":"    ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":32,"context_line":"    certbackend \u003d\u003e \u0027FILE\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_d9744fd0","line":29,"in_reply_to":"7aa08908_998487d3","updated":"2016-06-14 07:49:23.000000000","message":"not a nit. This is how I\u0027m setting the defaults for the certmonger_certificate resource. capitalizing it is valid puppet-syntax and does not instantiate a resource.","commit_id":"88eb722208fe75925397a3c35907827ca1bc1fe0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"91669ca28ecefc59842afcb1178f9ee3f256f851","unresolved":false,"context_lines":[{"line_number":26,"context_line":"){"},{"line_number":27,"context_line":"  include ::certmonger"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  Certmonger_certificate {"},{"line_number":30,"context_line":"    ca          \u003d\u003e $global_ca,"},{"line_number":31,"context_line":"    ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":32,"context_line":"    certbackend \u003d\u003e \u0027FILE\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_f0b77f1e","line":29,"in_reply_to":"7aa08908_d9744fd0","updated":"2016-06-14 15:33:11.000000000","message":"ack thanks for checking jaosorior","commit_id":"88eb722208fe75925397a3c35907827ca1bc1fe0"}],"manifests/profile/base/keystone.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bfa4c1c1cc3adaeca4cc20530668316ec5d454bf","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $tls_cert_refresh_command \u003d \u0027/bin/true\u0027,"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  include ::tripleo::internal_tls"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  if $::tripleo::internal_tls::enable_internal_tls {"},{"line_number":84,"context_line":"    certmonger_certificate { \u0027keystone-cert\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_427cd7b4","line":81,"updated":"2016-06-08 14:56:09.000000000","message":"move it into the conditional","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bfa4c1c1cc3adaeca4cc20530668316ec5d454bf","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  include ::tripleo::internal_tls"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  if $::tripleo::internal_tls::enable_internal_tls {"},{"line_number":84,"context_line":"    certmonger_certificate { \u0027keystone-cert\u0027:"},{"line_number":85,"context_line":"      certfile     \u003d\u003e $tls_certfile,"},{"line_number":86,"context_line":"      keyfile      \u003d\u003e $tls_keyfile,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_c26f27fa","line":83,"updated":"2016-06-08 14:56:09.000000000","message":"just use a hiera param here, you can create \"enable_internal_tls\" and check it here.","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bfa4c1c1cc3adaeca4cc20530668316ec5d454bf","unresolved":false,"context_lines":[{"line_number":87,"context_line":"      hostname     \u003d\u003e $::fqdn,"},{"line_number":88,"context_line":"      principal    \u003d\u003e $service_principal,"},{"line_number":89,"context_line":"      postsave_cmd \u003d\u003e $tls_cert_refresh_command,"},{"line_number":90,"context_line":"      notify       \u003d\u003e Class[\u0027::keystone::wsgi::apache\u0027],"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_c4c73494","line":90,"updated":"2016-06-08 14:56:09.000000000","message":"I would rather notify Service[\u0027httpd\u0027] so we make sure we create the certif before starting apache and also we restart apache everytime the certmonger resource change (updates or...).","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bfa4c1c1cc3adaeca4cc20530668316ec5d454bf","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    include ::keystone::config"},{"line_number":105,"context_line":"    class { \u0027::keystone::wsgi::apache\u0027:"},{"line_number":106,"context_line":"        ssl      \u003d\u003e $::tripleo::internal_tls::enable_internal_tls,"},{"line_number":107,"context_line":"        ssl_cert \u003d\u003e $tls_certfile,"},{"line_number":108,"context_line":"        ssl_key  \u003d\u003e $tls_keyfile,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_6443e013","line":105,"updated":"2016-06-08 14:56:09.000000000","message":"no, please try to hiera in THT eventually. Well otherwise that should be fine...","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"b8616d8675386f1aac4e100ea59ac34256a799ff","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    include ::keystone::config"},{"line_number":105,"context_line":"    class { \u0027::keystone::wsgi::apache\u0027:"},{"line_number":106,"context_line":"        ssl      \u003d\u003e $::tripleo::internal_tls::enable_internal_tls,"},{"line_number":107,"context_line":"        ssl_cert \u003d\u003e $tls_certfile,"},{"line_number":108,"context_line":"        ssl_key  \u003d\u003e $tls_keyfile,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_11eafc73","line":105,"in_reply_to":"7aa08908_6443e013","updated":"2016-06-09 04:56:24.000000000","message":"well, the idea is that tls_certfile and tls_keyfile would have the defaults set here; and then the deployer could overwrite the values via hieradata in t-h-t. The reason I decide not to set the ssl value through hiera in t-h-t, is that it would require a lot more code to set in t-h-t. And not every puppet manifest takes a flag that enables ssl; Some just take the cert and key. So to have consistency and to have it more simple; I decided to have one key for hiera.","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f37119b55e71488255f932d10c8229442f57bb0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $tls_cert_refresh_command \u003d \u0027/bin/true\u0027,"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  $enable_internal_tls \u003d hiera(\u0027enable_internal_tls\u0027, false)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  if $enable_internal_tls {"},{"line_number":84,"context_line":"    include ::tripleo::internal_tls"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_7fc96d5a","line":81,"updated":"2016-06-09 14:30:18.000000000","message":"yes","commit_id":"2945d7694e5eb4655230773ce274ef810f9bc618"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4f37119b55e71488255f932d10c8229442f57bb0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      hostname     \u003d\u003e $::fqdn,"},{"line_number":90,"context_line":"      principal    \u003d\u003e $service_principal,"},{"line_number":91,"context_line":"      postsave_cmd \u003d\u003e $tls_cert_refresh_command,"},{"line_number":92,"context_line":"      notify       \u003d\u003e Service[$::apache::params::service_name],"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_df07c17f","line":92,"updated":"2016-06-09 14:30:18.000000000","message":"yes, just to make sure you have it in catalog, you can include ::apache::params before this resource.","commit_id":"2945d7694e5eb4655230773ce274ef810f9bc618"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3dd24d9cd9dfaf0e6325cd43bc5682aaa12a961a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $tls_certfile             \u003d \u0027/etc/pki/tls/certs/keystone.crt\u0027,"},{"line_number":76,"context_line":"  $tls_keyfile              \u003d \u0027/etc/pki/tls/private/keystone.key\u0027,"},{"line_number":77,"context_line":"  $service_principal        \u003d \"keystone/${::fqdn}\","},{"line_number":78,"context_line":"  $tls_cert_refresh_command \u003d undef,"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  $enable_internal_tls \u003d hiera(\u0027enable_internal_tls\u0027, false)"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_99d2c7cf","line":78,"updated":"2016-06-14 07:43:57.000000000","message":"are we going to land as is and revisit the default here? Can\u0027t we just systemctl reload as you say above?\n\nIf we will land like this \u0026\u0026 iterate, then we should fixup the comment above to be clear about this and also be consistent (here we default to undef but have true @ https://review.openstack.org/#/c/328859/4/manifests/profile/base/cinder/api.pp )","commit_id":"88eb722208fe75925397a3c35907827ca1bc1fe0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c15bfe53b1c5065a1bc0191d9c34dc28bcc4d38a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $tls_certfile             \u003d \u0027/etc/pki/tls/certs/keystone.crt\u0027,"},{"line_number":76,"context_line":"  $tls_keyfile              \u003d \u0027/etc/pki/tls/private/keystone.key\u0027,"},{"line_number":77,"context_line":"  $service_principal        \u003d \"keystone/${::fqdn}\","},{"line_number":78,"context_line":"  $tls_cert_refresh_command \u003d undef,"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  $enable_internal_tls \u003d hiera(\u0027enable_internal_tls\u0027, false)"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_39575327","line":78,"in_reply_to":"7aa08908_99d2c7cf","updated":"2016-06-14 07:49:23.000000000","message":"actually, I do the setting of the default value in line 89. I can\u0027t do it here in the parameters because we need ::apache::params to be in the resource catalog. So I do it with the pick command in the code.","commit_id":"88eb722208fe75925397a3c35907827ca1bc1fe0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8ed92469a99426383ea8172d9eaf3a0610acb9de","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   resubmit for the certificate. That is, when the certificate expires and a"},{"line_number":63,"context_line":"#   new one needs to be requested. This typically needs to be a command that"},{"line_number":64,"context_line":"#   can refresh the service so it can start using the new certificate."},{"line_number":65,"context_line":"#   Defaults to \"systemctl reload ${::apache::params::service_name}\""},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"class tripleo::profile::base::keystone ("},{"line_number":68,"context_line":"  $sync_db                  \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7aa08908_82bcca07","line":65,"updated":"2016-06-15 08:34:04.000000000","message":"this is a lie jaosorior :/ tsk tsk tsk\n\n[EDIT: nm... i saw it as undef in the params... but why not just default it there?]","commit_id":"c68d16672c637f8695ecba8400383cb6e4aa0cc1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8ed92469a99426383ea8172d9eaf3a0610acb9de","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $tls_certfile             \u003d \u0027/etc/pki/tls/certs/keystone.crt\u0027,"},{"line_number":76,"context_line":"  $tls_keyfile              \u003d \u0027/etc/pki/tls/private/keystone.key\u0027,"},{"line_number":77,"context_line":"  $service_principal        \u003d \"keystone/${::fqdn}\","},{"line_number":78,"context_line":"  $tls_cert_refresh_command \u003d undef,"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  $enable_internal_tls \u003d hiera(\u0027enable_internal_tls\u0027, false)"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7aa08908_e2430e12","line":78,"updated":"2016-06-15 08:34:04.000000000","message":"^","commit_id":"c68d16672c637f8695ecba8400383cb6e4aa0cc1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8ed92469a99426383ea8172d9eaf3a0610acb9de","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    $postsave_cmd \u003d pick("},{"line_number":88,"context_line":"      $tls_cert_refresh_command,"},{"line_number":89,"context_line":"      \"systemctl reload ${::apache::params::service_name}\","},{"line_number":90,"context_line":"    )"},{"line_number":91,"context_line":"    certmonger_certificate { \u0027keystone-cert\u0027:"},{"line_number":92,"context_line":"      certfile     \u003d\u003e $tls_certfile,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7aa08908_42702274","line":89,"updated":"2016-06-15 08:34:04.000000000","message":"why not just default it in the params?","commit_id":"c68d16672c637f8695ecba8400383cb6e4aa0cc1"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"3865f95c43a20a95b57c0b8bb2aba7b65b1c5f13","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    $postsave_cmd \u003d pick("},{"line_number":88,"context_line":"      $tls_cert_refresh_command,"},{"line_number":89,"context_line":"      \"systemctl reload ${::apache::params::service_name}\","},{"line_number":90,"context_line":"    )"},{"line_number":91,"context_line":"    certmonger_certificate { \u0027keystone-cert\u0027:"},{"line_number":92,"context_line":"      certfile     \u003d\u003e $tls_certfile,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7aa08908_a2df460b","line":89,"in_reply_to":"7aa08908_42702274","updated":"2016-06-15 08:38:35.000000000","message":"because the include of ::apache::params is needed. Else it won\u0027t be in the resource catalog and it will fail.","commit_id":"c68d16672c637f8695ecba8400383cb6e4aa0cc1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9047529084ee0331f8693889a09df174cbd66bfb","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    $postsave_cmd \u003d pick("},{"line_number":88,"context_line":"      $tls_cert_refresh_command,"},{"line_number":89,"context_line":"      \"systemctl reload ${::apache::params::service_name}\","},{"line_number":90,"context_line":"    )"},{"line_number":91,"context_line":"    certmonger_certificate { \u0027keystone-cert\u0027:"},{"line_number":92,"context_line":"      certfile     \u003d\u003e $tls_certfile,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7aa08908_00c37d8b","line":89,"in_reply_to":"7aa08908_a2df460b","updated":"2016-06-16 07:04:16.000000000","message":"makes sense thanks jaosorior","commit_id":"c68d16672c637f8695ecba8400383cb6e4aa0cc1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8ed92469a99426383ea8172d9eaf3a0610acb9de","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    include ::keystone::config"},{"line_number":112,"context_line":"    class { \u0027::keystone::wsgi::apache\u0027:"},{"line_number":113,"context_line":"      ssl      \u003d\u003e $enable_internal_tls,"},{"line_number":114,"context_line":"      ssl_cert \u003d\u003e $tls_certfile,"},{"line_number":115,"context_line":"      ssl_key  \u003d\u003e $tls_keyfile,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7aa08908_e2df8e38","line":112,"updated":"2016-06-15 08:34:04.000000000","message":"why not just make this an explicit if enable_internal_tls clause and just include the class otherwise? feels safer since you\u0027re already declaring and using that variable","commit_id":"c68d16672c637f8695ecba8400383cb6e4aa0cc1"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"3865f95c43a20a95b57c0b8bb2aba7b65b1c5f13","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    include ::keystone::config"},{"line_number":112,"context_line":"    class { \u0027::keystone::wsgi::apache\u0027:"},{"line_number":113,"context_line":"      ssl      \u003d\u003e $enable_internal_tls,"},{"line_number":114,"context_line":"      ssl_cert \u003d\u003e $tls_certfile,"},{"line_number":115,"context_line":"      ssl_key  \u003d\u003e $tls_keyfile,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7aa08908_42f66291","line":112,"in_reply_to":"7aa08908_e2df8e38","updated":"2016-06-15 08:38:35.000000000","message":"well, we have to use ::keystone::wsgi::apache, anyway, so this should work even if internal tls is not enabled.","commit_id":"c68d16672c637f8695ecba8400383cb6e4aa0cc1"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"eedcb9fab51c7210de65d320f10b83264e3e15a7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      principal    \u003d\u003e $service_principal,"},{"line_number":91,"context_line":"      postsave_cmd \u003d\u003e $postsave_cmd,"},{"line_number":92,"context_line":"      notify       \u003d\u003e Service[$::apache::params::service_name],"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  if $step \u003e\u003d 3 and $sync_db {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3aaa91ec_197b7ef6","line":93,"updated":"2016-06-24 13:00:27.000000000","message":"Took me a while to figure out how this actually provides enough data to make sure that the cert can be renewed (what CA is contacted and how).\n\nSaw this: https://review.openstack.org/#/c/328216/4/environments/internal-tls-freeipa-ca.yaml\n\nSo i guess FreeIPA will take care of the renewal, and the FreeIPA CA will be trusted on all nodes?\n\nStill wondering what will the actual InternalTLSData look like, how do we configure the deployment to connect with a FreeIPA authority etc., but in principle the approach LGTM :)\n\nDid you have some luck with e2e testing with FreeIPA? If we don\u0027t have TripleO + FreeIPA integration automated, it would be nice to at least doc it. Something in the sense of \"What do i need to do so that i can flip `enable_internal_tls` to true and make certmonger really work and renew my certs.\" It\u0027s still a bit hard to imagine how does everything happen end to end (for me at least).","commit_id":"abcf234b3521540d31f190f4a97c05a43644d0d6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7ee5fde8e8635ce7b89bb6880f11bbbb07844ee4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"class tripleo::profile::base::keystone ("},{"line_number":63,"context_line":"  $bootstrap_node                \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":64,"context_line":"  $certificates_specs            \u003d hiera(\u0027apache_certificates_specs\u0027, {}),"},{"line_number":65,"context_line":"  $enable_internal_tls           \u003d hiera(\u0027enable_internal_tls\u0027, false),"},{"line_number":66,"context_line":"  $generate_service_certificates \u003d hiera(\u0027generate_service_certificates\u0027, false),"},{"line_number":67,"context_line":"  $manage_db_purge               \u003d hiera(\u0027keystone_enable_db_purge\u0027, true),"}],"source_content_type":"text/x-puppet","patch_set":53,"id":"fa6399be_10d1c3cd","line":64,"range":{"start_line":64,"start_character":42,"end_line":64,"end_character":67},"updated":"2016-10-19 11:20:54.000000000","message":"where are we setting this hiera? (I see we already have enable_internal_tls from If47febb5b38b1c65f60f9de87a34cb31936a7c0d but can\u0027t quickly find the cert specs (i.e. is there a related tht side review too)","commit_id":"c7aa056afe66d04b5cbb296de331fd1b7a5723ec"},{"author":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"change_message_id":"d7a434c844b8de9cee2ecd8a4b90fee801d1f285","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"class tripleo::profile::base::keystone ("},{"line_number":63,"context_line":"  $bootstrap_node                \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":64,"context_line":"  $certificates_specs            \u003d hiera(\u0027apache_certificates_specs\u0027, {}),"},{"line_number":65,"context_line":"  $enable_internal_tls           \u003d hiera(\u0027enable_internal_tls\u0027, false),"},{"line_number":66,"context_line":"  $generate_service_certificates \u003d hiera(\u0027generate_service_certificates\u0027, false),"},{"line_number":67,"context_line":"  $manage_db_purge               \u003d hiera(\u0027keystone_enable_db_purge\u0027, true),"}],"source_content_type":"text/x-puppet","patch_set":53,"id":"fa6399be_92187086","line":64,"range":{"start_line":64,"start_character":42,"end_line":64,"end_character":67},"in_reply_to":"fa6399be_10d1c3cd","updated":"2016-10-19 13:47:51.000000000","message":"I think it\u0027s set in here: I12e794f2d4076be9505dabfe456c1ca6cfbd359c","commit_id":"c7aa056afe66d04b5cbb296de331fd1b7a5723ec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"19b29bace74ea85072255d49d1df3abc241b1548","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"class tripleo::profile::base::keystone ("},{"line_number":63,"context_line":"  $bootstrap_node                \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":64,"context_line":"  $certificates_specs            \u003d hiera(\u0027apache_certificates_specs\u0027, {}),"},{"line_number":65,"context_line":"  $enable_internal_tls           \u003d hiera(\u0027enable_internal_tls\u0027, false),"},{"line_number":66,"context_line":"  $generate_service_certificates \u003d hiera(\u0027generate_service_certificates\u0027, false),"},{"line_number":67,"context_line":"  $manage_db_purge               \u003d hiera(\u0027keystone_enable_db_purge\u0027, true),"}],"source_content_type":"text/x-puppet","patch_set":53,"id":"da6895a0_e1a048a8","line":64,"range":{"start_line":64,"start_character":42,"end_line":64,"end_character":67},"in_reply_to":"fa6399be_92187086","updated":"2016-10-21 08:56:50.000000000","message":"thanks shadower","commit_id":"c7aa056afe66d04b5cbb296de331fd1b7a5723ec"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"87ab7efbac385ec75bb1932452deb0aa8e8445ca","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      ensure_resources(\u0027tripleo::certmonger::httpd\u0027, $certificates_specs)"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    $public_endpoint_network \u003d hiera(\u0027keystone_public_api_network\u0027)"},{"line_number":94,"context_line":"    if !$public_endpoint_network {"},{"line_number":95,"context_line":"      fail(\u0027keystone_public_api_network is not set in the hieradata.\u0027)"},{"line_number":96,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":54,"id":"fa6399be_a5f36909","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":67},"updated":"2016-10-19 14:38:29.000000000","message":"Please move this to a class parameter with the default of undef if it\u0027s not going to be defined all the time. This will also aid in testing later. Also the if clause below will make sense...","commit_id":"fae92358104941b50d30b6d66f7aed465168c35e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"87ab7efbac385ec75bb1932452deb0aa8e8445ca","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    $public_endpoint_network \u003d hiera(\u0027keystone_public_api_network\u0027)"},{"line_number":94,"context_line":"    if !$public_endpoint_network {"},{"line_number":95,"context_line":"      fail(\u0027keystone_public_api_network is not set in the hieradata.\u0027)"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"    $tls_certfile \u003d $certificates_specs[\"httpd-${public_endpoint_network}\"][\u0027service_certificate\u0027]"},{"line_number":98,"context_line":"    $tls_keyfile \u003d $certificates_specs[\"httpd-${public_endpoint_network}\"][\u0027service_key\u0027]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":54,"id":"fa6399be_e5964193","line":96,"range":{"start_line":94,"start_character":4,"end_line":96,"end_character":5},"updated":"2016-10-19 14:38:29.000000000","message":"This will never evaluate because if keystone_public_api_network doesn\u0027t exist in the hieradata, the hiera call would fail.","commit_id":"fae92358104941b50d30b6d66f7aed465168c35e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"87ab7efbac385ec75bb1932452deb0aa8e8445ca","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    $tls_certfile \u003d $certificates_specs[\"httpd-${public_endpoint_network}\"][\u0027service_certificate\u0027]"},{"line_number":98,"context_line":"    $tls_keyfile \u003d $certificates_specs[\"httpd-${public_endpoint_network}\"][\u0027service_key\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    $admin_endpoint_network \u003d hiera(\u0027keystone_admin_api_network\u0027)"},{"line_number":101,"context_line":"    if !$admin_endpoint_network {"},{"line_number":102,"context_line":"      fail(\u0027keystone_admin_api_network is not set in the hieradata.\u0027)"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"    $tls_certfile_admin \u003d $certificates_specs[\"httpd-${admin_endpoint_network}\"][\u0027service_certificate\u0027]"},{"line_number":105,"context_line":"    $tls_keyfile_admin \u003d $certificates_specs[\"httpd-${admin_endpoint_network}\"][\u0027service_key\u0027]"},{"line_number":106,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":54,"id":"fa6399be_45e36d33","line":103,"range":{"start_line":100,"start_character":4,"end_line":103,"end_character":5},"updated":"2016-10-19 14:38:29.000000000","message":"same. Move the hiera call to a class parameter then the if clause will make sense.","commit_id":"fae92358104941b50d30b6d66f7aed465168c35e"}],"manifests/profile/pacemaker/keystone.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bfa4c1c1cc3adaeca4cc20530668316ec5d454bf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $tls_cert_refresh_command \u003d \u0027/bin/true\u0027,"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  include ::tripleo::internal_tls"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  Service \u003c| tag \u003d\u003d \u0027keystone-service\u0027 |\u003e {"},{"line_number":52,"context_line":"    hasrestart \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_446184a8","line":49,"updated":"2016-06-08 14:56:09.000000000","message":"it\u0027s already in base, you should not need it.","commit_id":"debcdf5e0056cdccd82514af35fab2f9e0eb05d9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3dd24d9cd9dfaf0e6325cd43bc5682aaa12a961a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $bootstrap_node           \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":44,"context_line":"  $step                     \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $enable_load_balancer     \u003d hiera(\u0027enable_load_balancer\u0027, true),"},{"line_number":46,"context_line":"  $tls_cert_refresh_command \u003d \u0027/bin/true\u0027,"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  include ::tripleo::internal_tls"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_19dff7d6","line":46,"updated":"2016-06-14 07:43:57.000000000","message":"consistency ^^^ assuming we\u0027re landing like this and if so fixup the comment for the parameter","commit_id":"88eb722208fe75925397a3c35907827ca1bc1fe0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c15bfe53b1c5065a1bc0191d9c34dc28bcc4d38a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $bootstrap_node           \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":44,"context_line":"  $step                     \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $enable_load_balancer     \u003d hiera(\u0027enable_load_balancer\u0027, true),"},{"line_number":46,"context_line":"  $tls_cert_refresh_command \u003d \u0027/bin/true\u0027,"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  include ::tripleo::internal_tls"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_59369f03","line":46,"in_reply_to":"7aa08908_19dff7d6","updated":"2016-06-14 07:49:23.000000000","message":"I will provide a fixup for this. I was just doing some research before getting this to an actual value.","commit_id":"88eb722208fe75925397a3c35907827ca1bc1fe0"}]}
