)]}'
{"manifests/profile/base/nova/compute.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7ee8f9c430ed21fb8be5fe2a94c135310874079e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    # deploy basic bits for nova-compute"},{"line_number":35,"context_line":"    include ::nova::compute"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # deploy basic bits for neutron"},{"line_number":38,"context_line":"    include ::neutron"},{"line_number":39,"context_line":"    include ::neutron::config"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # deploy bits to connect nova compute to neutron"},{"line_number":42,"context_line":"    include ::nova::network::neutron"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_59b78220","line":43,"range":{"start_line":36,"start_character":0,"end_line":43,"end_character":3},"updated":"2016-06-15 05:33:51.000000000","message":"is this the direction that wants to be taken? Thought neutron would be included in it\u0027s own manifest.","commit_id":"8bef199364e1ae621a41ad365607b2a261ddceea"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"38d4e53548c8fcc22049a1c24243e7f782c55026","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    # deploy basic bits for nova-compute"},{"line_number":35,"context_line":"    include ::nova::compute"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # deploy basic bits for neutron"},{"line_number":38,"context_line":"    include ::neutron"},{"line_number":39,"context_line":"    include ::neutron::config"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # deploy bits to connect nova compute to neutron"},{"line_number":42,"context_line":"    include ::nova::network::neutron"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_6161bc11","line":43,"range":{"start_line":36,"start_character":0,"end_line":43,"end_character":3},"in_reply_to":"7aa08908_59b78220","updated":"2016-06-15 18:38:58.000000000","message":"it\u0027s not neutron, it\u0027s just neutron params in nova.conf, only required by nova api \u0026 nova compute.","commit_id":"8bef199364e1ae621a41ad365607b2a261ddceea"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"39e829164ae182057590371ed7e59b499c6d46b4","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # deploy basic bits for neutron"},{"line_number":38,"context_line":"    include ::neutron"},{"line_number":39,"context_line":"    include ::neutron::config"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # deploy bits to connect nova compute to neutron"},{"line_number":42,"context_line":"    include ::nova::network::neutron"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_e408da2a","line":39,"updated":"2016-06-16 19:18:11.000000000","message":"Wouldn\u0027t it be better to include the neutron base profile for these?","commit_id":"69bde19c7cb3140b9a7719d6e4684f6e2b3b90e5"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"c035e37c42131f97c41020e067c14e85e8e95d8b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    include ::nova::compute"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # deploy basic bits for neutron"},{"line_number":38,"context_line":"    include ::tripleo::profile::base::neutron"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # deploy bits to connect nova compute to neutron"},{"line_number":41,"context_line":"    include ::nova::network::neutron"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_2b3715ff","line":38,"updated":"2016-06-17 21:14:44.000000000","message":"Can we just remove this entirely because it is already included via the Heat neutron-plugin services in Heat (which should always get included on a compute role via Heat anyways)","commit_id":"0ccc7505637a93639ccec73ffb2666bae479bf2e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2b428ca85de83c6dcbfa73f0c86316c1c85fd968","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    include ::nova::compute"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # deploy basic bits for neutron"},{"line_number":38,"context_line":"    include ::tripleo::profile::base::neutron"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # deploy bits to connect nova compute to neutron"},{"line_number":41,"context_line":"    include ::nova::network::neutron"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_d678b891","line":38,"in_reply_to":"7aa08908_2b3715ff","updated":"2016-06-17 21:20:46.000000000","message":"ok I\u0027ll drop it. Just for history it\u0027s included by agent, not plugin.","commit_id":"0ccc7505637a93639ccec73ffb2666bae479bf2e"}],"manifests/profile/base/nova/compute/libvirt.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"32e7f1ec492f33e769b2a945fe09c6faf0e796ea","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# \u003d\u003d Class: tripleo::profile::base::nova::compute::libvirt"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# Nova Compute profile for tripleo"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":20,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a9d85d2_5090f2ec","line":17,"updated":"2016-06-18 20:42:14.000000000","message":"Nova Compute libvirt profile","commit_id":"091d805141c9944725992f1b8a612ab4358f0bba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ab6a17587de01796a993a944999027786c68ffce","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# \u003d\u003d Class: tripleo::profile::base::nova::compute::libvirt"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# Nova Compute profile for tripleo"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":20,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a9d85d2_169f7d04","line":17,"in_reply_to":"5a9d85d2_5090f2ec","updated":"2016-06-19 16:33:09.000000000","message":"Done","commit_id":"091d805141c9944725992f1b8a612ab4358f0bba"}]}