)]}'
{"manifests/profile/base/nova/compute.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0fa512cd8587ef9d7f45c7cb7384115a3d3c9b18","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    include ::nova::network::neutron"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_2d9102f2","line":41,"updated":"2016-06-29 15:43:58.000000000","message":"indentation","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"471f5d14e0fc31242410989079490f4c5e36a9c1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    include ::nova::network::neutron"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_c8f78cd1","line":41,"in_reply_to":"3aaa91ec_2d9102f2","updated":"2016-06-29 15:51:12.000000000","message":"Done","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0fa512cd8587ef9d7f45c7cb7384115a3d3c9b18","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_adb33299","line":42,"updated":"2016-06-29 15:43:58.000000000","message":"would be nice to make this a class parameter","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"330be19ffd361508040a18298ce782e10d046359","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_e8552850","line":42,"in_reply_to":"3aaa91ec_2801f0af","updated":"2016-06-29 15:58:24.000000000","message":"so that we bound the seboolean manipulation to the module is doing it and don\u0027t carry a top-level hiera ... but it won\u0027t change the behaviour, it\u0027s a sort of \u0027organizational\u0027 change\n\nideally we\u0027d need to set the seboolean based on the fact that cinder is or is not using nfs so we could just grab the cinder parameter but this would be a relation in between two services which are deployed on different nodes and we don\u0027t have an interface for this (same problem with keystone endpoints which should be enabled based on a puppet parameter coming from a service template which might have been deployed on a different node)\n\nI think there is value in making this a class param until we sort the above issue, just so that it binds strictly where it is needed making it easier the cleanup later","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"471f5d14e0fc31242410989079490f4c5e36a9c1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_2801f0af","line":42,"in_reply_to":"3aaa91ec_adb33299","updated":"2016-06-29 15:51:12.000000000","message":"why?","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0abad97ff9f588cad851276ee75476e61725ca48","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_ae5cc97d","line":42,"in_reply_to":"3aaa91ec_e8552850","updated":"2016-06-29 16:11:15.000000000","message":"ok","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0fa512cd8587ef9d7f45c7cb7384115a3d3c9b18","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"},{"line_number":46,"context_line":"      selboolean { \u0027virt_use_nfs\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_4d69eef8","line":43,"updated":"2016-06-29 15:43:58.000000000","message":"I think we have a fake provider which always returns true, what is the purpose of this line?","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"471f5d14e0fc31242410989079490f4c5e36a9c1","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"},{"line_number":46,"context_line":"      selboolean { \u0027virt_use_nfs\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_8828e434","line":43,"in_reply_to":"3aaa91ec_4d69eef8","updated":"2016-06-29 15:51:12.000000000","message":"the package was defined here:\nhttps://review.openstack.org/#/c/332955/4/puppet/manifests/overcloud_compute.pp\n\nLet\u0027s keep it for now, maybe we can drop it later.","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"330be19ffd361508040a18298ce782e10d046359","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"},{"line_number":46,"context_line":"      selboolean { \u0027virt_use_nfs\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_c8e5cc09","line":43,"in_reply_to":"3aaa91ec_8828e434","updated":"2016-06-29 15:58:24.000000000","message":"right it makes this more explicit, cool, thanks","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0fa512cd8587ef9d7f45c7cb7384115a3d3c9b18","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"},{"line_number":46,"context_line":"      selboolean { \u0027virt_use_nfs\u0027:"},{"line_number":47,"context_line":"        value      \u003d\u003e on,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_0d53663a","line":44,"updated":"2016-06-29 15:43:58.000000000","message":"shouldn\u0027t this be -\u003e instead of ~\u003e ?","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0abad97ff9f588cad851276ee75476e61725ca48","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"},{"line_number":46,"context_line":"      selboolean { \u0027virt_use_nfs\u0027:"},{"line_number":47,"context_line":"        value      \u003d\u003e on,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_6e666152","line":44,"in_reply_to":"3aaa91ec_08a51446","updated":"2016-06-29 16:11:15.000000000","message":"ok, I\u0027ll use -\u003e like before.","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"471f5d14e0fc31242410989079490f4c5e36a9c1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"},{"line_number":46,"context_line":"      selboolean { \u0027virt_use_nfs\u0027:"},{"line_number":47,"context_line":"        value      \u003d\u003e on,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_2818d01d","line":44,"in_reply_to":"3aaa91ec_0d53663a","updated":"2016-06-29 15:51:12.000000000","message":"I think we want to restart nova compute everytime nfs utils is upgraded, so nova can take benefit of new nfs utils, no?","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1564caa4db190a4f8c58192e1b3edb4db99153ca","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# If NFS is used as a Cinder backend"},{"line_number":42,"context_line":"  if hiera(\u0027cinder_enable_nfs_backend\u0027, false) {"},{"line_number":43,"context_line":"    ensure_packages(\u0027nfs-utils\u0027, { ensure \u003d\u003e present })"},{"line_number":44,"context_line":"    Package[\u0027nfs-utils\u0027] ~\u003e Service[\u0027nova-compute\u0027]"},{"line_number":45,"context_line":"    if str2bool($::selinux) {"},{"line_number":46,"context_line":"      selboolean { \u0027virt_use_nfs\u0027:"},{"line_number":47,"context_line":"        value      \u003d\u003e on,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_08a51446","line":44,"in_reply_to":"3aaa91ec_2818d01d","updated":"2016-06-29 16:00:18.000000000","message":"I am not sure we need to, maybe restarting nova-compute is not dangerous but to use the newer utils it should probably unmount/remoung the NFS share where the cinder volumes are which it won\u0027t do anyway","commit_id":"5b9ae2f0cc59c3091934501c7d8353e09d8e1ddd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2ca09cacb8fa1b431bd46cb1a5e9b3a6dc41c5fb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::base::nova::compute ("},{"line_number":31,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $cinder_nfs_backend \u003d hiera(\u0027cinder_enable_nfs_backend\u0027, false),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_b170a8a5","line":32,"updated":"2016-06-29 16:16:54.000000000","message":"in the future we can provide this from the nova-compute.yaml template grabbing CinderEnableNfsBackend parameter","commit_id":"9e21def99609dc173bcd99f4d9b709fcdf661c57"}]}
