)]}'
{"manifests/profile/base/ceph/osd.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"833b1d6e692bfb2cca536aa7a541f44fec056a89","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":38,"context_line":"    if $ceph_osd_selinux_permissive {"},{"line_number":39,"context_line":"      class { \u0027::tripleo::selinux\u0027:"},{"line_number":40,"context_line":"        mode \u003d\u003e \u0027permissive\u0027,"},{"line_number":41,"context_line":"      } -\u003e Class[\u0027ceph::profile::osd\u0027]"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_ce7e6a69","line":39,"updated":"2016-06-29 19:51:53.000000000","message":"imho we should not declare this class here, it\u0027s a high level class, like firewall for example. I suggest we include it everywhere and set permissive if needed in the tht/service directly.","commit_id":"3f842bfa8b19febb834127bf7dfef7396ab0f6b9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4fead2728ebfc9776e56d8300791ae55efb10795","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":38,"context_line":"    if $ceph_osd_selinux_permissive {"},{"line_number":39,"context_line":"      class { \u0027::tripleo::selinux\u0027:"},{"line_number":40,"context_line":"        mode \u003d\u003e \u0027permissive\u0027,"},{"line_number":41,"context_line":"      } -\u003e Class[\u0027ceph::profile::osd\u0027]"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_feb650da","line":39,"in_reply_to":"3aaa91ec_14a7d80b","updated":"2016-06-30 12:47:48.000000000","message":"yeah, but if one day we include the selinux class somewhere, it will conflict for sure. We need to cleanup this selinux thing, by setting a general parameter to whether or not enable selinux on the node.","commit_id":"3f842bfa8b19febb834127bf7dfef7396ab0f6b9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e6dee270b8944802a7f9f744355860264f2e2f7e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":38,"context_line":"    if $ceph_osd_selinux_permissive {"},{"line_number":39,"context_line":"      class { \u0027::tripleo::selinux\u0027:"},{"line_number":40,"context_line":"        mode \u003d\u003e \u0027permissive\u0027,"},{"line_number":41,"context_line":"      } -\u003e Class[\u0027ceph::profile::osd\u0027]"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_14a7d80b","line":39,"in_reply_to":"3aaa91ec_ce7e6a69","updated":"2016-06-29 23:54:19.000000000","message":"given my goal here is just to default ceph_osd_selinux_permissive to false, should I keep the execs as they were?","commit_id":"3f842bfa8b19febb834127bf7dfef7396ab0f6b9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ea6473838767f31815c6b84bea8408b299abefe1","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":38,"context_line":"    if $ceph_osd_selinux_permissive {"},{"line_number":39,"context_line":"      class { \u0027::tripleo::selinux\u0027:"},{"line_number":40,"context_line":"        mode \u003d\u003e \u0027permissive\u0027,"},{"line_number":41,"context_line":"      } -\u003e Class[\u0027ceph::profile::osd\u0027]"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_7e0d403d","line":39,"in_reply_to":"3aaa91ec_feb650da","updated":"2016-06-30 12:55:30.000000000","message":"agreed, for the time being is better to keep the execs then, which won\u0027t conflict with the tripleo::selinux::mode parameter and preserve backward compat\n\nalso, but switching the if condition to false by default as it happens this code will just not be executed unless one explicitly provides a different hiera value to profile::base::ceph::osd","commit_id":"3f842bfa8b19febb834127bf7dfef7396ab0f6b9"}]}