)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eefc830a7db3e4d333acc6180455a2cf609b9a37","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Keith Schincke \u003ckeith.schincke@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-27 07:24:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add RGW to the Ceph mon profile."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds tripleo::profile::base::ceph::rgw"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_59460d50","line":7,"updated":"2016-06-28 16:12:46.000000000","message":"Add Ceph RGW profile.","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"5b693ced9defeb0613454715841b2597f2f86929","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Keith Schincke \u003ckeith.schincke@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-27 07:24:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add RGW to the Ceph mon profile."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds tripleo::profile::base::ceph::rgw"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_a2db4a7b","line":7,"in_reply_to":"3aaa91ec_59460d50","updated":"2016-06-29 12:31:40.000000000","message":"Done","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"}],"manifests/profile/base/ceph/rgw.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eefc830a7db3e4d333acc6180455a2cf609b9a37","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class tripleo::profile::base::ceph::rgw ("},{"line_number":27,"context_line":"  $step       \u003d hiera(\u0027step\u0027),"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  include ::tripleo::profile::base::ceph"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_1cf473cd","line":27,"updated":"2016-06-28 16:12:46.000000000","message":"we can add rgw_key as a class parameter here","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"5b693ced9defeb0613454715841b2597f2f86929","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class tripleo::profile::base::ceph::rgw ("},{"line_number":27,"context_line":"  $step       \u003d hiera(\u0027step\u0027),"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  include ::tripleo::profile::base::ceph"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_df7bcfbc","line":27,"in_reply_to":"3aaa91ec_1cf473cd","updated":"2016-06-29 12:31:40.000000000","message":"Done","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eefc830a7db3e4d333acc6180455a2cf609b9a37","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":33,"context_line":"    if hiera(\u0027ceph::profile::params::enable_rgw\u0027)"},{"line_number":34,"context_line":"    {"},{"line_number":35,"context_line":"      include ::ceph::profile::rgw"},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_b93611b2","line":33,"updated":"2016-06-28 16:12:46.000000000","message":"I don\u0027t see this in ::params:: ?\n\nlooks like we don\u0027t want this condition anyway so we could just skip to the include","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"5b693ced9defeb0613454715841b2597f2f86929","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":33,"context_line":"    if hiera(\u0027ceph::profile::params::enable_rgw\u0027)"},{"line_number":34,"context_line":"    {"},{"line_number":35,"context_line":"      include ::ceph::profile::rgw"},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_5f46bf7b","line":33,"in_reply_to":"3aaa91ec_b93611b2","updated":"2016-06-29 12:31:40.000000000","message":"Done","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eefc830a7db3e4d333acc6180455a2cf609b9a37","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":40,"context_line":"    if hiera(\u0027ceph::profile::params::enable_rgw\u0027)"},{"line_number":41,"context_line":"    {"},{"line_number":42,"context_line":"      $rgw_name \u003d $::ceph::profile::params::rgw_name ? {"},{"line_number":43,"context_line":"        undef   \u003d\u003e \u0027radosgw.gateway\u0027,"},{"line_number":44,"context_line":"        default \u003d\u003e $::ceph::profile::params::rgw_name,"},{"line_number":45,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_bc8eff24","line":42,"updated":"2016-06-28 16:12:46.000000000","message":"we can just call ::ceph::profile::params::rgw_name\n\nthe default will be set by ceph::profile::rgw anyway","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"5b693ced9defeb0613454715841b2597f2f86929","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":40,"context_line":"    if hiera(\u0027ceph::profile::params::enable_rgw\u0027)"},{"line_number":41,"context_line":"    {"},{"line_number":42,"context_line":"      $rgw_name \u003d $::ceph::profile::params::rgw_name ? {"},{"line_number":43,"context_line":"        undef   \u003d\u003e \u0027radosgw.gateway\u0027,"},{"line_number":44,"context_line":"        default \u003d\u003e $::ceph::profile::params::rgw_name,"},{"line_number":45,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_622202a5","line":42,"in_reply_to":"3aaa91ec_bc8eff24","updated":"2016-06-29 12:31:40.000000000","message":"ceph::profile::rgw only sets the local rgw_name parameter. I\u0027ll need to submit a patch to set the ceph::profile::params::rgw_name parameter","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eefc830a7db3e4d333acc6180455a2cf609b9a37","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        undef   \u003d\u003e \u0027radosgw.gateway\u0027,"},{"line_number":44,"context_line":"        default \u003d\u003e $::ceph::profile::params::rgw_name,"},{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"      ceph::key { \"client.${rgw_name}\":"},{"line_number":47,"context_line":"        secret  \u003d\u003e hiera(\u0027rgw_key\u0027),"},{"line_number":48,"context_line":"        cap_mon \u003d\u003e \u0027allow *\u0027,"},{"line_number":49,"context_line":"        cap_osd \u003d\u003e \u0027allow *\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_7c901796","line":46,"updated":"2016-06-28 16:12:46.000000000","message":"I think this should happen in step 2 as well","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"5b693ced9defeb0613454715841b2597f2f86929","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        undef   \u003d\u003e \u0027radosgw.gateway\u0027,"},{"line_number":44,"context_line":"        default \u003d\u003e $::ceph::profile::params::rgw_name,"},{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"      ceph::key { \"client.${rgw_name}\":"},{"line_number":47,"context_line":"        secret  \u003d\u003e hiera(\u0027rgw_key\u0027),"},{"line_number":48,"context_line":"        cap_mon \u003d\u003e \u0027allow *\u0027,"},{"line_number":49,"context_line":"        cap_osd \u003d\u003e \u0027allow *\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_02321ef2","line":46,"in_reply_to":"3aaa91ec_7c901796","updated":"2016-06-29 12:31:40.000000000","message":"Done","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eefc830a7db3e4d333acc6180455a2cf609b9a37","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cap_osd \u003d\u003e \u0027allow *\u0027,"},{"line_number":50,"context_line":"        inject  \u003d\u003e true,"},{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"      ceph::rgw::keystone { $rgw_name:"},{"line_number":53,"context_line":"        rgw_keystone_version        \u003d\u003e hiera(\u0027ceph::rgw::keystone::rgw_keystone_version\u0027),"},{"line_number":54,"context_line":"        rgw_keystone_admin_token    \u003d\u003e hiera(\u0027keystone::admin_token\u0027),"},{"line_number":55,"context_line":"        rgw_keystone_url            \u003d\u003e hiera(\u0027keystone::public_endpoint\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_7cadb787","line":52,"updated":"2016-06-28 16:12:46.000000000","message":"this should happen in step 5","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"5b693ced9defeb0613454715841b2597f2f86929","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cap_osd \u003d\u003e \u0027allow *\u0027,"},{"line_number":50,"context_line":"        inject  \u003d\u003e true,"},{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"      ceph::rgw::keystone { $rgw_name:"},{"line_number":53,"context_line":"        rgw_keystone_version        \u003d\u003e hiera(\u0027ceph::rgw::keystone::rgw_keystone_version\u0027),"},{"line_number":54,"context_line":"        rgw_keystone_admin_token    \u003d\u003e hiera(\u0027keystone::admin_token\u0027),"},{"line_number":55,"context_line":"        rgw_keystone_url            \u003d\u003e hiera(\u0027keystone::public_endpoint\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_826baeb8","line":52,"in_reply_to":"3aaa91ec_7cadb787","updated":"2016-06-29 12:31:40.000000000","message":"Done","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eefc830a7db3e4d333acc6180455a2cf609b9a37","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        rgw_keystone_version        \u003d\u003e hiera(\u0027ceph::rgw::keystone::rgw_keystone_version\u0027),"},{"line_number":54,"context_line":"        rgw_keystone_admin_token    \u003d\u003e hiera(\u0027keystone::admin_token\u0027),"},{"line_number":55,"context_line":"        rgw_keystone_url            \u003d\u003e hiera(\u0027keystone::public_endpoint\u0027),"},{"line_number":56,"context_line":"        rgw_keystone_accepted_roles \u003d\u003e hiera(\u0027radosgw_operator_roles\u0027),"},{"line_number":57,"context_line":"      }"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_9c2d0300","line":56,"updated":"2016-06-28 16:12:46.000000000","message":"not sure why we need this line?","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"5b693ced9defeb0613454715841b2597f2f86929","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        rgw_keystone_version        \u003d\u003e hiera(\u0027ceph::rgw::keystone::rgw_keystone_version\u0027),"},{"line_number":54,"context_line":"        rgw_keystone_admin_token    \u003d\u003e hiera(\u0027keystone::admin_token\u0027),"},{"line_number":55,"context_line":"        rgw_keystone_url            \u003d\u003e hiera(\u0027keystone::public_endpoint\u0027),"},{"line_number":56,"context_line":"        rgw_keystone_accepted_roles \u003d\u003e hiera(\u0027radosgw_operator_roles\u0027),"},{"line_number":57,"context_line":"      }"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_22ef5a1f","line":56,"in_reply_to":"3aaa91ec_9c2d0300","updated":"2016-06-29 12:31:40.000000000","message":"I need to investigate this.","commit_id":"8658add40806b0fbee512f375fda1a73b57d58ca"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"98c8eec325050f00d2790ea7fb57c3a74633c409","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":37,"context_line":"    include ::ceph::profile::rgw"},{"line_number":38,"context_line":"    $rgw_name \u003d $::ceph::profile::params::rgw_name ? {"},{"line_number":39,"context_line":"      undef   \u003d\u003e \u0027radosgw.gateway\u0027,"},{"line_number":40,"context_line":"      default \u003d\u003e $::ceph::profile::params::rgw_name,"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_5a07b617","line":38,"updated":"2016-07-06 18:55:36.000000000","message":"I think this could just be:\n\n  $rgw_name \u003d hiera(\u0027ceph::profile::params::rgw_name\u0027)","commit_id":"a2d49d0bcb81c71f61bccfe0e20faf01770b652a"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0af6be29e07201245ad0f9f26923da313f38548c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":37,"context_line":"    include ::ceph::profile::rgw"},{"line_number":38,"context_line":"    $rgw_name \u003d $::ceph::profile::params::rgw_name ? {"},{"line_number":39,"context_line":"      undef   \u003d\u003e \u0027radosgw.gateway\u0027,"},{"line_number":40,"context_line":"      default \u003d\u003e $::ceph::profile::params::rgw_name,"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_ee37c4fc","line":38,"in_reply_to":"1aa78d24_5a07b617","updated":"2016-07-06 23:14:43.000000000","message":"Done but the check needs to remain as ceph::profile::params::rgw_name defaults to undef.","commit_id":"a2d49d0bcb81c71f61bccfe0e20faf01770b652a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"98c8eec325050f00d2790ea7fb57c3a74633c409","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      rgw_keystone_version        \u003d\u003e hiera(\u0027ceph::rgw::keystone::rgw_keystone_version\u0027),"},{"line_number":52,"context_line":"      rgw_keystone_admin_token    \u003d\u003e hiera(\u0027keystone::admin_token\u0027),"},{"line_number":53,"context_line":"      rgw_keystone_url            \u003d\u003e hiera(\u0027keystone::public_endpoint\u0027),"},{"line_number":54,"context_line":"      rgw_keystone_accepted_roles \u003d\u003e hiera(\u0027radosgw_operator_roles\u0027),"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_7a127258","line":54,"updated":"2016-07-06 18:55:36.000000000","message":"I don\u0027t think we\u0027re emitting radosgw_operator_roles anywhere?","commit_id":"a2d49d0bcb81c71f61bccfe0e20faf01770b652a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"79dbce8d70137ee0324aa9afdc04b16cc79da4cb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      rgw_keystone_version        \u003d\u003e hiera(\u0027ceph::rgw::keystone::rgw_keystone_version\u0027),"},{"line_number":52,"context_line":"      rgw_keystone_admin_token    \u003d\u003e hiera(\u0027keystone::admin_token\u0027),"},{"line_number":53,"context_line":"      rgw_keystone_url            \u003d\u003e hiera(\u0027keystone::public_endpoint\u0027),"},{"line_number":54,"context_line":"      rgw_keystone_accepted_roles \u003d\u003e hiera(\u0027radosgw_operator_roles\u0027),"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_da49e661","line":54,"in_reply_to":"1aa78d24_7a127258","updated":"2016-07-06 18:56:53.000000000","message":"I would rmeove this line","commit_id":"a2d49d0bcb81c71f61bccfe0e20faf01770b652a"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"0af6be29e07201245ad0f9f26923da313f38548c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      rgw_keystone_version        \u003d\u003e hiera(\u0027ceph::rgw::keystone::rgw_keystone_version\u0027),"},{"line_number":52,"context_line":"      rgw_keystone_admin_token    \u003d\u003e hiera(\u0027keystone::admin_token\u0027),"},{"line_number":53,"context_line":"      rgw_keystone_url            \u003d\u003e hiera(\u0027keystone::public_endpoint\u0027),"},{"line_number":54,"context_line":"      rgw_keystone_accepted_roles \u003d\u003e hiera(\u0027radosgw_operator_roles\u0027),"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_ae7c9cb5","line":54,"in_reply_to":"1aa78d24_da49e661","updated":"2016-07-06 23:14:43.000000000","message":"In my upstream source this value was pass from the custom environment template. They poked the hiera data directly. I will remove this and let it default to \"_member_, Member\" as the accepted roles.","commit_id":"a2d49d0bcb81c71f61bccfe0e20faf01770b652a"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"e0a102b248b07f3aa4955df9f8ed80b11ab10f13","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      use_pki                  \u003d\u003e false,"},{"line_number":58,"context_line":"      rgw_keystone_admin_token \u003d\u003e $keystone_admin_token,"},{"line_number":59,"context_line":"      rgw_keystone_url         \u003d\u003e $keystone_url,"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"fa7ab95a_e42132b6","line":60,"updated":"2016-08-31 12:18:12.000000000","message":"Would putting this in an earlier step cause issues? (Does keystone have to be running for this to succeed?)","commit_id":"a7f57acdf3fddee3b0eceecece812bebd2f12a64"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"547f4bbe2cd01e315a9aa6e3b4f4a75b5d011a80","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      use_pki                  \u003d\u003e false,"},{"line_number":58,"context_line":"      rgw_keystone_admin_token \u003d\u003e $keystone_admin_token,"},{"line_number":59,"context_line":"      rgw_keystone_url         \u003d\u003e $keystone_url,"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"fa7ab95a_8d1fa95a","line":60,"in_reply_to":"fa7ab95a_e42132b6","updated":"2016-08-31 12:42:40.000000000","message":"there is an include on L92 in https://review.openstack.org/#/c/347956/30/manifests/rgw/keystone.pp\n\nthat should probably go in ::auth instead ... which means that this piece could run earlier than step 5, testing it","commit_id":"a7f57acdf3fddee3b0eceecece812bebd2f12a64"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4b7b16a79ad95e33c54158d2637699f32f4e7061","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      inject  \u003d\u003e true,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    ceph::rgw::keystone { $rgw_name:"},{"line_number":55,"context_line":"      rgw_keystone_admin_token \u003d\u003e $keystone_admin_token,"},{"line_number":56,"context_line":"      rgw_keystone_url         \u003d\u003e $keystone_url,"},{"line_number":57,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"fa7ab95a_64233ba8","line":54,"updated":"2016-08-31 21:48:25.000000000","message":"this needs keystone [1], moving it to step 4\n\n1. https://github.com/openstack/puppet-ceph/blob/master/manifests/rgw/keystone.pp#L103","commit_id":"8c0d969acd8ee17c0fc9ebcdbb1b681f4106e887"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"bb458224ba528eb01e8e4fa301256cf03514d043","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":45,"context_line":"    include ::ceph::profile::rgw"},{"line_number":46,"context_line":"    $rgw_name \u003d hiera(\u0027ceph::profile::params::rgw_name\u0027, \u0027radosgw.gateway\u0027)"},{"line_number":47,"context_line":"    ceph::key { \"client.${rgw_name}\":"},{"line_number":48,"context_line":"      secret  \u003d\u003e $rgw_key,"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"fa7ab95a_684b095a","line":45,"range":{"start_line":44,"start_character":17,"end_line":45,"end_character":1},"updated":"2016-09-01 01:17:28.000000000","message":"so if $step is less than 2 nothing happens and RGW is not being set.\nIf 3 then setup but not using keystone.\nAnd if 4 or more than setup usage of keystone for authentication. No option which keystone configuration to use? No PKI only?\n\nWhere is the logic that calls here passing $step?","commit_id":"fb71e101cd10fb30c71cc6acca89640f8027294a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a4a29a2982e4f4e719e5ad8ad1b68f6917a7efaf","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":45,"context_line":"    include ::ceph::profile::rgw"},{"line_number":46,"context_line":"    $rgw_name \u003d hiera(\u0027ceph::profile::params::rgw_name\u0027, \u0027radosgw.gateway\u0027)"},{"line_number":47,"context_line":"    ceph::key { \"client.${rgw_name}\":"},{"line_number":48,"context_line":"      secret  \u003d\u003e $rgw_key,"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"fa7ab95a_52d18bfa","line":45,"range":{"start_line":44,"start_character":17,"end_line":45,"end_character":1},"in_reply_to":"fa7ab95a_684b095a","updated":"2016-09-01 06:48:34.000000000","message":"all profiles go through all steps, this is meant to orchestrate the sequence in which the operations must happen","commit_id":"fb71e101cd10fb30c71cc6acca89640f8027294a"}]}