)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b5224ad9e18953dd9ed18610282598995aa08657","unresolved":false,"context_lines":[{"line_number":974,"context_line":"      ip_addresses      \u003d\u003e $nova_api_node_ips,"},{"line_number":975,"context_line":"      server_names      \u003d\u003e $nova_api_node_names,"},{"line_number":976,"context_line":"      public_ssl_port   \u003d\u003e $ports[ec2_api_ssl_port],"},{"line_number":977,"context_line":"      service_network   \u003d\u003e $ec2_api_network,"},{"line_number":978,"context_line":"    }"},{"line_number":979,"context_line":"  }"},{"line_number":980,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ba5201f7_daa2d598","line":977,"updated":"2017-01-04 20:43:47.000000000","message":"why not adding listen options for ssl?","commit_id":"a39fa205948f7a13f1d85bdb91c604de631ee8ec"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"3fe3051a0e29090d396f24e2eeec49c061156c6b","unresolved":false,"context_lines":[{"line_number":974,"context_line":"      ip_addresses      \u003d\u003e $nova_api_node_ips,"},{"line_number":975,"context_line":"      server_names      \u003d\u003e $nova_api_node_names,"},{"line_number":976,"context_line":"      public_ssl_port   \u003d\u003e $ports[ec2_api_ssl_port],"},{"line_number":977,"context_line":"      service_network   \u003d\u003e $ec2_api_network,"},{"line_number":978,"context_line":"    }"},{"line_number":979,"context_line":"  }"},{"line_number":980,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a3c09a3_3a7acc77","line":977,"in_reply_to":"ba5201f7_daa2d598","updated":"2017-01-17 17:44:03.000000000","message":"done","commit_id":"a39fa205948f7a13f1d85bdb91c604de631ee8ec"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"61f5cb0895d6f25a2a1790f7b6822d39aabe9703","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"      },"},{"line_number":1027,"context_line":"      public_ssl_port   \u003d\u003e $ports[ec2_api_ssl_port],"},{"line_number":1028,"context_line":"      service_network   \u003d\u003e $ec2_api_network,"},{"line_number":1029,"context_line":"      member_options    \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"},{"line_number":1030,"context_line":"    }"},{"line_number":1031,"context_line":"  }"},{"line_number":1032,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5a3905b3_85820851","line":1029,"range":{"start_line":1029,"start_character":10,"end_line":1029,"end_character":11},"updated":"2017-01-19 18:51:35.000000000","message":"please delete line 1029. The rest looks fine.","commit_id":"b3d7a64368a1116df1eada0cfd514437b3edadcb"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1e136969252372129196cd919c96db6b11b63f71","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"      },"},{"line_number":1027,"context_line":"      public_ssl_port   \u003d\u003e $ports[ec2_api_ssl_port],"},{"line_number":1028,"context_line":"      service_network   \u003d\u003e $ec2_api_network,"},{"line_number":1029,"context_line":"      member_options    \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"},{"line_number":1030,"context_line":"    }"},{"line_number":1031,"context_line":"  }"},{"line_number":1032,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5a3905b3_62a8b220","line":1029,"updated":"2017-01-19 18:46:09.000000000","message":"this will break since you don\u0027t actually support TLS for the ec2 service in the internal network.","commit_id":"b3d7a64368a1116df1eada0cfd514437b3edadcb"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9f4105e09e795edd1cb80137300e5d7ca520da96","unresolved":false,"context_lines":[{"line_number":526,"context_line":"  $nova_metadata               \u003d hiera(\u0027nova_api_enabled\u0027, false),"},{"line_number":527,"context_line":"  $nova_novncproxy             \u003d hiera(\u0027nova_vnc_proxy_enabled\u0027, false),"},{"line_number":528,"context_line":"  $ec2_api                     \u003d hiera(\u0027ec2_api_enabled\u0027, false),"},{"line_number":529,"context_line":"  $ec2_api_metadata            \u003d hiera(\u0027ec2_api_enabled\u0027, false),"},{"line_number":530,"context_line":"  $ceilometer                  \u003d hiera(\u0027ceilometer_api_enabled\u0027, false),"},{"line_number":531,"context_line":"  $aodh                        \u003d hiera(\u0027aodh_api_enabled\u0027, false),"},{"line_number":532,"context_line":"  $panko                       \u003d hiera(\u0027panko_api_enabled\u0027, false),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a3905b3_68e5f135","line":529,"updated":"2017-01-19 19:17:12.000000000","message":"this is fine","commit_id":"8a8a77435a8bbcd85258775a9b1b3dd494bcf9b2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f037aa41d74ad6ee6de4a92e687e9a13d1995536","unresolved":false,"context_lines":[{"line_number":579,"context_line":"  $panko_network               \u003d hiera(\u0027panko_api_network\u0027, undef),"},{"line_number":580,"context_line":"  $ovn_dbs_network             \u003d hiera(\u0027ovn_dbs_network\u0027, undef),"},{"line_number":581,"context_line":"  $ec2_api_network             \u003d hiera(\u0027ec2_api_network\u0027, undef),"},{"line_number":582,"context_line":"  $ec2_api_metadata_network    \u003d hiera(\u0027ec2_api_metadata_network\u0027, undef),"},{"line_number":583,"context_line":"  $sahara_network              \u003d hiera(\u0027sahara_api_network\u0027, undef),"},{"line_number":584,"context_line":"  $swift_proxy_server_network  \u003d hiera(\u0027swift_proxy_network\u0027, undef),"},{"line_number":585,"context_line":"  $trove_network               \u003d hiera(\u0027trove_api_network\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a3905b3_05cff87f","line":582,"updated":"2017-01-19 19:00:23.000000000","message":"This entry doesn\u0027t exist since there isn\u0027t a profile in t-h-t. might want to default it to something else.","commit_id":"8a8a77435a8bbcd85258775a9b1b3dd494bcf9b2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9f4105e09e795edd1cb80137300e5d7ca520da96","unresolved":false,"context_lines":[{"line_number":579,"context_line":"  $panko_network               \u003d hiera(\u0027panko_api_network\u0027, undef),"},{"line_number":580,"context_line":"  $ovn_dbs_network             \u003d hiera(\u0027ovn_dbs_network\u0027, undef),"},{"line_number":581,"context_line":"  $ec2_api_network             \u003d hiera(\u0027ec2_api_network\u0027, undef),"},{"line_number":582,"context_line":"  $ec2_api_metadata_network    \u003d hiera(\u0027ec2_api_metadata_network\u0027, undef),"},{"line_number":583,"context_line":"  $sahara_network              \u003d hiera(\u0027sahara_api_network\u0027, undef),"},{"line_number":584,"context_line":"  $swift_proxy_server_network  \u003d hiera(\u0027swift_proxy_network\u0027, undef),"},{"line_number":585,"context_line":"  $trove_network               \u003d hiera(\u0027trove_api_network\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a3905b3_08c54d8d","line":582,"in_reply_to":"5a3905b3_05cff87f","updated":"2017-01-19 19:17:12.000000000","message":"ec2_api_metadata_network \u003d \u003d hiera(\u0027ec2_api_network\u0027, undef),","commit_id":"8a8a77435a8bbcd85258775a9b1b3dd494bcf9b2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9f4105e09e795edd1cb80137300e5d7ca520da96","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"  if $ec2_api {"},{"line_number":1015,"context_line":"    ::tripleo::haproxy::endpoint { \u0027ec2_api\u0027:"},{"line_number":1016,"context_line":"      public_virtual_ip \u003d\u003e $public_virtual_ip,"},{"line_number":1017,"context_line":"      internal_ip       \u003d\u003e hiera(\u0027ec2_api_vip\u0027, $nova_api_vip),"},{"line_number":1018,"context_line":"      service_port      \u003d\u003e $ports[ec2_api_port],"},{"line_number":1019,"context_line":"      ip_addresses      \u003d\u003e hiera(\u0027ec2_api_node_ips\u0027, $nova_api_node_ips),"},{"line_number":1020,"context_line":"      server_names      \u003d\u003e hiera(\u0027ec2_api_node_names\u0027, $nova_api_node_names),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a3905b3_a86359b0","line":1017,"updated":"2017-01-19 19:17:12.000000000","message":"no need to defalut the hiera lookup to the nova_api_vip. Just do as we do for other services and defalut to the controller_virtual_ip","commit_id":"8a8a77435a8bbcd85258775a9b1b3dd494bcf9b2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9f4105e09e795edd1cb80137300e5d7ca520da96","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"      internal_ip       \u003d\u003e hiera(\u0027ec2_api_vip\u0027, $nova_api_vip),"},{"line_number":1018,"context_line":"      service_port      \u003d\u003e $ports[ec2_api_port],"},{"line_number":1019,"context_line":"      ip_addresses      \u003d\u003e hiera(\u0027ec2_api_node_ips\u0027, $nova_api_node_ips),"},{"line_number":1020,"context_line":"      server_names      \u003d\u003e hiera(\u0027ec2_api_node_names\u0027, $nova_api_node_names),"},{"line_number":1021,"context_line":"      mode              \u003d\u003e \u0027http\u0027,"},{"line_number":1022,"context_line":"      listen_options    \u003d\u003e {"},{"line_number":1023,"context_line":"          \u0027http-request\u0027 \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a3905b3_e81481f6","line":1020,"updated":"2017-01-19 19:17:12.000000000","message":"lets default these as we do for other services.","commit_id":"8a8a77435a8bbcd85258775a9b1b3dd494bcf9b2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f037aa41d74ad6ee6de4a92e687e9a13d1995536","unresolved":false,"context_lines":[{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"  if $ec2_api_metadata {"},{"line_number":1033,"context_line":"    ::tripleo::haproxy::endpoint { \u0027ec2_api_metadata\u0027:"},{"line_number":1034,"context_line":"      internal_ip     \u003d\u003e hiera(\u0027ec2_api_metadata_vip\u0027, $nova_metadata_vip),"},{"line_number":1035,"context_line":"      service_port    \u003d\u003e $ports[ec2_api_metadata_port],"},{"line_number":1036,"context_line":"      ip_addresses    \u003d\u003e hiera(\u0027ec2_api_metadata_node_ips\u0027, $nova_metadata_node_ips),"},{"line_number":1037,"context_line":"      server_names    \u003d\u003e hiera(\u0027ec2_api_metadata_node_names\u0027, $nova_metadata_node_names),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a3905b3_c5825000","line":1034,"updated":"2017-01-19 19:00:23.000000000","message":"ec2_api_metadata_vip doesn\u0027t actually exist since there isn\u0027t a profile for it in t-h-t. I see that you then default it to the metadata vip, is this intended?","commit_id":"8a8a77435a8bbcd85258775a9b1b3dd494bcf9b2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9f4105e09e795edd1cb80137300e5d7ca520da96","unresolved":false,"context_lines":[{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"  if $ec2_api_metadata {"},{"line_number":1033,"context_line":"    ::tripleo::haproxy::endpoint { \u0027ec2_api_metadata\u0027:"},{"line_number":1034,"context_line":"      internal_ip     \u003d\u003e hiera(\u0027ec2_api_metadata_vip\u0027, $nova_metadata_vip),"},{"line_number":1035,"context_line":"      service_port    \u003d\u003e $ports[ec2_api_metadata_port],"},{"line_number":1036,"context_line":"      ip_addresses    \u003d\u003e hiera(\u0027ec2_api_metadata_node_ips\u0027, $nova_metadata_node_ips),"},{"line_number":1037,"context_line":"      server_names    \u003d\u003e hiera(\u0027ec2_api_metadata_node_names\u0027, $nova_metadata_node_names),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a3905b3_28704972","line":1034,"in_reply_to":"5a3905b3_c5825000","updated":"2017-01-19 19:17:12.000000000","message":"Lets have this value match the internal_ip parameter you will set for ec2_api","commit_id":"8a8a77435a8bbcd85258775a9b1b3dd494bcf9b2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9f4105e09e795edd1cb80137300e5d7ca520da96","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"      internal_ip     \u003d\u003e hiera(\u0027ec2_api_metadata_vip\u0027, $nova_metadata_vip),"},{"line_number":1035,"context_line":"      service_port    \u003d\u003e $ports[ec2_api_metadata_port],"},{"line_number":1036,"context_line":"      ip_addresses    \u003d\u003e hiera(\u0027ec2_api_metadata_node_ips\u0027, $nova_metadata_node_ips),"},{"line_number":1037,"context_line":"      server_names    \u003d\u003e hiera(\u0027ec2_api_metadata_node_names\u0027, $nova_metadata_node_names),"},{"line_number":1038,"context_line":"      service_network \u003d\u003e $ec2_api_metadata_network,"},{"line_number":1039,"context_line":"    }"},{"line_number":1040,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a3905b3_8805bdc3","line":1037,"updated":"2017-01-19 19:17:12.000000000","message":"lets use the values for ec2_api_node_ips and ec2_api_node_names","commit_id":"8a8a77435a8bbcd85258775a9b1b3dd494bcf9b2"}],"manifests/profile/base/nova/ec2api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b5224ad9e18953dd9ed18610282598995aa08657","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    include ::ec2api"},{"line_number":31,"context_line":"    include ::ec2api::api"},{"line_number":32,"context_line":"    include ::ec2api::db::sync"},{"line_number":33,"context_line":"    include ::ec2api::metadata"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ba5201f7_bad35103","line":33,"updated":"2017-01-04 20:43:47.000000000","message":"no, we need 2 services: api and metadata.\n\nThink containers, where we want one profile per container.\nOne profile \u003d\u003d one app.\n\nSo please create tripleo::profile::base::nova::ec2api::api and tripleo::profile::base::nova::ec2api::metadata.","commit_id":"a39fa205948f7a13f1d85bdb91c604de631ee8ec"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"3fe3051a0e29090d396f24e2eeec49c061156c6b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    include ::ec2api"},{"line_number":31,"context_line":"    include ::ec2api::api"},{"line_number":32,"context_line":"    include ::ec2api::db::sync"},{"line_number":33,"context_line":"    include ::ec2api::metadata"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a3c09a3_1a3ef08b","line":33,"in_reply_to":"ba5201f7_bad35103","updated":"2017-01-17 17:44:03.000000000","message":"In nova metadata service is also not split from the api, and the EC2 api service is a 1:1 proxy to the nova API, so I would prefer to keep it like it is, to not risk ocata deadline, and then split both nova and ec2 api in a combined effort in a second step.","commit_id":"a39fa205948f7a13f1d85bdb91c604de631ee8ec"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1e136969252372129196cd919c96db6b11b63f71","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    include ::ec2api"},{"line_number":31,"context_line":"    include ::ec2api::api"},{"line_number":32,"context_line":"    include ::ec2api::db::sync"},{"line_number":33,"context_line":"    include ::ec2api::metadata"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5a3905b3_4259f659","line":33,"updated":"2017-01-19 18:46:09.000000000","message":"this is were TLS would be supported ideally, however, it depends on what ec2 API runs on. if it\u0027s httpd it\u0027s fine, if it\u0027s eventlet then it isn\u0027t, and we should rather remove the intenral TLS options from the haproxy config.","commit_id":"b3d7a64368a1116df1eada0cfd514437b3edadcb"}]}
