)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6a5ed70ec18ec8bdd842106cef58d7659dcae582","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes a reference to a cinder:: parameter into the nova compute"},{"line_number":10,"context_line":"class to a nova:: parameter, which makes sure we\u0027re not trying"},{"line_number":11,"context_line":"to access \"out of bound\" parameters."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I871ef420700e6d0ee5c1e444e019d58b3a9a45a6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_9e6ec5c7","line":11,"updated":"2016-07-04 08:58:16.000000000","message":"do you mean we have rbd storage but cinder::volume::rbd_user_name isn\u0027t set...\n\nack thanks from irc:\n\n11:53 \u003c marios\u003e gfidente: so is it that we could have rbd storage but for some reason cinder::volume::rbd_user_name isn\u0027t set?\n11:53 \u003c marios\u003e gfidente: i see it landed as that in https://review.openstack.org/#/c/329682/8/manifests/profile/base/nova/compute/libvirt.pp\n11:54 \u003c gfidente\u003e yes when the roles are split on different nodes noda role doesn\u0027t have access to the cinder parameter\n11:54 \u003c gfidente\u003e *nova role","commit_id":"05a2b8820111ba05c3b5e1fe0d6df0c7162a1fc8"}],"manifests/profile/base/nova/compute/libvirt.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"73f337f2daf70612673887831731a46919a4c442","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    $rbd_persistent_storage \u003d hiera(\u0027rbd_persistent_storage\u0027, false)"},{"line_number":36,"context_line":"    if $rbd_ephemeral_storage or $rbd_persistent_storage {"},{"line_number":37,"context_line":"      $client_keys \u003d hiera(\u0027ceph::profile::params::client_keys\u0027)"},{"line_number":38,"context_line":"      $client_user \u003d join([\u0027client.\u0027, hiera(\u0027nova::compute::rbd::libvirt_rbd_user\u0027)])"},{"line_number":39,"context_line":"      class { \u0027::nova::compute::rbd\u0027:"},{"line_number":40,"context_line":"        libvirt_rbd_secret_key \u003d\u003e $client_keys[$client_user][\u0027secret\u0027],"},{"line_number":41,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_be23c104","line":38,"updated":"2016-07-04 09:05:07.000000000","message":"this has to be moved in the nova service templates; the change which makes ceph composable is moving the cinder:: parameter in the cinder service template [1] (cause cinder is deployed as a role already)\n\n1 I1921115cb6218c7554348636c404245c79937673","commit_id":"05a2b8820111ba05c3b5e1fe0d6df0c7162a1fc8"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4494e0e81103bbf92ec10d9aa93c7ed590cf47bf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    $rbd_persistent_storage \u003d hiera(\u0027rbd_persistent_storage\u0027, false)"},{"line_number":36,"context_line":"    if $rbd_ephemeral_storage or $rbd_persistent_storage {"},{"line_number":37,"context_line":"      $client_keys \u003d hiera(\u0027ceph::profile::params::client_keys\u0027)"},{"line_number":38,"context_line":"      $client_user \u003d join([\u0027client.\u0027, hiera(\u0027nova::compute::rbd::libvirt_rbd_user\u0027)])"},{"line_number":39,"context_line":"      class { \u0027::nova::compute::rbd\u0027:"},{"line_number":40,"context_line":"        libvirt_rbd_secret_key \u003d\u003e $client_keys[$client_user][\u0027secret\u0027],"},{"line_number":41,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_898851e9","line":38,"in_reply_to":"1aa78d24_892b3130","updated":"2016-07-04 09:25:41.000000000","message":"no it\u0027s other way around, this change does not depend on the roles because currently the same value is provided for both the cinder:: and the nova:: classes\n\nthe change decomposing ceph into roles instead depends on this one because it will remove the cinder:: parameter from the shared ceph cluster template","commit_id":"05a2b8820111ba05c3b5e1fe0d6df0c7162a1fc8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bd8878f17f553940b3a1dba5da837f09b2bababe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    $rbd_persistent_storage \u003d hiera(\u0027rbd_persistent_storage\u0027, false)"},{"line_number":36,"context_line":"    if $rbd_ephemeral_storage or $rbd_persistent_storage {"},{"line_number":37,"context_line":"      $client_keys \u003d hiera(\u0027ceph::profile::params::client_keys\u0027)"},{"line_number":38,"context_line":"      $client_user \u003d join([\u0027client.\u0027, hiera(\u0027nova::compute::rbd::libvirt_rbd_user\u0027)])"},{"line_number":39,"context_line":"      class { \u0027::nova::compute::rbd\u0027:"},{"line_number":40,"context_line":"        libvirt_rbd_secret_key \u003d\u003e $client_keys[$client_user][\u0027secret\u0027],"},{"line_number":41,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_892b3130","line":38,"in_reply_to":"1aa78d24_be23c104","updated":"2016-07-04 09:18:57.000000000","message":"ok so then do we need a depends-on ^^^ ?","commit_id":"05a2b8820111ba05c3b5e1fe0d6df0c7162a1fc8"}]}
