)]}'
{"manifests/profile/base/ceilometer.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c400a619646f22c40f429b1257b50a3ab994ff57","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   Defaults to true"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class tripleo::profile::base::ceilometer ("},{"line_number":35,"context_line":"  $ceilometer_backend \u003d \u0027mongodb\u0027,"},{"line_number":36,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":37,"context_line":"  $sync_db            \u003d true,"},{"line_number":38,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_de286388","line":35,"updated":"2016-07-01 18:22:04.000000000","message":"don\u0027t you want to lookup ceilometer_backend in hiera for it?","commit_id":"5632aa2092f632751fd73ff10ae5f32ca8acda44"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"f26e90c243c18acc56c7d1fc900a72dbeebc0bb2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   Defaults to true"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class tripleo::profile::base::ceilometer ("},{"line_number":35,"context_line":"  $ceilometer_backend \u003d \u0027mongodb\u0027,"},{"line_number":36,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":37,"context_line":"  $sync_db            \u003d true,"},{"line_number":38,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_7ec20f88","line":35,"in_reply_to":"3aaa91ec_de286388","updated":"2016-07-01 18:27:55.000000000","message":"I was thinking of passing this from service templates. something like:\n\ntripleo::profile::base::ceilometer::ceilometer_backend: {get_input: ceilometer_backend}","commit_id":"5632aa2092f632751fd73ff10ae5f32ca8acda44"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"04c58f21a077a414e3bfe8063956e90debb71665","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":36,"context_line":"    include ::ceilometer"},{"line_number":37,"context_line":"    include ::ceilometer::db"},{"line_number":38,"context_line":"    include ::ceilometer::config"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_94036a0d","side":"PARENT","line":37,"updated":"2016-07-02 00:07:33.000000000","message":"I think that\u0027s not good, because AFIK ceilometer API requires dabatase_connection parameters, supplied by ceilometer::db class.","commit_id":"389e7b42c0c1d9e81de928c6cc6763c294a9db6b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a2bf494a9612bdf38faef848c1f8191451099ca7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":31,"context_line":"    include ::ceilometer"},{"line_number":32,"context_line":"    include ::ceilometer::config"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1aa78d24_0e2f42f7","line":30,"updated":"2016-07-08 14:57:38.000000000","message":"shouldn\u0027t this stay at 4?","commit_id":"0f5f8f09296621036dc84e409aa4fda5649bb052"}],"manifests/profile/base/ceilometer/collector.pp":[{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"227332e535596eb8e8565ac4b9abe08830504a7b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $sync_db \u003d true,"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  $ceilometer_backend \u003d downcase(hiera(\u0027ceilometer_backend\u0027, \u0027mongodb\u0027))"},{"line_number":37,"context_line":"  # MongoDB"},{"line_number":38,"context_line":"  if $ceilometer_backend \u003d\u003d \u0027mongodb\u0027 {"},{"line_number":39,"context_line":"    # NOTE(gfidente): We need to pass the list of IPv6 addresses *with* port and"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_0669ab8b","line":36,"updated":"2016-07-05 15:10:25.000000000","message":"I wasnt sure if ceilometer_backend is accessible here as we remvoed that from puppet/controller.pp thats why i passed in a param and set it via the t-h-t. Lets see if ci passes","commit_id":"ce040f55e5fa745873caa0c1446577d4443a5b7c"}]}