)]}'
{"manifests/profile/pacemaker/nova.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8ac32e491354d6512a1f200d64c8461e4fe4f140","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  # We don\u0027t want pacemaker to manage nova-compute"},{"line_number":30,"context_line":"  Service\u003c|"},{"line_number":31,"context_line":"    title \u003d\u003d \u0027nova-api\u0027 or"},{"line_number":32,"context_line":"    title \u003d\u003d \u0027nova-conductor\u0027 or"},{"line_number":33,"context_line":"    title \u003d\u003d \u0027nova-consoleauth\u0027 or"},{"line_number":34,"context_line":"    title \u003d\u003d \u0027nova-scheduler\u0027 or"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_90ffc400","line":31,"updated":"2016-07-04 13:44:28.000000000","message":"actually can we migreate these within the roles themselves one by one?","commit_id":"cecadfbe67c66e738b608832b28c797d0ede19eb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1b4f364ecb2cf339d6ff7b6bb2a46501a85e3474","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  # We don\u0027t want pacemaker to manage nova-compute"},{"line_number":30,"context_line":"  Service\u003c|"},{"line_number":31,"context_line":"    title \u003d\u003d \u0027nova-api\u0027 or"},{"line_number":32,"context_line":"    title \u003d\u003d \u0027nova-conductor\u0027 or"},{"line_number":33,"context_line":"    title \u003d\u003d \u0027nova-consoleauth\u0027 or"},{"line_number":34,"context_line":"    title \u003d\u003d \u0027nova-scheduler\u0027 or"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_e34aba82","line":31,"in_reply_to":"1aa78d24_90ffc400","updated":"2016-07-04 18:21:19.000000000","message":"ok","commit_id":"cecadfbe67c66e738b608832b28c797d0ede19eb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1110a8e3c9671e22422c7cf7920c2207997a66fa","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    restart    \u003d\u003e \u0027/bin/true\u0027,"},{"line_number":34,"context_line":"    start      \u003d\u003e \u0027/bin/true\u0027,"},{"line_number":35,"context_line":"    stop       \u003d\u003e \u0027/bin/true\u0027,"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  include ::tripleo::profile::base::nova"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_3e96834c","side":"PARENT","line":36,"updated":"2016-07-05 08:29:27.000000000","message":"sorry for silly question/clarification... so we have these blocks in cases where we definitely do not want puppet to restart/start/stop these services -  since a restart just executes /bin/true... so by having these it implies the service is pacemaker managed and it will restart/start/stop the services.\n\nin this review, we keep these blocks in all nova component services - except nova compute - so that even in the case that nova-compute gets deployed on the controller, it won\u0027t be pcmk managed.","commit_id":"389e7b42c0c1d9e81de928c6cc6763c294a9db6b"}]}