)]}'
{"manifests/profile/base/heat.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7f261c6d04825c4dddb9bde92e0cec28fd9a3438","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      manage_user   \u003d\u003e false,"},{"line_number":51,"context_line":"      manage_role   \u003d\u003e false,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":56,"context_line":"    class { \u0027::heat\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_5031a604","line":53,"updated":"2016-07-19 15:04:15.000000000","message":"I thought of alternative ways to write this e.g. putting this into conditional of\n\n    hiera(\u0027step\u0027) \u003e\u003d 3\n\nand then for manage_domain etc. parameter values we could use:\n\n    ($bootstrap_master \u003d\u003d $::hostname) and hiera(\u0027step\u0027) \u003e\u003d 5\n\nwhich should be functionally equivalent to the current state, and we don\u0027t repeat the same code in here and in step 5.\n\nNeither of these solutions is super-easy to parse for the human eye i\u0027m afraid, so i\u0027m fine with either. +2.","commit_id":"14e2255d1b400b527f4cbe7fd8d46a1eca6c90d3"}]}
