)]}'
{"manifests/network/contrail/analytics.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"eda4ab8d25bf0b2429f364a443c3b95d2d7e764c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"#  Defaults to 6379"},{"line_number":120,"context_line":"#"},{"line_number":121,"context_line":"class tripleo::network::contrail::analytics("},{"line_number":122,"context_line":"  $auth_host,"},{"line_number":123,"context_line":"  $auth_protocol \u003d \u0027http\u0027,"},{"line_number":124,"context_line":"  $auth_port \u003d 35357,"},{"line_number":125,"context_line":"  $admin_user,"},{"line_number":126,"context_line":"  $admin_password,"},{"line_number":127,"context_line":"  $admin_token,"},{"line_number":128,"context_line":"  $admin_tenant_name,"},{"line_number":129,"context_line":"  $insecure \u003d false,"},{"line_number":130,"context_line":"  $memcached_servers \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":131,"context_line":"  $host_ip,"},{"line_number":132,"context_line":"  $http_server_port \u003d 8090,"},{"line_number":133,"context_line":"  $rest_api_ip \u003d \u00270.0.0.0\u0027,"},{"line_number":134,"context_line":"  $rest_api_port \u003d 8081,"},{"line_number":135,"context_line":"  $cassandra_server_list,"},{"line_number":136,"context_line":"  $zk_server_ip,"},{"line_number":137,"context_line":"  $disc_server_ip,"},{"line_number":138,"context_line":"  $disc_server_port,"},{"line_number":139,"context_line":"  $redis_server \u003d \u0027127.0.0.1\u0027,"},{"line_number":140,"context_line":"  $redis_server_port \u003d 6379,"},{"line_number":141,"context_line":"  $collector_http_server_port \u003d 8089,"},{"line_number":142,"context_line":"  $kafka_broker_list,"},{"line_number":143,"context_line":"  $collector_sandesh_port \u003d 8086,"},{"line_number":144,"context_line":")"},{"line_number":145,"context_line":"{"},{"line_number":146,"context_line":"  class {\u0027::contrail::keystone\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_d93c76ca","line":143,"range":{"start_line":122,"start_character":0,"end_line":143,"end_character":33},"updated":"2016-08-10 12:54:26.000000000","message":"Would be nice to sort this (and the comments) alphabetically. \n\nFirst should go mandatory parameters, then the optionals.","commit_id":"043dd3e7c3e45b606c147d98e57e9af5cdd140d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f95bc80eff72c458b647a60a75da33d6d4c37f9b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"#  String (IPv4) value + port"},{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"class tripleo::network::contrail::analytics("},{"line_number":126,"context_line":"  $admin_password,"},{"line_number":127,"context_line":"  $admin_tenant_name,"},{"line_number":128,"context_line":"  $admin_token,"},{"line_number":129,"context_line":"  $admin_user,"},{"line_number":130,"context_line":"  $auth_host,"},{"line_number":131,"context_line":"  $auth_port \u003d 35357,"},{"line_number":132,"context_line":"  $auth_protocol \u003d \u0027http\u0027,"},{"line_number":133,"context_line":"  $cassandra_server_list,"},{"line_number":134,"context_line":"  $collector_http_server_port \u003d 8089,"},{"line_number":135,"context_line":"  $collector_sandesh_port \u003d 8086,"},{"line_number":136,"context_line":"  $disc_server_ip,"},{"line_number":137,"context_line":"  $disc_server_port,"},{"line_number":138,"context_line":"  $host_ip,"},{"line_number":139,"context_line":"  $http_server_port \u003d 8090,"},{"line_number":140,"context_line":"  $insecure \u003d false,"},{"line_number":141,"context_line":"  $kafka_broker_list,"},{"line_number":142,"context_line":"  $redis_server \u003d \u0027127.0.0.1\u0027,"},{"line_number":143,"context_line":"  $redis_server_port \u003d 6379,"},{"line_number":144,"context_line":"  $rest_api_ip \u003d \u00270.0.0.0\u0027,"},{"line_number":145,"context_line":"  $rest_api_port \u003d 8081,"},{"line_number":146,"context_line":"  $zk_server_ip,"},{"line_number":147,"context_line":"  $memcached_servers \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":148,"context_line":")"},{"line_number":149,"context_line":"{"},{"line_number":150,"context_line":"  class {\u0027::contrail::keystone\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3ac371cc_ac7e0eac","line":147,"range":{"start_line":126,"start_character":0,"end_line":147,"end_character":41},"updated":"2016-08-15 11:11:45.000000000","message":"Should be like:\n  $admin_password,\n  $admin_tenant_name,\n  $admin_token,\n  $admin_user,\n  $auth_host,\n  $cassandra_server_list,\n  $disc_server_ip,\n  $disc_server_port,\n  $host_ip,\n  $kafka_broker_list,\n  $zk_server_ip,\n  $auth_port \u003d 35357,\n  $auth_protocol \u003d \u0027http\u0027,\n  $collector_http_server_port \u003d 8089,\n  $collector_sandesh_port \u003d 8086,\n  $http_server_port \u003d 8090,\n  $insecure \u003d false,\n  $memcached_servers \u003d \u0027127.0.0.1:11211\u0027,\n  $redis_server \u003d \u0027127.0.0.1\u0027,\n  $redis_server_port \u003d 6379,\n  $rest_api_ip \u003d \u00270.0.0.0\u0027,\n  $rest_api_port \u003d 8081,","commit_id":"6f6926d5da51a31b88fd011a08dba7814c043248"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":"# [*insecure*]"},{"line_number":93,"context_line":"#  (required) insecure mode."},{"line_number":94,"context_line":"#  String value."},{"line_number":95,"context_line":"#  Defaults to false"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*redis_server*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_0cd67027","line":94,"updated":"2016-08-18 14:43:30.000000000","message":"Boolean value","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":143,"context_line":"  $rest_api_port \u003d 8081,"},{"line_number":144,"context_line":"  $memcached_servers \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":145,"context_line":")"},{"line_number":146,"context_line":"{"},{"line_number":147,"context_line":"  class {\u0027::contrail::keystone\u0027:"},{"line_number":148,"context_line":"    keystone_config \u003d\u003e {"},{"line_number":149,"context_line":"      \u0027KEYSTONE\u0027 \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_e684cc5e","line":146,"updated":"2016-08-18 14:43:30.000000000","message":"ip validation.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        \u0027auth_port\u0027         \u003d\u003e $auth_port,"},{"line_number":156,"context_line":"        \u0027auth_protocol\u0027     \u003d\u003e $auth_protocol,"},{"line_number":157,"context_line":"        \u0027insecure\u0027          \u003d\u003e $insecure,"},{"line_number":158,"context_line":"        \u0027memcached_servers\u0027 \u003d\u003e $memcached_servers"},{"line_number":159,"context_line":"      }"},{"line_number":160,"context_line":"    }"},{"line_number":161,"context_line":"  } -\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_cc48d8ce","line":158,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        \u0027auth_protocol\u0027     \u003d\u003e $auth_protocol,"},{"line_number":157,"context_line":"        \u0027insecure\u0027          \u003d\u003e $insecure,"},{"line_number":158,"context_line":"        \u0027memcached_servers\u0027 \u003d\u003e $memcached_servers"},{"line_number":159,"context_line":"      }"},{"line_number":160,"context_line":"    }"},{"line_number":161,"context_line":"  } -\u003e"},{"line_number":162,"context_line":"  class {\u0027::contrail::analytics\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_f584745e","line":159,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \u0027insecure\u0027          \u003d\u003e $insecure,"},{"line_number":158,"context_line":"        \u0027memcached_servers\u0027 \u003d\u003e $memcached_servers"},{"line_number":159,"context_line":"      }"},{"line_number":160,"context_line":"    }"},{"line_number":161,"context_line":"  } -\u003e"},{"line_number":162,"context_line":"  class {\u0027::contrail::analytics\u0027:"},{"line_number":163,"context_line":"    analytics_api_config  \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_157e7069","line":160,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \u0027redis_server_port\u0027 \u003d\u003e $redis_server_port,"},{"line_number":178,"context_line":"        \u0027redis_query_port\u0027  \u003d\u003e $redis_server_port,"},{"line_number":179,"context_line":"        \u0027server\u0027            \u003d\u003e $redis_server,"},{"line_number":180,"context_line":"      }"},{"line_number":181,"context_line":"    },"},{"line_number":182,"context_line":"    collector_config      \u003d\u003e {"},{"line_number":183,"context_line":"      \u0027DEFAULTS\u0027  \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_b54afc52","line":180,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":198,"context_line":"      \u0027REDIS\u0027     \u003d\u003e {"},{"line_number":199,"context_line":"        \u0027port\u0027   \u003d\u003e $redis_server_port,"},{"line_number":200,"context_line":"        \u0027server\u0027 \u003d\u003e $redis_server,"},{"line_number":201,"context_line":"      }"},{"line_number":202,"context_line":"    },"},{"line_number":203,"context_line":"    query_engine_config   \u003d\u003e {"},{"line_number":204,"context_line":"      \u0027DEFAULTS\u0027  \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_75e08429","line":201,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":212,"context_line":"      \u0027REDIS\u0027     \u003d\u003e {"},{"line_number":213,"context_line":"        \u0027port\u0027   \u003d\u003e $redis_server_port,"},{"line_number":214,"context_line":"        \u0027server\u0027 \u003d\u003e $redis_server,"},{"line_number":215,"context_line":"      }"},{"line_number":216,"context_line":"    },"},{"line_number":217,"context_line":"    snmp_collector_config \u003d\u003e {"},{"line_number":218,"context_line":"      \u0027DEFAULTS\u0027  \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_f53914a5","line":215,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        \u0027disc_server_ip\u0027   \u003d\u003e $disc_server_ip,"},{"line_number":232,"context_line":"        \u0027disc_server_port\u0027 \u003d\u003e $disc_server_port,"},{"line_number":233,"context_line":"      },"},{"line_number":234,"context_line":"    }"},{"line_number":235,"context_line":"  }"},{"line_number":236,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_f560f4a6","line":234,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"a0f3f3f2d6762d13f3487e14891a381e73673c15","unresolved":false,"context_lines":[{"line_number":120,"context_line":"#  Defaults to \u0027127.0.0.1:12111\u0027"},{"line_number":121,"context_line":"#"},{"line_number":122,"context_line":"class tripleo::network::contrail::analytics("},{"line_number":123,"context_line":"  $admin_password \u003d hiera(\u0027contrail::admin_password\u0027),"},{"line_number":124,"context_line":"  $admin_tenant_name \u003d hiera(\u0027contrail::admin_tenant_name\u0027),"},{"line_number":125,"context_line":"  $admin_token \u003d hiera(\u0027contrail::admin_token\u0027),"},{"line_number":126,"context_line":"  $admin_user \u003d hiera(\u0027contrail::admin_user\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9a89bdaa_3606db20","line":123,"updated":"2016-09-09 16:55:07.000000000","message":"At first i wondered why we don\u0027t set the keys directly for tripleo::network::contrail::analytics class, then i noticed we have several classes using essentially the same parameter values, so i think this is a good approach. In case we could come up with some \"more usual Puppet way\" to address this in the future, we can iterate.\n\nThanks for the contribution!","commit_id":"591238d1cc4f9f34326555ca4ba8d45862223f12"}],"manifests/network/contrail/config.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"eda4ab8d25bf0b2429f364a443c3b95d2d7e764c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"#  String value."},{"line_number":105,"context_line":"#"},{"line_number":106,"context_line":"class tripleo::network::contrail::config("},{"line_number":107,"context_line":"  $multi_tenancy \u003d true,"},{"line_number":108,"context_line":"  $auth \u003d \u0027keystone\u0027,"},{"line_number":109,"context_line":"  $listen_ip_address \u003d \u00270.0.0.0\u0027,"},{"line_number":110,"context_line":"  $listen_port \u003d 8082,"},{"line_number":111,"context_line":"  $auth_host,"},{"line_number":112,"context_line":"  $auth_protocol \u003d \u0027http\u0027,"},{"line_number":113,"context_line":"  $auth_port \u003d 35357,"},{"line_number":114,"context_line":"  $admin_user,"},{"line_number":115,"context_line":"  $admin_password,"},{"line_number":116,"context_line":"  $admin_token,"},{"line_number":117,"context_line":"  $admin_tenant_name,"},{"line_number":118,"context_line":"  $insecure \u003d false,"},{"line_number":119,"context_line":"  $memcached_servers \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":120,"context_line":"  $cassandra_server_list,"},{"line_number":121,"context_line":"  $zk_server_ip,"},{"line_number":122,"context_line":"  $disc_server_ip,"},{"line_number":123,"context_line":"  $rabbit_server,"},{"line_number":124,"context_line":"  $redis_server \u003d \u0027127.0.0.1\u0027,"},{"line_number":125,"context_line":"  $ifmap_password,"},{"line_number":126,"context_line":"  $ifmap_username,"},{"line_number":127,"context_line":"  $ifmap_server_ip,"},{"line_number":128,"context_line":")"},{"line_number":129,"context_line":"{"},{"line_number":130,"context_line":"  validate_ip_address($listen_ip_address)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_1933aef7","line":127,"range":{"start_line":107,"start_character":0,"end_line":127,"end_character":19},"updated":"2016-08-10 12:54:26.000000000","message":"Would be nice to sort this (and the comments) alphabetically. \n\nFirst should go mandatory parameters, then the optionals.","commit_id":"043dd3e7c3e45b606c147d98e57e9af5cdd140d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f95bc80eff72c458b647a60a75da33d6d4c37f9b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"#  Array of strings value."},{"line_number":105,"context_line":"#"},{"line_number":106,"context_line":"class tripleo::network::contrail::config("},{"line_number":107,"context_line":"  $admin_password,"},{"line_number":108,"context_line":"  $admin_tenant_name,"},{"line_number":109,"context_line":"  $admin_token,"},{"line_number":110,"context_line":"  $admin_user,"},{"line_number":111,"context_line":"  $auth \u003d \u0027keystone\u0027,"},{"line_number":112,"context_line":"  $auth_host,"},{"line_number":113,"context_line":"  $auth_port \u003d 35357,"},{"line_number":114,"context_line":"  $auth_protocol \u003d \u0027http\u0027,"},{"line_number":115,"context_line":"  $cassandra_server_list,"},{"line_number":116,"context_line":"  $disc_server_ip,"},{"line_number":117,"context_line":"  $ifmap_password,"},{"line_number":118,"context_line":"  $ifmap_server_ip,"},{"line_number":119,"context_line":"  $ifmap_username,"},{"line_number":120,"context_line":"  $insecure \u003d false,"},{"line_number":121,"context_line":"  $listen_ip_address \u003d \u00270.0.0.0\u0027,"},{"line_number":122,"context_line":"  $listen_port \u003d 8082,"},{"line_number":123,"context_line":"  $memcached_servers \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":124,"context_line":"  $multi_tenancy \u003d true,"},{"line_number":125,"context_line":"  $rabbit_server,"},{"line_number":126,"context_line":"  $redis_server \u003d \u0027127.0.0.1\u0027,"},{"line_number":127,"context_line":"  $zk_server_ip,"},{"line_number":128,"context_line":")"},{"line_number":129,"context_line":"{"},{"line_number":130,"context_line":"  validate_ip_address($listen_ip_address)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3ac371cc_4c44ba73","line":127,"range":{"start_line":107,"start_character":0,"end_line":127,"end_character":16},"updated":"2016-08-15 11:11:45.000000000","message":"ditto here","commit_id":"6f6926d5da51a31b88fd011a08dba7814c043248"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#  Array of strings value."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [*auth*]"},{"line_number":71,"context_line":"#  (required) Authentication method."},{"line_number":72,"context_line":"#  Defaults to \u0027keystone\u0027."},{"line_number":73,"context_line":"#"},{"line_number":74,"context_line":"# [*auth_port*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_127046a3","line":71,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":72,"context_line":"#  Defaults to \u0027keystone\u0027."},{"line_number":73,"context_line":"#"},{"line_number":74,"context_line":"# [*auth_port*]"},{"line_number":75,"context_line":"#  (required) keystone port."},{"line_number":76,"context_line":"#  Defaults to 35357."},{"line_number":77,"context_line":"#"},{"line_number":78,"context_line":"# [*auth_protocol*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_92b3964c","line":75,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":76,"context_line":"#  Defaults to 35357."},{"line_number":77,"context_line":"#"},{"line_number":78,"context_line":"# [*auth_protocol*]"},{"line_number":79,"context_line":"#  (required) authentication protocol."},{"line_number":80,"context_line":"#  Defaults to http."},{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"# [*insecure*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_d2eeae20","line":79,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":80,"context_line":"#  Defaults to http."},{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"# [*insecure*]"},{"line_number":83,"context_line":"#  (required) insecure mode."},{"line_number":84,"context_line":"#  Defaults to false"},{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"# [*listen_ip_address*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_d2d50e43","line":83,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#  Defaults to \u00270.0.0.0\u0027."},{"line_number":90,"context_line":"#"},{"line_number":91,"context_line":"# [*listen_port*]"},{"line_number":92,"context_line":"#  (required) Listen port for config-api"},{"line_number":93,"context_line":"#  Defaults to 8082."},{"line_number":94,"context_line":"#"},{"line_number":95,"context_line":"# [*memcached_servers*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_72c7fa95","line":92,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#  Defaults to \u0027127.0.0.1:12111\u0027"},{"line_number":99,"context_line":"#"},{"line_number":100,"context_line":"# [*multi_tenancy*]"},{"line_number":101,"context_line":"#  (required) Defines if mutli-tenancy is enabled."},{"line_number":102,"context_line":"#  Defaults to \u0027true\u0027."},{"line_number":103,"context_line":"#"},{"line_number":104,"context_line":"# [*redis_server*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_b2bdf203","line":101,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":132,"context_line":"{"},{"line_number":133,"context_line":"  validate_ip_address($listen_ip_address)"},{"line_number":134,"context_line":"  validate_ip_address($disc_server_ip)"},{"line_number":135,"context_line":"  validate_ip_address($ifmap_server_ip)"},{"line_number":136,"context_line":"  class {\u0027::contrail::keystone\u0027:"},{"line_number":137,"context_line":"    keystone_config \u003d\u003e {"},{"line_number":138,"context_line":"      \u0027KEYSTONE\u0027 \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_d81d2f74","line":135,"updated":"2016-08-18 14:43:30.000000000","message":"you can validate like this:\n\nvalidate_ip_address($listen_ip_address, $disc_server_ip, $ifmap_server_ip)\n\nFurthermore, why not validate the redis_server, zk_server_ip, rabbit_server variable.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  validate_ip_address($listen_ip_address)"},{"line_number":134,"context_line":"  validate_ip_address($disc_server_ip)"},{"line_number":135,"context_line":"  validate_ip_address($ifmap_server_ip)"},{"line_number":136,"context_line":"  class {\u0027::contrail::keystone\u0027:"},{"line_number":137,"context_line":"    keystone_config \u003d\u003e {"},{"line_number":138,"context_line":"      \u0027KEYSTONE\u0027 \u003d\u003e {"},{"line_number":139,"context_line":"        \u0027admin_password\u0027    \u003d\u003e $admin_password,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_fb1465a0","line":136,"updated":"2016-08-18 14:43:30.000000000","message":"This class is also defined in control.pp and analytic.pp.  \n\nThat will not work if network::contrail::control or network::contrail::analytic are called in the same manifest (puppet run) because of the duplicate declaration resource.\n\nIf those classes are not meant to be included in the same manifest, then just ignore my comment, else use\n\n    ensure_resource (\u0027class\u0027, \u0027::contrail::keystone\u0027 , {\u0027keystone_config\u0027 \u003d\u003e { .... }})\n\nin every file.\n\nOr better yet avoid the repetition altogether and define a network::contrail::keystone class.  It will on the caller to define the keystone only once, plus you avoid the parameters definition/validation duplication.  I really think this would be a better option.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \u0027auth_port\u0027         \u003d\u003e $auth_port,"},{"line_number":145,"context_line":"        \u0027auth_protocol\u0027     \u003d\u003e $auth_protocol,"},{"line_number":146,"context_line":"        \u0027insecure\u0027          \u003d\u003e $insecure,"},{"line_number":147,"context_line":"        \u0027memcached_servers\u0027 \u003d\u003e $memcached_servers"},{"line_number":148,"context_line":"      }"},{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":"  } -\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_75236456","line":147,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        \u0027auth_protocol\u0027     \u003d\u003e $auth_protocol,"},{"line_number":146,"context_line":"        \u0027insecure\u0027          \u003d\u003e $insecure,"},{"line_number":147,"context_line":"        \u0027memcached_servers\u0027 \u003d\u003e $memcached_servers"},{"line_number":148,"context_line":"      }"},{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":"  } -\u003e"},{"line_number":151,"context_line":"  class {\u0027::contrail::config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_b5195c24","line":148,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        \u0027insecure\u0027          \u003d\u003e $insecure,"},{"line_number":147,"context_line":"        \u0027memcached_servers\u0027 \u003d\u003e $memcached_servers"},{"line_number":148,"context_line":"      }"},{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":"  } -\u003e"},{"line_number":151,"context_line":"  class {\u0027::contrail::config\u0027:"},{"line_number":152,"context_line":"    api_config            \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_f5d5941b","line":149,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \u0027rabbit_server\u0027         \u003d\u003e $rabbit_server,"},{"line_number":164,"context_line":"        \u0027redis_server\u0027          \u003d\u003e $redis_server,"},{"line_number":165,"context_line":"        \u0027zk_server_ip\u0027          \u003d\u003e $zk_server_ip,"},{"line_number":166,"context_line":"      }"},{"line_number":167,"context_line":"    },"},{"line_number":168,"context_line":"    device_manager_config \u003d\u003e {"},{"line_number":169,"context_line":"      \u0027DEFAULTS\u0027 \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_d5d85855","line":166,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        \u0027rabbit_server\u0027         \u003d\u003e $rabbit_server,"},{"line_number":173,"context_line":"        \u0027redis_server\u0027          \u003d\u003e $redis_server,"},{"line_number":174,"context_line":"        \u0027zk_server_ip\u0027          \u003d\u003e $zk_server_ip,"},{"line_number":175,"context_line":"      }"},{"line_number":176,"context_line":"    },"},{"line_number":177,"context_line":"    schema_config         \u003d\u003e {"},{"line_number":178,"context_line":"      \u0027DEFAULTS\u0027 \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_55e58806","line":175,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        \u0027rabbit_server\u0027         \u003d\u003e $rabbit_server,"},{"line_number":185,"context_line":"        \u0027redis_server\u0027          \u003d\u003e $redis_server,"},{"line_number":186,"context_line":"        \u0027zk_server_ip\u0027          \u003d\u003e $zk_server_ip,"},{"line_number":187,"context_line":"      }"},{"line_number":188,"context_line":"    },"},{"line_number":189,"context_line":"    discovery_config      \u003d\u003e {"},{"line_number":190,"context_line":"      \u0027DEFAULTS\u0027 \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_55cc6888","line":187,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":190,"context_line":"      \u0027DEFAULTS\u0027 \u003d\u003e {"},{"line_number":191,"context_line":"        \u0027cassandra_server_list\u0027 \u003d\u003e $cassandra_server_list,"},{"line_number":192,"context_line":"        \u0027zk_server_ip\u0027          \u003d\u003e $zk_server_ip,"},{"line_number":193,"context_line":"      }"},{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    svc_monitor_config    \u003d\u003e {"},{"line_number":196,"context_line":"      \u0027DEFAULTS\u0027 \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_95c26051","line":193,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        \u0027ifmap_username\u0027        \u003d\u003e $ifmap_username,"},{"line_number":202,"context_line":"        \u0027rabbit_server\u0027         \u003d\u003e $rabbit_server,"},{"line_number":203,"context_line":"        \u0027redis_server\u0027          \u003d\u003e $redis_server,"},{"line_number":204,"context_line":"      }"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"  }"},{"line_number":207,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_15add09a","line":204,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \u0027rabbit_server\u0027         \u003d\u003e $rabbit_server,"},{"line_number":203,"context_line":"        \u0027redis_server\u0027          \u003d\u003e $redis_server,"},{"line_number":204,"context_line":"      }"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"  }"},{"line_number":207,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_b59e7c60","line":205,"updated":"2016-08-18 14:43:30.000000000","message":"Missing trailing coma.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"}],"manifests/network/contrail/control.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"eda4ab8d25bf0b2429f364a443c3b95d2d7e764c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"#  String value."},{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":"class tripleo::network::contrail::control("},{"line_number":88,"context_line":"  $auth_host,"},{"line_number":89,"context_line":"  $auth_protocol \u003d \u0027http\u0027,"},{"line_number":90,"context_line":"  $auth_port \u003d 35357,"},{"line_number":91,"context_line":"  $admin_user,"},{"line_number":92,"context_line":"  $admin_password,"},{"line_number":93,"context_line":"  $admin_token,"},{"line_number":94,"context_line":"  $admin_tenant_name,"},{"line_number":95,"context_line":"  $insecure \u003d false,"},{"line_number":96,"context_line":"  $memcached_servers \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":97,"context_line":"  $host_ip,"},{"line_number":98,"context_line":"  $disc_server_ip,"},{"line_number":99,"context_line":"  $disc_server_port \u003d 5998,"},{"line_number":100,"context_line":"  $ifmap_username,"},{"line_number":101,"context_line":"  $ifmap_password,"},{"line_number":102,"context_line":")"},{"line_number":103,"context_line":"{"},{"line_number":104,"context_line":"  class {\u0027::contrail::keystone\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_9955defb","line":101,"range":{"start_line":88,"start_character":0,"end_line":101,"end_character":18},"updated":"2016-08-10 12:54:26.000000000","message":"Would be nice to sort this (and the comments) alphabetically. \n\nFirst should go mandatory parameters, then the optionals.","commit_id":"043dd3e7c3e45b606c147d98e57e9af5cdd140d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f95bc80eff72c458b647a60a75da33d6d4c37f9b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"#  Defaults to \u0027true\u0027."},{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":"class tripleo::network::contrail::control("},{"line_number":88,"context_line":"  $admin_tenant_name,"},{"line_number":89,"context_line":"  $admin_token,"},{"line_number":90,"context_line":"  $admin_password,"},{"line_number":91,"context_line":"  $admin_user,"},{"line_number":92,"context_line":"  $auth_host,"},{"line_number":93,"context_line":"  $auth_port \u003d 35357,"},{"line_number":94,"context_line":"  $auth_protocol \u003d \u0027http\u0027,"},{"line_number":95,"context_line":"  $disc_server_ip,"},{"line_number":96,"context_line":"  $disc_server_port \u003d 5998,"},{"line_number":97,"context_line":"  $host_ip,"},{"line_number":98,"context_line":"  $ifmap_password,"},{"line_number":99,"context_line":"  $ifmap_username,"},{"line_number":100,"context_line":"  $insecure \u003d false,"},{"line_number":101,"context_line":"  $memcached_servers \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":102,"context_line":")"},{"line_number":103,"context_line":"{"},{"line_number":104,"context_line":"  class {\u0027::contrail::keystone\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3ac371cc_8c5eb243","line":101,"range":{"start_line":88,"start_character":0,"end_line":101,"end_character":41},"updated":"2016-08-15 11:11:45.000000000","message":"also here","commit_id":"6f6926d5da51a31b88fd011a08dba7814c043248"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8545bc5f55b8e5bedef4ecd9305098f99b3531c5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    }"},{"line_number":119,"context_line":"  } -\u003e"},{"line_number":120,"context_line":"  class {\u0027::contrail::control\u0027:"},{"line_number":121,"context_line":"    control_config         \u003d\u003e {"},{"line_number":122,"context_line":"      \u0027DEFAULTS\u0027  \u003d\u003e {"},{"line_number":123,"context_line":"        \u0027hostip\u0027 \u003d\u003e $host_ip,"},{"line_number":124,"context_line":"      },"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3ac371cc_d81e7262","line":121,"range":{"start_line":121,"start_character":19,"end_line":121,"end_character":27},"updated":"2016-08-16 07:38:08.000000000","message":"remove","commit_id":"ec5885e9cd1eebe1d00773bb6c16f3e2eae5293b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8545bc5f55b8e5bedef4ecd9305098f99b3531c5","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  } -\u003e"},{"line_number":120,"context_line":"  class {\u0027::contrail::control\u0027:"},{"line_number":121,"context_line":"    control_config         \u003d\u003e {"},{"line_number":122,"context_line":"      \u0027DEFAULTS\u0027  \u003d\u003e {"},{"line_number":123,"context_line":"        \u0027hostip\u0027 \u003d\u003e $host_ip,"},{"line_number":124,"context_line":"      },"},{"line_number":125,"context_line":"      \u0027DISCOVERY\u0027 \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3ac371cc_18276ab7","line":122,"range":{"start_line":122,"start_character":17,"end_line":122,"end_character":18},"updated":"2016-08-16 07:38:08.000000000","message":"remove","commit_id":"ec5885e9cd1eebe1d00773bb6c16f3e2eae5293b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8545bc5f55b8e5bedef4ecd9305098f99b3531c5","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        \u0027port\u0027   \u003d\u003e $disc_server_port,"},{"line_number":127,"context_line":"        \u0027server\u0027 \u003d\u003e $disc_server_ip,"},{"line_number":128,"context_line":"      },"},{"line_number":129,"context_line":"      \u0027IFMAP\u0027     \u003d\u003e {"},{"line_number":130,"context_line":"        \u0027password\u0027 \u003d\u003e $ifmap_password,"},{"line_number":131,"context_line":"        \u0027user\u0027     \u003d\u003e $ifmap_username,"},{"line_number":132,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3ac371cc_9814fa44","line":129,"range":{"start_line":129,"start_character":14,"end_line":129,"end_character":18},"updated":"2016-08-16 07:38:08.000000000","message":"remove","commit_id":"ec5885e9cd1eebe1d00773bb6c16f3e2eae5293b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8545bc5f55b8e5bedef4ecd9305098f99b3531c5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        \u0027user\u0027     \u003d\u003e $ifmap_username,"},{"line_number":132,"context_line":"      }"},{"line_number":133,"context_line":"    },"},{"line_number":134,"context_line":"    dns_config             \u003d\u003e {"},{"line_number":135,"context_line":"      \u0027DEFAULTS\u0027  \u003d\u003e {"},{"line_number":136,"context_line":"        \u0027hostip\u0027 \u003d\u003e $host_ip,"},{"line_number":137,"context_line":"      },"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3ac371cc_f8024e08","line":134,"range":{"start_line":134,"start_character":15,"end_line":134,"end_character":27},"updated":"2016-08-16 07:38:08.000000000","message":"remove","commit_id":"ec5885e9cd1eebe1d00773bb6c16f3e2eae5293b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8545bc5f55b8e5bedef4ecd9305098f99b3531c5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"      }"},{"line_number":133,"context_line":"    },"},{"line_number":134,"context_line":"    dns_config             \u003d\u003e {"},{"line_number":135,"context_line":"      \u0027DEFAULTS\u0027  \u003d\u003e {"},{"line_number":136,"context_line":"        \u0027hostip\u0027 \u003d\u003e $host_ip,"},{"line_number":137,"context_line":"      },"},{"line_number":138,"context_line":"      \u0027DISCOVERY\u0027 \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3ac371cc_3824e6ad","line":135,"range":{"start_line":135,"start_character":17,"end_line":135,"end_character":18},"updated":"2016-08-16 07:38:08.000000000","message":"remove","commit_id":"ec5885e9cd1eebe1d00773bb6c16f3e2eae5293b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8545bc5f55b8e5bedef4ecd9305098f99b3531c5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        \u0027hostip\u0027 \u003d\u003e $host_ip,"},{"line_number":137,"context_line":"      },"},{"line_number":138,"context_line":"      \u0027DISCOVERY\u0027 \u003d\u003e {"},{"line_number":139,"context_line":"        \u0027port  \u0027 \u003d\u003e $disc_server_port,"},{"line_number":140,"context_line":"        \u0027server\u0027 \u003d\u003e $disc_server_ip,"},{"line_number":141,"context_line":"      },"},{"line_number":142,"context_line":"      \u0027IFMAP\u0027     \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3ac371cc_78365ee8","line":139,"range":{"start_line":139,"start_character":13,"end_line":139,"end_character":15},"updated":"2016-08-16 07:38:08.000000000","message":"remove","commit_id":"ec5885e9cd1eebe1d00773bb6c16f3e2eae5293b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8545bc5f55b8e5bedef4ecd9305098f99b3531c5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        \u0027port  \u0027 \u003d\u003e $disc_server_port,"},{"line_number":140,"context_line":"        \u0027server\u0027 \u003d\u003e $disc_server_ip,"},{"line_number":141,"context_line":"      },"},{"line_number":142,"context_line":"      \u0027IFMAP\u0027     \u003d\u003e {"},{"line_number":143,"context_line":"        \u0027password\u0027 \u003d\u003e $ifmap_password,"},{"line_number":144,"context_line":"        \u0027user\u0027     \u003d\u003e $ifmap_username,"},{"line_number":145,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3ac371cc_7d08102e","line":142,"range":{"start_line":142,"start_character":14,"end_line":142,"end_character":18},"updated":"2016-08-16 07:38:08.000000000","message":"remove","commit_id":"ec5885e9cd1eebe1d00773bb6c16f3e2eae5293b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8545bc5f55b8e5bedef4ecd9305098f99b3531c5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    },"},{"line_number":147,"context_line":"    control_nodemgr_config \u003d\u003e {"},{"line_number":148,"context_line":"      \u0027DISCOVERY\u0027 \u003d\u003e {"},{"line_number":149,"context_line":"        \u0027port  \u0027 \u003d\u003e $disc_server_port,"},{"line_number":150,"context_line":"        \u0027server\u0027 \u003d\u003e $disc_server_ip,"},{"line_number":151,"context_line":"      }"},{"line_number":152,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3ac371cc_f8508e0c","line":149,"range":{"start_line":149,"start_character":13,"end_line":149,"end_character":15},"updated":"2016-08-16 07:38:08.000000000","message":"remove","commit_id":"ec5885e9cd1eebe1d00773bb6c16f3e2eae5293b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":60,"context_line":"#  String value."},{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"# [*auth_port*]"},{"line_number":63,"context_line":"#  (required) keystone port."},{"line_number":64,"context_line":"#  Defaults to 35357."},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# [*auth_protocol*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_12ea0674","line":63,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#  Defaults to 35357."},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# [*auth_protocol*]"},{"line_number":67,"context_line":"#  (required) authentication protocol."},{"line_number":68,"context_line":"#  Defaults to http."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [*disc_server_port*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_92f6f65a","line":67,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#  Defaults to 5998"},{"line_number":74,"context_line":"#"},{"line_number":75,"context_line":"# [*insecure*]"},{"line_number":76,"context_line":"#  (required) insecure mode."},{"line_number":77,"context_line":"#  Defaults to false"},{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# [*memcached_servers*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_928d56d5","line":76,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":82,"context_line":"#  Defaults to \u0027127.0.0.1:12111\u0027"},{"line_number":83,"context_line":"#"},{"line_number":84,"context_line":"# [*multi_tenancy*]"},{"line_number":85,"context_line":"#  (required) Defines if mutli-tenancy is enabled."},{"line_number":86,"context_line":"#  Defaults to \u0027true\u0027."},{"line_number":87,"context_line":"#"},{"line_number":88,"context_line":"class tripleo::network::contrail::control("}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_52ae3e2e","line":85,"updated":"2016-08-18 14:43:30.000000000","message":"Missing type.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"}],"manifests/network/contrail/database.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"eda4ab8d25bf0b2429f364a443c3b95d2d7e764c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#  Defaults to 64"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"class tripleo::network::contrail::database("},{"line_number":41,"context_line":"  $host_ip,"},{"line_number":42,"context_line":"  $disc_server_ip,"},{"line_number":43,"context_line":"  $disc_server_port \u003d 5998,"},{"line_number":44,"context_line":")"},{"line_number":45,"context_line":"{"},{"line_number":46,"context_line":"  class {\u0027::contrail::database\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_5976c6a4","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":27},"updated":"2016-08-10 12:54:26.000000000","message":"Would be nice to sort this (and the comments) alphabetically. \n\nFirst should go mandatory parameters, then the optionals.","commit_id":"043dd3e7c3e45b606c147d98e57e9af5cdd140d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f95bc80eff72c458b647a60a75da33d6d4c37f9b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#  Defaults to 64"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"class tripleo::network::contrail::database("},{"line_number":41,"context_line":"  $disc_server_ip,"},{"line_number":42,"context_line":"  $disc_server_port \u003d 5998,"},{"line_number":43,"context_line":"  $host_ip,"},{"line_number":44,"context_line":")"},{"line_number":45,"context_line":"{"},{"line_number":46,"context_line":"  class {\u0027::contrail::database\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3ac371cc_ac556e1e","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":11},"updated":"2016-08-15 11:11:45.000000000","message":"here","commit_id":"6f6926d5da51a31b88fd011a08dba7814c043248"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# \u003d\u003d Class: tripleo::network::contrail::control"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Configure Contrail Control services"},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_6cae042f","line":16,"updated":"2016-08-18 14:43:30.000000000","message":"copy/paste leftover, should be database.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# \u003d\u003d Class: tripleo::network::contrail::control"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Configure Contrail Control services"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# \u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_cc80d88d","line":18,"updated":"2016-08-18 14:43:30.000000000","message":"Database services.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $host_ip,"},{"line_number":38,"context_line":"  $disc_server_port \u003d 5998,"},{"line_number":39,"context_line":")"},{"line_number":40,"context_line":"{"},{"line_number":41,"context_line":"  class {\u0027::contrail::database\u0027:"},{"line_number":42,"context_line":"    database_nodemgr_config \u003d\u003e {"},{"line_number":43,"context_line":"      \u0027DEFAULTS\u0027  \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_86451844","line":40,"updated":"2016-08-18 14:43:30.000000000","message":"You should validate the ips.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"}],"manifests/network/contrail/webui.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"eda4ab8d25bf0b2429f364a443c3b95d2d7e764c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#  Defaults to 8143"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"class tripleo::network::contrail::webui("},{"line_number":74,"context_line":"  $contrail_config_vip,"},{"line_number":75,"context_line":"  $contrail_analytics_vip,"},{"line_number":76,"context_line":"  $neutron_vip,"},{"line_number":77,"context_line":"  $redis_ip \u003d \u0027127.0.0.1\u0027,"},{"line_number":78,"context_line":"  $auth_host,"},{"line_number":79,"context_line":"  $admin_user,"},{"line_number":80,"context_line":"  $admin_password,"},{"line_number":81,"context_line":"  $admin_token,"},{"line_number":82,"context_line":"  $admin_tenant_name,"},{"line_number":83,"context_line":"  $cassandra_server_list,"},{"line_number":84,"context_line":"  $contrail_webui_http_port \u003d 8080,"},{"line_number":85,"context_line":"  $contrail_webui_https_port \u003d 8143,"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":"{"},{"line_number":88,"context_line":"  class {\u0027::contrail::webui\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_191c4e69","line":85,"range":{"start_line":74,"start_character":0,"end_line":85,"end_character":36},"updated":"2016-08-10 12:54:26.000000000","message":"Would be nice to sort this (and the comments) alphabetically.","commit_id":"043dd3e7c3e45b606c147d98e57e9af5cdd140d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f95bc80eff72c458b647a60a75da33d6d4c37f9b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#  Defaults to \u0027127.0.0.1\u0027"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"class tripleo::network::contrail::webui("},{"line_number":74,"context_line":"  $admin_password,"},{"line_number":75,"context_line":"  $admin_tenant_name,"},{"line_number":76,"context_line":"  $admin_token,"},{"line_number":77,"context_line":"  $admin_user,"},{"line_number":78,"context_line":"  $auth_host,"},{"line_number":79,"context_line":"  $cassandra_server_list,"},{"line_number":80,"context_line":"  $contrail_analytics_vip,"},{"line_number":81,"context_line":"  $contrail_config_vip,"},{"line_number":82,"context_line":"  $contrail_webui_http_port \u003d 8080,"},{"line_number":83,"context_line":"  $contrail_webui_https_port \u003d 8143,"},{"line_number":84,"context_line":"  $neutron_vip,"},{"line_number":85,"context_line":"  $redis_ip \u003d \u0027127.0.0.1\u0027,"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":"{"},{"line_number":88,"context_line":"  class {\u0027::contrail::webui\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3ac371cc_8c2512c4","line":85,"range":{"start_line":74,"start_character":0,"end_line":85,"end_character":26},"updated":"2016-08-15 11:11:45.000000000","message":"and here","commit_id":"6f6926d5da51a31b88fd011a08dba7814c043248"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  $contrail_webui_http_port \u003d 8080,"},{"line_number":84,"context_line":"  $contrail_webui_https_port \u003d 8143,"},{"line_number":85,"context_line":"  $redis_ip \u003d \u0027127.0.0.1\u0027,"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":"{"},{"line_number":88,"context_line":"  class {\u0027::contrail::webui\u0027:"},{"line_number":89,"context_line":"      openstack_vip \u003d\u003e $auth_host,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_f2012a06","line":86,"updated":"2016-08-18 14:43:30.000000000","message":"Why all those parameters if only auth_host is used ?","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"920ff8ab877b09e9c9177b8a29bd5e409960e534","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  $contrail_webui_https_port \u003d 8143,"},{"line_number":85,"context_line":"  $redis_ip \u003d \u0027127.0.0.1\u0027,"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":"{"},{"line_number":88,"context_line":"  class {\u0027::contrail::webui\u0027:"},{"line_number":89,"context_line":"      openstack_vip \u003d\u003e $auth_host,"},{"line_number":90,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3ac371cc_e69decbc","line":87,"updated":"2016-08-18 14:43:30.000000000","message":"Ip validation.","commit_id":"04aac58fbbee3b7eb72e55c0d5321f152601537d"}]}
