)]}'
{"manifests/profile/pacemaker/manila.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3d6e97fe886e4311b12d83db90869890a7b99396","unresolved":false,"context_lines":[{"line_number":86,"context_line":"class tripleo::profile::pacemaker::manila ("},{"line_number":87,"context_line":"  $bootstrap_node                   \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":88,"context_line":"  $step                             \u003d hiera(\u0027step\u0027),"},{"line_number":89,"context_line":"  $manila_generic_enable            \u003d hiera(\u0027manila_generic_enable_backend\u0027, false),"},{"line_number":90,"context_line":"  $driver_handles_share_servers     \u003d hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027),"},{"line_number":91,"context_line":"  $smb_template_config_path         \u003d hiera(\u0027manila::backend::generic::smb_template_config_path\u0027),"},{"line_number":92,"context_line":"  $volume_name_template             \u003d hiera(\u0027manila::backend::generic::volume_name_template\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_9de38533","line":89,"updated":"2016-08-02 15:58:17.000000000","message":"if this is given by the template, maybe we can remove the hiera() call and just default it to false?","commit_id":"2d4e733013deafc733d6e16bc048e520f7a18eaa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b2cb4734b444d46ccc5bed78f22a64f62e335b25","unresolved":false,"context_lines":[{"line_number":86,"context_line":"class tripleo::profile::pacemaker::manila ("},{"line_number":87,"context_line":"  $bootstrap_node                   \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":88,"context_line":"  $step                             \u003d hiera(\u0027step\u0027),"},{"line_number":89,"context_line":"  $manila_generic_enable            \u003d hiera(\u0027manila_generic_enable_backend\u0027, false),"},{"line_number":90,"context_line":"  $driver_handles_share_servers     \u003d hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027),"},{"line_number":91,"context_line":"  $smb_template_config_path         \u003d hiera(\u0027manila::backend::generic::smb_template_config_path\u0027),"},{"line_number":92,"context_line":"  $volume_name_template             \u003d hiera(\u0027manila::backend::generic::volume_name_template\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_36db6f1d","line":89,"in_reply_to":"bacf61ea_7f6dcccb","updated":"2016-08-03 10:49:17.000000000","message":"thanks gents, but this review is about fixing the duplicate variable and it is a dependency for manila to land.\n\nThat code, whilst it could/should be improved, has already been reviewed and imo we shouldn\u0027t block on a fix because of some other part of the code.\n\nWe finally have a green run at https://review.openstack.org/#/c/342961/9 so I\u0027m rather we just land manila now rather than iterate here to fix some other thing.","commit_id":"2d4e733013deafc733d6e16bc048e520f7a18eaa"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c37210bd2d995b8af42dee50958e26d7f3204e84","unresolved":false,"context_lines":[{"line_number":86,"context_line":"class tripleo::profile::pacemaker::manila ("},{"line_number":87,"context_line":"  $bootstrap_node                   \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":88,"context_line":"  $step                             \u003d hiera(\u0027step\u0027),"},{"line_number":89,"context_line":"  $manila_generic_enable            \u003d hiera(\u0027manila_generic_enable_backend\u0027, false),"},{"line_number":90,"context_line":"  $driver_handles_share_servers     \u003d hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027),"},{"line_number":91,"context_line":"  $smb_template_config_path         \u003d hiera(\u0027manila::backend::generic::smb_template_config_path\u0027),"},{"line_number":92,"context_line":"  $volume_name_template             \u003d hiera(\u0027manila::backend::generic::volume_name_template\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_7f6dcccb","line":89,"in_reply_to":"bacf61ea_9de38533","updated":"2016-08-03 05:34:37.000000000","message":"Actually this is a good idea. Why not just set:\n\ntripleo::profile::pacemaker::manila::manila_generic_enable: true/false\n\nin t-h-t?","commit_id":"2d4e733013deafc733d6e16bc048e520f7a18eaa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3d6e97fe886e4311b12d83db90869890a7b99396","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        cinder_volume_type               \u003d\u003e $cinder_volume_type,"},{"line_number":138,"context_line":"      }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"      manila_config {"},{"line_number":141,"context_line":"        \"${manila_generic_backend}/service_instance_user\":      value \u003d\u003e $service_instance_user;"},{"line_number":142,"context_line":"        \"${manila_generic_backend}/service_instance_password\":  value \u003d\u003e $service_instance_password;"},{"line_number":143,"context_line":"        \"${manila_generic_backend}/service_instance_flavor_id\": value \u003d\u003e $service_instance_flavor_id;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bacf61ea_9d8c2581","line":140,"updated":"2016-08-02 15:58:17.000000000","message":"do we need these set via manila_config or are the manila::service_instance::* params sufficient? maybe these can be removed as well?","commit_id":"2d4e733013deafc733d6e16bc048e520f7a18eaa"}]}