)]}'
{"manifests/profile/base/ceilometer/collector.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"edc447e75e5a516a2e5fbf8728114e4f1b67f465","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::base::ceilometer::collector ("},{"line_number":31,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"},{"line_number":35,"context_line":"    $sync_db \u003d true"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_13414f0c","line":32,"updated":"2016-08-08 11:43:43.000000000","message":"weren\u0027t these in the correct (alphabetical) order before?","commit_id":"5f0534e367ffd27682ee4fb70b3fa59392d6e9d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"99f7d9b4b4c78d3c309648cbbc9787c82e9ba43f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::base::ceilometer::collector ("},{"line_number":31,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"},{"line_number":35,"context_line":"    $sync_db \u003d true"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_382b7184","line":32,"in_reply_to":"9ad45d7e_13414f0c","updated":"2016-08-08 21:14:16.000000000","message":"Done","commit_id":"5f0534e367ffd27682ee4fb70b3fa59392d6e9d6"}],"manifests/profile/base/ceph/mon.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"edc447e75e5a516a2e5fbf8728114e4f1b67f465","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::base::ceph::mon ("},{"line_number":31,"context_line":"  $step       \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $ceph_pools \u003d [],"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_7317ebed","line":32,"updated":"2016-08-08 11:43:43.000000000","message":"this goes in contrast with base/ceph.pp though, do we want hiera() parameters to go before or after the other ones?","commit_id":"5f0534e367ffd27682ee4fb70b3fa59392d6e9d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"99f7d9b4b4c78d3c309648cbbc9787c82e9ba43f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::base::ceph::mon ("},{"line_number":31,"context_line":"  $step       \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $ceph_pools \u003d [],"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_26c1b381","line":32,"in_reply_to":"9ad45d7e_7317ebed","updated":"2016-08-08 21:14:16.000000000","message":"Ordered alphabetically","commit_id":"5f0534e367ffd27682ee4fb70b3fa59392d6e9d6"}],"manifests/profile/base/ceph/osd.pp":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7b761825321e87b2695ff69d84d8985253b90559","unresolved":false,"context_lines":[{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":37,"context_line":"    if $ceph_osd_selinux_permissive {"},{"line_number":38,"context_line":"      exec { \u0027set selinux to permissive on boot\u0027:"},{"line_number":39,"context_line":"        command \u003d\u003e \"sed -ie \u0027s/^SELINUX\u003d.*/SELINUX\u003dpermissive/\u0027 /etc/selinux/config\","}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bacf61ea_f28f9f20","line":36,"updated":"2016-08-05 13:38:37.000000000","message":"AFAIU, this is a logic change (fix). The commit message is contradicting \"No logic added or removed in this submission.\"","commit_id":"5f0534e367ffd27682ee4fb70b3fa59392d6e9d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"700ce99c8bd18a7b535a111498bbf48db01f2906","unresolved":false,"context_lines":[{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":37,"context_line":"    if $ceph_osd_selinux_permissive {"},{"line_number":38,"context_line":"      exec { \u0027set selinux to permissive on boot\u0027:"},{"line_number":39,"context_line":"        command \u003d\u003e \"sed -ie \u0027s/^SELINUX\u003d.*/SELINUX\u003dpermissive/\u0027 /etc/selinux/config\","}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bacf61ea_c0972638","line":36,"in_reply_to":"bacf61ea_60d8fa53","updated":"2016-08-05 13:50:43.000000000","message":"Commit:\n\nhttps://github.com/openstack/puppet-tripleo/commit/dca56361fc99d8b8ceb8ebca154ec1d9228ce748","commit_id":"5f0534e367ffd27682ee4fb70b3fa59392d6e9d6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"024268084e3562292f301acff7a908ccc093eade","unresolved":false,"context_lines":[{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":37,"context_line":"    if $ceph_osd_selinux_permissive {"},{"line_number":38,"context_line":"      exec { \u0027set selinux to permissive on boot\u0027:"},{"line_number":39,"context_line":"        command \u003d\u003e \"sed -ie \u0027s/^SELINUX\u003d.*/SELINUX\u003dpermissive/\u0027 /etc/selinux/config\","}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bacf61ea_60d8fa53","line":36,"in_reply_to":"bacf61ea_f28f9f20","updated":"2016-08-05 13:48:45.000000000","message":"Hey, this change came from rebasing the submission (Patchset 4 to 5). This submission it\u0027s not intended to make any change in the code logic.","commit_id":"5f0534e367ffd27682ee4fb70b3fa59392d6e9d6"}],"manifests/profile/base/cinder/volume/nfs.pp":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"6d3c0b71c4ff5256458d01ee17636925e13b7fce","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class tripleo::profile::base::cinder::volume::nfs ("},{"line_number":38,"context_line":"  $step                     \u003d hiera(\u0027step\u0027),"},{"line_number":39,"context_line":"  $cinder_nfs_mount_options \u003d \u0027\u0027,"},{"line_number":40,"context_line":"  $cinder_nfs_servers,"},{"line_number":41,"context_line":"  $backend_name             \u003d hiera(\u0027cinder::backend::nfs::volume_backend_name\u0027, \u0027tripleo_nfs\u0027),"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":"  include ::tripleo::profile::base::cinder::volume"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_d0737b4c","line":40,"updated":"2016-08-05 11:59:45.000000000","message":"nit: Generally all mandatory params comes at top, since the \u0027step\u0027 parameter is made as first parameter for all, i guess  it better to align like https://review.openstack.org/#/c/351625/3/manifests/profile/base/cinder/volume/iscsi.pp@46","commit_id":"00de187aadf3646a6685abad58b6ed5001851a04"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"77bb7535fd26348256ea99dea2a9a7c9c5146da6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class tripleo::profile::base::cinder::volume::nfs ("},{"line_number":38,"context_line":"  $step                     \u003d hiera(\u0027step\u0027),"},{"line_number":39,"context_line":"  $cinder_nfs_mount_options \u003d \u0027\u0027,"},{"line_number":40,"context_line":"  $cinder_nfs_servers,"},{"line_number":41,"context_line":"  $backend_name             \u003d hiera(\u0027cinder::backend::nfs::volume_backend_name\u0027, \u0027tripleo_nfs\u0027),"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":"  include ::tripleo::profile::base::cinder::volume"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_430ce7eb","line":40,"in_reply_to":"bacf61ea_d0737b4c","updated":"2016-08-05 12:10:10.000000000","message":"Done","commit_id":"00de187aadf3646a6685abad58b6ed5001851a04"}],"manifests/profile/base/neutron/midonet.pp":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"6d3c0b71c4ff5256458d01ee17636925e13b7fce","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (Optional) Password to use for Neutron authentication"},{"line_number":63,"context_line":"#   Defaults to hiera(\u0027neutron::server::auth_password\u0027)"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*step*]"},{"line_number":66,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":67,"context_line":"#   for more details."},{"line_number":68,"context_line":"#   Defaults to hiera(\u0027step\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_107a33f1","line":65,"updated":"2016-08-05 11:59:45.000000000","message":"Remove","commit_id":"00de187aadf3646a6685abad58b6ed5001851a04"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"77bb7535fd26348256ea99dea2a9a7c9c5146da6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (Optional) Password to use for Neutron authentication"},{"line_number":63,"context_line":"#   Defaults to hiera(\u0027neutron::server::auth_password\u0027)"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*step*]"},{"line_number":66,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":67,"context_line":"#   for more details."},{"line_number":68,"context_line":"#   Defaults to hiera(\u0027step\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_e3d51b43","line":65,"in_reply_to":"bacf61ea_107a33f1","updated":"2016-08-05 12:10:10.000000000","message":"Done","commit_id":"00de187aadf3646a6685abad58b6ed5001851a04"}]}
