)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"8a01ca201a0c1f25aa952e50fcafb3cd2de92811","unresolved":false,"context_lines":[{"line_number":235,"context_line":"#  The available keys to modify the services\u0027 ports are:"},{"line_number":236,"context_line":"#    \u0027aodh_api_port\u0027 (Defaults to 8042)"},{"line_number":237,"context_line":"#    \u0027aodh_api_ssl_port\u0027 (Defaults to 13042)"},{"line_number":238,"context_line":"#    \u0027barbican_api_port\u0027 (Defaults to 9312)"},{"line_number":239,"context_line":"#    \u0027barbican_api_ssl_port\u0027 (Defaults to 9311)"},{"line_number":240,"context_line":"#    \u0027ceilometer_api_port\u0027 (Defaults to 8777)"},{"line_number":241,"context_line":"#    \u0027ceilometer_api_ssl_port\u0027 (Defaults to 13777)"},{"line_number":242,"context_line":"#    \u0027cinder_api_port\u0027 (Defaults to 8776)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_4d931ba4","line":239,"range":{"start_line":238,"start_character":0,"end_line":239,"end_character":47},"updated":"2016-08-08 14:35:58.000000000","message":"Lets follow the scheme from the other endpoints. Should be something like this:\n#    \u0027barbican_api_port\u0027 (Defaults to 9311)\n#    \u0027barbican_api_ssl_port\u0027 (Defaults to 13311)","commit_id":"c4888976227dd4630759cf74aca7bf047e132b12"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"8a01ca201a0c1f25aa952e50fcafb3cd2de92811","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    aodh_api_port \u003d\u003e 8042,"},{"line_number":336,"context_line":"    aodh_api_ssl_port \u003d\u003e 13042,"},{"line_number":337,"context_line":"    barbican_api_port \u003d\u003e 9312,"},{"line_number":338,"context_line":"    barbican_api_ssl_port \u003d\u003e 9311,"},{"line_number":339,"context_line":"    ceilometer_api_port \u003d\u003e 8777,"},{"line_number":340,"context_line":"    ceilometer_api_ssl_port \u003d\u003e 13777,"},{"line_number":341,"context_line":"    cinder_api_port \u003d\u003e 8776,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ad45d7e_ede80f19","line":338,"updated":"2016-08-08 14:35:58.000000000","message":"this should follow the scheme as I put as an example in the documentation.","commit_id":"c4888976227dd4630759cf74aca7bf047e132b12"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"d9bf485c64455f55efd8a02930e97d5eda3e8e9c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"#"},{"line_number":180,"context_line":"# [*barbican*]"},{"line_number":181,"context_line":"#  (optional) Enable or not Barbican API binding"},{"line_number":182,"context_line":"#  Defaults to false"},{"line_number":183,"context_line":"#"},{"line_number":184,"context_line":"# [*gnocchi*]"},{"line_number":185,"context_line":"#  (optional) Enable or not Gnocchi API binding"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba5da102_eb18bd77","line":182,"updated":"2016-11-01 12:07:04.000000000","message":"The default here doesn\u0027t match the real default below. This is a small thing but might be worth fixing anyway.","commit_id":"aa6660376d1b0145d7ab040f50ba2755bc4b3c18"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"f1e334cd356d6026e91f044f87b8a5028b2f9d90","unresolved":false,"context_lines":[{"line_number":179,"context_line":"#"},{"line_number":180,"context_line":"# [*barbican*]"},{"line_number":181,"context_line":"#  (optional) Enable or not Barbican API binding"},{"line_number":182,"context_line":"#  Defaults to false"},{"line_number":183,"context_line":"#"},{"line_number":184,"context_line":"# [*gnocchi*]"},{"line_number":185,"context_line":"#  (optional) Enable or not Gnocchi API binding"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba5da102_4bc8c9a8","line":182,"in_reply_to":"ba5da102_eb18bd77","updated":"2016-11-01 12:10:54.000000000","message":"WFM https://review.openstack.org/392119","commit_id":"aa6660376d1b0145d7ab040f50ba2755bc4b3c18"}],"manifests/profile/base/barbican.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0128b6054ac0b05714f872122197b6f5bc07316c","unresolved":false,"context_lines":[{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":32,"context_line":"    include ::barbican"},{"line_number":33,"context_line":"    include ::barbican::config"},{"line_number":34,"context_line":"    include ::barbican::client"},{"line_number":35,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"fa6399be_cb7260ad","line":32,"updated":"2016-10-18 16:11:12.000000000","message":"do we need to include ::barbican::keystone::authtoken?","commit_id":"c3f298ab226a703822793c6d93c9d901cf27b44f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"0c70019dac9f3dc5f3ce638cdbf6bfa80504292c","unresolved":false,"context_lines":[{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":32,"context_line":"    include ::barbican"},{"line_number":33,"context_line":"    include ::barbican::config"},{"line_number":34,"context_line":"    include ::barbican::client"},{"line_number":35,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"fa6399be_d3ada389","line":32,"in_reply_to":"fa6399be_cb7260ad","updated":"2016-10-19 05:42:52.000000000","message":"Probably in the api, such as is the case for nova.","commit_id":"c3f298ab226a703822793c6d93c9d901cf27b44f"}],"manifests/profile/base/barbican/api.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f18dcb5bd52bd02bbdcfdeb91217bc017b3c751e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":27,"context_line":"#   for more details."},{"line_number":28,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class tripleo::profile::base::barbican::api ("},{"line_number":31,"context_line":"  $bootstrap_node  \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":32,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_c6977c46","line":29,"updated":"2016-08-10 11:18:27.000000000","message":"add #","commit_id":"328fde5cad48bc96d229a2dd2acfe99d5fd604eb"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"beaa15edc9d75d923a5cc09d6f143fba683ecc40","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":27,"context_line":"#   for more details."},{"line_number":28,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class tripleo::profile::base::barbican::api ("},{"line_number":31,"context_line":"  $bootstrap_node  \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":32,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_14d3eb39","line":29,"in_reply_to":"9ad45d7e_c6977c46","updated":"2016-08-19 16:00:14.000000000","message":"Done","commit_id":"328fde5cad48bc96d229a2dd2acfe99d5fd604eb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f18dcb5bd52bd02bbdcfdeb91217bc017b3c751e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class tripleo::profile::base::barbican::api ("},{"line_number":31,"context_line":"  $bootstrap_node  \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":32,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_a6940843","line":31,"range":{"start_line":31,"start_character":18,"end_line":31,"end_character":19},"updated":"2016-08-10 11:18:27.000000000","message":"remove","commit_id":"328fde5cad48bc96d229a2dd2acfe99d5fd604eb"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"beaa15edc9d75d923a5cc09d6f143fba683ecc40","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class tripleo::profile::base::barbican::api ("},{"line_number":31,"context_line":"  $bootstrap_node  \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":32,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_f4d72f21","line":31,"range":{"start_line":31,"start_character":18,"end_line":31,"end_character":19},"in_reply_to":"9ad45d7e_a6940843","updated":"2016-08-19 16:00:14.000000000","message":"Done","commit_id":"328fde5cad48bc96d229a2dd2acfe99d5fd604eb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f18dcb5bd52bd02bbdcfdeb91217bc017b3c751e","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class tripleo::profile::base::barbican::api ("},{"line_number":31,"context_line":"  $bootstrap_node  \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":32,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"},{"line_number":35,"context_line":"    $sync_db \u003d true"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_069eb462","line":32,"range":{"start_line":32,"start_character":18,"end_line":32,"end_character":19},"updated":"2016-08-10 11:18:27.000000000","message":"remove","commit_id":"328fde5cad48bc96d229a2dd2acfe99d5fd604eb"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"beaa15edc9d75d923a5cc09d6f143fba683ecc40","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class tripleo::profile::base::barbican::api ("},{"line_number":31,"context_line":"  $bootstrap_node  \u003d hiera(\u0027bootstrap_nodeid\u0027, undef),"},{"line_number":32,"context_line":"  $step            \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"},{"line_number":35,"context_line":"    $sync_db \u003d true"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_54dd6341","line":32,"range":{"start_line":32,"start_character":18,"end_line":32,"end_character":19},"in_reply_to":"9ad45d7e_069eb462","updated":"2016-08-19 16:00:14.000000000","message":"Done","commit_id":"328fde5cad48bc96d229a2dd2acfe99d5fd604eb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"93e4d9244d54a295a8a293c4c6f8beb4934e39ca","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 3 and $sync_db {"},{"line_number":43,"context_line":"    include ::barbican::db::mysql"},{"line_number":44,"context_line":"    include ::barbican::db::sync"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db ) {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"fa6399be_8bbea8d2","line":44,"range":{"start_line":44,"start_character":3,"end_line":44,"end_character":32},"updated":"2016-10-18 16:18:08.000000000","message":"by the way ::barbican::api includes this by default. So if we don\u0027t want to run this on other hosts other than the bootstrap node, you need to swithc the  include ::barbican::api below to be class { \u0027::barbican::api\u0027: sync_db \u003d\u003e false }.  I found a similar thing when i was writing the tests for ceilometer, https://review.openstack.org/#/c/380414/.","commit_id":"c3f298ab226a703822793c6d93c9d901cf27b44f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"0c70019dac9f3dc5f3ce638cdbf6bfa80504292c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 3 and $sync_db {"},{"line_number":43,"context_line":"    include ::barbican::db::mysql"},{"line_number":44,"context_line":"    include ::barbican::db::sync"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $step \u003e\u003d 4 or ( $step \u003e\u003d 3 and $sync_db ) {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"fa6399be_f3bf07a8","line":44,"range":{"start_line":44,"start_character":3,"end_line":44,"end_character":32},"in_reply_to":"fa6399be_8bbea8d2","updated":"2016-10-19 05:42:52.000000000","message":"Thanks for this!","commit_id":"c3f298ab226a703822793c6d93c9d901cf27b44f"}]}
