)]}'
{"manifests/deploy_cas.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"db7416679c2d3c276d9eff6acaf9b359beb8551c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*ca_map*]"},{"line_number":22,"context_line":"#   The content of the CA certificate in PEM format."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class tripleo::deploy_cas("},{"line_number":25,"context_line":"  $ca_map \u003d {},"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":"  create_resources(\u0027::tripleo::trust_ca\u0027, $ca_map)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_0755281c","line":24,"updated":"2016-08-22 15:01:59.000000000","message":"Just a nit -- i think it\u0027s customary to not use verbs for puppet classes, so if i were implementing it i\u0027d rather call the class \"cas\" and the define \"ca\", or \"trusted_cas\" and \"trusted_ca\" respectively. E.g. puppet-ceph follows this pattern with ceph::osd and ceph::osds, IIRC.\n\nNot a blocker but is a nice to have imo :)","commit_id":"c15e0f64ae79318597e49b0e5df0db81335cec49"}],"manifests/trust_ca.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"db7416679c2d3c276d9eff6acaf9b359beb8551c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    command \u003d\u003e \u0027update-ca-trust extract\u0027,"},{"line_number":35,"context_line":"    path    \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":36,"context_line":"    require \u003d\u003e File[\"/etc/pki/ca-trust/source/anchors/${name}\"],"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_ca6e7595","line":37,"updated":"2016-08-22 15:01:59.000000000","message":"This should be refreshonly and notified from the file resource above, to make the exec idempotent, to make it only run when the pem changes. (Otherwise the `update-ca-trust extract` could run NxM times where N is the number of puppet steps and M is the number of CA certs, even on stack-updates.)","commit_id":"c15e0f64ae79318597e49b0e5df0db81335cec49"}],"manifests/trusted_ca.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"05c35d2a04a84d978de155a1dfd6d00e2ec22abf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*content*]"},{"line_number":22,"context_line":"#   The content of the CA certificate in PEM format."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"define tripleo::trusted_ca("},{"line_number":25,"context_line":"  $content,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":"  file { \"/etc/pki/ca-trust/source/anchors/${name}.pem\":"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_0ff05ffd","line":24,"updated":"2016-08-23 12:27:32.000000000","message":"Thanks!","commit_id":"c59df801b7e18b15087edcd316a707b10e6941e7"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"05c35d2a04a84d978de155a1dfd6d00e2ec22abf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":30,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":31,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"  exec { \"trust-ca-${name}\":"},{"line_number":34,"context_line":"    command     \u003d\u003e \u0027update-ca-trust extract\u0027,"},{"line_number":35,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_efb7c337","line":32,"updated":"2016-08-23 12:27:32.000000000","message":"We should put a `~\u003e` arrow here, and then we can remove the `require` parameter from the exec below.\n\n(I think the `require` works like `-\u003e` arrow, which doesn\u0027t do notifications, so if we updated the pem file, update-ca-trust extract wouldn\u0027t run.)\n\nOtherwise LGTM :)\n\nhttps://docs.puppet.com/puppet/latest/reference/lang_relationships.html#syntax-chaining-arrows","commit_id":"c59df801b7e18b15087edcd316a707b10e6941e7"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"6651917ba399540df3d579cf32f1460ad85091ba","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":30,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":31,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"  exec { \"trust-ca-${name}\":"},{"line_number":34,"context_line":"    command     \u003d\u003e \u0027update-ca-trust extract\u0027,"},{"line_number":35,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_8f256f0a","line":32,"in_reply_to":"1ac06dbe_efb7c337","updated":"2016-08-23 12:30:55.000000000","message":"Reading the docs further, alternatively we could also just change the `require` into `subscribe`, IIUC.\n\nhttps://docs.puppet.com/puppet/latest/reference/lang_relationships.html#syntax-relationship-metaparameters","commit_id":"c59df801b7e18b15087edcd316a707b10e6941e7"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b68b9a0d44d1074a162eff6b724c973e109224f9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  exec { \"trust-ca-${name}\":"},{"line_number":34,"context_line":"    command     \u003d\u003e \u0027update-ca-trust extract\u0027,"},{"line_number":35,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":36,"context_line":"    subscribe   \u003d\u003e File[\"/etc/pki/ca-trust/source/anchors/${name}\"],"},{"line_number":37,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1ac06dbe_eb37aefc","line":36,"updated":"2016-08-23 14:35:48.000000000","message":"I know you hate me at this point but there\u0027s missing .pem here, so it relationship wouldn\u0027t map to the file { ... } above. Sorry for not noticing on the previous run-through. I\u0027m going to fix this up in gerrit directly :)","commit_id":"854524e6a2ebf70231f9fdfbc7dbd85a6c935483"}]}