)]}'
{"manifests/profile/base/logging/fluentd.pp":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"55761acc86d2726f971fb14e82a0445667403a56","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*step*]"},{"line_number":22,"context_line":"#   (Optional) String. The current step of the deployment"},{"line_number":23,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"class tripleo::profile::base::logging::fluentd ("},{"line_number":26,"context_line":"  $step \u003d hiera(\u0027step\u0027, undef),"},{"line_number":27,"context_line":"  $sources \u003d hiera(\u0027tripleo::fluentd::sources\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ac371cc_e56c8d9e","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":1},"updated":"2016-08-15 14:59:47.000000000","message":"You will need to add documentation to parameters here, otherwise the lint gate won\u0027t let you pass.","commit_id":"14510429fd36c27482385c18b9c02a937c280f0b"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"e688fc7b6e3feb9935b6b6a030a188386a4e4d3e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*step*]"},{"line_number":22,"context_line":"#   (Optional) String. The current step of the deployment"},{"line_number":23,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"class tripleo::profile::base::logging::fluentd ("},{"line_number":26,"context_line":"  $step \u003d hiera(\u0027step\u0027, undef),"},{"line_number":27,"context_line":"  $sources \u003d hiera(\u0027tripleo::fluentd::sources\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ac371cc_b7b479f2","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":1},"in_reply_to":"3ac371cc_e56c8d9e","updated":"2016-08-15 19:41:52.000000000","message":"Thanks.  I am aware of some of the linting errors, but I\u0027m not terribly concerned about them yet. Still waiting for some validation of the basic architecture :).","commit_id":"14510429fd36c27482385c18b9c02a937c280f0b"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"55761acc86d2726f971fb14e82a0445667403a56","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    if $groups {"},{"line_number":36,"context_line":"      user { \u0027fluentd\u0027:"},{"line_number":37,"context_line":"        ensure \u003d\u003e present,"},{"line_number":38,"context_line":"        groups \u003d\u003e $groups,"},{"line_number":39,"context_line":"        membership \u003d\u003e \u0027minimum\u0027,"},{"line_number":40,"context_line":"      }"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ac371cc_65b09dde","line":38,"updated":"2016-08-15 14:59:47.000000000","message":"Not sure why lint is failing on indentation of above two lines. I suppose you are using spaces right?","commit_id":"14510429fd36c27482385c18b9c02a937c280f0b"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"55761acc86d2726f971fb14e82a0445667403a56","unresolved":false,"context_lines":[{"line_number":70,"context_line":"          \u0027match\u0027 \u003d\u003e {"},{"line_number":71,"context_line":"            \u0027tag_pattern\u0027 \u003d\u003e \u0027**\u0027,"},{"line_number":72,"context_line":"            \u0027type\u0027 \u003d\u003e \u0027forward\u0027,"},{"line_number":73,"context_line":"            \u0027server\u0027 \u003d\u003e $servers,"},{"line_number":74,"context_line":"          }"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ac371cc_c5d87120","line":73,"updated":"2016-08-15 14:59:47.000000000","message":"You have to have rockets aligned, otherwise lint won\u0027t pass:\n\n  \u0027tag_pattern\u0027 \u003d\u003e \u0027**\u0027,\n  \u0027type\u0027        \u003d\u003e \u0027forward\u0027,\n  \u0027server\u0027      \u003d\u003e $servers,","commit_id":"14510429fd36c27482385c18b9c02a937c280f0b"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"b8b913e409a155ea462dd1db7141caded3503ffb","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    ::fluentd::plugin { \u0027rubygem-fluent-plugin-elasticsearch\u0027:"},{"line_number":99,"context_line":"      plugin_provider \u003d\u003e \u0027yum\u0027,"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if $fluentd_sources {"},{"line_number":103,"context_line":"      ::fluentd::config { \u0027100-openstack-sources.conf\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1ac06dbe_fb48c58c","line":100,"updated":"2016-08-24 15:57:08.000000000","message":"Does this allow any elasticsearch plugin configuration?  How do you specify the es url, username, password, cert/key, index name, etc.?","commit_id":"c7bcf0aa6945eda19121f9fd067d3af162a6f829"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"6c33c8a8885ed633a3da7321fc718424512834b1","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    ::fluentd::plugin { \u0027rubygem-fluent-plugin-elasticsearch\u0027:"},{"line_number":99,"context_line":"      plugin_provider \u003d\u003e \u0027yum\u0027,"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if $fluentd_sources {"},{"line_number":103,"context_line":"      ::fluentd::config { \u0027100-openstack-sources.conf\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1ac06dbe_fe48b38c","line":100,"in_reply_to":"1ac06dbe_def1776c","updated":"2016-08-24 16:13:20.000000000","message":"ack","commit_id":"c7bcf0aa6945eda19121f9fd067d3af162a6f829"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"b4f359383bd7a0435bd05021b45736658ee1ab3b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    ::fluentd::plugin { \u0027rubygem-fluent-plugin-elasticsearch\u0027:"},{"line_number":99,"context_line":"      plugin_provider \u003d\u003e \u0027yum\u0027,"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if $fluentd_sources {"},{"line_number":103,"context_line":"      ::fluentd::config { \u0027100-openstack-sources.conf\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1ac06dbe_def1776c","line":100,"in_reply_to":"1ac06dbe_fb48c58c","updated":"2016-08-24 16:11:42.000000000","message":"This is only the client side support, which is only meant to forward to a fluentd aggregator.  The manifest(s) for the server side will permit (in fact will default to) sending log data to an elasticsearch instance.  The existing plugin entries predate my work on the plugin and should probably just be removed.","commit_id":"c7bcf0aa6945eda19121f9fd067d3af162a6f829"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"5cbccc7843f7c165854fb0f0ae1d50adc1bde2be","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#   secure-foward plugin."},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"# [*fluentd_listen_syslog*]"},{"line_number":55,"context_line":"#   (Optional, default true) When true, fluentd will listen for syslog "},{"line_number":56,"context_line":"#   messages on a local UDP port."},{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# [*fluentd_syslog_port*]"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"fa7ab95a_de096133","line":55,"range":{"start_line":55,"start_character":70,"end_line":55,"end_character":71},"updated":"2016-08-26 10:03:32.000000000","message":"White space","commit_id":"166d3330f654766ed41f51a1f91a8b2771b0d508"}]}