)]}'
{"manifests/profile/pacemaker/manila.pp":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"c4d060720ed9638940d96ed441cd0da4a3ae3a4d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    $manila_enable_netapp \u003d hiera(\u0027manila_netapp_enable_backend\u0027, false)"},{"line_number":150,"context_line":"    if $manila_enable_netapp {"},{"line_number":151,"context_line":"      $manila_netapp_backend \u003d hiera(\u0027manila::backend::netapp::title\u0027)"},{"line_number":152,"context_line":"      manila::backend::netapp { $manila_netapp_backend: }"},{"line_number":153,"context_line":"    }"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    $manila_enabled_backends \u003d delete_undef_values([$manila_generic_backend, $manila_netapp_backend])"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_5850a80a","line":152,"updated":"2016-08-25 17:03:05.000000000","message":"Missing parameters to the define.  You should have a look at https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/cinder/volume/netapp.pp#L41-L62 or manila::backend::generic above.","commit_id":"0c553ed7b0b5d93bfb9e20d0d2828ed00415011a"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"dae92aaac3190f8454a7a993d1228f39a74976f2","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    $manila_enable_netapp \u003d hiera(\u0027manila_netapp_enable_backend\u0027, false)"},{"line_number":150,"context_line":"    if $manila_enable_netapp {"},{"line_number":151,"context_line":"      $manila_netapp_backend \u003d hiera(\u0027manila::backend::netapp::title\u0027)"},{"line_number":152,"context_line":"      manila::backend::netapp { $manila_netapp_backend: }"},{"line_number":153,"context_line":"    }"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    $manila_enabled_backends \u003d delete_undef_values([$manila_generic_backend, $manila_netapp_backend])"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_9185db08","line":152,"in_reply_to":"1ac06dbe_5850a80a","updated":"2016-08-25 18:13:50.000000000","message":"Thanks for the pointer it was helpful.","commit_id":"0c553ed7b0b5d93bfb9e20d0d2828ed00415011a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f3fb894b936f29b18989d9210204799927090089","unresolved":false,"context_lines":[{"line_number":86,"context_line":"class tripleo::profile::pacemaker::manila ("},{"line_number":87,"context_line":"  $bootstrap_node                   \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":88,"context_line":"  $cinder_volume_type               \u003d hiera(\u0027manila::backend::generic::cinder_volume_type\u0027, \u0027\u0027),"},{"line_number":89,"context_line":"  $driver_handles_share_servers     \u003d hiera(\u0027manila::backend::driver_handles_share_servers\u0027),"},{"line_number":90,"context_line":"  $manila_generic_enable            \u003d hiera(\u0027manila_generic_enable_backend\u0027, false),"},{"line_number":91,"context_line":"  $max_time_to_attach               \u003d hiera(\u0027manila::backend::generic::max_time_to_attach\u0027),"},{"line_number":92,"context_line":"  $max_time_to_create_volume        \u003d hiera(\u0027manila::backend::generic::max_time_to_create_volume\u0027),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_19aaad70","line":89,"updated":"2016-08-29 07:36:37.000000000","message":"Sure we don\u0027t want to specify this per backend if multiple deployed simultaneously?","commit_id":"a4c889f2bac69fa647d57611aaf34dc45a6f7249"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"2b785bbbe8c4b476b8d759164bcc47a0b6ed889d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        netapp_server_port                     \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_server_port\u0027, undef),"},{"line_number":157,"context_line":"        netapp_transport_type                  \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_transport_type\u0027, undef),"},{"line_number":158,"context_line":"        netapp_login                           \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_login\u0027, undef),"},{"line_number":159,"context_line":"        netapp_password                        \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_password\u0027, undef),"},{"line_number":160,"context_line":"        netapp_enabled_share_protocols         \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_enabled_share_protocols\u0027, undef),"},{"line_number":161,"context_line":"        netapp_volume_name_template            \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_volume_name_template\u0027, undef),"},{"line_number":162,"context_line":"        netapp_vserver_name_template           \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_vserver_name_template\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_3dfe9d38","line":159,"range":{"start_line":159,"start_character":55,"end_line":159,"end_character":57},"updated":"2016-08-27 05:18:19.000000000","message":"The fact that you\u0027re having to reference all the module specific hiera keys and pass them into the class looks like a bug in puppet-manila to me?\n\nE.g shouldn\u0027t the module default to these hiera values anyway, then use some non-undef default if it\u0027s not set?","commit_id":"a4c889f2bac69fa647d57611aaf34dc45a6f7249"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"da8508c4689befc3ed4724d8478b91b097261588","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        netapp_lif_name_template               \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_lif_name_template\u0027, undef),"},{"line_number":165,"context_line":"        netapp_aggregate_name_search_pattern   \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_aggregate_name_search_pattern\u0027, undef),"},{"line_number":166,"context_line":"        netapp_root_volume_aggregate           \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_root_volume_aggregate\u0027, undef),"},{"line_number":167,"context_line":"        netapp_root_volume                     \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_root_volume\u0027, undef),"},{"line_number":168,"context_line":"        netapp_volume_snapshot_reserve_percent \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_volume_snapshot_reserve_percent\u0027, undef),"},{"line_number":169,"context_line":"        netapp_vserver                         \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_vserver\u0027, undef),"},{"line_number":170,"context_line":"        netapp_trace_flags                     \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_trace_flags\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_fbf9cc4e","line":167,"updated":"2016-08-26 12:29:33.000000000","message":"In the module https://github.com/openstack/puppet-manila/blob/master/manifests/backend/netapp.pp#L73 this is netapp_root_volume_name .  So maybe it would be better to put VolumeName everywhere (in the associated template file), your call.","commit_id":"a4c889f2bac69fa647d57611aaf34dc45a6f7249"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"2a0286c1e02343c881c2e67900fd46a11fb3f37e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        netapp_lif_name_template               \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_lif_name_template\u0027, undef),"},{"line_number":165,"context_line":"        netapp_aggregate_name_search_pattern   \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_aggregate_name_search_pattern\u0027, undef),"},{"line_number":166,"context_line":"        netapp_root_volume_aggregate           \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_root_volume_aggregate\u0027, undef),"},{"line_number":167,"context_line":"        netapp_root_volume                     \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_root_volume\u0027, undef),"},{"line_number":168,"context_line":"        netapp_volume_snapshot_reserve_percent \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_volume_snapshot_reserve_percent\u0027, undef),"},{"line_number":169,"context_line":"        netapp_vserver                         \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_vserver\u0027, undef),"},{"line_number":170,"context_line":"        netapp_trace_flags                     \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_trace_flags\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_4e101ba9","line":167,"in_reply_to":"fa7ab95a_fbf9cc4e","updated":"2016-08-26 18:42:07.000000000","message":"The old option name was deprecated. I\u0027m trying to fix it here. If using the old deprecated name is better in some way I\u0027ll change it but I suspect it\u0027s better to move to the correct option name.","commit_id":"a4c889f2bac69fa647d57611aaf34dc45a6f7249"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2c88f0adca0c9a59f8ecf3eadb5ee3d236bce44a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        netapp_volume_snapshot_reserve_percent \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_volume_snapshot_reserve_percent\u0027, undef),"},{"line_number":218,"context_line":"        netapp_vserver                         \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_vserver\u0027, undef),"},{"line_number":219,"context_line":"        netapp_trace_flags                     \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_trace_flags\u0027, undef),"},{"line_number":220,"context_line":"        netapp_snapmirror_quiesce_timeout      \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_snapmirror_quiesce_timeout\u0027, undef),"},{"line_number":221,"context_line":"      }"},{"line_number":222,"context_line":"    }"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa7ab95a_a7dfc867","line":220,"updated":"2016-08-29 12:06:06.000000000","message":"i am going to remove all of this i don\u0027t think we need to duplicate it as we are setting it on the tht side like at https://review.openstack.org/#/c/354019/5/puppet/services/manila-base.yaml \n\nsimilarly for the generic i will remove the unnecessary params, revision incoming","commit_id":"f3d3669c4a3176c3612f486130ed781763252406"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"17469904dc29adb14f245f713f6e28b63ed90458","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    $manila_generic_enable \u003d hiera(\u0027manila_generic_enable_backend\u0027, false)"},{"line_number":91,"context_line":"    if $manila_generic_enable {"},{"line_number":92,"context_line":"      $manila_generic_backend \u003d hiera(\u0027manila::backend::generic::title\u0027)"},{"line_number":93,"context_line":"      manila::backend::generic { $manila_generic_backend : }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"      include ::manila::volume::cinder"},{"line_number":96,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa7ab95a_597b448c","line":93,"updated":"2016-08-29 12:18:21.000000000","message":"going to update the tripleo-heat-templates next, but this is the dependent so we should get this right first.\n\nThe idea is, we are already setting config, correctly afaics, on the tht side. We don\u0027t need to do so again here, unless there is some reason to do that. So we don\u0027t need to carry all the backend specific parameters as class params to tripleo::profile::pacemaker::manila as we *are* setting them on the tht side (with the exception of the driver_handles_share_servers params which as pointed out in earlier comments need to be per backend. that will also be fixed and set on the tht side)","commit_id":"6027f7ce8034046c6685159c23f4123811d5e753"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"30084b3157381aef160fbc770647cf136b0455be","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    $manila_generic_enable \u003d hiera(\u0027manila_generic_enable_backend\u0027, false)"},{"line_number":91,"context_line":"    if $manila_generic_enable {"},{"line_number":92,"context_line":"      $manila_generic_backend \u003d hiera(\u0027manila::backend::generic::title\u0027)"},{"line_number":93,"context_line":"      manila::backend::generic { $manila_generic_backend : }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"      include ::manila::volume::cinder"},{"line_number":96,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a89bdaa_c6a741a5","line":93,"updated":"2016-09-13 12:01:45.000000000","message":"going to revisit here and include the driver_handles_share_servers based on discussion at https://review.openstack.org/#/c/366760/","commit_id":"784ac6ce442f5d0d10b5bd2462bfdb002aa19eb8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"30084b3157381aef160fbc770647cf136b0455be","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    $manila_netapp_enable \u003d hiera(\u0027manila_netapp_enable_backend\u0027, false)"},{"line_number":113,"context_line":"    if $manila_netapp_enable {"},{"line_number":114,"context_line":"      $manila_netapp_backend \u003d hiera(\u0027manila::backend::netapp::title\u0027)"},{"line_number":115,"context_line":"      manila::backend::netapp { $manila_netapp_backend : }"},{"line_number":116,"context_line":"    }"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    $manila_enabled_backends \u003d delete_undef_values("}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a89bdaa_26e46dde","line":115,"updated":"2016-09-13 12:01:45.000000000","message":"ditto, going to explicitly pass/set the driver_handles_share_servers","commit_id":"784ac6ce442f5d0d10b5bd2462bfdb002aa19eb8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9f08df3c5e4caa9c677df85e4be484a6d32da5c7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if $manila_generic_enable {"},{"line_number":92,"context_line":"      $manila_generic_backend \u003d hiera(\u0027manila::backend::generic::title\u0027)"},{"line_number":93,"context_line":"      manila::backend::generic { $manila_generic_backend :"},{"line_number":94,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027, true)"},{"line_number":95,"context_line":"      }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      include ::manila::volume::cinder"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a89bdaa_5cc5be8b","line":94,"updated":"2016-09-13 12:22:44.000000000","message":"so I\u0027m not sure if, because the manila::backend::generic and netapp etc are \u0027define\u0027 rather than classes puppet-manila side @ https://github.com/openstack/puppet-manila/blob/master/manifests/backend/netapp.pp#L100 or https://github.com/openstack/puppet-manila/blob/master/manifests/backend/generic.pp#L5 we need to explicitly pass parameters here. I\u0027ve added just the required one for now lets see that goes in testing.","commit_id":"4c9a8162d74e5182d5b6f1bf1f95c201465ab288"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77f4d5c0663be10dbc41da1c067e2ff624eaf0c2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if $manila_generic_enable {"},{"line_number":92,"context_line":"      $manila_generic_backend \u003d hiera(\u0027manila::backend::generic::title\u0027)"},{"line_number":93,"context_line":"      manila::backend::generic { $manila_generic_backend :"},{"line_number":94,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027, true)"},{"line_number":95,"context_line":"      }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      include ::manila::volume::cinder"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_f5dc33e6","line":94,"in_reply_to":"9a89bdaa_5cc5be8b","updated":"2016-09-15 11:10:14.000000000","message":"correct, we can\u0027t because they are defined types, so we need to lookup the hieradata ourselves","commit_id":"4c9a8162d74e5182d5b6f1bf1f95c201465ab288"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"392ef544306a4cf90633ccf8e6937f9079e9419b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if $manila_generic_enable {"},{"line_number":92,"context_line":"      $manila_generic_backend \u003d hiera(\u0027manila::backend::generic::title\u0027)"},{"line_number":93,"context_line":"      manila::backend::generic { $manila_generic_backend :"},{"line_number":94,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027, true)"},{"line_number":95,"context_line":"      }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      include ::manila::volume::cinder"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_d5ec9791","line":94,"in_reply_to":"9a89bdaa_5cc5be8b","updated":"2016-09-15 11:10:47.000000000","message":"looks like we need to pass all of them exactly because they are \"define\" see https://review.openstack.org/#/c/366760/5/manifests/profile/pacemaker/manila.pp","commit_id":"4c9a8162d74e5182d5b6f1bf1f95c201465ab288"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"96ac877f0e0fb8f4350f4e40301342b48587c5c6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        driver_handles_share_servers    \u003d\u003e hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027, true),"},{"line_number":95,"context_line":"        max_time_to_attach              \u003d\u003e hiera(\u0027manila::backend::generic::max_time_to_attach\u0027),"},{"line_number":96,"context_line":"        max_time_to_create_volume       \u003d\u003e hiera(\u0027manila::backend::generic::max_time_to_create_volume\u0027),"},{"line_number":97,"context_line":"        service_instance_smb_config_path \u003d\u003e hiera(\u0027manila::backend::generic::service_instance_smb_config_path\u0027),"},{"line_number":98,"context_line":"        share_mount_path                \u003d\u003e hiera(\u0027manila::backend::generic::share_mount_path\u0027),"},{"line_number":99,"context_line":"        share_volume_fstype             \u003d\u003e hiera(\u0027manila::backend::generic::share_volume_fstype\u0027),"},{"line_number":100,"context_line":"        smb_template_config_path        \u003d\u003e hiera(\u0027manila::backend::generic::smb_template_config_path\u0027),"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_68ff5a67","line":97,"updated":"2016-09-15 14:59:36.000000000","message":"I think these should be aligned to pass -lint","commit_id":"5580b91ffd97e6e430da475c5a0a6228dafe8cfc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"96ac877f0e0fb8f4350f4e40301342b48587c5c6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        netapp_vserver                  \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_vserver\u0027),"},{"line_number":142,"context_line":"        netapp_vserver_name_template    \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_vserver_name_template\u0027),"},{"line_number":143,"context_line":"        netapp_lif_name_template        \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_lif_name_template\u0027),"},{"line_number":144,"context_line":"        netapp_aggregate_name_search_pattern \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_aggregate_name_search_pattern\u0027),"},{"line_number":145,"context_line":"        netapp_root_volume_aggregate    \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_root_volume_aggregate\u0027),"},{"line_number":146,"context_line":"        netapp_root_volume_name         \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_root_volume\u0027),"},{"line_number":147,"context_line":"        netapp_port_name_search_pattern \u003d\u003e hiera(\u0027manila::backend::netapp::netapp_port_name_search_pattern\u0027),"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_e8f36a9c","line":144,"updated":"2016-09-15 14:59:36.000000000","message":"-lint","commit_id":"5580b91ffd97e6e430da475c5a0a6228dafe8cfc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a32e69612cc64a58f82657fb230a4310bf1b3a2a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        driver_handles_share_servers        \u003d\u003e hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027, true),"},{"line_number":95,"context_line":"        max_time_to_attach                  \u003d\u003e hiera(\u0027manila::backend::generic::max_time_to_attach\u0027),"},{"line_number":96,"context_line":"        max_time_to_create_volume           \u003d\u003e hiera(\u0027manila::backend::generic::max_time_to_create_volume\u0027),"},{"line_number":97,"context_line":"        service_instance_smb_config_path    \u003d\u003e hiera(\u0027manila::backend::generic::service_instance_smb_config_path\u0027),"},{"line_number":98,"context_line":"        share_mount_path                    \u003d\u003e hiera(\u0027manila::backend::generic::share_mount_path\u0027),"},{"line_number":99,"context_line":"        share_volume_fstype                 \u003d\u003e hiera(\u0027manila::backend::generic::share_volume_fstype\u0027),"},{"line_number":100,"context_line":"        smb_template_config_path            \u003d\u003e hiera(\u0027manila::backend::generic::smb_template_config_path\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_3ecbcc1f","line":97,"updated":"2016-09-15 15:30:21.000000000","message":"I hope it won\u0027t complain for too many spaces :P","commit_id":"5e90e9e117065ebec61cbf06e604322c01c51f3e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"afce9d386f30362b7a90d680c3445e3a9d320417","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      manila_config {"},{"line_number":107,"context_line":"        \"${manila_generic_backend}/service_instance_user\":      value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_user\u0027),"},{"line_number":108,"context_line":"        \"${manila_generic_backend}/service_instance_password\":  value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_password\u0027),"},{"line_number":109,"context_line":"        \"${manila_generic_backend}/service_instance_flavor_id\": value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"},{"line_number":110,"context_line":"      }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"      include ::manila::volume::cinder"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_0c55dff8","line":109,"updated":"2016-09-16 09:50:14.000000000","message":"this syntax is wrong I need to keep the previous syntax like \u0027;\u0027 - at least I think that is the root for the errors tbarron sees at https://review.openstack.org/#/c/366760/7/manifests/profile/pacemaker/manila.pp","commit_id":"5e90e9e117065ebec61cbf06e604322c01c51f3e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c855b745c050bfe59e6a5eb233742ec0a2e4efb0","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      manila_config {"},{"line_number":107,"context_line":"        \"${manila_generic_backend}/service_instance_user\":      value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_user\u0027),"},{"line_number":108,"context_line":"        \"${manila_generic_backend}/service_instance_password\":  value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_password\u0027),"},{"line_number":109,"context_line":"        \"${manila_generic_backend}/service_instance_flavor_id\": value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"},{"line_number":110,"context_line":"      }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"      include ::manila::volume::cinder"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_0c56bfcd","line":109,"in_reply_to":"7a8ec9b2_0c55dff8","updated":"2016-09-16 09:53:25.000000000","message":"yeah, sorry about the braces remark, getting another cup of coffee :)","commit_id":"5e90e9e117065ebec61cbf06e604322c01c51f3e"}]}