)]}'
{"manifests/profile/pacemaker/manila.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"72e9cb51b3bdecffba61c6ed2bf0bc3d4942a5c8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  $cinder_volume_type               \u003d hiera(\u0027manila::backend::generic::cinder_volume_type\u0027, \u0027\u0027),"},{"line_number":93,"context_line":"  $driver_handles_share_servers     \u003d hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027),"},{"line_number":94,"context_line":"  $manila_generic_enable            \u003d hiera(\u0027manila_generic_enable_backend\u0027, false),"},{"line_number":95,"context_line":"  $manila_cephfsnative_enable       \u003d hiera(\u0027manila_cephfsnative_enable_backend\u0027, false),"},{"line_number":96,"context_line":"  $max_time_to_attach               \u003d hiera(\u0027manila::backend::generic::max_time_to_attach\u0027),"},{"line_number":97,"context_line":"  $max_time_to_create_volume        \u003d hiera(\u0027manila::backend::generic::max_time_to_create_volume\u0027),"},{"line_number":98,"context_line":"  $service_instance_flavor_id       \u003d hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_8b6f1a2a","line":95,"updated":"2016-08-23 14:32:02.000000000","message":"I think the manila_cephfsnative_enable_backend global hiera default here is probably not required. Stylistically I would rather see this set directly via the class hiera variable tripleo::profile::pacemaker::manila::manila_cephfsnative_enable via the composable services.","commit_id":"800fbe23479503314663fc430c9b63b4b42233dd"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"371e6a1a95646acaa57609c00fcb3c2944b26862","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  $cinder_volume_type               \u003d hiera(\u0027manila::backend::generic::cinder_volume_type\u0027, \u0027\u0027),"},{"line_number":93,"context_line":"  $driver_handles_share_servers     \u003d hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027),"},{"line_number":94,"context_line":"  $manila_generic_enable            \u003d hiera(\u0027manila_generic_enable_backend\u0027, false),"},{"line_number":95,"context_line":"  $manila_cephfsnative_enable       \u003d hiera(\u0027manila_cephfsnative_enable_backend\u0027, false),"},{"line_number":96,"context_line":"  $max_time_to_attach               \u003d hiera(\u0027manila::backend::generic::max_time_to_attach\u0027),"},{"line_number":97,"context_line":"  $max_time_to_create_volume        \u003d hiera(\u0027manila::backend::generic::max_time_to_create_volume\u0027),"},{"line_number":98,"context_line":"  $service_instance_flavor_id       \u003d hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_d0a33fb0","line":95,"in_reply_to":"1ac06dbe_8b6f1a2a","updated":"2016-08-24 10:11:20.000000000","message":"Done","commit_id":"800fbe23479503314663fc430c9b63b4b42233dd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"56a0eb6a4e8b5908d0b311563a762c9c4e49be34","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  $cinder_volume_type               \u003d hiera(\u0027manila::backend::generic::cinder_volume_type\u0027, \u0027\u0027),"},{"line_number":93,"context_line":"  $driver_handles_share_servers     \u003d hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027),"},{"line_number":94,"context_line":"  $manila_generic_enable            \u003d hiera(\u0027manila_generic_enable_backend\u0027, false),"},{"line_number":95,"context_line":"  $manila_cephfsnative_enable       \u003d hiera(\u0027manila_cephfsnative_enable_backend\u0027, false),"},{"line_number":96,"context_line":"  $max_time_to_attach               \u003d hiera(\u0027manila::backend::generic::max_time_to_attach\u0027),"},{"line_number":97,"context_line":"  $max_time_to_create_volume        \u003d hiera(\u0027manila::backend::generic::max_time_to_create_volume\u0027),"},{"line_number":98,"context_line":"  $service_instance_flavor_id       \u003d hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_a0b8fa2a","line":95,"in_reply_to":"1ac06dbe_8b6f1a2a","updated":"2016-08-24 08:55:07.000000000","message":"the tht submission where to do this would be If013d796bcdfe48b2c995bcab462c89c360b7367","commit_id":"800fbe23479503314663fc430c9b63b4b42233dd"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"371e6a1a95646acaa57609c00fcb3c2944b26862","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  $cinder_volume_type               \u003d hiera(\u0027manila::backend::generic::cinder_volume_type\u0027, \u0027\u0027),"},{"line_number":93,"context_line":"  $driver_handles_share_servers     \u003d hiera(\u0027manila::backend::generic::driver_handles_share_servers\u0027),"},{"line_number":94,"context_line":"  $manila_generic_enable            \u003d hiera(\u0027manila_generic_enable_backend\u0027, false),"},{"line_number":95,"context_line":"  $manila_cephfsnative_enable       \u003d hiera(\u0027manila_cephfsnative_enable_backend\u0027, false),"},{"line_number":96,"context_line":"  $max_time_to_attach               \u003d hiera(\u0027manila::backend::generic::max_time_to_attach\u0027),"},{"line_number":97,"context_line":"  $max_time_to_create_volume        \u003d hiera(\u0027manila::backend::generic::max_time_to_create_volume\u0027),"},{"line_number":98,"context_line":"  $service_instance_flavor_id       \u003d hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_f0ac7ba0","line":95,"in_reply_to":"1ac06dbe_a0b8fa2a","updated":"2016-08-24 10:11:20.000000000","message":"Done","commit_id":"800fbe23479503314663fc430c9b63b4b42233dd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"56a0eb6a4e8b5908d0b311563a762c9c4e49be34","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # manila cephfsnative:"},{"line_number":154,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":155,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":156,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend: }"},{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    $manila_enabled_backends \u003d delete_undef_values("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_20252a5b","line":156,"updated":"2016-08-24 08:55:07.000000000","message":"problem is this is a defined type, not a class, so hiera parameters don\u0027t do automatic binding","commit_id":"800fbe23479503314663fc430c9b63b4b42233dd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"bc2f241d44bf98d5c641dd8c04e82dbd69e580d9","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # manila cephfsnative:"},{"line_number":154,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":155,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":156,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend: }"},{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    $manila_enabled_backends \u003d delete_undef_values("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_cb2b9780","line":156,"in_reply_to":"1ac06dbe_20252a5b","updated":"2016-08-24 09:05:19.000000000","message":"I think we\u0027ll have to do parse manila::backend::cephfsnative params and feed those back to the defined type as it is happening for manila::backend::generic","commit_id":"800fbe23479503314663fc430c9b63b4b42233dd"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"371e6a1a95646acaa57609c00fcb3c2944b26862","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # manila cephfsnative:"},{"line_number":154,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":155,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":156,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend: }"},{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    $manila_enabled_backends \u003d delete_undef_values("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_d0917f48","line":156,"in_reply_to":"1ac06dbe_cb2b9780","updated":"2016-08-24 10:11:20.000000000","message":"I hope the PS5 was what you were thinking of.","commit_id":"800fbe23479503314663fc430c9b63b4b42233dd"}]}
