)]}'
{"manifests/profile/base/pacemaker.pp":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"1d46d0601b8dabc9ef2b0f60072c3367269ba38e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    Pacemaker::Resource::Service {"},{"line_number":76,"context_line":"      op_params \u003d\u003e \u0027start timeout\u003d200s stop timeout\u003d200s\u0027,"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    file { \u0027/var/lib/tripleo/pacemaker-restarts\u0027:"},{"line_number":80,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"  }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":85,"context_line":"    if $pacemaker_master {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_6fa5e5b3","line":82,"range":{"start_line":78,"start_character":0,"end_line":82,"end_character":3},"updated":"2016-08-22 10:16:17.000000000","message":"question: are we guaranteed this will happen before all the other touch commands that happen at step 1?","commit_id":"c6377074572be60bf5071653380b265965d31019"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"58ea9bfd8f2c7f43e6b1e978afefebefcd262d59","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    Pacemaker::Resource::Service {"},{"line_number":76,"context_line":"      op_params \u003d\u003e \u0027start timeout\u003d200s stop timeout\u003d200s\u0027,"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    file { \u0027/var/lib/tripleo/pacemaker-restarts\u0027:"},{"line_number":80,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"  }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":85,"context_line":"    if $pacemaker_master {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_b110d702","line":82,"range":{"start_line":78,"start_character":0,"end_line":82,"end_character":3},"in_reply_to":"1ac06dbe_6fa5e5b3","updated":"2016-08-22 13:03:45.000000000","message":"We aren\u0027t, good catch! Will update.","commit_id":"c6377074572be60bf5071653380b265965d31019"}],"manifests/profile/pacemaker/cinder/backup.pp":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"03c41a6b02669f6ac8068c8db0e10fcce9e9cf07","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    exec { \u0027cinder-backup restart flag\u0027:"},{"line_number":53,"context_line":"      command     \u003d\u003e \"touch /var/lib/tripleo/pacemaker-restarts/${::cinder::params::backup_service}\","},{"line_number":54,"context_line":"      path        \u003d\u003e [\u0027/bin\u0027,\u0027/usr/bin\u0027,\u0027/sbin\u0027,\u0027/usr/sbin\u0027],"},{"line_number":55,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_5bea5510","line":55,"updated":"2016-08-22 16:09:47.000000000","message":"You could wrap this exec inside a define:\n\n  define ::blah ( pacemaker_name\u003d$title ) {\n    exec { \"$name\":\n       command \u003d\u003e ... ${pacemaker_name}\",\n       ...\n    }\n  }\n\nIt would document the require parameter as the name in pacemaker and would avoid some repetition, wdyt?","commit_id":"c6377074572be60bf5071653380b265965d31019"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ed45d6ea1c8cd856a9a1cf7e958d134d55dc7c46","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    exec { \u0027cinder-backup restart flag\u0027:"},{"line_number":53,"context_line":"      command     \u003d\u003e \"touch /var/lib/tripleo/pacemaker-restarts/${::cinder::params::backup_service}\","},{"line_number":54,"context_line":"      path        \u003d\u003e [\u0027/bin\u0027,\u0027/usr/bin\u0027,\u0027/sbin\u0027,\u0027/usr/sbin\u0027],"},{"line_number":55,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_b802dd70","line":55,"in_reply_to":"1ac06dbe_5bea5510","updated":"2016-08-24 13:51:21.000000000","message":"Sounds good, thanks! It will also be helpful to handle the ordering issue that bandini mentioned.","commit_id":"c6377074572be60bf5071653380b265965d31019"}],"manifests/profile/pacemaker/database/redis.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"22ff5d0bd431f5ea09998adf4a8aec2a8eddec38","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      tripleo::pacemaker::resource_restart_flag { \u0027redis-master\u0027:"},{"line_number":50,"context_line":"        # ouch, but trying to stay close how notification works in"},{"line_number":51,"context_line":"        # puppet-redis when pacemaker is not being used"},{"line_number":52,"context_line":"        subscribe \u003d\u003e Exec[\"cp -p ${::redis::config_file_orig} ${::redis::config_file}\"]"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa7ab95a_bee3b204","line":52,"updated":"2016-08-31 14:05:59.000000000","message":"oh I see what you mean","commit_id":"da4bcee4d65cf2e0d48eab03a4a9582e3806238e"}]}
