)]}'
{"manifests/profile/base/haproxy.pp":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"fed2330de546d6c96933f81338a47f2b5e02bb96","unresolved":false,"context_lines":[{"line_number":90,"context_line":"          command     \u003d\u003e \u0027systemctl reload haproxy\u0027,"},{"line_number":91,"context_line":"          path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":92,"context_line":"          refreshonly \u003d\u003e true,"},{"line_number":93,"context_line":"          onlyif      \u003d\u003e \u0027pcs property | grep -q maintenance-mode\u0027,"},{"line_number":94,"context_line":"          subscribe   \u003d\u003e Class[\u0027::haproxy\u0027]"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":"        Haproxy::Listen\u003c||\u003e ~\u003e Exec[\u0027haproxy-reload\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_3622dd52","line":93,"range":{"start_line":93,"start_character":10,"end_line":93,"end_character":66},"updated":"2016-08-23 10:36:27.000000000","message":"grep -q maintenance-mode\u003dtrue no? We probably do not want to trigger this when maintenance-mode is set to false","commit_id":"c32b4fc65fc108fdd63898f857bdbf816d82cfa2"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ad9f5202526584886c73d76e4ac401215d7c635e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"          onlyif      \u003d\u003e \u0027sudo pcs property | grep \"maintenance-mode.*true\"\u0027,"},{"line_number":94,"context_line":"          subscribe   \u003d\u003e Class[\u0027::haproxy\u0027]"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":"        Haproxy::Listen\u003c||\u003e ~\u003e Exec[\u0027haproxy-reload\u0027]"},{"line_number":97,"context_line":"      }"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_66d6bef2","line":96,"updated":"2016-08-25 12:20:06.000000000","message":"Should it also be hooked onto Haproxy::Balancermember?\n\nOr alternatively i think you could drop the current subscribes altogether and perhaps only subscribe to the resulting config file resource: Concat[\u0027/etc/haproxy/haproxy.cfg\u0027]","commit_id":"723d19ffcfb1288e4715bf83ec0c2bc0751496e2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"5799a1c50d3783e89026648c7aa31a455faa9d56","unresolved":false,"context_lines":[{"line_number":93,"context_line":"          onlyif      \u003d\u003e \u0027sudo pcs property | grep \"maintenance-mode.*true\"\u0027,"},{"line_number":94,"context_line":"          subscribe   \u003d\u003e Class[\u0027::haproxy\u0027]"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":"        Haproxy::Listen\u003c||\u003e ~\u003e Exec[\u0027haproxy-reload\u0027]"},{"line_number":97,"context_line":"      }"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_a6c9d627","line":96,"in_reply_to":"1ac06dbe_66d6bef2","updated":"2016-08-25 12:22:17.000000000","message":"Well, mostly the issue is a front-end configuration change. That\u0027s why I only used a haproxy::listen. not sure if subscribing to the actual file will be overkill :/","commit_id":"723d19ffcfb1288e4715bf83ec0c2bc0751496e2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2535d15327a6480d2f9658a4a8d8c900f5f7a549","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"      include ::tripleo::haproxy"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"      unless hiera(\u0027tripleo::haproxy::haproxy_service_manage\u0027, true) {"},{"line_number":87,"context_line":"        # Reload HAProxy configuration if the haproxy class has refreshed or any"},{"line_number":88,"context_line":"        # HAProxy frontend endpoint has changed."},{"line_number":89,"context_line":"        exec { \u0027haproxy-reload\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa7ab95a_70e6d217","line":86,"updated":"2016-08-31 07:53:08.000000000","message":"i am a bit confused should that default to false? NM I had to go see how unless works (is like \"if not\"). So I see we default that to false in the haproxy.yaml tht side, so this should get executed by default fine","commit_id":"d30e9bcc067c432fe93519dc5971ea98866a10cb"}]}