)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"598f35be20dcc0d2563f6f61745fe5c31180306c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds brackets to mon_host, removing old _v6 param"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: If8a5c65f17e677fe62243b3aa746fd642f72d2b0"},{"line_number":10,"context_line":"Change-Id: I481dd2cd2cde7f1491080e6d9c7dcb7047c22de1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_30ff9435","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":53},"updated":"2016-08-28 09:38:37.000000000","message":"I think the dependency is the wrong way round?  We\u0027ll need this to land before the tht patch or ipv6 ceph will get broken?","commit_id":"f390de7fdb50056b3cbc92caa83b5260d9028d28"}],"manifests/profile/base/ceph.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cd2a16a29396dccc93a1b675c34ecbde9ccb3dd3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"class tripleo::profile::base::ceph ("},{"line_number":43,"context_line":"  $ceph_ipv6                \u003d false,"},{"line_number":44,"context_line":"  $ceph_mon_initial_members \u003d undef,"},{"line_number":45,"context_line":"  $ceph_mon_host            \u003d undef,"},{"line_number":46,"context_line":"  $enable_ceph_storage      \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa7ab95a_b3112eaf","line":43,"updated":"2016-08-26 11:43:16.000000000","message":"if you remove this param from ceph-base in If8a5c65f17e677fe62243b3aa746fd642f72d2b0 I can remove it from here as well","commit_id":"450bba3fba5bd5a7cb8292f4e94dedf23d5b2ae4"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"469f7aa34606ffca5ef7903dced1956fad3ac25c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      $mon_initial_members \u003d undef"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    $mons_array \u003d strip(split(rstrip($ceph_mon_host), \u0027,\u0027))"},{"line_number":58,"context_line":"    if is_ipv6_address($mons_array[0]) {"},{"line_number":59,"context_line":"      $mon_host \u003d join(enclose_ipv6($mons_array), \u0027,\u0027)"},{"line_number":60,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_0f3b83d2","line":57,"updated":"2016-08-26 13:53:56.000000000","message":"As mentioned at https://review.openstack.org/#/c/355067 i think we may want to consider feeding an array to puppet-tripleo module, because the current data processing of this information in TripleO is:\n\n    array-to-string -\u003e string-to-array -\u003e maybe-edit-items -\u003e array-to-string\n\nif we pass the array all the way through here, we would just do:\n\n    maybe-edit-items -\u003e array-to-string","commit_id":"f390de7fdb50056b3cbc92caa83b5260d9028d28"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2decf1e6bbf760dfe6d05a74e6d2db87d6ad5685","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      $mon_initial_members \u003d undef"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    $mons_array \u003d strip(split(rstrip($ceph_mon_host), \u0027,\u0027))"},{"line_number":58,"context_line":"    if is_ipv6_address($mons_array[0]) {"},{"line_number":59,"context_line":"      $mon_host \u003d join(enclose_ipv6($mons_array), \u0027,\u0027)"},{"line_number":60,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_cc499e8d","line":57,"in_reply_to":"fa7ab95a_0f3b83d2","updated":"2016-08-26 16:06:46.000000000","message":"doing the dirty work in puppet-tripleo to turn arrays into strings for puppet-ceph sounds fine to me","commit_id":"f390de7fdb50056b3cbc92caa83b5260d9028d28"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"f7e4f8705134d86bab4ea93440195e33c801138d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      $mon_initial_members \u003d undef"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    $mons_array \u003d strip(split(rstrip($ceph_mon_host), \u0027,\u0027))"},{"line_number":58,"context_line":"    if is_ipv6_address($mons_array[0]) {"},{"line_number":59,"context_line":"      $mon_host \u003d join(enclose_ipv6($mons_array), \u0027,\u0027)"},{"line_number":60,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_d2b73438","line":57,"in_reply_to":"fa7ab95a_507978f5","updated":"2016-08-29 10:04:59.000000000","message":"I don\u0027t think we can do interpolation of arrays. I tried to do interpolation of an *integer* value before and it didn\u0027t work. The result was always a string. Do we already know that we need the interpolation somewhere?","commit_id":"f390de7fdb50056b3cbc92caa83b5260d9028d28"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"fbd48878696ab5f25ceaeb20cb334e3f7205f3db","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      $mon_initial_members \u003d undef"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    $mons_array \u003d strip(split(rstrip($ceph_mon_host), \u0027,\u0027))"},{"line_number":58,"context_line":"    if is_ipv6_address($mons_array[0]) {"},{"line_number":59,"context_line":"      $mon_host \u003d join(enclose_ipv6($mons_array), \u0027,\u0027)"},{"line_number":60,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_507978f5","line":57,"in_reply_to":"fa7ab95a_cc499e8d","updated":"2016-08-28 09:32:24.000000000","message":"Ok, I\u0027ll adjust my custom-roles series to do this - I did a quick test and it looks like the hiera interpolation works even when the initial value is a list, although I\u0027m not sure if the post-interpolation value ends up as a string - it\u0027s not that clear from the hiera CLI output so will need some puppet debugging to confirm.\n\n# grep -A3 aodh_api_node_ips all_nodes.yaml \naodh_api_node_ips: [\n  \"192.0.2.8\"\n]\naodh_api_node_ips_interpolated: \"%{hiera(\\\"aodh_api_node_ips\\\")}\"\n\n[root@overcloud-controller-0 hieradata]# hiera aodh_api_node_ips\n[\"192.0.2.8\"]\n[root@overcloud-controller-0 hieradata]# hiera aodh_api_node_ips_interpolated\n[\"192.0.2.8\"]","commit_id":"f390de7fdb50056b3cbc92caa83b5260d9028d28"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"790b5c44241e0f7e6745dcae1b8f14b783fb6b15","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      $mon_initial_members \u003d undef"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    $mons_array \u003d strip(split(rstrip($ceph_mon_host), \u0027,\u0027))"},{"line_number":58,"context_line":"    if is_ipv6_address($mons_array[0]) {"},{"line_number":59,"context_line":"      $mon_host \u003d join(enclose_ipv6($mons_array), \u0027,\u0027)"},{"line_number":60,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_fb2fb385","line":57,"in_reply_to":"fa7ab95a_d2b73438","updated":"2016-08-29 10:51:15.000000000","message":"Hiera 2.0 has an alias function that doesn\u0027t convert everything into string, so we should probably be using this instead once we get to Hiera 2.0 https://tickets.puppetlabs.com/browse/HI-183","commit_id":"f390de7fdb50056b3cbc92caa83b5260d9028d28"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b1869f0d81c137bd8b4652a16dca2a8518c11aa7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"class tripleo::profile::base::ceph ("},{"line_number":39,"context_line":"  $ceph_mon_initial_members \u003d undef,"},{"line_number":40,"context_line":"  $ceph_mon_host            \u003d hiera(\u0027ceph_mon_node_ips\u0027)"},{"line_number":41,"context_line":"  $enable_ceph_storage      \u003d false,"},{"line_number":42,"context_line":"  $step                     \u003d hiera(\u0027step\u0027),"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_26065e86","line":40,"updated":"2016-08-29 11:21:47.000000000","message":"missing comma at the end","commit_id":"4078ec54e2875e4d265b10ed9de85650dbcebd7e"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b1869f0d81c137bd8b4652a16dca2a8518c11aa7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      $mon_initial_members \u003d undef"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if is_ipv6_address($ceph_mon_host) {"},{"line_number":53,"context_line":"      $mon_host \u003d join(enclose_ipv6($ceph_mon_host), \u0027,\u0027)"},{"line_number":54,"context_line":"    } else {"},{"line_number":55,"context_line":"      $mon_host \u003d join($ceph_mon_host, \u0027,\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_c66cd237","line":52,"updated":"2016-08-29 11:21:47.000000000","message":"You may need to pass 1st element here instead of the whole array?","commit_id":"4078ec54e2875e4d265b10ed9de85650dbcebd7e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"32a5b53b32649e9daa9a126041b92fe0bdd5aee1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      $mon_initial_members \u003d undef"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if is_ipv6_address($ceph_mon_host[0]) {"},{"line_number":53,"context_line":"      $mon_host \u003d join(enclose_ipv6($ceph_mon_host), \u0027,\u0027)"},{"line_number":54,"context_line":"    } else {"},{"line_number":55,"context_line":"      $mon_host \u003d join($ceph_mon_host, \u0027,\u0027)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa7ab95a_a06c08d1","line":52,"updated":"2016-08-29 14:05:21.000000000","message":"I think we want an if is_array for this to pass without tht change as well","commit_id":"7fb3a22d26ad75fdcc388329823f0519fe8096d0"}]}