)]}'
{"manifests/profile/base/ui.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"486d76b8112be9131bf01f335661efddb3ba00cd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# UI profile for tripleo"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class tripleo::profile::base::ui () {"},{"line_number":20,"context_line":"  package {\u0027openstack-tripleo-ui\u0027: }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  include ::apache"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_2a753531","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":36},"updated":"2016-09-07 08:22:09.000000000","message":"Installing packages via puppet is disabled in tripleo, so this will actually do nothing. The package needs to be included in the overcloud-full image or you need to document how to do virt-customize to include the rpm. Might be worth removing this.","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5bcbed3597eb559da99471c0d8eed5898a5a3f22","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# UI profile for tripleo"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class tripleo::profile::base::ui () {"},{"line_number":20,"context_line":"  package {\u0027openstack-tripleo-ui\u0027: }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  include ::apache"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_3572f649","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":36},"in_reply_to":"9a89bdaa_2a753531","updated":"2016-09-07 08:31:27.000000000","message":"Hmm, are you sure about this? I can find quite a few places where we install packages like this, and it seems to be working as expected in my tripleo environment.","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c609d3acbed83b27909e01c084faa975f34db898","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# UI profile for tripleo"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class tripleo::profile::base::ui () {"},{"line_number":20,"context_line":"  package {\u0027openstack-tripleo-ui\u0027: }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  include ::apache"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_15f17295","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":36},"in_reply_to":"9a89bdaa_3572f649","updated":"2016-09-07 08:33:49.000000000","message":"you\u0027re right. This works as expected for the undercloud. My assertion was made for the overcloud, which this doesn\u0027t run on. Got confused there.","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"}],"manifests/ui.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"913bcc36edb39e50bf50016c9128cb1e609679c4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"#  A string."},{"line_number":61,"context_line":"#  Defaults to \u0027tripleo\u0027"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"class tripleo::ui ("},{"line_number":64,"context_line":"  $ui_port \u003d 3000,"},{"line_number":65,"context_line":"  $keystone_url \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":66,"context_line":"  $heat_url \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa7ab95a_30b96dcc","line":63,"updated":"2016-08-31 23:45:47.000000000","message":"should add the servername/ip address to this as well. It\u0027d be ok to default to * but in the case where a user would like to lock down where the UI is available, it would be benficial to expose that now.","commit_id":"237a042203101d16beb286440887fda896bcb809"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"913bcc36edb39e50bf50016c9128cb1e609679c4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $zaqar_default_queue \u003d \u0027tripleo\u0027"},{"line_number":72,"context_line":") {"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  file { \u0027/etc/httpd/conf.d/10-tripleo-ui.conf\u0027 :"},{"line_number":75,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":76,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/httpd-tripleo-ui.conf.erb\u0027),"},{"line_number":77,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa7ab95a_50b0b1dd","line":74,"updated":"2016-08-31 23:45:47.000000000","message":"Is there a reason not to use the apache::vhost rather than a template for this?","commit_id":"237a042203101d16beb286440887fda896bcb809"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"b10ac51319c296c0205f710330b6230abecfaa44","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $zaqar_default_queue \u003d \u0027tripleo\u0027"},{"line_number":72,"context_line":") {"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  file { \u0027/etc/httpd/conf.d/10-tripleo-ui.conf\u0027 :"},{"line_number":75,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":76,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/httpd-tripleo-ui.conf.erb\u0027),"},{"line_number":77,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa7ab95a_f31d2867","line":74,"in_reply_to":"fa7ab95a_50b0b1dd","updated":"2016-09-01 13:46:19.000000000","message":"No reason other than I\u0027m currently learning puppet ;)\nThanks for the good suggestion.","commit_id":"237a042203101d16beb286440887fda896bcb809"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"65a536ab8b6982a7f050ab769a095df5f2060fb3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*servername*]"},{"line_number":23,"context_line":"#  The servername for the virtualhost."},{"line_number":24,"context_line":"#  Optional. Defaults to $::fqdn"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*bind_host*]"},{"line_number":27,"context_line":"#  The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_bb7a8b22","line":24,"range":{"start_line":24,"start_character":25,"end_line":24,"end_character":32},"updated":"2016-09-01 17:04:13.000000000","message":"You have it default to \u0027*\u0027","commit_id":"c2b8614aa687a95e2523f8b9dd65425a256bc56d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"874a8b5a7da426480d22c7259d998136e54fc7a3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*servername*]"},{"line_number":23,"context_line":"#  The servername for the virtualhost."},{"line_number":24,"context_line":"#  Optional. Defaults to $::fqdn"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*bind_host*]"},{"line_number":27,"context_line":"#  The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_56713b43","line":24,"range":{"start_line":24,"start_character":25,"end_line":24,"end_character":32},"in_reply_to":"fa7ab95a_bb7a8b22","updated":"2016-09-02 06:57:40.000000000","message":"Done","commit_id":"c2b8614aa687a95e2523f8b9dd65425a256bc56d"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"486d76b8112be9131bf01f335661efddb3ba00cd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"class tripleo::ui ("},{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_0a6dd130","line":73,"range":{"start_line":73,"start_character":23,"end_line":73,"end_character":30},"updated":"2016-09-07 08:22:09.000000000","message":"I would say this is mandatory, so it shouldn\u0027t default to undef.","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5bcbed3597eb559da99471c0d8eed5898a5a3f22","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"class tripleo::ui ("},{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_f5408e36","line":73,"range":{"start_line":73,"start_character":23,"end_line":73,"end_character":30},"in_reply_to":"9a89bdaa_0a6dd130","updated":"2016-09-07 08:31:27.000000000","message":"undef is treated as a special case, and would translate to \u0027*\u0027 in the resulting vhost config file.","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"486d76b8112be9131bf01f335661efddb3ba00cd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"},{"line_number":77,"context_line":"  $ironic_url          \u003d hiera(\u0027ironic::keystone::auth::public_url\u0027),"},{"line_number":78,"context_line":"  $mistral_url         \u003d hiera(\u0027mistral::keystone::auth::public_url\u0027),"},{"line_number":79,"context_line":"  $swift_url           \u003d hiera(\u0027swift::keystone::auth::public_url\u0027),"},{"line_number":80,"context_line":"  $zaqar_websocket_url \u003d hiera(\u0027zaqar::keystone::auth_websocket::public_url\u0027),"},{"line_number":81,"context_line":"  $zaqar_default_queue \u003d \u0027tripleo\u0027"},{"line_number":82,"context_line":") {"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_8af56158","line":80,"range":{"start_line":76,"start_character":0,"end_line":80,"end_character":78},"updated":"2016-09-07 08:22:09.000000000","message":"are these necessary? can\u0027t we get these values from keystone\u0027s service catalog?","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5bcbed3597eb559da99471c0d8eed5898a5a3f22","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"},{"line_number":77,"context_line":"  $ironic_url          \u003d hiera(\u0027ironic::keystone::auth::public_url\u0027),"},{"line_number":78,"context_line":"  $mistral_url         \u003d hiera(\u0027mistral::keystone::auth::public_url\u0027),"},{"line_number":79,"context_line":"  $swift_url           \u003d hiera(\u0027swift::keystone::auth::public_url\u0027),"},{"line_number":80,"context_line":"  $zaqar_websocket_url \u003d hiera(\u0027zaqar::keystone::auth_websocket::public_url\u0027),"},{"line_number":81,"context_line":"  $zaqar_default_queue \u003d \u0027tripleo\u0027"},{"line_number":82,"context_line":") {"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_154a5255","line":80,"range":{"start_line":76,"start_character":0,"end_line":80,"end_character":78},"in_reply_to":"9a89bdaa_8af56158","updated":"2016-09-07 08:31:27.000000000","message":"See PS5 :)","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bfb6679987d3feb7c595ecb7c5d85a6eec122984","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":104,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":105,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_5cbb50e5","line":105,"updated":"2016-09-06 13:49:36.000000000","message":"you\u0027ll need to add a \"require\" on Service[\u0027httpd\u0027] for example to make sure Apache doesn\u0027t try to start before we have this file.","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"486d76b8112be9131bf01f335661efddb3ba00cd","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":104,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":105,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_cab3e9e7","line":105,"in_reply_to":"9a89bdaa_44b5122f","updated":"2016-09-07 08:22:09.000000000","message":"Might be worth using ::apache::params::service_name. Also, I wouldn\u0027t hardcode owner and group to be root. Since you want the apache service to read those. Why not use ::apache::params::user and ::apache::params::group for this instead?","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5e7a13d4b9925e1e0c3d6a8776a392ccd1a7c78f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":104,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":105,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_9fe94a83","line":105,"in_reply_to":"9a89bdaa_5cbb50e5","updated":"2016-09-06 14:07:43.000000000","message":"Is this a service config file or a UI config file used by the client?  If it\u0027s the latter, then the service wouldn\u0027t be required","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"da24a2fd53be306ee2a28d22863c94590bd68cd5","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":104,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":105,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_44b5122f","line":105,"in_reply_to":"9a89bdaa_9fe94a83","updated":"2016-09-07 07:37:06.000000000","message":"Alex is probably right here, I\u0027m adding a couple of UI folks as reviewers so they can confirm.","commit_id":"098e525d494faebebfdd6a7ac30ed66bdf9c8158"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a9de322296ba3c3f4bfc4d62acc73e0d79816ea6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"class tripleo::ui ("},{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a89bdaa_cab9297b","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":31},"updated":"2016-09-07 08:23:34.000000000","message":"I would say this is mandatory, so it shouldn\u0027t default to undef.","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a9de322296ba3c3f4bfc4d62acc73e0d79816ea6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"class tripleo::ui ("},{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a89bdaa_aab4e581","line":73,"updated":"2016-09-07 08:23:34.000000000","message":"same comment as","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"fea74c320bfdc714ae2ac6d160a1ce6f3f5593e2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"class tripleo::ui ("},{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a8ec9b2_7cd2c7d3","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":31},"in_reply_to":"7a8ec9b2_1c6f35c6","updated":"2016-09-15 13:16:03.000000000","message":"I clarified this point in the previous PS. undef is a perfectly valid value here and it translates to \u0027*\u0027 in the resulting vhost config file.\n\nBTW, I looked for example in the puppet-keystone module. I suggest we keep it like that for consistency.","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f58f4f4922f1d2aa1cb77599b77da91eda7d6216","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"class tripleo::ui ("},{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a8ec9b2_1c6f35c6","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":31},"in_reply_to":"9a89bdaa_cab9297b","updated":"2016-09-14 16:14:34.000000000","message":"right, this parameter should be required. So don\u0027t set default value and update the doc.","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a9de322296ba3c3f4bfc4d62acc73e0d79816ea6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"},{"line_number":77,"context_line":"  $ironic_url          \u003d hiera(\u0027ironic::keystone::auth::public_url\u0027),"},{"line_number":78,"context_line":"  $mistral_url         \u003d hiera(\u0027mistral::keystone::auth::public_url\u0027),"},{"line_number":79,"context_line":"  $swift_url           \u003d hiera(\u0027swift::keystone::auth::public_url\u0027),"},{"line_number":80,"context_line":"  $zaqar_websocket_url \u003d hiera(\u0027zaqar::keystone::auth_websocket::public_url\u0027),"},{"line_number":81,"context_line":"  $zaqar_default_queue \u003d \u0027tripleo\u0027"},{"line_number":82,"context_line":") {"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a89bdaa_4aa6f953","line":80,"range":{"start_line":75,"start_character":1,"end_line":80,"end_character":78},"updated":"2016-09-07 08:23:34.000000000","message":"are these necessary? can\u0027t we get these values from keystone\u0027s service catalog?","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"fea74c320bfdc714ae2ac6d160a1ce6f3f5593e2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"},{"line_number":77,"context_line":"  $ironic_url          \u003d hiera(\u0027ironic::keystone::auth::public_url\u0027),"},{"line_number":78,"context_line":"  $mistral_url         \u003d hiera(\u0027mistral::keystone::auth::public_url\u0027),"},{"line_number":79,"context_line":"  $swift_url           \u003d hiera(\u0027swift::keystone::auth::public_url\u0027),"},{"line_number":80,"context_line":"  $zaqar_websocket_url \u003d hiera(\u0027zaqar::keystone::auth_websocket::public_url\u0027),"},{"line_number":81,"context_line":"  $zaqar_default_queue \u003d \u0027tripleo\u0027"},{"line_number":82,"context_line":") {"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a8ec9b2_dcd91b85","line":80,"range":{"start_line":75,"start_character":1,"end_line":80,"end_character":78},"in_reply_to":"7a8ec9b2_7cabd9d6","updated":"2016-09-15 13:16:03.000000000","message":"I guess it\u0027s fine, since these properties are only used for documentation purpose and it\u0027s not a big deal if they\u0027re missing. Wouldn\u0027t that break the templates though if it has an undef variable?","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"61695a1a9aaaaf0ecfc0f667d6c209caf9c7fef0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"},{"line_number":77,"context_line":"  $ironic_url          \u003d hiera(\u0027ironic::keystone::auth::public_url\u0027),"},{"line_number":78,"context_line":"  $mistral_url         \u003d hiera(\u0027mistral::keystone::auth::public_url\u0027),"},{"line_number":79,"context_line":"  $swift_url           \u003d hiera(\u0027swift::keystone::auth::public_url\u0027),"},{"line_number":80,"context_line":"  $zaqar_websocket_url \u003d hiera(\u0027zaqar::keystone::auth_websocket::public_url\u0027),"},{"line_number":81,"context_line":"  $zaqar_default_queue \u003d \u0027tripleo\u0027"},{"line_number":82,"context_line":") {"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a89bdaa_503948a3","line":80,"range":{"start_line":75,"start_character":1,"end_line":80,"end_character":78},"in_reply_to":"9a89bdaa_4aa6f953","updated":"2016-09-07 08:50:17.000000000","message":"They\u0027re not strictly necessary but we still want to have the default (commented out) value be valid in the rendered tripleo_ui_config.js file.","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f58f4f4922f1d2aa1cb77599b77da91eda7d6216","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $servername          \u003d $::fqdn,"},{"line_number":73,"context_line":"  $bind_host           \u003d undef,"},{"line_number":74,"context_line":"  $ui_port             \u003d 3000,"},{"line_number":75,"context_line":"  $keystone_url        \u003d hiera(\u0027keystone::endpoint::public_url\u0027),"},{"line_number":76,"context_line":"  $heat_url            \u003d hiera(\u0027heat::keystone::auth::public_url\u0027),"},{"line_number":77,"context_line":"  $ironic_url          \u003d hiera(\u0027ironic::keystone::auth::public_url\u0027),"},{"line_number":78,"context_line":"  $mistral_url         \u003d hiera(\u0027mistral::keystone::auth::public_url\u0027),"},{"line_number":79,"context_line":"  $swift_url           \u003d hiera(\u0027swift::keystone::auth::public_url\u0027),"},{"line_number":80,"context_line":"  $zaqar_websocket_url \u003d hiera(\u0027zaqar::keystone::auth_websocket::public_url\u0027),"},{"line_number":81,"context_line":"  $zaqar_default_queue \u003d \u0027tripleo\u0027"},{"line_number":82,"context_line":") {"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a8ec9b2_7cabd9d6","line":80,"range":{"start_line":75,"start_character":1,"end_line":80,"end_character":78},"in_reply_to":"9a89bdaa_503948a3","updated":"2016-09-14 16:14:34.000000000","message":"can we set hiera(\u0027xx\u0027, undef)?","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb98da4de87a220c9e5e325a6318b6ac9f77d40e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    ],"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  file { \u0027/var/www/openstack-tripleo-ui/dist/tripleo_ui_config.js\u0027 :"},{"line_number":101,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a89bdaa_a095ca87","line":100,"updated":"2016-09-07 15:26:21.000000000","message":"it\u0027s still unclear to me if we need Apache to be start after managing this file.","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f58f4f4922f1d2aa1cb77599b77da91eda7d6216","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    ],"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  file { \u0027/var/www/openstack-tripleo-ui/dist/tripleo_ui_config.js\u0027 :"},{"line_number":101,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a8ec9b2_fc852959","line":100,"in_reply_to":"9a89bdaa_00df560d","updated":"2016-09-14 16:14:34.000000000","message":"ok good.","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f9e9817521cad622f91bbca19cef91dd96117ca0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    ],"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  file { \u0027/var/www/openstack-tripleo-ui/dist/tripleo_ui_config.js\u0027 :"},{"line_number":101,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a89bdaa_00df560d","line":100,"in_reply_to":"9a89bdaa_a095ca87","updated":"2016-09-07 15:32:12.000000000","message":"We need apache to serve the file. It can be started before or after this file is created, we don\u0027t really care about ordering since it doesn\u0027t require apache to be reloaded.","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a9de322296ba3c3f4bfc4d62acc73e0d79816ea6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  file { \u0027/var/www/openstack-tripleo-ui/dist/tripleo_ui_config.js\u0027 :"},{"line_number":101,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":104,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":105,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a89bdaa_0a7791d3","line":105,"range":{"start_line":103,"start_character":4,"end_line":105,"end_character":22},"updated":"2016-09-07 08:23:34.000000000","message":"Might be worth using ::apache::params::service_name. Also, I wouldn\u0027t hardcode owner and group to be root. Since you want the apache service to read those. Why not use ::apache::params::user and ::apache::params::group for this instead?","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"61695a1a9aaaaf0ecfc0f667d6c209caf9c7fef0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  file { \u0027/var/www/openstack-tripleo-ui/dist/tripleo_ui_config.js\u0027 :"},{"line_number":101,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":102,"context_line":"    content \u003d\u003e template(\u0027tripleo/ui/tripleo_ui_config.js.erb\u0027),"},{"line_number":103,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":104,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":105,"context_line":"    mode    \u003d\u003e \u00270644\u0027,"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a89bdaa_d056385b","line":105,"range":{"start_line":103,"start_character":4,"end_line":105,"end_character":22},"in_reply_to":"9a89bdaa_0a7791d3","updated":"2016-09-07 08:50:17.000000000","message":"I chose root since /var/www/openstack-tripleo-ui/dist/ and all the files it contains are already owned by root. The current permissions allow apache to read the files. TBH, I don\u0027t have a preference here and I\u0027m totally open to change it to apache user.","commit_id":"f9410769af7e3046c890342ebbd38e8ca784d7a2"}]}
