)]}'
{"manifests/haproxy/endpoint.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b5e054a9ddc3ce10768b1edcf9b3660c235ce6c5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # must match the convention haproxy-\u003cnetwork name\u003e or else this"},{"line_number":124,"context_line":"    # will fail. Futherly, it must contain the path that we\u0027ll use under"},{"line_number":125,"context_line":"    # \u0027service_pem\u0027."},{"line_number":126,"context_line":"    $internal_cert_path \u003d $internal_certificates_specs[\"haproxy-${service_network}\"][\u0027service_pem\u0027]"},{"line_number":127,"context_line":"    $internal_bind_opts \u003d list_to_hash(suffix(any2array($internal_ip), \":${service_port}\"),"},{"line_number":128,"context_line":"                                        union($haproxy_listen_bind_param, [\u0027ssl\u0027, \u0027crt\u0027, $internal_cert_path]))"},{"line_number":129,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a8bc5a2_19cef12d","line":126,"updated":"2016-09-26 16:45:33.000000000","message":"It might be good to add a sanity check that $service_network isn\u0027t also undef. That would lead to some failures if this key isn\u0027t defined.  So if $use_internal_certificates \u0026\u0026 !$service_network then fail.  I see this being problematic if someone doesn\u0027t properly configure the hiera completely.","commit_id":"7e4bd85d35c3889707df001dede3f99a8515b1f2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1df4ed34e2aea97e7db7e4e9eeec52a4a3b1d663","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # must match the convention haproxy-\u003cnetwork name\u003e or else this"},{"line_number":124,"context_line":"    # will fail. Futherly, it must contain the path that we\u0027ll use under"},{"line_number":125,"context_line":"    # \u0027service_pem\u0027."},{"line_number":126,"context_line":"    $internal_cert_path \u003d $internal_certificates_specs[\"haproxy-${service_network}\"][\u0027service_pem\u0027]"},{"line_number":127,"context_line":"    $internal_bind_opts \u003d list_to_hash(suffix(any2array($internal_ip), \":${service_port}\"),"},{"line_number":128,"context_line":"                                        union($haproxy_listen_bind_param, [\u0027ssl\u0027, \u0027crt\u0027, $internal_cert_path]))"},{"line_number":129,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a8bc5a2_d9a56947","line":126,"in_reply_to":"5a8bc5a2_19cef12d","updated":"2016-09-26 16:48:20.000000000","message":"so, the hieradata should be done automatically and modifying it manually should be discouraged.\n\nservice_network is done automatically by tripleo-heat-templates, so that has to be there.\n\nShould I do the check on the key existing or not?","commit_id":"7e4bd85d35c3889707df001dede3f99a8515b1f2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"706be420415a9b60b8a3b4dcb36a582cd393826b","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  if $use_internal_certificates {"},{"line_number":122,"context_line":"    if !$service_network {"},{"line_number":123,"context_line":"      fail(\"The service_network for this service is undefined. Can\u0027t configure TLS for the internal network.\")"},{"line_number":124,"context_line":"    }"},{"line_number":125,"context_line":"    # NOTE(jaosorior): The key of the internal_certificates_specs hash must"},{"line_number":126,"context_line":"    # must match the convention haproxy-\u003cnetwork name\u003e or else this"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"5a8bc5a2_e89c0cc2","line":123,"updated":"2016-09-26 17:05:04.000000000","message":"nit: should be single quotes","commit_id":"32ae9189547665b55b60faf3759b5d2062724e04"}]}