)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"a43f4d05e2a8ecb750a868f9a5d39ed0e1b8ae10","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This will fixup the manila-cephfs puppet-tripleo side to be more"},{"line_number":15,"context_line":"in line with the tidy up adding netapp at [3]. The config is all"},{"line_number":16,"context_line":"moved tripleo-heat-templates side. The tht review for this"},{"line_number":17,"context_line":"is at https://review.openstack.org/#/c/358525/ and that will now"},{"line_number":18,"context_line":"depend on this review."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7a8ec9b2_e46eb1fe","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":58},"updated":"2016-09-19 12:27:23.000000000","message":"Don\u0027t get this.","commit_id":"6f9b3dd35115b7a3658120aa38f8800bb4a0e1cd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"79c6f4028f7ebedf4bf51aae95edb146c01f2339","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This will fixup the manila-cephfs puppet-tripleo side to be more"},{"line_number":15,"context_line":"in line with the tidy up adding netapp at [3]. The config is all"},{"line_number":16,"context_line":"moved tripleo-heat-templates side. The tht review for this"},{"line_number":17,"context_line":"is at https://review.openstack.org/#/c/358525/ and that will now"},{"line_number":18,"context_line":"depend on this review."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7a8ec9b2_fc060984","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":58},"in_reply_to":"7a8ec9b2_e46eb1fe","updated":"2016-09-20 12:03:57.000000000","message":"tht \u003d tripleo-heat-templates sorry","commit_id":"6f9b3dd35115b7a3658120aa38f8800bb4a0e1cd"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"f8aeb2e1691156e096f1ffa1ca74941990999be5","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This will fixup the manila-cephfs puppet-tripleo side to be more"},{"line_number":15,"context_line":"in line with the tidy up adding netapp at [3]. The config is all"},{"line_number":16,"context_line":"moved tripleo-heat-templates side. The tht review for this"},{"line_number":17,"context_line":"is at https://review.openstack.org/#/c/358525/ and that will now"},{"line_number":18,"context_line":"depend on this review."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7a8ec9b2_9ff25799","line":16,"range":{"start_line":16,"start_character":39,"end_line":16,"end_character":42},"updated":"2016-09-20 12:32:43.000000000","message":"Please expand the acronym if you need to upload an another patch set.","commit_id":"8f75bc372584096cd11afd90a23dad50c8b314bd"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"61aafa7d2937a8fe5928edb72f616023cba0bba1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This will fixup the manila-cephfs puppet-tripleo side to be more"},{"line_number":15,"context_line":"in line with the tidy up adding netapp at [3]. The config is all"},{"line_number":16,"context_line":"moved tripleo-heat-templates side. The tht review for this"},{"line_number":17,"context_line":"is at https://review.openstack.org/#/c/358525/ and that will now"},{"line_number":18,"context_line":"depend on this review."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://review.openstack.org/#/c/354047/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7a8ec9b2_40352ed8","line":17,"updated":"2016-09-20 21:16:32.000000000","message":"It\u0027s better to link reviews by change id instead of gerrit url.  Gerrit will link the id anyway, and it\u0027s still possible to look up the change offline or if gerrit changes its url layout.","commit_id":"8f75bc372584096cd11afd90a23dad50c8b314bd"}],"manifests/profile/pacemaker/manila.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1968d9d9111a85b6ff62e7583765158f1910fd1b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    # manila cephfsnative:"},{"line_number":64,"context_line":"    $manila_cephfsnative_enable \u003d hiera(\u0027manila::backend::cephfsnative::enable_backend\u0027, false),"},{"line_number":65,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":66,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":67,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend : }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a89bdaa_f12c0204","line":64,"updated":"2016-09-07 16:14:03.000000000","message":"nit here extra \u0027,\u0027 from copy/paste incoming\nhttp://logs.openstack.org/60/366760/3/check/gate-puppet-tripleo-puppet-syntax-3-centos-7/24cfa1e/console.html#_2016-09-07_14_17_18_278368","commit_id":"4dac6de79ae08a61efb54eb10d88a287aa479755"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"06dc0d3530e508d64a463f037270314bb7666050","unresolved":false,"context_lines":[{"line_number":58,"context_line":"class tripleo::profile::pacemaker::manila ("},{"line_number":59,"context_line":"  $bootstrap_node                   \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":60,"context_line":"  $step                             \u003d hiera(\u0027step\u0027),"},{"line_number":61,"context_line":"  $manila_cephfsnative_enable       \u003d hiera(\u0027manila::backend::cephfsnative::enable_backend\u0027, false),"},{"line_number":62,"context_line":"  $cephfs_handles_share_servers     \u003d hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027),"},{"line_number":63,"context_line":"  $cephfs_backend_name              \u003d hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":64,"context_line":"  $cephfs_conf_path                 \u003d hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a8ec9b2_55c1672d","side":"PARENT","line":61,"updated":"2016-09-15 11:06:25.000000000","message":"I don\u0027t think we can remove these because the manila backends are not classes but defined types in puppet-manila so hiera does not bind there automatically","commit_id":"4c9a8162d74e5182d5b6f1bf1f95c201465ab288"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c2e18272f8891b15dc57e8a78784d4d6b3ee05cf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"class tripleo::profile::pacemaker::manila ("},{"line_number":59,"context_line":"  $bootstrap_node                   \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":60,"context_line":"  $step                             \u003d hiera(\u0027step\u0027),"},{"line_number":61,"context_line":"  $manila_cephfsnative_enable       \u003d hiera(\u0027manila::backend::cephfsnative::enable_backend\u0027, false),"},{"line_number":62,"context_line":"  $cephfs_handles_share_servers     \u003d hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027),"},{"line_number":63,"context_line":"  $cephfs_backend_name              \u003d hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":64,"context_line":"  $cephfs_conf_path                 \u003d hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a8ec9b2_95cbef1d","side":"PARENT","line":61,"in_reply_to":"7a8ec9b2_55c1672d","updated":"2016-09-15 11:09:58.000000000","message":"thanks gfidente i had the same question https://review.openstack.org/#/c/354014/8/manifests/profile/pacemaker/manila.pp\n\nso in the very least we need to add them in to the definitions for the backends, even if we just pick them from hiera","commit_id":"4c9a8162d74e5182d5b6f1bf1f95c201465ab288"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"20a11c8840fd9ee9b084ee1ea86bf8d233aa5e82","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        cinder_volume_type                  \u003d\u003e hiera(\u0027manila::backend::generic::cinder_volume_type\u0027),"},{"line_number":69,"context_line":"      }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"      manila_config {"},{"line_number":72,"context_line":"        \"${manila_generic_backend}/service_instance_user\":      value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_user\u0027),"},{"line_number":73,"context_line":"        \"${manila_generic_backend}/service_instance_password\":  value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_password\u0027),"},{"line_number":74,"context_line":"        \"${manila_generic_backend}/service_instance_flavor_id\": value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"},{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      include ::manila::volume::cinder"},{"line_number":78,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_666762e9","line":75,"range":{"start_line":71,"start_character":0,"end_line":75,"end_character":7},"updated":"2016-09-16 09:25:18.000000000","message":"Looks like we have unbalanced curly braces here.","commit_id":"2c26f48c7911ca54ba77a0d57c84b350d0b4f78b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"29b1b639e56656633662ba896e53ab47abe932ae","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        cinder_volume_type                  \u003d\u003e hiera(\u0027manila::backend::generic::cinder_volume_type\u0027),"},{"line_number":69,"context_line":"      }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"      manila_config {"},{"line_number":72,"context_line":"        \"${manila_generic_backend}/service_instance_user\":      value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_user\u0027),"},{"line_number":73,"context_line":"        \"${manila_generic_backend}/service_instance_password\":  value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_password\u0027),"},{"line_number":74,"context_line":"        \"${manila_generic_backend}/service_instance_flavor_id\": value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"},{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      include ::manila::volume::cinder"},{"line_number":78,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_6c12e358","line":75,"range":{"start_line":71,"start_character":0,"end_line":75,"end_character":7},"in_reply_to":"7a8ec9b2_215aa42a","updated":"2016-09-16 09:50:02.000000000","message":"So I don\u0027t *think* it is to do with the braces... at least they are matching OK afaics.... I think the problem is the syntax I\u0027m using here...  compared to how it was before, I think we need \u0027;\u0027 at the end of each line... see https://review.openstack.org/#/c/354014/10/manifests/profile/pacemaker/manila.pp i.e. i changed this block in the parent review.\n\nI will restore the syntax to how it was in the parent and rebase this","commit_id":"2c26f48c7911ca54ba77a0d57c84b350d0b4f78b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"448d6513275a6ec5979f08c5dcb265dd9b4f5537","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        cinder_volume_type                  \u003d\u003e hiera(\u0027manila::backend::generic::cinder_volume_type\u0027),"},{"line_number":69,"context_line":"      }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"      manila_config {"},{"line_number":72,"context_line":"        \"${manila_generic_backend}/service_instance_user\":      value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_user\u0027),"},{"line_number":73,"context_line":"        \"${manila_generic_backend}/service_instance_password\":  value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_password\u0027),"},{"line_number":74,"context_line":"        \"${manila_generic_backend}/service_instance_flavor_id\": value \u003d\u003e hiera(\u0027manila::service_instance::service_instance_flavor_id\u0027),"},{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      include ::manila::volume::cinder"},{"line_number":78,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_215aa42a","line":75,"range":{"start_line":71,"start_character":0,"end_line":75,"end_character":7},"in_reply_to":"7a8ec9b2_666762e9","updated":"2016-09-16 09:36:45.000000000","message":"thanks tbarron firing up vim to fix incoming","commit_id":"2c26f48c7911ca54ba77a0d57c84b350d0b4f78b"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"620a58808462b48498d037272a20a10c2038b24f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":86,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":87,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend :"},{"line_number":88,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027, true),"},{"line_number":89,"context_line":"        share_backend_name           \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":90,"context_line":"        cephfs_conf_path             \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"},{"line_number":91,"context_line":"        cephfs_auth_id               \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_auth_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_8cf6015b","line":88,"range":{"start_line":88,"start_character":109,"end_line":88,"end_character":113},"updated":"2016-09-19 09:37:06.000000000","message":"Is there a reason why we default this true here, False in puppet-manila [0] and tht [1]?\n\n[0] https://github.com/openstack/puppet-manila/blob/master/manifests/backend/cephfsnative.pp#L33\n[1] https://review.openstack.org/#/c/358525/5/environments/manila-cephfsnative-config.yaml","commit_id":"3d3c1a805c33d76594cc0962480f8323ecd091dc"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"384d6f88b731f2c501f3158cb26a05f4ded77313","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":86,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":87,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend :"},{"line_number":88,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027, true),"},{"line_number":89,"context_line":"        share_backend_name           \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":90,"context_line":"        cephfs_conf_path             \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"},{"line_number":91,"context_line":"        cephfs_auth_id               \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_auth_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_b2015607","line":88,"range":{"start_line":88,"start_character":109,"end_line":88,"end_character":113},"in_reply_to":"7a8ec9b2_076f2afc","updated":"2016-09-19 09:54:59.000000000","message":"OK will make it so incoming","commit_id":"3d3c1a805c33d76594cc0962480f8323ecd091dc"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f54b36c3c1eaba9e6a04c2885ccbc3d4edd0e755","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":86,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":87,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend :"},{"line_number":88,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027, true),"},{"line_number":89,"context_line":"        share_backend_name           \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":90,"context_line":"        cephfs_conf_path             \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"},{"line_number":91,"context_line":"        cephfs_auth_id               \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_auth_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_e7fcfe73","line":88,"range":{"start_line":88,"start_character":109,"end_line":88,"end_character":113},"in_reply_to":"7a8ec9b2_8cf6015b","updated":"2016-09-19 09:50:49.000000000","message":"hey Erno, just because we default to true for generic and netapp (I mean in the tht too) ... We can update this as it sounds like it isn\u0027t true by default for the cephfs backend...","commit_id":"3d3c1a805c33d76594cc0962480f8323ecd091dc"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"566647e9f6bf433ed8889283031f1c8ae7ef02f0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":86,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":87,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend :"},{"line_number":88,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027, true),"},{"line_number":89,"context_line":"        share_backend_name           \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":90,"context_line":"        cephfs_conf_path             \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"},{"line_number":91,"context_line":"        cephfs_auth_id               \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_auth_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_075c8a7b","line":88,"range":{"start_line":88,"start_character":109,"end_line":88,"end_character":113},"in_reply_to":"7a8ec9b2_e7fcfe73","updated":"2016-09-19 09:52:41.000000000","message":"For cephfs backend this should be false.","commit_id":"3d3c1a805c33d76594cc0962480f8323ecd091dc"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8aa0de361cd6955d7c04576d608a5fa06554a270","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":86,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":87,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend :"},{"line_number":88,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027, true),"},{"line_number":89,"context_line":"        share_backend_name           \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":90,"context_line":"        cephfs_conf_path             \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"},{"line_number":91,"context_line":"        cephfs_auth_id               \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_auth_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_076f2afc","line":88,"range":{"start_line":88,"start_character":109,"end_line":88,"end_character":113},"in_reply_to":"7a8ec9b2_e7fcfe73","updated":"2016-09-19 09:53:59.000000000","message":"I just checked again, and for manila and netapp backends, this is a required parameter with no default in the puppet-manila manifests https://github.com/openstack/puppet-manila/blob/master/manifests/backend/netapp.pp or https://github.com/openstack/puppet-manila/blob/master/manifests/backend/generic.pp\n\nLooks like it is different indeed for cephfs as it gets false by default module side.","commit_id":"3d3c1a805c33d76594cc0962480f8323ecd091dc"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"eb45a789dc226b7fc1b6e1a7327c297aff1a0d64","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    if $manila_cephfsnative_enable {"},{"line_number":86,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":87,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend :"},{"line_number":88,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027, true),"},{"line_number":89,"context_line":"        share_backend_name           \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":90,"context_line":"        cephfs_conf_path             \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"},{"line_number":91,"context_line":"        cephfs_auth_id               \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_auth_id\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_a79756ea","line":88,"range":{"start_line":88,"start_character":109,"end_line":88,"end_character":113},"in_reply_to":"7a8ec9b2_e7fcfe73","updated":"2016-09-19 09:53:24.000000000","message":"The only reason I have kept it false is that the default behavior on the Manila driver is in all documentations referred to false. Honestly I do not know the Manila driver code well enough to take a stand on any other basis than that.","commit_id":"3d3c1a805c33d76594cc0962480f8323ecd091dc"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"41aac944682ebd2e0a7d61c9c0dbe9da57dda001","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":87,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend :"},{"line_number":88,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027, false),"},{"line_number":89,"context_line":"        share_backend_name           \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":90,"context_line":"        cephfs_conf_path             \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"},{"line_number":91,"context_line":"        cephfs_auth_id               \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_auth_id\u0027),"},{"line_number":92,"context_line":"        cephfs_cluster_name          \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_cluster_name\u0027),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7a8ec9b2_e4a07144","line":89,"range":{"start_line":89,"start_character":46,"end_line":89,"end_character":98},"updated":"2016-09-19 12:25:26.000000000","message":"s/cephfs_backend_name/share_backend_name/","commit_id":"6f9b3dd35115b7a3658120aa38f8800bb4a0e1cd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"79c6f4028f7ebedf4bf51aae95edb146c01f2339","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      $manila_cephfsnative_backend \u003d hiera(\u0027manila::backend::cephfsnative::title\u0027)"},{"line_number":87,"context_line":"      manila::backend::cephfsnative { $manila_cephfsnative_backend :"},{"line_number":88,"context_line":"        driver_handles_share_servers \u003d\u003e hiera(\u0027manila::backend::cephfsnative::driver_handles_share_servers\u0027, false),"},{"line_number":89,"context_line":"        share_backend_name           \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_backend_name\u0027),"},{"line_number":90,"context_line":"        cephfs_conf_path             \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_conf_path\u0027),"},{"line_number":91,"context_line":"        cephfs_auth_id               \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_auth_id\u0027),"},{"line_number":92,"context_line":"        cephfs_cluster_name          \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_cluster_name\u0027),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7a8ec9b2_1ce735e5","line":89,"range":{"start_line":89,"start_character":46,"end_line":89,"end_character":98},"in_reply_to":"7a8ec9b2_e4a07144","updated":"2016-09-20 12:03:57.000000000","message":"indeed thanks! just double checked https://review.openstack.org/#/c/358525/5/puppet/services/manila-backend-cephfs.yaml","commit_id":"6f9b3dd35115b7a3658120aa38f8800bb4a0e1cd"}]}