)]}'
{"manifests/profile/pacemaker/database/mysql.pp":[{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"9c3d968737a1b51dcb5074b0421d00d8e5e69ae3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      \u0027wsrep_drupal_282555_workaround\u0027\u003d\u003e \u00270\u0027,"},{"line_number":71,"context_line":"      \u0027wsrep_causal_reads\u0027            \u003d\u003e \u00270\u0027,"},{"line_number":72,"context_line":"      \u0027wsrep_sst_method\u0027              \u003d\u003e \u0027rsync\u0027,"},{"line_number":73,"context_line":"      \u0027wsrep_provider_options\u0027        \u003d\u003e \"gmcast.listen_addr\u003dtcp://${mysql_bind_host}:4567;\","},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a89bdaa_a9d84e1f","line":73,"range":{"start_line":73,"start_character":69,"end_line":73,"end_character":84},"updated":"2016-09-13 12:10:47.000000000","message":"I can confirm that removing the brackets still allows galera to bind to ipv6 address like tcp://fd00:dead:beef:55::2:4567 and bootstrap correctly. But getting rid of the brackets, we can\u0027t distinguish incomplete ip with port anymore.\n\nCan we ensure that an ipv6 be fully specified in ${mysql_bind_host}?","commit_id":"ee62c37656ee8eee5cedcd18a616341417dff821"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"37bdb5364894edc27c0fdb72aa6a00ce3fc57421","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  } else {"},{"line_number":32,"context_line":"    $pacemaker_master \u003d false"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":"  # Current known limitation, mysql_bind_host can be an ipv6 but"},{"line_number":35,"context_line":"  # needs to be sanitized before."},{"line_number":36,"context_line":"  # - Example of invalid IPv6: fd00:dead:beef:55::"},{"line_number":37,"context_line":"  #   If you use it, Galera won\u0027t be boostrapped."},{"line_number":38,"context_line":"  # - Example of valid IPv6: fd00:dead:beef:55::2"},{"line_number":39,"context_line":"  #"},{"line_number":40,"context_line":"  # We don\u0027t add brackets into mysql_bind_host because recent Galera"},{"line_number":41,"context_line":"  # version does not support it."},{"line_number":42,"context_line":"  # See more context on this discussion:"},{"line_number":43,"context_line":"  # - https://bugzilla.redhat.com/show_bug.cgi?id\u003d1298671"},{"line_number":44,"context_line":"  # - https://bugs.launchpad.net/tripleo/+bug/1622755"},{"line_number":45,"context_line":"  $mysql_bind_host \u003d hiera(\u0027mysql_bind_host\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  # use only mysql_node_names when we land a patch in t-h-t that"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a89bdaa_0bb12a01","line":44,"range":{"start_line":34,"start_character":0,"end_line":44,"end_character":53},"updated":"2016-09-13 13:27:13.000000000","message":"Ok, I\u0027m revising my last comment in previous patchset...\nIf I\u0027m reading galera src correctly [1], as soon as there is a \u0027:\u0027 in gmcast.listen_addr, the last occurrence will be considered as a port number.\n\nSince we explicitly set port number in our generated galera config, there cannot be a misinterpretation at galera startup, and mysql_bind_host can holds any IPv6 address, as long as it\u0027s not surrounded by square bracket\n\n[1] https://github.com/codership/galera/blob/3.x/galerautils/src/gu_uri.cpp#L47","commit_id":"a27c86650040736b1d9c1e8fb19a9ea4c7f7167f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cd60ab3e558e196297e9aaeed8dfb9ce8714c6ba","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      \u0027wsrep_drupal_282555_workaround\u0027\u003d\u003e \u00270\u0027,"},{"line_number":71,"context_line":"      \u0027wsrep_causal_reads\u0027            \u003d\u003e \u00270\u0027,"},{"line_number":72,"context_line":"      \u0027wsrep_sst_method\u0027              \u003d\u003e \u0027rsync\u0027,"},{"line_number":73,"context_line":"      \u0027wsrep_provider_options\u0027        \u003d\u003e \"gmcast.listen_addr\u003dtcp://${mysql_bind_host}:4567;\","},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_49791693","line":73,"updated":"2016-09-14 10:39:02.000000000","message":"given fd00:dead:beef:55:: seems to be a valid address, it\u0027s not great to have an ipv6:port value without brackets anywhere ... though one can work around it passing the ip address in the extended format, inclusive of the trailing :0000\n\nusing a normalization function to add brackets only around ipv6 addresses and fix the problem in galera is probably the real fix though we need to merge this for now","commit_id":"75108ca9a7fcc0939f5c007efe8efa8778114881"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"286a1dcc6377d9fba0294dab085220791aa20b03","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      \u0027wsrep_drupal_282555_workaround\u0027\u003d\u003e \u00270\u0027,"},{"line_number":71,"context_line":"      \u0027wsrep_causal_reads\u0027            \u003d\u003e \u00270\u0027,"},{"line_number":72,"context_line":"      \u0027wsrep_sst_method\u0027              \u003d\u003e \u0027rsync\u0027,"},{"line_number":73,"context_line":"      \u0027wsrep_provider_options\u0027        \u003d\u003e \"gmcast.listen_addr\u003dtcp://${mysql_bind_host}:4567;\","},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_c8e6a314","line":73,"in_reply_to":"7a8ec9b2_49791693","updated":"2016-09-15 17:54:32.000000000","message":"as Damien said, recent galera does not work when brackets are here. I guess the only clean solution for now is to remove the brackets and give full ipv6 (with trailing).","commit_id":"75108ca9a7fcc0939f5c007efe8efa8778114881"}]}
