)]}'
{"manifests/profile/base/cinder/volume/nexenta.pp":[{"author":{"_account_id":10910,"name":"Stig Telfer","email":"stig.openstack@telfer.org","username":"stigtelfer"},"change_message_id":"02e69615d3ce1e2adc0146222e98baec0a6502b7","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    cinder::backend::nexenta { $backend_name :"},{"line_number":38,"context_line":"      nexenta_user                \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_user\u0027, undef),"},{"line_number":39,"context_line":"      nexenta_password            \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_password\u0027, undef),"},{"line_number":40,"context_line":"      nexenta_host                \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_host\u0027, undef),"},{"line_number":41,"context_line":"      nexenta_rest_port           \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_rest_port\u0027, undef),"},{"line_number":42,"context_line":"      nexenta_volume              \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_volume\u0027, undef),"},{"line_number":43,"context_line":"      nexenta_target_prefix       \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_target_prefix\u0027, undef),"},{"line_number":44,"context_line":"      nexenta_target_group_prefix \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_target_group_prefix\u0027, undef),"},{"line_number":45,"context_line":"      nexenta_blocksize           \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_blocksize\u0027, undef),"},{"line_number":46,"context_line":"      nexenta_sparse              \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_sparse\u0027, undef),"},{"line_number":47,"context_line":"      extra_options               \u003d\u003e hiera(\u0027cinder::backend::nexenta::extra_options\u0027, {}),"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5201f7_7de3e305","line":46,"range":{"start_line":38,"start_character":0,"end_line":46,"end_character":94},"updated":"2017-01-03 14:28:53.000000000","message":"On the Nexenta deployment at Cambridge we use some additional parameters for that are not included here: \n\n- For NexentaStor: nexenta_dataset_compression\n- For NexentaEdge: nexenta_rest_{address,user,password}, nexenta_client_address, nexenta_lun_container, nexenta_iscsi_service\n\nCan those parameters still be set?","commit_id":"afde9751ff5c15b40f1bdf93a01732eab453cf5d"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"232e841c40e0899a062d8d64c8530767711192d0","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":37,"context_line":"    cinder::backend::nexenta { $backend_name :"},{"line_number":38,"context_line":"      nexenta_user                \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_user\u0027, undef),"},{"line_number":39,"context_line":"      nexenta_password            \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_password\u0027, undef),"},{"line_number":40,"context_line":"      nexenta_host                \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_host\u0027, undef),"},{"line_number":41,"context_line":"      nexenta_rest_port           \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_rest_port\u0027, undef),"},{"line_number":42,"context_line":"      nexenta_volume              \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_volume\u0027, undef),"},{"line_number":43,"context_line":"      nexenta_target_prefix       \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_target_prefix\u0027, undef),"},{"line_number":44,"context_line":"      nexenta_target_group_prefix \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_target_group_prefix\u0027, undef),"},{"line_number":45,"context_line":"      nexenta_blocksize           \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_blocksize\u0027, undef),"},{"line_number":46,"context_line":"      nexenta_sparse              \u003d\u003e hiera(\u0027cinder::backend::nexenta::nexenta_sparse\u0027, undef),"},{"line_number":47,"context_line":"      extra_options               \u003d\u003e hiera(\u0027cinder::backend::nexenta::extra_options\u0027, {}),"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5201f7_b4355ddb","line":46,"range":{"start_line":38,"start_character":0,"end_line":46,"end_character":94},"in_reply_to":"ba5201f7_7de3e305","updated":"2017-01-03 17:13:23.000000000","message":"For the dataset_compression, this parameter is not handle by cinder::backend::nexenta (https://github.com/openstack/puppet-cinder/blob/master/manifests/backend/nexenta.pp) but we can use the extra_options parameter to do it.\n\nRegarding the NexentaEdge, this review is only focus on NexentaStor. For that one, we need a new review using cinder::backend::nexenta_edge (https://github.com/openstack/puppet-cinder/blob/master/manifests/backend/nexenta_edge.pp)","commit_id":"afde9751ff5c15b40f1bdf93a01732eab453cf5d"}]}
