)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ddeadeecc82c7dff8e2570b49a980bc895556de1","unresolved":false,"context_lines":[{"line_number":598,"context_line":"  $ceph_rgw                    \u003d hiera(\u0027ceph_rgw_enabled\u0027, false),"},{"line_number":599,"context_line":"  $opendaylight                \u003d hiera(\u0027opendaylight_api_enabled\u0027, false),"},{"line_number":600,"context_line":"  $ovn_dbs                     \u003d hiera(\u0027ovn_dbs_enabled\u0027, false),"},{"line_number":601,"context_line":"  $ovn_dbs_ha_disabled         \u003d hiera(\u0027ovn_dbs_ha_disabled\u0027, true),"},{"line_number":602,"context_line":"  $zaqar_ws                    \u003d hiera(\u0027zaqar_api_enabled\u0027, false),"},{"line_number":603,"context_line":"  $ui                          \u003d hiera(\u0027enable_ui\u0027, false),"},{"line_number":604,"context_line":"  $aodh_network                \u003d hiera(\u0027aodh_api_network\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ffe62b97_f6e0ecfc","line":601,"updated":"2017-03-27 09:48:48.000000000","message":"where is this set in t-h-t? Is there a plan to add this?","commit_id":"f45126795a539ea5b6a31f74647a118bde9f8d10"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"92284c68824c83a672c8c96cc9ad8e70a2b74496","unresolved":false,"context_lines":[{"line_number":598,"context_line":"  $ceph_rgw                    \u003d hiera(\u0027ceph_rgw_enabled\u0027, false),"},{"line_number":599,"context_line":"  $opendaylight                \u003d hiera(\u0027opendaylight_api_enabled\u0027, false),"},{"line_number":600,"context_line":"  $ovn_dbs                     \u003d hiera(\u0027ovn_dbs_enabled\u0027, false),"},{"line_number":601,"context_line":"  $ovn_dbs_ha_disabled         \u003d hiera(\u0027ovn_dbs_ha_disabled\u0027, true),"},{"line_number":602,"context_line":"  $zaqar_ws                    \u003d hiera(\u0027zaqar_api_enabled\u0027, false),"},{"line_number":603,"context_line":"  $ui                          \u003d hiera(\u0027enable_ui\u0027, false),"},{"line_number":604,"context_line":"  $aodh_network                \u003d hiera(\u0027aodh_api_network\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ffe62b97_91507f5f","line":601,"in_reply_to":"ffe62b97_f6e0ecfc","updated":"2017-03-27 13:32:41.000000000","message":"I should have set this in this patch here - https://review.openstack.org/#/c/436767/3/puppet/services/pacemaker/ovn-dbs.yaml.\n\nI have some how missed updating it. I will update the t-h-t patch.","commit_id":"f45126795a539ea5b6a31f74647a118bde9f8d10"}],"manifests/profile/pacemaker/ovn_northd.pp":[{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"ee832442da0f371165ea7ac71e7ce5b1a5cbd367","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      meta_params     \u003d\u003e \u0027notify\u003dtrue\u0027"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    pacemaker::resource::service { \u0027$ovn_northd_resource_name\u0027:"},{"line_number":84,"context_line":"      op_params     \u003d\u003e \u0027start timeout\u003d200s stop timeout\u003d200s\u0027,"},{"line_number":85,"context_line":"      tries         \u003d\u003e $pcs_tries,"},{"line_number":86,"context_line":"      location_rule \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_85975d91","line":83,"updated":"2017-03-24 15:12:19.000000000","message":"Shouldn\u0027t this be double quotes so the variable gets interpreted?","commit_id":"c396fd22941a3232c1be7cd18d47a64678a6e949"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"2783bb65548be6ad976adac39fbfc89ccf93ca17","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      meta_params     \u003d\u003e \u0027notify\u003dtrue\u0027"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    pacemaker::resource::service { \u0027$ovn_northd_resource_name\u0027:"},{"line_number":84,"context_line":"      op_params     \u003d\u003e \u0027start timeout\u003d200s stop timeout\u003d200s\u0027,"},{"line_number":85,"context_line":"      tries         \u003d\u003e $pcs_tries,"},{"line_number":86,"context_line":"      location_rule \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_c5456572","line":83,"in_reply_to":"ffe62b97_85975d91","updated":"2017-03-24 15:23:33.000000000","message":"Done","commit_id":"c396fd22941a3232c1be7cd18d47a64678a6e949"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9788cc458d08069af23a5825c01f168e874c630a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # We want the config file to be created on all the cluster nodes,"},{"line_number":55,"context_line":"  # so that when a slave becomes master, it can start ovn-northd."},{"line_number":56,"context_line":"  if $step \u003e\u003d 2 and $::osfamily \u003d\u003d \u0027RedHat\u0027 {"},{"line_number":57,"context_line":"    augeas { \u0027sysconfig-ovn-northd\u0027:"},{"line_number":58,"context_line":"      context \u003d\u003e  \u0027/files/etc/sysconfig/ovn-northd\u0027,"},{"line_number":59,"context_line":"      changes \u003d\u003e  \"set OVN_NORTHD_OPTS \u0027\\\"--db-nb-addr\u003d${ovn_dbs_vip} --db-sb-addr\u003d${ovn_dbs_vip} \\"},{"line_number":60,"context_line":"--db-nb-create-insecure-remote\u003dyes --db-sb-create-insecure-remote\u003dyes --ovn-manage-ovsdb\u003dno\\\"\u0027\","}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1f013ff3_eb31340d","line":57,"updated":"2017-05-16 19:35:41.000000000","message":"This seems like it should be in puppet-ovn. This should be made configurable over there so you can just include ::ovn::northd.  Then the required switches can just be hieradata from THT","commit_id":"12b42ff75c41c4648c9378c08ccad7e2e9b253bf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3a955e483df3d42b7ab97122b7c2c0340f5d10ae","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # We want the config file to be created on all the cluster nodes,"},{"line_number":55,"context_line":"  # so that when a slave becomes master, it can start ovn-northd."},{"line_number":56,"context_line":"  if $step \u003e\u003d 2 and $::osfamily \u003d\u003d \u0027RedHat\u0027 {"},{"line_number":57,"context_line":"    augeas { \u0027sysconfig-ovn-northd\u0027:"},{"line_number":58,"context_line":"      context \u003d\u003e  \u0027/files/etc/sysconfig/ovn-northd\u0027,"},{"line_number":59,"context_line":"      changes \u003d\u003e  \"set OVN_NORTHD_OPTS \u0027\\\"--db-nb-addr\u003d${ovn_dbs_vip} --db-sb-addr\u003d${ovn_dbs_vip} \\"},{"line_number":60,"context_line":"--db-nb-create-insecure-remote\u003dyes --db-sb-create-insecure-remote\u003dyes --ovn-manage-ovsdb\u003dno\\\"\u0027\","}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff0f0b1f_b4bbe00c","line":57,"in_reply_to":"1f013ff3_47b5afcc","updated":"2017-05-17 13:51:13.000000000","message":"No the pacemaker stuff should stay here. Just this augueas line should be in puppet-ovn","commit_id":"12b42ff75c41c4648c9378c08ccad7e2e9b253bf"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"c27818307e1895d02b26278246e13b387471fb3a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # We want the config file to be created on all the cluster nodes,"},{"line_number":55,"context_line":"  # so that when a slave becomes master, it can start ovn-northd."},{"line_number":56,"context_line":"  if $step \u003e\u003d 2 and $::osfamily \u003d\u003d \u0027RedHat\u0027 {"},{"line_number":57,"context_line":"    augeas { \u0027sysconfig-ovn-northd\u0027:"},{"line_number":58,"context_line":"      context \u003d\u003e  \u0027/files/etc/sysconfig/ovn-northd\u0027,"},{"line_number":59,"context_line":"      changes \u003d\u003e  \"set OVN_NORTHD_OPTS \u0027\\\"--db-nb-addr\u003d${ovn_dbs_vip} --db-sb-addr\u003d${ovn_dbs_vip} \\"},{"line_number":60,"context_line":"--db-nb-create-insecure-remote\u003dyes --db-sb-create-insecure-remote\u003dyes --ovn-manage-ovsdb\u003dno\\\"\u0027\","}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1f013ff3_47b5afcc","line":57,"in_reply_to":"1f013ff3_eb31340d","updated":"2017-05-17 06:23:10.000000000","message":"Thanks. I will move it over to puppet-ovn.\nIt didn\u0027t get your last part. You mean to move over the code to create pacemaker resources in puppet-ovn itself ? Please correct me if I am wrong.","commit_id":"12b42ff75c41c4648c9378c08ccad7e2e9b253bf"}]}
