)]}'
{"manifests/profile/base/nova/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"420a92385a5b34ddacb76989eb63dfe6bf4ecd06","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # - Start apache after configuring all vhosts"},{"line_number":46,"context_line":"    exec { \u0027stop_nova-api\u0027:"},{"line_number":47,"context_line":"      command     \u003d\u003e \u0027service openstack-nova-api stop\u0027,"},{"line_number":48,"context_line":"      path        \u003d\u003e \u0027/usr/sbin\u0027,"},{"line_number":49,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":"    Nova_config\u003c||\u003e ~\u003e Exec[\u0027stop_nova-api\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_decf4e7d","line":48,"updated":"2016-10-12 20:52:32.000000000","message":"I agree that we should have an onlyif on this otherwise we\u0027ll be unnecessarily attempting to stop the service if any nova config change occurs. As mentioned below `systemctl is-active openstack-nova-api` should be sufficient","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"915aeb04a2c70abdd271e2b3842a16fd4af7c3f3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Exec[\u0027stop_nova-api\u0027] -\u003e Service[\u0027httpd\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":55,"context_line":"      service_name \u003d\u003e \u0027httpd\u0027, # Temporary: will be moved to t-h-t"},{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_3097b291","line":55,"updated":"2016-10-12 11:31:39.000000000","message":"why not add in https://review.openstack.org/#/c/376255/2/puppet/services/nova-api.yaml now?","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7b0ccfbf849365292507205735650338b469130b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Exec[\u0027stop_nova-api\u0027] -\u003e Service[\u0027httpd\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":55,"context_line":"      service_name \u003d\u003e \u0027httpd\u0027, # Temporary: will be moved to t-h-t"},{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_70dcca12","line":55,"in_reply_to":"fa6399be_3097b291","updated":"2016-10-12 11:36:12.000000000","message":"cause one commit is needed first and I quite didn\u0027t figure out how to do it other than this. First I added the necessary stuff to tripleo-heat-templates, it adds extra hieradata without changing the behavior. Then this is added, which takes the hiera and uses it. Then, once this merges, I can cleanup the hiera in t-h-t. And finally, clean up here.","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"420a92385a5b34ddacb76989eb63dfe6bf4ecd06","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::nova::wsgi::apache"},{"line_number":60,"context_line":"    include ::nova::network::neutron"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_feca526d","line":59,"updated":"2016-10-12 20:52:32.000000000","message":"I agree we should have an onlyif on the exec otherwise we\u0027ll be unnecessarily attempting to stop the nova api if it\u0027s reconfigured.  as mentioned `systemctl is-active openstack-nova-api` should suffice.","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"915aeb04a2c70abdd271e2b3842a16fd4af7c3f3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::nova::wsgi::apache"},{"line_number":60,"context_line":"    include ::nova::network::neutron"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_3021724e","line":59,"updated":"2016-10-12 11:31:39.000000000","message":"so this generally looks OK, in particular doesn\u0027t touch config outside nova api afaics\n\nso is the idea that this is run every time we update... i.e. you avoid needing an upgrade path here (e.g. migration to deliver ^^ as part of newton to ocata upgrade) by having this happen every run...\n\ncan we make it a caveat in that case? I mean can we somehow only conditionally go through the process of stopping nova-api  (if we\u0027re already on nova-api via apache wsgi don\u0027t need to?)","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7c5c59d98d4721a915df46e9886f8cb1774c9751","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::nova::wsgi::apache"},{"line_number":60,"context_line":"    include ::nova::network::neutron"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_c1277862","line":59,"in_reply_to":"fa6399be_17b1bde1","updated":"2016-10-12 16:39:16.000000000","message":"I guess `systemctl is-active openstack-nova-api` could do the trick. (With onlyif the action is idempotent also from Puppet point of view, not just on systemd side. Proper Puppet idempotency sometimes makes things clearer when debugging.)\n\nOr if we want to really hook onto the having / not having the WSGI in place, we could perhaps `grep` or `find` in the httpd config files, but personally i wouldn\u0027t consider that necessary.","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7b0ccfbf849365292507205735650338b469130b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::nova::wsgi::apache"},{"line_number":60,"context_line":"    include ::nova::network::neutron"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_304092a5","line":59,"in_reply_to":"fa6399be_3021724e","updated":"2016-10-12 11:36:12.000000000","message":"I\u0027m not sure how to do that. Any ideas?","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ac2388c7694454a5016885953afc89b0cd7046cb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::nova::wsgi::apache"},{"line_number":60,"context_line":"    include ::nova::network::neutron"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_ca087ddc","line":59,"in_reply_to":"fa6399be_304092a5","updated":"2016-10-12 13:20:24.000000000","message":"Exec accepts `onlyif \u003d\u003e` (shell code), which could be used for such a condition.\n\nThe high level issue here is that this migration doesn\u0027t follow our usual pattern of doing such things. We usually have a special migration step to move services to WSGI, before doing the upgrade. It usually has its own puppet manifest. However, as in this case we don\u0027t have to deal with Pacemaker anymore, maybe it\u0027s worth considering making the WSGI move with Puppet during the \"converge\" step in upgrade? This probably warrants some discussion of pros/cons. However, if we add the `onlyif` condition, then this code\u0027s presenc wouldn\u0027t hurt even if we eventually decide to do the migration \"the classic way\" with separate Puppet manifest and Heat template. WDYT?","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9816574b0f787c5eba71d5d86075b646b6435722","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::nova::wsgi::apache"},{"line_number":60,"context_line":"    include ::nova::network::neutron"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_17b1bde1","line":59,"in_reply_to":"fa6399be_ca087ddc","updated":"2016-10-12 13:52:40.000000000","message":"I kinda like the fact that it\u0027s here, that way upgrades become more seamless. Only thing that\u0027s not clear to me is what to put in that onlyif.","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"40373f09af671a39bf71d3719e8fd5e15d442a83","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":57,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::nova::wsgi::apache"},{"line_number":60,"context_line":"    include ::nova::network::neutron"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_ddabc21b","line":59,"in_reply_to":"fa6399be_feca526d","updated":"2016-10-13 08:48:14.000000000","message":"exactly jistr - that this is different to how we would normally migrate is what I was trying to call out here. Moving the upgrades logic to where each service is defined is likely the direction we will head for Ocata (whether that is bash, puppet, ansible w/e remains to be seen, probably bash for first iteration but anyway...) so I like the general thinking here... as long as we can make it \u0027if nova isn\u0027t already under apache\u0027 then I would +2 this\n\nIt should NOT be just \"if openstack-nova-api is active\" but rather \"if nova-api is under apache\" because that is what the code is doing here and it effectively becomes a migration with that conditional. \n\nPersonally first thing I can think of is checking the /etc/httpd/conf.d/..-nova_wsgi.conf or whatever it is called","commit_id":"08d2d40253edd6628dc093def296887fa38b266e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9f1840a9511e1d47ac8a7b0f75c7cf4b5eb36738","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # Manages the migration to Nova API in mod_wsgi with Apache."},{"line_number":43,"context_line":"    # - First update nova.conf with new parameters"},{"line_number":44,"context_line":"    # - Stop nova-api process before starting apache to avoid binding error"},{"line_number":45,"context_line":"    # - Start apache after configuring all vhosts"},{"line_number":46,"context_line":"    exec { \u0027stop_nova-api\u0027:"},{"line_number":47,"context_line":"      command     \u003d\u003e \u0027service openstack-nova-api stop\u0027,"},{"line_number":48,"context_line":"      path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":49,"context_line":"      onlyif      \u003d\u003e \u0027systemctl is-active openstack-nova-api\u0027,"},{"line_number":50,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"    Nova_config\u003c||\u003e ~\u003e Exec[\u0027stop_nova-api\u0027]"},{"line_number":53,"context_line":"    Exec[\u0027stop_nova-api\u0027] -\u003e Service[\u0027httpd\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":56,"context_line":"      service_name \u003d\u003e \u0027httpd\u0027, # Temporary: will be moved to t-h-t"},{"line_number":57,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    include ::nova::wsgi::apache"},{"line_number":61,"context_line":"    include ::nova::network::neutron"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_5858a032","line":60,"range":{"start_line":45,"start_character":12,"end_line":60,"end_character":32},"updated":"2016-10-13 08:49:52.000000000","message":"the condition we need here is not just \u0027stop nova-api only if it is running\u0027 but rather \n\ndo all of this stuff, stop and bringup nova-api under apache, only if we haven\u0027t already done that... added a note at v2 https://review.openstack.org/#/c/376267/2/manifests/profile/base/nova/api.pp","commit_id":"1941037308d5a375e86e54946476bde707b01c13"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"bf20b324cf3b9a12f402efb314c4c376fa50c829","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # Manages the migration to Nova API in mod_wsgi with Apache."},{"line_number":43,"context_line":"    # - First update nova.conf with new parameters"},{"line_number":44,"context_line":"    # - Stop nova-api process before starting apache to avoid binding error"},{"line_number":45,"context_line":"    # - Start apache after configuring all vhosts"},{"line_number":46,"context_line":"    exec { \u0027stop_nova-api\u0027:"},{"line_number":47,"context_line":"      command     \u003d\u003e \u0027service openstack-nova-api stop\u0027,"},{"line_number":48,"context_line":"      path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":49,"context_line":"      onlyif      \u003d\u003e \u0027systemctl is-active openstack-nova-api\u0027,"},{"line_number":50,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"    Nova_config\u003c||\u003e ~\u003e Exec[\u0027stop_nova-api\u0027]"},{"line_number":53,"context_line":"    Exec[\u0027stop_nova-api\u0027] -\u003e Service[\u0027httpd\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":56,"context_line":"      service_name \u003d\u003e \u0027httpd\u0027, # Temporary: will be moved to t-h-t"},{"line_number":57,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    include ::nova::wsgi::apache"},{"line_number":61,"context_line":"    include ::nova::network::neutron"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_3f3e6b8c","line":60,"range":{"start_line":45,"start_character":12,"end_line":60,"end_character":32},"in_reply_to":"fa6399be_2a2d4f95","updated":"2016-10-13 11:15:21.000000000","message":"I agree this is good, it doesn\u0027t prevent us from doing the migration earlier if we decide to. +2","commit_id":"1941037308d5a375e86e54946476bde707b01c13"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"066d3f1b4cf90fc80a9b82dd97eb0af4dfe0c3d7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # Manages the migration to Nova API in mod_wsgi with Apache."},{"line_number":43,"context_line":"    # - First update nova.conf with new parameters"},{"line_number":44,"context_line":"    # - Stop nova-api process before starting apache to avoid binding error"},{"line_number":45,"context_line":"    # - Start apache after configuring all vhosts"},{"line_number":46,"context_line":"    exec { \u0027stop_nova-api\u0027:"},{"line_number":47,"context_line":"      command     \u003d\u003e \u0027service openstack-nova-api stop\u0027,"},{"line_number":48,"context_line":"      path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":49,"context_line":"      onlyif      \u003d\u003e \u0027systemctl is-active openstack-nova-api\u0027,"},{"line_number":50,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"    Nova_config\u003c||\u003e ~\u003e Exec[\u0027stop_nova-api\u0027]"},{"line_number":53,"context_line":"    Exec[\u0027stop_nova-api\u0027] -\u003e Service[\u0027httpd\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":56,"context_line":"      service_name \u003d\u003e \u0027httpd\u0027, # Temporary: will be moved to t-h-t"},{"line_number":57,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    include ::nova::wsgi::apache"},{"line_number":61,"context_line":"    include ::nova::network::neutron"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_587d006d","line":60,"range":{"start_line":45,"start_character":12,"end_line":60,"end_character":32},"in_reply_to":"fa6399be_5858a032","updated":"2016-10-13 08:51:21.000000000","message":"But isn\u0027t that the way to check if a service is running under apache or not? If it\u0027s not running under apache, then the openstack-nova-api service will be running. If it\u0027s running under apache, then httpd will be running instead.","commit_id":"1941037308d5a375e86e54946476bde707b01c13"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"02acfce78171fae15e07fde9a5601a41a72c68a8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # Manages the migration to Nova API in mod_wsgi with Apache."},{"line_number":43,"context_line":"    # - First update nova.conf with new parameters"},{"line_number":44,"context_line":"    # - Stop nova-api process before starting apache to avoid binding error"},{"line_number":45,"context_line":"    # - Start apache after configuring all vhosts"},{"line_number":46,"context_line":"    exec { \u0027stop_nova-api\u0027:"},{"line_number":47,"context_line":"      command     \u003d\u003e \u0027service openstack-nova-api stop\u0027,"},{"line_number":48,"context_line":"      path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":49,"context_line":"      onlyif      \u003d\u003e \u0027systemctl is-active openstack-nova-api\u0027,"},{"line_number":50,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"    Nova_config\u003c||\u003e ~\u003e Exec[\u0027stop_nova-api\u0027]"},{"line_number":53,"context_line":"    Exec[\u0027stop_nova-api\u0027] -\u003e Service[\u0027httpd\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":56,"context_line":"      service_name \u003d\u003e \u0027httpd\u0027, # Temporary: will be moved to t-h-t"},{"line_number":57,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    include ::nova::wsgi::apache"},{"line_number":61,"context_line":"    include ::nova::network::neutron"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_d8c9107a","line":60,"range":{"start_line":45,"start_character":12,"end_line":60,"end_character":32},"in_reply_to":"fa6399be_5858a032","updated":"2016-10-13 08:56:17.000000000","message":"so the problem here is this won\u0027t be defined elsewhere... I got caught up thinking of this as a migration, when in fact this is it. It both defines that we deploy nova-api under apache and tries to handle cases where we didn\u0027t before and now want to.\n\nSo my request for \u0027only if this is already migrated\u0027 doesn\u0027t work anymore because there is no stand-alone migration yet.\n\nIn which case it is only the stop that is significant here. \n\nThinking a little more about the upgrade path here... since this is puppet it won\u0027t get applied to a new environment until the converge step. I mean if you start with e.g. stable/newton where nova-api isn\u0027t under apache and then try to upgrade with this, with the current workflow, it wouldn\u0027t get applied until converge (i.e. you wouldn\u0027t get nova-api apache/wsgi until the converge step.). However  as previously mentioned that workflow will be changing for ocata so that may not matter. This is new territory :)","commit_id":"1941037308d5a375e86e54946476bde707b01c13"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b0b4bee419b82316c51de031d8cc910ac14dcf0b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # Manages the migration to Nova API in mod_wsgi with Apache."},{"line_number":43,"context_line":"    # - First update nova.conf with new parameters"},{"line_number":44,"context_line":"    # - Stop nova-api process before starting apache to avoid binding error"},{"line_number":45,"context_line":"    # - Start apache after configuring all vhosts"},{"line_number":46,"context_line":"    exec { \u0027stop_nova-api\u0027:"},{"line_number":47,"context_line":"      command     \u003d\u003e \u0027service openstack-nova-api stop\u0027,"},{"line_number":48,"context_line":"      path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":49,"context_line":"      onlyif      \u003d\u003e \u0027systemctl is-active openstack-nova-api\u0027,"},{"line_number":50,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"    Nova_config\u003c||\u003e ~\u003e Exec[\u0027stop_nova-api\u0027]"},{"line_number":53,"context_line":"    Exec[\u0027stop_nova-api\u0027] -\u003e Service[\u0027httpd\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    class { \u0027::nova::api\u0027:"},{"line_number":56,"context_line":"      service_name \u003d\u003e \u0027httpd\u0027, # Temporary: will be moved to t-h-t"},{"line_number":57,"context_line":"      sync_db      \u003d\u003e $sync_db,"},{"line_number":58,"context_line":"      sync_db_api  \u003d\u003e $sync_db,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    include ::nova::wsgi::apache"},{"line_number":61,"context_line":"    include ::nova::network::neutron"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_2a2d4f95","line":60,"range":{"start_line":45,"start_character":12,"end_line":60,"end_character":32},"in_reply_to":"fa6399be_d8c9107a","updated":"2016-10-13 09:10:03.000000000","message":"In case it wasn\u0027t clear from the above and some chat with Juan - this looks OK. Even if we end up with a stand-alone migration script for this in newton..ocata upgrades the conditional above will make sure we don\u0027t unnecessarily stop nova-api if that\u0027s already happened.","commit_id":"1941037308d5a375e86e54946476bde707b01c13"}]}