)]}'
{"manifests/profile/base/database/mysql.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1d3130659970e8389ee89326b8cfff5e28330bd3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    if hiera(\u0027aodh_api_enabled\u0027, false) {"},{"line_number":103,"context_line":"      include ::aodh::db::mysql"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":"    if hiera(\u0027ceilometer_collector_enabled\u0027, false) {"},{"line_number":106,"context_line":"      include ::ceilometer::db::sync"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"    if hiera(\u0027cinder_api_enabled\u0027, false) {"},{"line_number":109,"context_line":"      include ::cinder::db::mysql"},{"line_number":110,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a8bc5a2_abc2fe31","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":5},"updated":"2016-09-26 17:17:04.000000000","message":"I think this one needs to stay on ceilometer collector node.\nAlso you missed to copy ::ceilometer::db::mysql from base/profile/ceilometer.pp into the mysql.pp.","commit_id":"b399db971be7c14896d791d7c6e8fdc73b574e5f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"88e96bbe13dfd23317a8f007d03bba6e94eced4c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if $step \u003e\u003d 2 and $sync_db {"},{"line_number":102,"context_line":"    if hiera(\u0027aodh_api_enabled\u0027, false) {"},{"line_number":103,"context_line":"      include ::aodh::db::mysql"},{"line_number":104,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a8bc5a2_7f66e751","line":101,"updated":"2016-09-26 20:16:31.000000000","message":"Does the *::db::mysql::host hiera data from THT get properly assigned to the mysql role so that it will pass in step 4 when the roles are split off?","commit_id":"079832fc584425ba1c95bf75e0979387652b88c9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"89acdc133f785986253de3c9e5ed856edb637450","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if $step \u003e\u003d 2 and $sync_db {"},{"line_number":102,"context_line":"    if hiera(\u0027aodh_api_enabled\u0027, false) {"},{"line_number":103,"context_line":"      include ::aodh::db::mysql"},{"line_number":104,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a8bc5a2_a4085f29","line":101,"in_reply_to":"5a8bc5a2_7f66e751","updated":"2016-09-26 21:37:18.000000000","message":"yes hiera is distributed for all steps; though I am not sure why we did step \u003e\u003d 2 here and not \u003e\u003d 3 as it is in the lines we\u0027re removing?","commit_id":"079832fc584425ba1c95bf75e0979387652b88c9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"49a0c65bbadd1bfc8628d6eb6ab91b7670e92ee3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if $step \u003e\u003d 2 and $sync_db {"},{"line_number":102,"context_line":"    if hiera(\u0027aodh_api_enabled\u0027, false) {"},{"line_number":103,"context_line":"      include ::aodh::db::mysql"},{"line_number":104,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a8bc5a2_e49987c5","line":101,"in_reply_to":"5a8bc5a2_a4085f29","updated":"2016-09-26 21:45:22.000000000","message":"OK wasn\u0027t sure if this information would also be distributed to whatever node that this gets run on. I did find https://review.openstack.org/#/c/376984/ which seems to do what I was asking but I just wanted to be sure that the user/pass/host information is properly included on all nodes that need it (database + service) and just to only one.","commit_id":"079832fc584425ba1c95bf75e0979387652b88c9"}]}
