)]}'
{"manifests/profile/pacemaker/rabbitmq.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ffc2b657902d2d98e19cc1068f1f3197c18a00df","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"},{"line_number":64,"context_line":"    include ::stdlib"},{"line_number":65,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":66,"context_line":"    if hiera(\u0027rabbitmq::nr_ha_queues\u0027) \u003d\u003d 0 {"},{"line_number":67,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a98d1f4_e03885d5","line":64,"updated":"2016-10-03 15:21:47.000000000","message":"you don\u0027t need to include it, it\u0027s in the puppet scope anyway. I can\u0027t tell you why exactly, but I know you don\u0027t need to include it.","commit_id":"87b30b1e345d1c724e443bcfd975aa331450b0a7"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"8712c48d754f50cb2a86f1adc151c091dc5920fd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"},{"line_number":64,"context_line":"    include ::stdlib"},{"line_number":65,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":66,"context_line":"    if hiera(\u0027rabbitmq::nr_ha_queues\u0027) \u003d\u003d 0 {"},{"line_number":67,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a98d1f4_a0ccbdbb","line":64,"in_reply_to":"3a98d1f4_e03885d5","updated":"2016-10-03 15:24:07.000000000","message":"Without it the call below to size() barfed on me (surprisingly to me)","commit_id":"87b30b1e345d1c724e443bcfd975aa331450b0a7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49193d47659bdaeb87f8bcdd73c1ee3e00904e4c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"},{"line_number":64,"context_line":"    include ::stdlib"},{"line_number":65,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":66,"context_line":"    if hiera(\u0027rabbitmq::nr_ha_queues\u0027) \u003d\u003d 0 {"},{"line_number":67,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"},{"line_number":68,"context_line":"      $nr_ha_queues \u003d $nr_rabbit_nodes / 2 + ($nr_rabbit_nodes % 2)"},{"line_number":69,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a98d1f4_98110d60","line":66,"range":{"start_line":66,"start_character":7,"end_line":66,"end_character":38},"updated":"2016-10-03 08:10:57.000000000","message":"do we also need to deal with this not being set at all? I mean where is this passed in hiera (had a quick poke at tht but couldn\u0027t see it). So if it isn\u0027t set do we want to include that in the calculate from number of nodes clause here\n\nsorry if this is not a valid concern","commit_id":"87b30b1e345d1c724e443bcfd975aa331450b0a7"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"8712c48d754f50cb2a86f1adc151c091dc5920fd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"},{"line_number":64,"context_line":"    include ::stdlib"},{"line_number":65,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":66,"context_line":"    if hiera(\u0027rabbitmq::nr_ha_queues\u0027) \u003d\u003d 0 {"},{"line_number":67,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"},{"line_number":68,"context_line":"      $nr_ha_queues \u003d $nr_rabbit_nodes / 2 + ($nr_rabbit_nodes % 2)"},{"line_number":69,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a98d1f4_e0496532","line":66,"range":{"start_line":66,"start_character":7,"end_line":66,"end_character":38},"in_reply_to":"3a98d1f4_205d0d15","updated":"2016-10-03 15:24:07.000000000","message":"We set the default in THT, but yeah I guess an extra check is in order.","commit_id":"87b30b1e345d1c724e443bcfd975aa331450b0a7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"30e182b48603decd6d80055101a45a13a0edb1f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"},{"line_number":64,"context_line":"    include ::stdlib"},{"line_number":65,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":66,"context_line":"    if hiera(\u0027rabbitmq::nr_ha_queues\u0027) \u003d\u003d 0 {"},{"line_number":67,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"},{"line_number":68,"context_line":"      $nr_ha_queues \u003d $nr_rabbit_nodes / 2 + ($nr_rabbit_nodes % 2)"},{"line_number":69,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a98d1f4_f3db127a","line":66,"range":{"start_line":66,"start_character":7,"end_line":66,"end_character":38},"in_reply_to":"3a98d1f4_98110d60","updated":"2016-10-03 08:19:35.000000000","message":"yup... just looked at the depends on sorry i missed that","commit_id":"87b30b1e345d1c724e443bcfd975aa331450b0a7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a0129d3602a87538733a6bfe44be41de503e107c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"},{"line_number":64,"context_line":"    include ::stdlib"},{"line_number":65,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":66,"context_line":"    if hiera(\u0027rabbitmq::nr_ha_queues\u0027) \u003d\u003d 0 {"},{"line_number":67,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"},{"line_number":68,"context_line":"      $nr_ha_queues \u003d $nr_rabbit_nodes / 2 + ($nr_rabbit_nodes % 2)"},{"line_number":69,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a98d1f4_80b34109","line":66,"range":{"start_line":66,"start_character":7,"end_line":66,"end_character":38},"in_reply_to":"3a98d1f4_e0496532","updated":"2016-10-03 15:25:43.000000000","message":"ok nevermind then","commit_id":"87b30b1e345d1c724e443bcfd975aa331450b0a7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ffc2b657902d2d98e19cc1068f1f3197c18a00df","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"},{"line_number":64,"context_line":"    include ::stdlib"},{"line_number":65,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":66,"context_line":"    if hiera(\u0027rabbitmq::nr_ha_queues\u0027) \u003d\u003d 0 {"},{"line_number":67,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"},{"line_number":68,"context_line":"      $nr_ha_queues \u003d $nr_rabbit_nodes / 2 + ($nr_rabbit_nodes % 2)"},{"line_number":69,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a98d1f4_205d0d15","line":66,"range":{"start_line":66,"start_character":7,"end_line":66,"end_character":38},"in_reply_to":"3a98d1f4_f3db127a","updated":"2016-10-03 15:21:47.000000000","message":"I would set a default to the hiera lookup, in case the value is not defined. What about 0 ?","commit_id":"87b30b1e345d1c724e443bcfd975aa331450b0a7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a98fa335aa8a8a4bf7277ce4d029ac9c689edc40","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master {"},{"line_number":64,"context_line":"    include ::stdlib"},{"line_number":65,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":66,"context_line":"    if hiera(\u0027rabbitmq::nr_ha_queues\u0027, 0) \u003d\u003d 0 {"},{"line_number":67,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"},{"line_number":68,"context_line":"      $nr_ha_queues \u003d $nr_rabbit_nodes / 2 + ($nr_rabbit_nodes % 2)"},{"line_number":69,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_6e237f56","line":66,"range":{"start_line":66,"start_character":7,"end_line":66,"end_character":41},"updated":"2016-10-03 18:16:18.000000000","message":"The hiera lookups should probably be parameters to this class to assist in testing and configuration overrides in the future.","commit_id":"6f58007d687727101daf6f9153a445c2e44f08a4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f95e2f64eead7970650a955668ab5f3d82a197e7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    include ::stdlib"},{"line_number":66,"context_line":"    # The default nr of ha queues is ceiling(N/2)"},{"line_number":67,"context_line":"    if $user_ha_queues \u003d\u003d 0 {"},{"line_number":68,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"},{"line_number":69,"context_line":"      $nr_ha_queues \u003d $nr_rabbit_nodes / 2 + ($nr_rabbit_nodes % 2)"},{"line_number":70,"context_line":"    } else {"},{"line_number":71,"context_line":"      $nr_ha_queues \u003d hiera(\u0027rabbitmq::nr_ha_queues\u0027)"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a98d1f4_d100b204","line":68,"range":{"start_line":68,"start_character":30,"end_line":68,"end_character":58},"updated":"2016-10-03 19:10:14.000000000","message":"this should technically also be a param","commit_id":"b3629ec9466de4c7d90f257779e663af10d6c093"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f95e2f64eead7970650a955668ab5f3d82a197e7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      $nr_rabbit_nodes \u003d size(hiera(\u0027rabbitmq_node_names\u0027))"},{"line_number":69,"context_line":"      $nr_ha_queues \u003d $nr_rabbit_nodes / 2 + ($nr_rabbit_nodes % 2)"},{"line_number":70,"context_line":"    } else {"},{"line_number":71,"context_line":"      $nr_ha_queues \u003d hiera(\u0027rabbitmq::nr_ha_queues\u0027)"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"    pacemaker::resource::ocf { \u0027rabbitmq\u0027:"},{"line_number":74,"context_line":"      ocf_agent_name  \u003d\u003e \u0027heartbeat:rabbitmq-cluster\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a98d1f4_b12ec6a2","line":71,"range":{"start_line":71,"start_character":22,"end_line":71,"end_character":53},"updated":"2016-10-03 19:10:14.000000000","message":"use $user_ha_queues, there\u0027s no need to do the lookup twice","commit_id":"b3629ec9466de4c7d90f257779e663af10d6c093"}]}