)]}'
{"manifests/ui.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bb2c757351eed7ce04d2d61e29b8508b6c7b60ab","unresolved":false,"context_lines":[{"line_number":108,"context_line":"# OpenStack TripleO UI configuration has been moved to:"},{"line_number":109,"context_line":"# - 25-tripleo-ui.conf"},{"line_number":110,"context_line":"#\","},{"line_number":111,"context_line":"    require \u003d\u003e Package[\u0027openstack-tripleo-ui\u0027],"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  file { \u0027/var/www/openstack-tripleo-ui/dist/tripleo_ui_config.js\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a98d1f4_c513ccb6","line":111,"updated":"2016-09-30 22:40:25.000000000","message":"Do we need to do a before \u003d\u003e Service[$::apache::params::service_name] to prevent apache from starting with the old bad file since we\u0027re not notifying the service if the content changes.","commit_id":"9db6bf471c28ed8a0613581bef7eea1ae0c19885"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"b055caecd36941f7ddd9f140b69230a2525bb2b8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"# OpenStack TripleO UI configuration has been moved to:"},{"line_number":109,"context_line":"# - 25-tripleo-ui.conf"},{"line_number":110,"context_line":"#\","},{"line_number":111,"context_line":"    require \u003d\u003e Package[\u0027openstack-tripleo-ui\u0027],"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  file { \u0027/var/www/openstack-tripleo-ui/dist/tripleo_ui_config.js\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a98d1f4_8188b572","line":111,"in_reply_to":"3a98d1f4_c513ccb6","updated":"2016-10-03 11:07:03.000000000","message":"I think we\u0027re probably fine without it because the files are duplicate of each other, so no matter which one Apache runs with it\u0027ll be ok. The problem is when it tries to run with both at the same time (due to the port conflict).\n\nI\u0027m not very familiar with Puppet so I read/tested this a bit and it looks like adding the parameter is just fine too so, let\u0027s add it in for additional safety anyway. I\u0027ll update the patch. Thanks for the comment!","commit_id":"9db6bf471c28ed8a0613581bef7eea1ae0c19885"}]}
