)]}'
{"manifests/profile/base/manila/api.pp":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"448af648019080dfc523297eaf4e63d94493baf1","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":43,"context_line":"    if hiera(\u0027manila_backend_generic_enabled\u0027, false) or hiera(\u0027manila_backend_netapp_enabled\u0027, false) {"},{"line_number":44,"context_line":"      generic_protocols \u003d \u0027NFS,CIFS\u0027"},{"line_number":45,"context_line":"    } else {"},{"line_number":46,"context_line":"      generic_protocols \u003d undef"},{"line_number":47,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_ebec8bc9","line":44,"updated":"2016-10-05 13:29:14.000000000","message":"Getting the following when trying to deploy with this patch:\n\n    Error: Syntax error at \u0027\u003d\u0027; expected \u0027}\u0027 at /etc/puppet/modules/tripleo/manifests/profile/base/manila/api.pp:44 on node overcloud-controller-2.localdomain","commit_id":"fd6443d3d4e735f5758f0230707c18c63878e445"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b66d685052f603df0b3b6dc61120aa85a2e77d39","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":43,"context_line":"    if hiera(\u0027manila_backend_generic_enabled\u0027, false) or hiera(\u0027manila_backend_netapp_enabled\u0027, false) {"},{"line_number":44,"context_line":"      generic_protocols \u003d \u0027NFS,CIFS\u0027"},{"line_number":45,"context_line":"    } else {"},{"line_number":46,"context_line":"      generic_protocols \u003d undef"},{"line_number":47,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_86c77e11","line":44,"in_reply_to":"1a95cdbc_ebec8bc9","updated":"2016-10-05 13:48:23.000000000","message":"sorry I had missed all the $ :(","commit_id":"fd6443d3d4e735f5758f0230707c18c63878e445"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0cb446b3a72af692e15347c0ca60e6f221856b73","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      $cephfs_protocols \u003d undef"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"    class { \u0027::manila::api\u0027 :"},{"line_number":54,"context_line":"      enabled_share_protocols \u003d delete_undef_values([$generic_protocols,$cephfs_protocols])"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a95cdbc_da25d6ab","line":54,"range":{"start_line":54,"start_character":53,"end_line":54,"end_character":89},"updated":"2016-10-05 13:55:27.000000000","message":"Is link going to complain about lack of a space here?","commit_id":"afcc546b50d807b109456aaecaa08fad615da824"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a2740b4b3183ef5e9582e782f086a57e7f9813e8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      $cephfs_protocols \u003d undef"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"    class { \u0027::manila::api\u0027 :"},{"line_number":54,"context_line":"      enabled_share_protocols \u003d delete_undef_values([$generic_protocols,$cephfs_protocols])"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a95cdbc_d317814f","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":91},"updated":"2016-10-05 14:50:09.000000000","message":"Now I get:\n\n    Error: Syntax error at \u0027\u003d\u0027; expected \u0027}\u0027 at /etc/puppet/modules/tripleo/manifests/profile/base/manila/api.pp:54 on node overcloud-controller-2.localdomain\n\nI wonder if you have to use an intermediate  $enabled_share_protocols to collect the result of delete_undef_values() as done for enabled_share_backends in pacemaker/manila.pp","commit_id":"afcc546b50d807b109456aaecaa08fad615da824"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"32309604cbda14cc1bb55477c460339bdb52de4a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      $cephfs_protocols \u003d undef"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"    class { \u0027::manila::api\u0027 :"},{"line_number":54,"context_line":"      enabled_share_protocols \u003d delete_undef_values([$generic_protocols,$cephfs_protocols])"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a95cdbc_0278ac8e","line":54,"range":{"start_line":54,"start_character":30,"end_line":54,"end_character":31},"updated":"2016-10-05 16:57:02.000000000","message":"Oh, this should be \u0027\u003d\u003e\u0027, right?","commit_id":"afcc546b50d807b109456aaecaa08fad615da824"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c15eca3fe56c23f5d39adf9fe35f2fe2a08a75a2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      $cephfs_protocols \u003d undef"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"    class { \u0027::manila::api\u0027 :"},{"line_number":54,"context_line":"      enabled_share_protocols \u003d delete_undef_values([$generic_protocols,$cephfs_protocols])"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a95cdbc_627df01b","line":54,"range":{"start_line":54,"start_character":30,"end_line":54,"end_character":31},"in_reply_to":"1a95cdbc_0278ac8e","updated":"2016-10-05 17:01:43.000000000","message":"yes!","commit_id":"afcc546b50d807b109456aaecaa08fad615da824"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35d679df75140e1ac1432626135523c6ab81f14e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::tripleo::profile::base::manila"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":43,"context_line":"    if hiera(\u0027manila_backend_generic_enabled\u0027, false) or hiera(\u0027manila_backend_netapp_enabled\u0027, false) {"},{"line_number":44,"context_line":"      $generic_protocols \u003d \u0027NFS,CIFS\u0027"},{"line_number":45,"context_line":"    } else {"},{"line_number":46,"context_line":"      $generic_protocols \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a95cdbc_1a3715e4","line":43,"range":{"start_line":43,"start_character":7,"end_line":43,"end_character":53},"updated":"2016-10-06 09:57:35.000000000","message":"pacemaker/manila.pp checks for hiera(\u0027manila_generic_enable_backend\u0027, false)","commit_id":"2acba34b224b470168a5891dade341c1741af558"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35d679df75140e1ac1432626135523c6ab81f14e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::tripleo::profile::base::manila"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":43,"context_line":"    if hiera(\u0027manila_backend_generic_enabled\u0027, false) or hiera(\u0027manila_backend_netapp_enabled\u0027, false) {"},{"line_number":44,"context_line":"      $generic_protocols \u003d \u0027NFS,CIFS\u0027"},{"line_number":45,"context_line":"    } else {"},{"line_number":46,"context_line":"      $generic_protocols \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a95cdbc_ba6f01c4","line":43,"range":{"start_line":43,"start_character":57,"end_line":43,"end_character":104},"updated":"2016-10-06 09:57:35.000000000","message":"pacemaker/manila.pp checks for hiera(\u0027manila_netapp_enable_backend\u0027, false)","commit_id":"2acba34b224b470168a5891dade341c1741af558"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35d679df75140e1ac1432626135523c6ab81f14e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    } else {"},{"line_number":46,"context_line":"      $generic_protocols \u003d undef"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"    if hiera(\u0027manila_backend_cephfs_enabled\u0027, false) {"},{"line_number":49,"context_line":"      $cephfs_protocols \u003d \u0027CEPHFS\u0027"},{"line_number":50,"context_line":"    } else {"},{"line_number":51,"context_line":"      $cephfs_protocols \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a95cdbc_da804d49","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":52},"updated":"2016-10-06 09:57:35.000000000","message":"pacemaker/manila.pp checks for  hiera(\u0027manila::backend::cephfsnative::enable_backend\u0027, false)","commit_id":"2acba34b224b470168a5891dade341c1741af558"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f73dd29e5bf8b16646d4ef9d20d7ca6fefdac5f5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::tripleo::profile::base::manila"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":43,"context_line":"    if hiera(\u0027manila_backend_generic_enabled\u0027, false) or hiera(\u0027manila_backend_netapp_enabled\u0027, false) {"},{"line_number":44,"context_line":"      $nfs_protocol \u003d \u0027NFS\u0027"},{"line_number":45,"context_line":"      $cifs_protocol \u003d \u0027CIFS\u0027"},{"line_number":46,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a95cdbc_2e7b978d","line":43,"updated":"2016-10-06 18:52:03.000000000","message":"if we\u0027re adding new hiera variables, please make them parameters to this class so that we can test them better with spec tests.  Additionally it\u0027s much more readable than this.","commit_id":"102b4e1730d11511172b1c49bceb235370a2911e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"089681f61c9ad383a1a1d3652cb8d08d6ae90784","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::tripleo::profile::base::manila"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":43,"context_line":"    if hiera(\u0027manila_backend_generic_enabled\u0027, false) or hiera(\u0027manila_backend_netapp_enabled\u0027, false) {"},{"line_number":44,"context_line":"      $nfs_protocol \u003d \u0027NFS\u0027"},{"line_number":45,"context_line":"      $cifs_protocol \u003d \u0027CIFS\u0027"},{"line_number":46,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a95cdbc_2e9c770e","line":43,"in_reply_to":"1a95cdbc_2e7b978d","updated":"2016-10-06 19:00:31.000000000","message":"no these are not new parameters, they are dyamically created by heat for each role following a ${service_name}_enabled scheme","commit_id":"102b4e1730d11511172b1c49bceb235370a2911e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d8c2e30d14960fac31266121ce1ff49f84052d84","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::tripleo::profile::base::manila"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":43,"context_line":"    if hiera(\u0027manila_backend_generic_enabled\u0027, false) or hiera(\u0027manila_backend_netapp_enabled\u0027, false) {"},{"line_number":44,"context_line":"      $nfs_protocol \u003d \u0027NFS\u0027"},{"line_number":45,"context_line":"      $cifs_protocol \u003d \u0027CIFS\u0027"},{"line_number":46,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a95cdbc_d132d4f1","line":43,"in_reply_to":"1a95cdbc_2e9c770e","updated":"2016-10-06 19:04:05.000000000","message":"I didn\u0027t say they are new parameters, but they are new hiera lookups to this class. To allow for better testing and flexibility any new hiera lookups should be added as parameters to this class so that we can mock out the testing using traditional puppet tooling rather than having to come up with a bunch of hiera files to do so.","commit_id":"102b4e1730d11511172b1c49bceb235370a2911e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f73dd29e5bf8b16646d4ef9d20d7ca6fefdac5f5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      $nfs_protocol \u003d undef"},{"line_number":48,"context_line":"      $cifs_protocol \u003d undef"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"    if hiera(\u0027manila_backend_cephfs_enabled\u0027, false) {"},{"line_number":51,"context_line":"      $cephfs_protocol \u003d \u0027CEPHFS\u0027"},{"line_number":52,"context_line":"    } else {"},{"line_number":53,"context_line":"      $cephfs_protocol \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a95cdbc_4e6c63d0","line":50,"updated":"2016-10-06 18:52:03.000000000","message":"same please move this to a parameter on the class","commit_id":"102b4e1730d11511172b1c49bceb235370a2911e"}]}