)]}'
{"manifests/profile/base/ceph.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7d544ad725e1e45b4e705251f8e4abfef2f5eecb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"class tripleo::profile::base::ceph ("},{"line_number":39,"context_line":"  $ceph_mon_initial_members \u003d hiera(\u0027ceph_mon_short_node_names\u0027, undef),"},{"line_number":40,"context_line":"  $ceph_mon_host            \u003d hiera(\u0027ceph_mon_node_ips\u0027, \u0027127.0.0.1\u0027),"},{"line_number":41,"context_line":"  $enable_ceph_storage      \u003d false,"},{"line_number":42,"context_line":"  $step                     \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_d74c8972","line":39,"updated":"2016-10-06 18:26:22.000000000","message":"why not just hiera(\u0027ceph_mon_short_node_names\u0027, hiera(\u0027ceph_mon_node_names\u0027, undef))","commit_id":"5ca5102472af1e4690e78c345c7d7654df85455b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7d544ad725e1e45b4e705251f8e4abfef2f5eecb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    $ceph_mon_initial_members_real \u003d hiera(\u0027ceph_mon_node_names\u0027, undef)"},{"line_number":46,"context_line":"  } else {"},{"line_number":47,"context_line":"    $ceph_mon_initial_members_real \u003d $ceph_mon_initial_members"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":51,"context_line":"    if $ceph_mon_initial_members_real {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_f747c548","line":48,"updated":"2016-10-06 18:26:22.000000000","message":"If you use the hiera(...,hiera(...)) this entire block is not needed","commit_id":"5ca5102472af1e4690e78c345c7d7654df85455b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7d544ad725e1e45b4e705251f8e4abfef2f5eecb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      if is_array($ceph_mon_initial_members_real) {"},{"line_number":53,"context_line":"        $mon_initial_members \u003d downcase(join($ceph_mon_initial_members_real, \u0027,\u0027))"},{"line_number":54,"context_line":"      } else {"},{"line_number":55,"context_line":"        $mon_initial_members \u003d downcase($ceph_mon_initial_members_real)"},{"line_number":56,"context_line":"      }"},{"line_number":57,"context_line":"    } else {"},{"line_number":58,"context_line":"      $mon_initial_members \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_17751197","line":55,"updated":"2016-10-06 18:26:22.000000000","message":"additionally this if/else can just be $mon_initial_members \u003d downcase(join(any2array($ceph_mon_initial_members), \u0027,\u0027))","commit_id":"5ca5102472af1e4690e78c345c7d7654df85455b"}]}