)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"10d25181e8e869dfd0d31e793516beb79ebb9999","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        Cinder_config\u003c||\u003e ~\u003e Tripleo::Pacemaker::Resource_restart_flag[\"${::cinder::params::volume_service}\"]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"but in the convergence step, the base/pacemaker.pp is not included and"},{"line_number":23,"context_line":"the above trigger fails as the directory is not created."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"It looks the same for manilla.pp."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa6399be_ff715345","line":23,"updated":"2016-10-13 11:22:45.000000000","message":"Makes sense, thanks Sofer.","commit_id":"7f2931941e5b6894f51ea0a49b6be0e5549971e5"}],"manifests/pacemaker/resource_restart_flag.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"af71e2354e2ae195f92dfd037e513ab06d10eb42","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"define tripleo::pacemaker::resource_restart_flag() {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  file { \u0027/var/lib/tripleo/pacemaker-restarts\u0027:"},{"line_number":30,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":31,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":32,"context_line":"    mode   \u003d\u003e \u00270755\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_f33f2023","line":29,"updated":"2016-10-11 19:44:01.000000000","message":"You\u0027re going to get a duplicate definition error for this since this is is a resource and can be included multiple times in the catalog","commit_id":"06df4e96407ebd777b1d6acb2126a59793814b1a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"af71e2354e2ae195f92dfd037e513ab06d10eb42","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  exec { \"${title} resource restart flag\":"},{"line_number":37,"context_line":"    command \u003d\u003e \"touch /var/lib/tripleo/pacemaker-restarts/${title}\","},{"line_number":38,"context_line":"    path    \u003d\u003e [\u0027/bin\u0027,\u0027/usr/bin\u0027,\u0027/sbin\u0027,\u0027/usr/sbin\u0027],"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_133d742b","line":37,"updated":"2016-10-11 19:44:01.000000000","message":"You could just mkdir -p /var/lib/tripleo/pacemaker-restarts \u0026\u0026 touch /var/lib/tripleo/pacemaker-restarts/${title}","commit_id":"06df4e96407ebd777b1d6acb2126a59793814b1a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9c2e13478c1156a8cef5496969d6284b0954e2fd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  exec { \"${title} resource restart flag\":"},{"line_number":39,"context_line":"    command \u003d\u003e \"touch /var/lib/tripleo/pacemaker-restarts/${title}\","},{"line_number":40,"context_line":"    path    \u003d\u003e [\u0027/bin\u0027,\u0027/usr/bin\u0027,\u0027/sbin\u0027,\u0027/usr/sbin\u0027],"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  File[\u0027/var/lib/tripleo/pacemaker-restarts\u0027] -\u003e"},{"line_number":44,"context_line":"  Exec[\"${title} resource restart flag\"]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_e24f01bb","line":41,"updated":"2016-10-13 08:30:40.000000000","message":"this lgtm Sofer, though admittedly I had to go looking at puppet docs a bit :)\n\nI was trying to understand the significance of not using refreshonly any more. If I understand correctly, you create/ensure the directories every time, define the exec above and then below execute it every time because that file /pacemaker-restarts/ exists for sure now?","commit_id":"7f2931941e5b6894f51ea0a49b6be0e5549971e5"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"10d25181e8e869dfd0d31e793516beb79ebb9999","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  exec { \"${title} resource restart flag\":"},{"line_number":39,"context_line":"    command \u003d\u003e \"touch /var/lib/tripleo/pacemaker-restarts/${title}\","},{"line_number":40,"context_line":"    path    \u003d\u003e [\u0027/bin\u0027,\u0027/usr/bin\u0027,\u0027/sbin\u0027,\u0027/usr/sbin\u0027],"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  File[\u0027/var/lib/tripleo/pacemaker-restarts\u0027] -\u003e"},{"line_number":44,"context_line":"  Exec[\"${title} resource restart flag\"]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_ff1b13c8","line":41,"in_reply_to":"fa6399be_90984cc2","updated":"2016-10-13 11:22:45.000000000","message":"All else looks good to me, but i think removing the refreshonly breaks it. Refreshonly is crucial for this to work correctly, otherwise we\u0027ll keep restarting services on every stack update, regardless if their config was changed or not. This is specifically a situation we wanted to avoid by implementing the flags.","commit_id":"7f2931941e5b6894f51ea0a49b6be0e5549971e5"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"f60d8628a58ad87347c2649d4c0fa383df2bfd94","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  exec { \"${title} resource restart flag\":"},{"line_number":39,"context_line":"    command \u003d\u003e \"touch /var/lib/tripleo/pacemaker-restarts/${title}\","},{"line_number":40,"context_line":"    path    \u003d\u003e [\u0027/bin\u0027,\u0027/usr/bin\u0027,\u0027/sbin\u0027,\u0027/usr/sbin\u0027],"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  File[\u0027/var/lib/tripleo/pacemaker-restarts\u0027] -\u003e"},{"line_number":44,"context_line":"  Exec[\"${title} resource restart flag\"]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_f15347e0","line":41,"in_reply_to":"fa6399be_9fb21793","updated":"2016-10-13 11:32:45.000000000","message":"Re ensure_resource fixing the bug -- yea that\u0027s my understanding.\n\nRe removing `File -\u003e Exec` below - i think we have to keep that to ensure proper ordering. `-\u003e` shouldn\u0027t trigger refresh, only `~\u003e` does.\n\nWe just need to put back the refreshonly, because that ensures we don\u0027t run the `touch` command on every puppet run, but we run it only when something refreshes the resource via `~\u003e` or `notify \u003d\u003e`. That\u0027s vital to how the restart flags work (\u003d only create them when a config file changes).","commit_id":"7f2931941e5b6894f51ea0a49b6be0e5549971e5"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"3b366f6f96dcbe0a7df3e3a4458314d9c934155f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  exec { \"${title} resource restart flag\":"},{"line_number":39,"context_line":"    command \u003d\u003e \"touch /var/lib/tripleo/pacemaker-restarts/${title}\","},{"line_number":40,"context_line":"    path    \u003d\u003e [\u0027/bin\u0027,\u0027/usr/bin\u0027,\u0027/sbin\u0027,\u0027/usr/sbin\u0027],"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  File[\u0027/var/lib/tripleo/pacemaker-restarts\u0027] -\u003e"},{"line_number":44,"context_line":"  Exec[\"${title} resource restart flag\"]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_90984cc2","line":41,"in_reply_to":"fa6399be_e24f01bb","updated":"2016-10-13 09:50:40.000000000","message":"That\u0027s correct.  As the define depends on the directory the best place to create it is in the define.  The use of ensure avoid duplicate declaration error, as the define can be used several times in a manifest.","commit_id":"7f2931941e5b6894f51ea0a49b6be0e5549971e5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c45ff530ea8ce530e1f2a1f42b99841585038d09","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  exec { \"${title} resource restart flag\":"},{"line_number":39,"context_line":"    command \u003d\u003e \"touch /var/lib/tripleo/pacemaker-restarts/${title}\","},{"line_number":40,"context_line":"    path    \u003d\u003e [\u0027/bin\u0027,\u0027/usr/bin\u0027,\u0027/sbin\u0027,\u0027/usr/sbin\u0027],"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  File[\u0027/var/lib/tripleo/pacemaker-restarts\u0027] -\u003e"},{"line_number":44,"context_line":"  Exec[\"${title} resource restart flag\"]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_9fb21793","line":41,"in_reply_to":"fa6399be_ff1b13c8","updated":"2016-10-13 11:26:40.000000000","message":"So if re remove the File -\u003e from below so it doesn\u0027t run every time, and just leave the refreshonly in the exec declaration would that be OK?\n\nThe ensure_resource for the directories added above is what the bug being fixed here is for right?","commit_id":"7f2931941e5b6894f51ea0a49b6be0e5549971e5"}]}
