)]}'
{"manifests/profile/base/heat.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9bbc7c1481efef045640aea4fcc4084b9c21f4d2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  if $step \u003e\u003d 5 {"},{"line_number":69,"context_line":"    if $manage_db_purge {"},{"line_number":70,"context_line":"      include ::heat::cron::purge_deleted"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":"    if $bootstrap_node \u003d\u003d $::hostname {"},{"line_number":73,"context_line":"      # Class ::heat::keystone::domain has to run on bootstrap node"},{"line_number":74,"context_line":"      # because it creates DB entities via API calls."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_20129109","side":"PARENT","line":71,"updated":"2016-10-14 12:19:34.000000000","message":"so you removed it, but what about configuration? I think you still need to declare the class to have params in heat.conf, no?","commit_id":"700ad3ee5381135c21a4fddcb1d952d1607fefd0"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"5f0fb0cdf5158a05343589d40a3f4600bb6510ab","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  # Domain resources will be created at step5 on the node running keystone.pp"},{"line_number":50,"context_line":"  # configure heat.conf at step3 and 4 but actually create the domain later."},{"line_number":51,"context_line":"  if $step \u003d\u003d 3 or $step \u003d\u003d 4 {"},{"line_number":52,"context_line":"    class { \u0027::heat::keystone::domain\u0027:"},{"line_number":53,"context_line":"      manage_domain \u003d\u003e false,"},{"line_number":54,"context_line":"      manage_user   \u003d\u003e false,"},{"line_number":55,"context_line":"      manage_role   \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_f2495032","line":52,"range":{"start_line":52,"start_character":15,"end_line":52,"end_character":19},"updated":"2016-10-14 12:39:45.000000000","message":"Emilien - heat is still configured here, we just don\u0027t need to create the user/domain in step 5 anymore.","commit_id":"7891c1a645bf7835d2dcbbae97c9d79cd5b6ea70"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"67421dc7f6637da7bc0a9d731ac3893377f9607a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  # Domain resources will be created at step5 on the node running keystone.pp"},{"line_number":50,"context_line":"  # configure heat.conf at step3 and 4 but actually create the domain later."},{"line_number":51,"context_line":"  if $step \u003d\u003d 3 or $step \u003d\u003d 4 {"},{"line_number":52,"context_line":"    class { \u0027::heat::keystone::domain\u0027:"},{"line_number":53,"context_line":"      manage_domain \u003d\u003e false,"},{"line_number":54,"context_line":"      manage_user   \u003d\u003e false,"},{"line_number":55,"context_line":"      manage_role   \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_92dc9447","line":52,"range":{"start_line":52,"start_character":15,"end_line":52,"end_character":19},"in_reply_to":"fa6399be_f2495032","updated":"2016-10-14 12:41:27.000000000","message":"sorry I missed it. I need more more coffee :)","commit_id":"7891c1a645bf7835d2dcbbae97c9d79cd5b6ea70"}],"manifests/profile/base/keystone.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a241292c2df3201c8b424886a60e0e6f790cf79f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      include ::heat::keystone::domain"},{"line_number":84,"context_line":"      Class[\u0027::keystone::roles::admin\u0027] -\u003e Class[\u0027::heat::keystone::domain\u0027]"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $step \u003e\u003d 5 and $manage_endpoint{"},{"line_number":89,"context_line":"    if hiera(\u0027aodh_api_enabled\u0027, false) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_c82f4986","line":86,"updated":"2016-10-14 07:49:18.000000000","message":"We were previously also explicitly declaring the heat::keystone::domain with \u0027false\u0027 when it wasn\u0027t the bootstrap node do we need to do that here?","commit_id":"4aa8057ba7de90fa24525fbd64380a6997ac566b"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"590035858f1a4c441d017303f26b0cd2f710faa3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      include ::heat::keystone::domain"},{"line_number":84,"context_line":"      Class[\u0027::keystone::roles::admin\u0027] -\u003e Class[\u0027::heat::keystone::domain\u0027]"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $step \u003e\u003d 5 and $manage_endpoint{"},{"line_number":89,"context_line":"    if hiera(\u0027aodh_api_enabled\u0027, false) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_a874d535","line":86,"in_reply_to":"fa6399be_c82f4986","updated":"2016-10-14 08:04:19.000000000","message":"So in heat.pp we include heat::keystone::domain for steps 3 and 4 with false params, which means we configure heat.conf with the domain stuff (only on nodes running heat).\n\nThen this include will create the domain/user only on the bootstrap node of the cluster running keyston (at step5)","commit_id":"4aa8057ba7de90fa24525fbd64380a6997ac566b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9c76d4ed9c29dd9a008b57326e87c81c3b5a960c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  if $step \u003e\u003d 5 and $manage_domain {"},{"line_number":82,"context_line":"      if hiera(\u0027heat_engine_enabled\u0027, false) {"},{"line_number":83,"context_line":"        class { \u0027::heat::keystone::domain\u0027:"},{"line_number":84,"context_line":"          manage_config \u003d\u003e false,"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":"        Class[\u0027::keystone::roles::admin\u0027] -\u003e Class[\u0027::heat::keystone::domain\u0027]"},{"line_number":87,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_e07fb9dd","line":84,"updated":"2016-10-14 12:26:20.000000000","message":"no, don\u0027t use this new param. Instead, do something like:\n\n class { \u0027::heat::keystone::domain\u0027:\n   domain_name     \u003d\u003e $::os_service_default,\n   domain_admin    \u003d\u003e $::os_service_default,\n   domain_password \u003d\u003e $::os_service_default,\n }\n\nAnd heat.conf won\u0027t be configured.","commit_id":"7891c1a645bf7835d2dcbbae97c9d79cd5b6ea70"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"5f0fb0cdf5158a05343589d40a3f4600bb6510ab","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  if $step \u003e\u003d 5 and $manage_domain {"},{"line_number":82,"context_line":"      if hiera(\u0027heat_engine_enabled\u0027, false) {"},{"line_number":83,"context_line":"        class { \u0027::heat::keystone::domain\u0027:"},{"line_number":84,"context_line":"          manage_config \u003d\u003e false,"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":"        Class[\u0027::keystone::roles::admin\u0027] -\u003e Class[\u0027::heat::keystone::domain\u0027]"},{"line_number":87,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_b25a78f0","line":84,"in_reply_to":"fa6399be_205d3179","updated":"2016-10-14 12:39:45.000000000","message":"Ok I can do that instead, thanks","commit_id":"7891c1a645bf7835d2dcbbae97c9d79cd5b6ea70"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d2841fc04dc99f05087537764e7796e48ccd2425","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  if $step \u003e\u003d 5 and $manage_domain {"},{"line_number":82,"context_line":"      if hiera(\u0027heat_engine_enabled\u0027, false) {"},{"line_number":83,"context_line":"        class { \u0027::heat::keystone::domain\u0027:"},{"line_number":84,"context_line":"          manage_config \u003d\u003e false,"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":"        Class[\u0027::keystone::roles::admin\u0027] -\u003e Class[\u0027::heat::keystone::domain\u0027]"},{"line_number":87,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_205d3179","line":84,"in_reply_to":"fa6399be_e07fb9dd","updated":"2016-10-14 12:27:31.000000000","message":"Yeah, indeed.","commit_id":"7891c1a645bf7835d2dcbbae97c9d79cd5b6ea70"}]}
